With these changes, the "happy path" when the leading and trailing
number of bits don't need an update, fewer operations are needed.
The change is probably very marginal (no change in the benchmark added
here, but the benchmark also doesn't cover non-changing values), and
an argument could me made that avoiding pointers also has its
benefits.
However, I think that reducing the number of return values improves
readability. Which convinced me that I should at least propose this.
Signed-off-by: beorn7 <beorn@grafana.com>
* wrap api error on get series/labels on `returnAPIError` function
Signed-off-by: Alan Protasio <approtas@amazon.com>
* lint
Signed-off-by: Alan Protasio <approtas@amazon.com>
* query exemplars
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
This PR updates the Serverset url at the configuration.md documentation.
Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
* Updated feature request template
Signed-off-by: Brian Choromanski <BrianChoromanski@gmail.com>
* Added newline to the end of file
Signed-off-by: Brian Choromanski <BrianChoromanski@gmail.com>
* Ran yamllint on feature_request.yml
Signed-off-by: Brian Choromanski <BrianChoromanski@gmail.com>
* Made proposal required
Signed-off-by: Brian Choromanski <BrianChoromanski@gmail.com>
Signed-off-by: Brian Choromanski <BrianChoromanski@gmail.com>
The wlog.WL type can now be used to create a Write Ahead Log or a Write
Behind Log.
Before the prefix for wbl metrics was
'prometheus_tsdb_out_of_order_wal_' and has been replaced with
'prometheus_tsdb_out_of_order_wbl_'.
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Signed-off-by: Jesus Vazquez <jesusvazquez@users.noreply.github.com>
Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
* Update README.md
using logo prometheus in readme that looks nicer
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Update README.md
changing the logo in readme using the orange one and reduce the size
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Add files via upload
add logo orange
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Update README.md
update logo orange in readme using local path
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Delete logo-prometheus-orange.png
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Added logo to the documentation folder
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Update logo in readme.md
- update logo using svg in readme
- fix target property in link
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Rename Prometheus_software_logo.svg to prometheus-logo
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* Rename prometheus-logo to prometheus-logo.svg
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
* update prometheus logo name file
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
Signed-off-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com>
The bucket receiving math.MaxFloat64 observations now has
math.MaxFloat64 as upper bound, while the bucket after it (the last
possible bucket) has +Inf.
This also adds a test for getBound and moves the getBound code to
generic.go (where it should have been in the first place).
Signed-off-by: beorn7 <beorn@grafana.com>
* histogram: Simplify iterators
We don't really need currLower and currUpper and can calculate it when
needed (as already done for the floatBucketIterator). The calculation
is cheap, while keeping those extra variables around costs RAM
(potentially a lot with many iterators).
* histogram: Convert Bucket/FloatBucket to one generic type
* histogram: Move some bucket iterator code into generic base iterator
* histogram: Remove cumulative iterator for FloatHistogram
We added it in the past for completeness (Histogram has one), but it
has never been used. Plus, even the cumulative iterator for Histogram
is only there for test reasons.
We can always add it back, and then maybe even using generics.
Signed-off-by: beorn7 <beorn@grafana.com>
Currently all the github actions return warnings because the "on"
keyword in the yaml files are being interpreted as a "truthy" value by
yamllint. To ignore this behavior I added a rule which ignores the "on".
See https://github.com/adrienverge/yamllint/issues/430.
Signed-off-by: Gabriel Goller <gabriel.goller@acs.it>
Signed-off-by: Gabriel Goller <gabriel.goller@acs.it>
Co-authored-by: Gabriel Goller <gabriel.goller@acs.it>
