mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-28 15:09:39 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
14172 commits 243 branches 444 tags 649 MiB
Commit graph

48 commits

Author SHA1 Message Date
Matthieu MOREL ab64966e9d
fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094) 
* fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()"

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-10-06 16:35:29 +00:00
beorn7 0f760f63dd lint: Revamp our linting rules, mostly around doc comments 
Several things done here:

- Set `max-issues-per-linter` to 0 so that we actually see all linter
  warnings and not just 50 per linter. (As we also set
  `max-same-issues` to 0, I assume this was the intention from the
  beginning.)

- Stop using the golangci-lint default excludes (by setting
  `exclude-use-default: false`. Those are too generous and don't match
  our style conventions. (I have re-added some of the excludes
  explicitly in this commit. See below.)

- Re-add the `errcheck` exclusion we have used so far via the
  defaults.

- Exclude the signature requirement `govet` has for `Seek` methods
  because we use non-standard `Seek` methods a lot. (But we keep other
  requirements, while the default excludes completely disabled the
  check for common method segnatures.)

- Exclude warnings about missing doc comments on exported symbols. (We
  used to be pretty adamant about doc comments, but stopped that at
  some point in the past. By now, we have about 500 missing doc
  comments. We may consider reintroducing this check, but that's
  outside of the scope of this commit. The default excludes of
  golangci-lint essentially ignore doc comments completely.)

- By stop using the default excludes, we now get warnings back on
  malformed doc comments. That's the most impactful change in this
  commit. It does not enforce doc comments (again), but _if_ there is
  a doc comment, it has to have the recommended form. (Most of the
  changes in this commit are fixing this form.)

- Improve wording/spelling of some comments in .golangci.yml, and
  remove an outdated comment.

- Leave `package-comments` inactive, but add a TODO asking if we
  should change that.

- Add a new sub-linter `comment-spacings` (and fix corresponding
  comments), which avoids missing spaces after the leading `//`.

Signed-off-by: beorn7 <beorn@grafana.com>
 2024-08-22 17:36:11 +02:00
Arve Knudsen 506729480e golangci-lint: Don't use deprecated config params 
Replace deprecated golangci-lint configuration parameters with current
equivalents:

* `run.skip-files` => `issues.exclude-files`
* `run.skip-dirs` => `issues.exclude-dirs`

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-07-14 14:10:45 +02:00
Arve Knudsen be975bf8d7 golangci-lint: Enable loggercheck linter 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-06-18 20:41:26 +02:00
Arve Knudsen b2396c0c8f Upgrade to golangci-lint v1.59.0 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-05-27 22:38:48 +02:00
Oleksandr Redko f10c3454e9 Enable perfsprint linter and fix up code 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
 2024-05-15 17:51:05 +03:00
Matthieu MOREL 6f595c6762
golangci-lint: enable whitespace linter (#13905) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-04-11 09:27:54 +01:00
Matthieu MOREL d496687c8e golangci-lint: enable usestdlibvars linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-04-08 19:26:23 +00:00
heyitao c7ca85388f Fix yaml file format and clear ci errors 
Signed-off-by: heyitao <heyitao@uniontech.com>
 2024-03-21 11:32:02 +08:00
machine424 f477e0539a
Move from golang.org/x/exp/slices into slices now that we only support Go >= 1.21 
Prevent adding back golang.org/x/exp/slices.

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-02-28 14:54:53 +01:00
Łukasz Mierzwa daeef6ffc3 Add lint checks for gzip/zlib 
Since we want to use a faster gzip/zlib libraries we should add a lint check so that it's used everywhere

Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
 2024-02-22 17:08:40 +00:00
Matthieu MOREL 8f6cf3aabb tsdb: use Go standard errors 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-12-11 12:18:54 +00:00
Matthieu MOREL 9c4782f1cc
golangci-lint: enable testifylint linter (#13254) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-12-07 11:35:01 +00:00
Oleksandr Redko 2a75604f8e
Enable default revive rules (#13068) 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-11-29 17:23:34 +00:00
Goutham 4710679fbe
Skip golanglint-ci on copied folders 
Signed-off-by: Goutham <gouthamve@gmail.com>
 2023-11-15 15:30:09 +01:00
Matthieu MOREL 05fba53e57 web : use Go standard package 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-11-08 06:37:59 +00:00
Matthieu MOREL fe057fc60d use Go standard errors package 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-11-03 07:26:31 +00:00
Matthieu MOREL 7eaefcf379
ci(lint): enable errorlint on scrape (#12923) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Jesus Vazquez <jesusvazquez@users.noreply.github.com>
Co-authored-by: Jesus Vazquez <jesusvazquez@users.noreply.github.com>
 2023-11-01 20:06:46 +01:00
Oleksandr Redko fa90ca46e5 ci(lint): enable godot; append dot at the end of comments 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-10-31 19:53:38 +02:00
Matthieu MOREL 68e6b4dd34
ci(lint): enable errorlint on discovery (#12918) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-10-31 12:46:55 +01:00
Oleksandr Redko 8e5f0387a2
ci(lint): enable nolintlint and remove redundant comments (#12926) 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-10-31 12:35:13 +01:00
Matthieu MOREL 1ec6e407d0
ci(lint): enable errorlint on storage (#12935) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-10-31 12:15:30 +01:00
Matthieu MOREL 0a513f827d ci(lint): enable errorlint linter on model 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-09-29 21:11:33 +00:00
Matthieu MOREL 67dcca5005 ci(lint): enable errorlint linter on cmd 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-09-28 08:21:01 +00:00
Goutham Veeramachaneni ad4f514e66
Add OTLP Ingestion endpoint (#12571) 
* Add OTLP Ingestion endpoint

We copy files from the otel-collector-contrib. See the README in
`storage/remote/otlptranslator/README.md`.

This supersedes: https://github.com/prometheus/prometheus/pull/11965

Signed-off-by: gouthamve <gouthamve@gmail.com>

* Return a 200 OK

It is what the OTEL Golang SDK expect :(

https://github.com/open-telemetry/opentelemetry-go/issues/4363

Signed-off-by: Goutham <gouthamve@gmail.com>

---------

Signed-off-by: gouthamve <gouthamve@gmail.com>
Signed-off-by: Goutham <gouthamve@gmail.com>
 2023-07-28 12:35:28 +02:00
SuperQ 4e9b89f887
Update depguard config syntax. 
Signed-off-by: SuperQ <superq@gmail.com>
 2023-06-27 14:21:39 +02:00
SuperQ 16c3cd35b1
Disable revive unused-parameter 
Signed-off-by: SuperQ <superq@gmail.com>
 2023-06-27 14:21:39 +02:00
Matthieu MOREL c8e7f95a3c ci(lint): enable predeclared linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-05-21 07:33:54 +00:00
Matthieu MOREL 7e9acc2e46
golangci-lint: remove skip-cache and restore singleCaseSwitch rule 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-04-20 18:43:51 +02:00
Matthieu MOREL fb3eb21230 enable gocritic, unconvert and unused linters 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-04-13 19:20:22 +00:00
SuperQ 8b01189327
Move errcheck excludes config 
Eliminate the need for a second config file for golangci-lint config
file by moving the list of errcheck exclude functions into the yaml
config.

Signed-off-by: SuperQ <superq@gmail.com>
 2023-04-03 09:33:04 +02:00
Matthieu MOREL e2ede285a2
refactor: move from io/ioutil to io and os packages (#10528) 
* refactor: move from io/ioutil to io and os packages
* use fs.DirEntry instead of os.FileInfo after os.ReadDir

Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>
 2022-04-27 11:24:36 +02:00
Łukasz Mierzwa da23c4649a
Enable misspell check in golangci-lint (#10393) 
Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
 2022-03-03 18:11:19 +01:00
Julien Pivotto 9a2e93228e
Switch to grafana/regexp everywhere (#10268) 
Let's have a consistent library for regexp.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2022-02-13 00:58:27 +01:00
Mateusz Gozdek ed698c5480 .golangci.yml: sort output by default 
So running linter several times will yell the same order of reported
issues, which makes it much easier to address them.

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
 2021-11-11 01:37:24 +01:00
Mateusz Gozdek 01c5582216 .golangci.yml: enable gofumpt and goimports linters 
For imports and more opinionated code formatting.

Closes #9557

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
 2021-11-02 19:52:34 +01:00
Mateusz Gozdek ce65883588 .golangci.yml: don't lint autogenerated files 
So when we enable linters for formatting, they do not complain about
those files.

Refs #9557

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
 2021-11-02 19:52:34 +01:00
Ben Kochie 1c624c58ca
Replace deprecated linter (#9571) 
Upstream is replacing `golint` with `revive`.

Signed-off-by: SuperQ <superq@gmail.com>
 2021-10-23 00:36:59 +02:00
Levi Harrison 58556c19be Revert "Fix logging after the move to go-kit/log (#9021)" 
This reverts commit 642722e5d0.

Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-07-27 07:37:03 -04:00
Julius Volz 441e6cd7d6
Merge release-2.28 back into main (#9035) 
* Cut v2.28.0-rc.0 (#8954)

* Cut v2.28.0-rc.0

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Changelog fixup

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Address review comments

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Downgrade some features to enhancements

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Adjust release date to today

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Migrate HTTP SD docs from docs repo (#8972)

See discussion in https://github.com/prometheus/docs/pull/1975

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Cut Prometheus v2.28.0 (#8973)

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* HTTP SD: Allow charset in content type (#8981)

* Added content type regex

Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* fixed disappeared target groups in http_sd #9019

Signed-off-by: servak <fservak@gmail.com>

* Add a testcase for http-sd

Signed-off-by: servak <fservak@gmail.com>

* HTTP SD: Simplify logic of disappeared targetgroups (#9026)

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Fix logging after the move to go-kit/log (#9021)

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Cut Prometheus v2.28.1 (#9034)

Signed-off-by: Julius Volz <julius.volz@gmail.com>

Co-authored-by: Levi Harrison <git@leviharrison.dev>
Co-authored-by: Julien Pivotto <roidelapluie@inuits.eu>
Co-authored-by: servak <fservak@gmail.com>
 2021-07-01 18:02:13 +02:00
Michal Wasilewski 3f686cad8b
fixes yamllint errors 
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
 2021-06-12 12:47:47 +02:00
Levi Harrison 48c9cbdeb3 Added warning for go-kit/kit/log 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-06-11 12:29:03 -04:00
Ben Kochie 000d7edec9 Remove inline Go vendor dir 
Remove the inline Go vendoring per Prometheus 2020 Dev Summit[0].

[0]: https://docs.google.com/document/d/1yuaPKLDvhJNXMF1ubsOOm5kE2_6dvCxHowBQIDs0KdU/edit

Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-02-11 11:53:22 +01:00
Julien Pivotto 318190021d
Enforce the usage of github.com/stretchr/testify/require (#8129) 
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-10-29 11:09:08 +01:00
Javier Palomo Almena 7ec647dbe9
golangci: Use depguard to prevent using restricted packages (#7825) 
Enabling this linter in golangci will check that we are not using
restricted packages, and when a match is found, it will provide a
message suggesting the alternative package.

In this particular case, we enable it for `sync/atomic`.

Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
 2020-08-21 11:37:21 +02:00
Ben Kochie 51057daaa4
Enable golint in CI 
Enable the golint module in golangci-lint.

Fixes: https://github.com/prometheus/prometheus/issues/4125

Signed-off-by: Ben Kochie <superq@gmail.com>
 2020-03-23 15:32:37 +01:00
Simon Pasquier 45506841e6
*: enable all default linters (#5504) 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
 2019-05-03 15:11:28 +02:00
Simon Pasquier f5d54e5be6
*: enable golangci-lint (#5437) 
* *: enable golangci-lint

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Remove freebsd from supported platforms for lint

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update CONTRIBUTING.md

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update CONTRIBUTING.md

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Add common-staticcheck for compatibility

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
 2019-04-24 14:18:40 +02:00