14172 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Björn Rabenstein	4cb5f23c35	api: Improve doc comments for v1.MinTime and v1.MaxTime (#14986) ... api: Improve doc comments for v1.MinTime and v1.MaxTime While investigated something mostly unrelated, I got nerd-sniped by the calculation of v1.MinTime and v1.MaxTime. The seemingly magic number in there (62135596801) needed an explanation. While looking for it, I found out that the offsets used here are actually needlessly conservative. Since the timestamps are so far in the past or future, respectively, that there is no practical impact, except that the calculation is needlessly obfuscated. However, we won't change the values now to not cause any confusion for users of this code. Still, I think the doc comment should explain the circumstances so nobody gets nerd-sniped again as I did today. For the record: 62135596800 is the difference in seconds between 0001-01-01 00:00:00 (Unix time zero point) and 1971-01-01 00:00:00 (Go time zero point) in the Gregorian calendar. If "Prometheus time" were in seconds (not milliseconds), that difference would be relevant to prevent over-/underflow when converting from "Prometheus time" to "Go time". Signed-off-by: beorn7 <beorn@grafana.com> --------- Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-01 18:03:46 +02:00
Jesus Vazquez	c5c2566b8a	MAINTAINERS: Add Arthur as an otlptranslator maintainer (#15024) ... Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>	2024-10-01 15:15:21 +02:00
Jesus Vazquez	77d3b3aff3	OTLP: Remove experimental word form OTLP receiver (#14894) ... The OTLP receiver can now considered stable. We've had it for longer than a year in main and has received constant improvements. Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>	2024-10-01 14:36:52 +02:00
bas smit	73997289c3	tests: update discovery tests with new labael ... Previous commit added the pod_container_init label to discovery, so all the tests need to reflect that. Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
bas smit	a10dc9298e	sd k8s: support sidecar containers in endpoint discovery ... Sidecar containers are a newish feature in k8s. They're implemented similar to init containers but actually stay running and allow you to delay startup of your application pod until the sidecar started (like init containers always do). This adds the ports of the sidecar container to the list of discovered endpoint(slice), allowing you to target those containers as well. The implementation is a copy of that of Pod discovery fixes: #14927 Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
bas smit	7a90d73fa6	sd k8s: test for sidecar container support in endpoints ... This test is expected to fail, the followup will add the feature Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
Bryan Boreham	d4423b1928	Merge pull request #14992 from bboreham/remove-stubs ... [REFACTOR] PromQL: remove label_join and label_replace stubs	2024-09-30 15:10:22 -04:00
Levi Harrison	9bb7fab4ab	remove LeviHarrison as default maintainer (#15005) ... Signed-off-by: Levi Harrison <git@leviharrison.dev>	2024-09-30 09:44:41 -04:00
Julius Volz	b826c43987	Calculate path prefix directly in initial settings Redux value (#14981) ... Without this, the page that is shown first renders once with an empty path prefix value, since the settings update takes a render cycle to complete. However, we only fetch certain data from the API exactly once for a given page, and not for every re-render with changed path prefix value (and we also wouldn't want to fetch it from the wrong location initially). This duplicates the served endpoint list once more, but exporting them from App.tsx would also have been dirty (hot reload only works when a file only exports one component and nothing else, thus there'd be a linter warning). Signed-off-by: Julius Volz <julius.volz@gmail.com>	2024-09-30 14:22:40 +02:00
machine424	b5569c4070	fix(discovery): adjust how type is retrieved in Configs' MarshalYAML/UnmarshalYAML ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-30 12:33:07 +02:00
machine424	97f3219157	test(discovery): add a Configs test showing that the custom unmarshalling/marshalling is broken. ... This went under the radar because the utils are never called directly. We usually marshall/unmarshal Configs as embeded in a struct using UnmarshalYAMLWithInlineConfigs/MarshalYAMLWithInlineConfigs which bypasses Configs' custom UnmarshalYAML/MarshalYAML Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-30 12:33:07 +02:00
Julien	537c5dbbcf	Merge pull request #14994 from roidelapluie/notifications2 ... Follow-up on notifications via SSE	2024-09-30 10:17:34 +02:00
Bryan Boreham	54de4fb780	Merge pull request #14975 from colega/process-mempostings-delete-with-gomaxprocs-workers ... Process `MemPostings.Delete()` with `GOMAXPROCS` workers	2024-09-29 07:58:42 +01:00
Ayoub Mrini	105ab2e95a	fix(test): adjust defer invocations (#14996) ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-27 17:13:51 +01:00
Julien	e34563bfe0	Retry SSE connection unless max clients have been reached. ... This switches from the prehistoric EventSource API to the more modern fetch-event-source package. That packages gives us full control over the retries. It also gives us the opportunity to close the event source when the browser tab is hidden, saving resources. Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-09-27 16:18:33 +02:00
Julien	f9bbad1148	Limit the number of SSE Subscribers to 16 by default ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-09-27 15:51:51 +02:00
Julien	7aa4721373	Merge pull request #14946 from roidelapluie/notifications ... Add notifications to the Web UI	2024-09-27 15:50:43 +02:00
Julien	6cde0096e2	Add notifications to the web UI when configuration reload fails. ... This commit introduces a new `/api/v1/notifications/live` endpoint that utilizes Server-Sent Events (SSE) to stream notifications to the web UI. This is used to display alerts such as when a configuration reload has failed. I opted for SSE over WebSockets because SSE is simpler to implement and more robust for our use case. Since we only need one-way communication from the server to the client, SSE fits perfectly without the overhead of establishing and maintaining a two-way WebSocket connection. When the SSE connection fails, we go back to a classic /api/v1/notifications API endpoint. This commit also contains the required UI changes for the new Mantine UI. Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-09-27 15:28:38 +02:00
Bryan Boreham	b8e5b7cda9	[REFACTOR] PromQL: remove label_join and label_replace stubs ... These functions operate on whole series, not on samples, so they do not fit into the table of functions that return a Vector. Remove the stub entries that were left to help downstream users of the code identify what changed. We cannot remove the entries from the `FunctionCalls` map without breaking `TestFunctionList`, so put some nils in to keep it happy. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-27 11:20:45 +01:00
Oleg Zaytsev	ada8a6ef10	Add some more tests for MemPostings_Delete ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-27 10:14:39 +02:00
Bryan Boreham	410fcce6f0	Remove unnecessary pprof import (#14988) ... The pattern of `import _ "net/http/pprof"` adds handlers to the default http handler, but Prometheus does not use that. There are explicit handlers in `web/web.go`. So, we can remove this line with no impact to behaviour. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-27 07:45:49 +01:00
Neeraj Gartia	8aef821e10	eval_info command ... Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-09-27 01:10:00 +05:30
Julius Volz	5f26d86daa	Merge pull request #14982 from prometheus/fix-remove-defunct-alert-close-buttons ... Remove Query page alert close buttons that don't do anything	2024-09-26 20:39:45 +02:00
Björn Rabenstein	f74722841b	Merge pull request #14160 from alex-kattathra-johnson/issue-13959 ... Remove no-default-scrape-port featureFlag	2024-09-26 18:45:56 +02:00
George Krajcsovits	79a6238e19	scrape/scrape_test.go: reduce the time it takes to reload the manager (#14447) ... * scrape/scrape_test.go: reduce the time it takes to reload the manager TestNativeHistogramMaxSchemaSet took over 3x5s to complete because there's a minimum reload interval. I've made the testcases run in parallel and reduced the reload interval to 10ms. Now the test runs in around 0.1-0.2 seconds. Ran test 10000 times to check if it's flaky. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-26 18:35:15 +02:00
Arthur Silva Sens	d5f65cfce0	Merge pull request #14694 from prometheus/ct-histogram ... Histogram CT Zero ingestion	2024-09-26 12:48:46 -03:00
Bryan Boreham	5710ddf24f	[ENHANCEMENT] Alerts: remove metrics for removed Alertmanagers (#13909) ... * [ENHANCEMENT] Alerts: remove metrics for removed Alertmanagers So they don't continue to report stale values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-26 15:32:18 +01:00
Arthur Silva Sens	95a53ef982	Join tests for appending float and histogram CTs ... Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2024-09-26 11:29:31 -03:00
Arthur Silva Sens	6bd9b1a7cc	Histogram CT Zero ingestion ... Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2024-09-26 11:29:22 -03:00
Oleg Zaytsev	4fd2556baa	Extract processWithBoundedParallelismAndConsistentWorkers ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-26 15:43:19 +02:00
Björn Rabenstein	751100b3d0	Merge pull request #12998 from ringerc/docs-instant-vector-staleness ... Docs: Refer to staleness in instant vector documentation	2024-09-26 14:52:34 +02:00
Craig Ringer	15b68e989c	Refer to staleness in instant vector documentation ... The instant vector documentation does not explain which metric samples are selected - in particular, it makes no reference to staleness. It's confusing when reading the docs to understand how exactly Prometheus selects the metrics to report: the most recent sample older than the search timestamp specified in the API request, so long as that metric is not "stale". Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>	2024-09-26 11:54:31 +12:00
Julius Volz	fcbd18dabb	Remove Query page alert close buttons that don't do anything ... Signed-off-by: Julius Volz <julius.volz@gmail.com>	2024-09-25 18:27:27 +02:00
Alex Johnson	be0f10054e	Remove no-default-scrape-port featureFlag ... Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>	2024-09-25 10:13:19 -05:00
Oleg Zaytsev	ccd0308abc	Don't do anything if MemPostings are empty ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 15:00:10 +02:00
Oleg Zaytsev	9c417aa710	Fix deadlock with empty MemPostings ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 14:08:50 +02:00
Bryan Boreham	5d8f0ef0c2	Merge pull request #14721 from bboreham/exp-grow-postings ... [PERF] TSDB: Grow postings by doubling	2024-09-25 10:47:55 +01:00
Oleg Zaytsev	e196b977af	Process MemPostings.Delete() with GOMAXPROCS workers ... We are still seeing lock contention on MemPostings.mtx, and MemPostings.Delete() is by far the most expensive operation on that mutex. This adds parallelism to that method, trying to reduce the amount of time we spend with the mutex held. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 10:38:47 +02:00
Julius Volz	5037cf75f2	Merge pull request #14972 from prometheus/jvp/make-mantime-ui-assets-relative ... UI: Make mantime UI assets relative	2024-09-24 17:38:21 +02:00
Björn Rabenstein	67caa03dc1	Merge pull request #14970 from prometheus/beorn7/doc ... docs: Improve, clarify, and fix documentation on scrape limits	2024-09-24 16:30:15 +02:00
Jesus Vazquez	cb4bc5e786	UI: Make mantime UI assets relative ... Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>	2024-09-24 15:30:54 +02:00
beorn7	a9243d4d2c	docs: Improve, clarify, and fix documentation on scrape limits ... In detail: - Clarify that label name and value length limits are in byte, not in UTF-8 data points. - More consistent formatting to keep 80 characters line limet. - Clarify various misleading specifications around "per sample", "per scrape", "per scrape config", "per job"... - Fix grammar. Signed-off-by: beorn7 <beorn@grafana.com>	2024-09-24 14:55:54 +02:00
Bryan Boreham	a0f26febc2	Merge pull request #12180 from damnever/perf/relabel-add-label ... Optimize constant label pair adding from relabeling.	2024-09-24 12:22:05 +01:00
Arve Knudsen	c2bbabb4a7	promql.Engine: Refactor vector selector evaluation into a method (#14900) ... * PromQL.Engine: Refactor Matrix expansion into a method Add utility method promql.evaluator.expandSeriesToMatrix, for expanding a slice of storage.Series into a promql.Matrix. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rename to generateMatrix Rename evaluator.expandSeriesToMatrix into generateMatrix, while also dropping the start, end, interval arguments since they are evaluator fields. Write more extensive method documentation. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rename to evalVectorSelector Rename to evalVectorSelector after discussing with @michahoffmann. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-09-24 11:03:56 +01:00
Bryan Boreham	faf5ba29ba	Merge pull request #14959 from prometheus/merge-2.55-into-main ... Merge 2.55 into main	2024-09-23 18:39:37 +01:00
Arve Knudsen	3f9b869fb5	Fix react-app (old UI) package-lock.json ... cd web/ui/react-app npm install Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-09-23 16:34:37 +01:00
George Krajcsovits	f179cb948b	chore: bump client_golang from 1.20.3 to 1.20.4 (#14963) ... Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-23 13:46:51 +02:00
Julien	919648cafc	Merge pull request #14947 from roidelapluie/reloadinvalidyaml ... fix(autoreload): Reload invalid yaml files	2024-09-23 10:03:23 +02:00
Bryan Boreham	4c90118361	Remove CHANGELOG duplicate line ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com> #14402 is the issue and #14403 is the fix.	2024-09-22 17:53:41 +01:00
Bryan Boreham	ca673eb749	Merge remote-tracking branch 'origin/release-2.55' into merge-2.55-into-main ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-22 17:49:34 +01:00