Brian Brazil
296f943ec4
More efficient Merge implementation. ( #486 )
...
Avoid a tree of merge objects, which can result in
what I suspect is n^2 calls to Seek when using Without.
With 100k metrics, and a regex of ^$ in BenchmarkHeadPostingForMatchers:
Before:
BenchmarkHeadPostingForMatchers-8 1 51633185216 ns/op 29745528 B/op 200357 allocs/op
After:
BenchmarkHeadPostingForMatchers-8 10 108924996 ns/op 25715025 B/op 101748 allocs/op
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-01-03 16:59:52 +00:00
zhulongcheng
7632e976c0
Move the build badge to the badge list ( #5060 )
...
Move the `build` badge to the badge list.
Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>
2019-01-03 14:56:49 +00:00
glutamatt
5ddde1965b
tune the "Wal segment size" with a flag ( #5029 )
...
Add WALSegmentSize as an option, and the corresponding flag "storage.tsdb.wal-segment-size" to tune the max size of wal segment files.
The addressed base problem is to reduce the disk space used by wal segment files : on a raspberry pi, for instance, we often want to reduce write load of the sd card, then, the wal directory is mounted on a memory (space limited) partition.
the default value of the segment max file size, pushed the size of directory to 128 MB for each segment , which is too much ram consumption on a rasp.
the initial discussion is at https://github.com/prometheus/tsdb/pull/450
2019-01-03 17:13:21 +03:00
Fabian Reinartz
93d13c59d0
Sort
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
2019-01-03 13:10:57 +01:00
Fabian Reinartz
7a41038695
Add Azure tenant and subscription ID labels
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
2019-01-03 13:09:13 +01:00
Tom Wilkie
121603c417
Expose rules.NewGroupMetrics and rules.Metrics. ( #5059 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-03 12:07:06 +00:00
Brian Brazil
b2d7bbd6b1
Move series fetches out of inner loop of SortedPostings. ( #485 )
...
With 1M series:
Before:
BenchmarkHeadPostingForMatchers-8 1 3501996117 ns/op 61311520 B/op 78 allocs/op
After:
BenchmarkHeadPostingForMatchers-8 1 1403072952 ns/op 69261568 B/op 72 allocs/op
This works out as 3X faster, as the above time includes other things.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-01-03 10:35:10 +00:00
Krasi Georgiev
48c439d26d
fix statick check errors ( #475 )
...
fix the tests for `check_license` and `staticcheck`
the static check also found some actual bugs.
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2019-01-02 19:48:42 +03:00
Tom Wilkie
6e08029b56
Move err to be the last return value from storage.Select. ( #5054 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-02 11:10:13 +00:00
Ganesh Vernekar
7d30ccd0eb
Sort samples before comparing - PromQL unit test ( #5052 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-12-31 10:55:49 +00:00
Krasi Georgiev
eb6586f513
rename createPopulatedBlock to createBlock and use it instead ot createEmptyBlock ( #488 )
...
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-29 14:20:51 +03:00
Krasi Georgiev
a90a7195d4
createPopulatedBlock returns the block dir instead of the block ( #487 )
...
It is easy to forget to close the block returned by createPopulatedBlock
which causes failures for windows so instead it returns the block dir
and which can be used by OpenBlock explicitly.
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-29 10:23:56 +03:00
Krasi Georgiev
090b6852e1
remove unused PrefixMatcher
( #474 )
...
* remove unused `PrefixMatcher`
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-28 21:13:02 +03:00
Krasi Georgiev
2e0571caba
remove unused WALFlushInterval option and NopWAL struct ( #468 )
...
The WALFlushInterval is not used anywhere in the code base.
The WAL is not an interface anymore to save some lookup time so can't use NopWAL in the tests. Instead can just pass nil as the code checks for that and it is essentially a noop.
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-28 20:42:46 +03:00
Brian Brazil
915d7cf937
Add a tsdbutil command to analyse churn etc. ( #478 )
...
This reports the cardinality of each label,
the total number of label pairs,
and how much series worth of time is "uncovered"
by series data. Which is basically how much churn there is.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2018-12-28 17:06:12 +00:00
Bartek Płotka
de213d4a5e
rule manager: Moved metric registration to custom registerer which is already available. ( #4961 )
...
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
2018-12-28 10:20:29 +00:00
AixesHunter
806632790e
update inconsistent comment ( #5046 )
...
Co-Authored-By: aixeshunter <44970652+aixeshunter@users.noreply.github.com>
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-27 14:02:36 +00:00
Eyal Levin
d304269ac4
Update text ( #5039 )
...
The `rule_files` section is not inside the `global` configuration section
Signed-off-by: Eyal Levin <eyalev@gmail.com>
2018-12-25 13:28:56 +00:00
AixesHunter
9f903fb3f7
github.com/cznic/golex has moved to modernc.org/golex ( #5034 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-24 23:59:32 +01:00
Lv Jiawei
ad22389218
Add ingress in UnmarshalYAML and init ( #5035 )
...
Both UnmarshalYAML and init lacks the role type ingress.
Signed-off-by: MIBc <lvjiawei@cmss.chinamobile.com>
2018-12-24 09:24:01 +00:00
Parker Moore
a15a5a2ba0
Fix Docker Hub markdown link ( #5032 )
...
The syntax is [Text](link), but it was [Text[(link).
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
2018-12-22 18:04:34 +00:00
Ganesh Vernekar
dbe55c1352
Subquery ( #4831 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-12-22 13:47:13 +00:00
Julien Pivotto
2e725a195a
Niptick about relabel config ( #4994 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2018-12-21 10:42:18 +00:00
tariqibrahim
122b47caa0
address review comment in client_metrics
...
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-21 00:46:47 -08:00
tariqibrahim
1e4e4c46ba
Merge branch 'master' of https://github.com/prometheus/prometheus into update_k8s
...
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-20 11:36:54 -08:00
Ilya Gladyshev
922c17e119
added name label to all discovery metrics ( #5002 )
...
Signed-off-by: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
2018-12-20 14:47:29 +00:00
Erik Hollensbe
b94eea482c
discovery/gce: oauth2.NoContext is deprecated, replace with context.Background() ( #5024 )
...
* vendor update
* discovery/gce: oauth2.NoContext is deprecated, replace with context.Background()
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
2018-12-20 14:45:18 +00:00
Simon Pasquier
5e2f5e4eea
circleci: add back 'unused' and 'staticcheck' tests ( #5021 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2018-12-20 14:40:34 +01:00
AixesHunter
29f21b8d0c
import aliases yaml that can be omitted ( #5018 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-20 09:45:30 +00:00
Paul Gier
1ca7037526
the go test -race option is only supported on amd64 ( #4382 )
...
Adds checks for current OS and arch to determine whether the '-race' option
should be used with go test
Signed-off-by: Paul Gier <pgier@redhat.com>
2018-12-19 11:28:26 +01:00
Marcel D. Juhnke
c7d83b2b6a
discovery: add support for Managed Identity authentication in Azure SD ( #4590 )
...
Signed-off-by: Marcel Juhnke <marrat@marrat.de>
2018-12-19 10:03:33 +00:00
AixesHunter
fb8479a677
Variable 'labels' collides with imported package name ( #5012 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-19 09:44:03 +00:00
Krasi Georgiev
6d489a1004
fix TestWALSegmentSizeOption for windows. ( #482 )
...
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-19 12:40:47 +03:00
glutamatt
22e3aeb107
Add WALSegmentSize as an option of tsdb creation ( #450 )
...
Expose `WALSegmentSize` option to allow overriding the `DefaultOptions.WALSegmentSize`.
2018-12-18 21:56:51 +03:00
tariqibrahim
0d4b6e4e66
address review comments
...
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-18 08:14:30 -08:00
tariqibrahim
b883f6826b
updating k8s.io/api to v1.13.1
...
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-18 07:58:09 -08:00
Paul Gier
d55bd57bdc
Makefile.common: fix promu download path for arm32 ( #4998 )
...
Signed-off-by: Paul Gier <pgier@redhat.com>
2018-12-18 16:20:43 +01:00
Tariq Ibrahim
de6f3b6af7
expose kubernetes service cluster ip ( #4940 )
...
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
2018-12-18 15:17:34 +00:00
Julius Volz
68f0787c37
Fix various misspellings of "shepherd" in the release docs ( #5006 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-12-18 12:53:28 +01:00
Bartek Płotka
62c8337e77
Moved configuration into relabel
package. ( #4955 )
...
Adapted top dir relabel to use pkg relabel structs.
Removal of this in a separate tracked here: https://github.com/prometheus/prometheus/issues/3647
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
2018-12-18 11:26:36 +00:00
Alin Sinpalean
44bec482fb
Minor optimization for BufferedSeriesIterator: actually drop the samples falling outside of the new delta from the underlying sampleRing, when ReduceDelta is called. ( #4849 )
...
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-12-18 11:25:45 +00:00
Alin Sinpalean
d6adfe2ae2
Use a fake SeriesIterator (that generates samples on the fly instead of using a slice) for BufferedSeriesIterator, to reduce the variance of benchmark results due to memory pressure. ( #4847 )
...
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-12-18 11:22:33 +00:00
Simon Pasquier
a2766a94a3
cmd/prometheus: add tests for sendAlerts() ( #4910 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2018-12-18 11:15:46 +00:00
AixesHunter
1b166d7174
Fix variable 'notifier' collides with imported package name 'github.com/prometheus/prometheus/notifier', changed to 'notifierManager'. ( #4947 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-18 11:13:18 +00:00
Julius Volz
c96828fb57
Mention PromQL by name in querying basics doc ( #4996 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-12-18 11:57:00 +01:00
Thomas J. Fox
11a93b2b37
fix link in docs/examples/k8s-rabbitmq readme ( #4967 )
...
Signed-off-by: Thomas J. Fox <thomasjfox1@gmail.com>
2018-12-18 11:53:55 +01:00
JoeWrightss
e8be31eed9
Fixs typo: 'possibliy' to 'possibly' ( #4974 )
...
Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>
2018-12-18 11:52:40 +01:00
SenXuDC
8fd0c0ab2e
fix typo imeplements -> implements ( #4979 )
...
Signed-off-by: SenXuDC <sen.xu@daocloud.io>
2018-12-18 11:52:16 +01:00
Samuel Alfageme
240321acee
Add taggedAddress to the labels in ConsulSD ( #5001 )
...
Useful when multiple (tagged) addresses for a node are exposed on the catalog API
Ref. https://www.consul.io/api/catalog.html#taggedaddresses
Signed-off-by: Samuel Alfageme <samuel@alfage.me>
2018-12-18 11:51:05 +01:00
Krasi Georgiev
520ab7dc53
re-add the missing prometheus_tsdb_wal_corruptions_total ( #473 )
...
closes https://github.com/prometheus/tsdb/issues/471
after implementing the new WAL this metric was missing so adding it again.
Also added it in a test to make sure it works as expected.
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-12-18 13:24:56 +03:00