Jeanette Tan
754e7df97e
Make it possible to unwrap annotation errors
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-28 01:11:49 +08:00
Charles Korn
667a1efb04
Add trace ID to log lines emitted during rule evaluation
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-10-26 16:14:54 +11:00
Charles Korn
fc132a4557
Use common logger instance to reduce duplication in Group.Eval()
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-10-26 16:14:12 +11:00
Bryan Boreham
05356e76de
Build: remove -a from build to speed up rebuilds ( #13026 )
...
I think this is a hold-over from when Go was less careful about separating architectures.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-25 16:06:17 +01:00
Levi Harrison
7bdabb01d2
Release 2.48.0-rc.1 ( #13028 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-25 12:33:03 +01:00
Björn Rabenstein
c8332a852e
Merge pull request #13031 from zenador/hide-pos-info-for-warnings
...
Hide position info for warnings when position is unknown
2023-10-25 13:08:35 +02:00
Jeanette Tan
72cc93d225
Hide position info for warnings when position is unknown (empty query string passed in)
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-25 18:10:42 +08:00
zenador
80e977aae6
Remove NewPossibleNonCounterInfo
and minimise creating empty annotations ( #13012 )
...
* Remove NewPossibleNonCounterInfo until it can be made more efficient, and avoid creating empty annotations as much as possible
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-24 17:36:07 +01:00
Linas Medžiūnas
e3e22abadb
Merge branch 'main' into linasm/optimize-floatBucketIterator2
...
Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>
2023-10-24 16:27:10 +03:00
Björn Rabenstein
f2e02c52db
Merge pull request #12958 from ptodev/prefer-to-not-register-metrics-globally-scrape
...
Metrics in the "scrape" package can now be registered with a non-default registry
2023-10-24 13:40:04 +02:00
Márcio Carôso
dff1c395f6
Expose --storage.tsdb.retention.time in metric prometheus_tsdb_retention_limit_seconds ( #12986 )
...
* Expose --storage.tsdb.retention.time in a metric
Signed-off-by: Marcio Caroso <msscaroso@gmail.com>
---------
Signed-off-by: Marcio Caroso <msscaroso@gmail.com>
2023-10-24 13:34:42 +02:00
Björn Rabenstein
059f7f0738
Merge pull request #12997 from prometheus/wal-samples-size
...
TSDB: Pre-size buffer to read samples from WAL
2023-10-24 13:26:06 +02:00
Julien Pivotto
b8f5b314ae
Merge pull request #13014 from dannykopping/dannykopping/refactor
...
Refactor `rules/manager.go` into separate concerns
2023-10-24 01:32:41 +02:00
Gilles De Mey
4912c82ed0
ui: Pass unexpected boot errors to StartingContent component ( #13016 )
...
Signed-off-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-10-23 14:17:53 +02:00
Yannick te Kulve
a807dd1616
Bump prometheus common to v0.45.0 ( #13003 )
...
* Bump prometheus common to v0.44.0
Signed-off-by: Yannick te Kulve <738464+YannickTeKulve@users.noreply.github.com>
* Fix golang_protobuf_extensions sum
Signed-off-by: Yannick te Kulve <738464+YannickTeKulve@users.noreply.github.com>
* Remove unused deps
Signed-off-by: Yannick te Kulve <738464+YannickTeKulve@users.noreply.github.com>
---------
Signed-off-by: Yannick te Kulve <738464+YannickTeKulve@users.noreply.github.com>
2023-10-22 16:42:01 -04:00
Bryan Boreham
90e98e0235
tsdb: create isolation transaction slice on demand
...
When Prometheus restarts it creates every series read in from the WAL,
but many of those series will be finished, and never receive any more
samples. By defering allocation of the txRing slice to when it is first
needed, we save 32 bytes per stale series.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-21 13:45:47 +00:00
Bryan Boreham
6fe8217ce4
tsdb: shrink txRing with smaller integers
...
4 billion active transactions ought to be enough for anyone.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-21 12:44:34 +00:00
Danny Kopping
498b836654
Refactoring manager.go into separate concerns
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-10-21 11:11:11 +02:00
Rens Groothuijsen
122f9506e9
Set test group interval default to evaluation interval ( #13011 )
...
Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl>
2023-10-20 21:32:46 +11:00
Bartlomiej Plotka
6d083312e7
native-histograms: Fixed PrometheusProto scrape format preference. ( #13010 )
...
Broken by https://github.com/prometheus/prometheus/pull/12738 . We have to update both global variables (as GlobalConfig is not a pointer here).
DefaultConfig is used when no global: section is provided, whereas DefaultGlobalConfig is used when it's provided and for individual scrape configs.
Reported on #prometheus-dev (thanks to @beorn7): https://cloud-native.slack.com/archives/C01AUBA4PFE/p1697733267205649
Tested manually, it would be nice to add test at some point (quick fix for now).
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-10-19 20:38:45 +01:00
Björn Rabenstein
8a3af74121
Merge pull request #13008 from prometheus/beorn7/protobuf
...
prompb: Clarify things around optional fields in proto3 and gogo-protobuf
2023-10-19 21:09:50 +02:00
beorn7
a5abd92541
prompb: Remove gogoproto.nullable) = true]
from created_timestamp
...
In proto3, this doesn't change anything. However, since the
`CreatedTimestamp` field is generated as a pointer
(`*types.Timestamp`), we are still able to detect the unset state.
(This is in contrast to the `timestamp_ms` field, which is a plain
int64, for which we cannot enforce generation as a pointer, see
comment updated in the previous commit for future actions.)
Signed-off-by: beorn7 <beorn@grafana.com>
2023-10-19 17:59:07 +02:00
beorn7
b428416f06
textparse: Update comment about timestamp_ms protobuf parsing
...
By now, we know better what the plan is.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-10-19 17:54:42 +02:00
Julien Pivotto
88de3d4491
Merge pull request #13007 from zenador/update-tsdb-ooo-head-read-overflow
...
Very minor refactor of the integer overflow fix
2023-10-19 10:15:39 +02:00
Jeanette Tan
71a36d2396
Very minor refactor of the integer overflow fix
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-19 13:17:46 +08:00
Arthur Silva Sens
ef8e6ae780
Parse created timestamps from Prometheus Protobuf ( #12973 )
...
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
2023-10-18 19:04:02 +01:00
Björn Rabenstein
4d50e5d122
Merge pull request #12609 from marctc/query_max_samples_float_histogram
...
promql(histograms): Change sample total calculation for histograms
2023-10-18 16:40:18 +02:00
Marc Tuduri
1ce066e51c
More periods
...
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
2023-10-18 11:53:50 +02:00
Marc Tuduri
af7c31ee10
PR feedback
...
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
2023-10-18 11:53:50 +02:00
Marc Tuduri
8fededf6ad
promql(histograms): Change sample total calculation for histograms
...
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
2023-10-18 11:51:11 +02:00
Anand Rajagopal
2ade8adf9e
Adding a query parameter to filter out active alerts
...
Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
2023-10-18 02:05:26 +00:00
Björn Rabenstein
16af86734f
Merge pull request #12994 from prometheus/beorn7/release
...
Merge release-2.48 back into main
2023-10-18 00:36:13 +02:00
Björn Rabenstein
f33bffa788
Merge pull request #12891 from linasm/fix-gaps-in-histogram-equals
...
Fix NaN checks in [Float]Histogram.Equals method
2023-10-18 00:35:17 +02:00
Bryan Boreham
26fa2e8356
TSDB: Pre-size buffer to read samples from WAL
...
When reading the WAL this method is called with buffers from a pool, on
multiple goroutines. Pre-allocating sufficient size avoids slow growth
and many reallocations in `append`.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-17 17:31:26 +00:00
Björn Rabenstein
35ec9d1f89
Merge pull request #12868 from jdellithorpe-db/alert-unit-test-doc-fix
...
Promtool: Fix/clarify documentation for axn notation.
2023-10-17 19:04:30 +02:00
Bryan Boreham
551fa8378c
Merge pull request #12959 from LeviHarrison/release-2.48.0-rc0
...
Release 2.48.0-rc0
2023-10-17 15:06:40 +01:00
Levi Harrison
d1620abde9
Add last warning pr
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-17 09:37:50 -04:00
beorn7
ca450a6d79
Merge branch 'release-2.48' into beorn7/release
2023-10-17 15:03:44 +02:00
Björn Rabenstein
fb0b9fc0da
Merge pull request #12988 from zenador/release-2.48-fix-non-counter-warning
...
Fix possible non-counter warning for empty names and native histograms
2023-10-17 11:41:20 +02:00
Julien Pivotto
a06c6680aa
Merge pull request #12990 from pnacht/scorecard-action
...
Add the OpenSSF Scorecard GitHub Action
2023-10-17 09:35:53 +02:00
Levi Harrison
700f9bd7c6
nits
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-16 22:26:45 -04:00
Pedro Kaj Kjellerup Nacht
d92dd108bc
Update workflow name in sync script
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
2023-10-16 19:02:31 +00:00
Pedro Kaj Kjellerup Nacht
1ac8b5801a
Remove duplicate scorecard workflow
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
2023-10-16 19:00:47 +00:00
Pedro Kaj Kjellerup Nacht
927fbfca53
Add scorecard.yml to sync_repo_files.sh
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
2023-10-16 15:33:17 +00:00
Pedro Kaj Kjellerup Nacht
0968e7d907
Create scorecard.yml
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pedro.k.night@gmail.com>
2023-10-16 15:29:44 +00:00
George Krajcsovits
7d7b9eacff
Fix int32 overflow issues ( #12978 )
...
On a 32 bit architecture the size of int is 32 bits. Thus converting from
int64, uint64 can overflow it and flip the sign.
Try for yourself in playground:
package main
import "fmt"
func main() {
x := int64(0x1F0000001)
y := int64(1)
z := int32(x - y) // numerically this is 0x1F0000000
fmt.Printf("%v\n", z)
}
Prints -268435456 as if x was smaller.
Followup to #12650
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-10-16 16:23:26 +02:00
Jeanette Tan
9a8bd8eac6
Fix possible non-counter warning for empty names and native histograms
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-16 15:52:10 +08:00
Levi Harrison
827804c79d
Release 2.48.0-rc0
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-15 22:32:41 -04:00
Julien Pivotto
8a0c9aec1c
Merge pull request #12985 from LeviHarrison/merge-main-release-2.48
...
Cherry pick latest main changes into 2.48
2023-10-15 22:28:34 +02:00
Levi Harrison
454a0a2c1b
Update dependencies for 2.48 ( #12964 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-15 13:47:42 -04:00