Conor Broderick
5169ccf258
Merge pull request #3724 from simonpasquier/fix-bad-data-error
...
Don't reset FiredAt for inactive alerts
2018-02-01 16:18:09 +00:00
Krasi Georgiev
b75428ec19
rename package retrieve to scrape
...
no fucnctinal changes just renaming retrieval to scrape
2018-02-01 09:55:07 +00:00
Krasi Georgiev
7858745c04
rename structs for consistency
2018-01-30 17:49:05 +00:00
Krasi Georgiev
acc4197098
remove dicovery race for the context field
2018-01-29 15:18:07 +00:00
Julien Pivotto
8b20cb1e8d
last config success time gauge: use SetToCurrentTime() ( #3750 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2018-01-27 07:48:13 +00:00
Simon Pasquier
81c0ab69e0
Don't reset FiredAt for inactive alerts
...
Otherwise AlertManager receives resolved alerts where StartsAt is zero which
fails the validation.
2018-01-22 17:17:33 +01:00
Krasi Georgiev
719c579f7b
refactor main execution reloadReady handling, update some comments
2018-01-17 18:14:24 +00:00
Krasi Georgiev
0eafaf32d3
set the correct config reloading execution for scraper and notifier
2018-01-17 13:06:56 +00:00
Krasi Georgiev
97f0461e29
refactor the config reloading execution
2018-01-17 12:02:13 +00:00
Krasi Georgiev
5260c650ec
use the config hash for the map lookup
2018-01-16 11:10:54 +00:00
Krasi Georgiev
8369826808
comment to rethink the map reference for the notifier discovery
2018-01-16 09:47:53 +00:00
Krasi Georgiev
d12e6f29fc
discovery manager ApplyConfig now takes a direct ServiceDiscoveryConfig so that it can be used for the notify manager
...
reimplement the service discovery for the notify manager
Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>
2018-01-15 13:39:44 +00:00
Goutham Veeramachaneni
35a6ffbaf3
Merge pull request #3587 from krasi-georgiev/web-test-error-check
...
handle web_test webhandler errors.
2018-01-10 22:03:25 +05:30
Brian Brazil
ecc24b554d
Hide block duration flags. ( #3618 )
...
Users are starting to use these mistakenly thinking they'll help
with issues, and thus causing some confusion.
Thus hide them and make it clear that they're only there for testing
reasons.
2017-12-24 12:13:48 +00:00
Krasi Georgiev
c94fa731aa
bypass the proxy for the tests
2017-12-20 18:21:10 +00:00
Krasi Georgiev
ad66476c4f
fix flaky main.go test and simplify a bit
2017-12-19 15:07:49 +00:00
Fabian Reinartz
2881d73ed8
Merge pull request #3362 from krasi-georgiev/discovery-refactoring
...
Decouple the discovery and refactor the retrieval package
2017-12-19 12:56:34 +01:00
Goutham Veeramachaneni
9c9f96b2c0
Merge pull request #3529 from krasi-georgiev/main-integration-test
...
main.go integration test for Startup interrupting.
2017-12-18 22:12:13 -06:00
Krasi Georgiev
587dec9eb9
rebased and resolved conflicts with the new Discovery GUI page
...
Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>
2017-12-18 20:10:03 +00:00
Krasi Georgiev
1ec76d1950
rearange the contexts variables and logic
...
split the groupsMerge function to set and get
other small nits
2017-12-18 17:23:47 +00:00
Krasi Georgiev
6ff1d5c51e
add the scrape manager config reloader
...
handle errors with invalid scrape config
2017-12-18 17:23:47 +00:00
Krasi Georgiev
b0d4f6ee08
resolved merge confilc in main.go
2017-12-18 17:23:46 +00:00
Krasi Georgiev
c5cb0d2910
simplify naming and API.
2017-12-18 17:22:50 +00:00
Krasi Georgiev
9c61f0e8a0
scrape pool doesn't rely on context as Stop() needs to be blocking to prevent Scrape loops trying to write to a closed TSDB storage.
2017-12-18 17:22:49 +00:00
Krasi Georgiev
e405e2f1ea
refactored discovery
2017-12-18 17:22:49 +00:00
pasquier-s
2440696961
Log file descriptor limits at startup ( #3567 )
...
Fixes #3564
2017-12-11 13:01:53 +00:00
Alberto Cortés
29da2fb9cd
testutil: update to go1.9 testing.Helper
2017-12-08 19:06:53 +01:00
Alberto Cortés
8f6a9f7833
config: simplify tests by using testutil.NotOk ( #3289 )
...
Also include filename in all LoadFile errors
Also add mesage to testuitl.NotOk so we can identify failing tests when
using table driven tests.
2017-12-08 16:52:25 +00:00
Krasi Georgiev
740662644e
write to temp dir and remove it at the end.
...
Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>
2017-12-06 10:45:58 +00:00
Brian Brazil
b97f4cf48c
Add metrics for rule group interval and last duration.
2017-12-04 11:44:38 +00:00
Krasi Georgiev
2c2a962da3
main.go integration test for Startup interrupting.
2017-12-01 10:58:01 +00:00
Goutham Veeramachaneni
823b7f90b3
Use the files globbed files and not the files in cfg
...
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-11-30 17:08:34 +05:30
Fabian Reinartz
62461379b7
rules: decouple notifier packages
...
The dependency on the notifier packages caused a transitive dependency
on discovery and with that all client libraries our service discovery
uses.
2017-11-27 16:38:14 +01:00
Fabian Reinartz
4d964a0a0d
rules: make glob expansion a concern of main
2017-11-24 08:22:57 +01:00
Fabian Reinartz
bd9f7460eb
rules: remove config package dependency
2017-11-24 07:57:54 +01:00
Fabian Reinartz
2d0e3746ac
rules: remove dependency on promql.Engine
2017-11-24 07:57:54 +01:00
Krasi Georgiev
e2f4850fea
Refactor main.go with oklog/pkg/group actors pattern
2017-11-11 12:33:15 +00:00
Thibault Chataigner
fc4406201e
Tsdb StartTime : Use a simplier way to compute StartTime
2017-10-25 17:41:00 +02:00
Julius Volz
099df0c5f0
Migrate "golang.org/x/net/context" -> "context" ( #3333 )
...
In some places, where ctxhttp or gRPC are concerned, we still need to use the
old contexts.
2017-10-24 21:21:42 -07:00
Julius Volz
9d43176ab3
Remove unused printVersion variable ( #3335 )
...
Kingpin now automatically does this via --version.
2017-10-23 08:50:13 +01:00
Julius Volz
82c5b98496
Capitalize Prometheus in startup message ( #3332 )
...
Hey, branding :)
2017-10-23 08:49:28 +01:00
Thibault Chataigner
bf4a279a91
Remote storage reads based on oldest timestamp in primary storage ( #3129 )
...
Currently all read queries are simply pushed to remote read clients.
This is fine, except for remote storage for wich it unefficient and
make query slower even if remote read is unnecessary.
So we need instead to compare the oldest timestamp in primary/local
storage with the query range lower boundary. If the oldest timestamp
is older than the mint parameter, then there is no need for remote read.
This is an optionnal behavior per remote read client.
Signed-off-by: Thibault Chataigner <t.chataigner@criteo.com>
2017-10-18 12:08:14 +01:00
Julius Volz
5f715f5733
Fix typo in flag description ( #3302 )
2017-10-16 23:00:05 +01:00
Tobias Schmidt
3589f2f1d4
Merge pull request #3285 from jlevesy/use-testutils-in-cmd-subpackage
...
Use testutil assertion helpers in cmd package
2017-10-13 00:12:39 +02:00
Julien Levesy
d7b4fa8d78
use testutil assertions in the cmd/prometheus package
2017-10-12 13:45:38 +02:00
Mathieu Pasquet
38afa507bb
Provide better errors messages in commandline
...
Instead or only printing the help message, which is not always helpful.
For example, when upgrading from prometheus v1, the retention time value
format has changed and now only accepts one unit (e.g. "15d") where it
previously allowed more complex strings (e.g. "360h0m0s").
This commit provides the error message as an explanation for the parsing
failure.
2017-10-09 16:25:50 +02:00
Marc Sluiter
6a633eece1
Added go-conntrack for monitoring http connections ( #3241 )
...
Added metrics for in- and outgoing traffic with go-conntrack.
2017-10-06 11:22:19 +01:00
Fabian Reinartz
2d0b8e8b94
Merge branch 'master' into dev-2.0
2017-10-05 13:09:18 +02:00
Paul Gier
08af129b4d
cmd/prometheus: don't allow quotes at beginning or end of url
...
This prevents accidental copy/paste error where a the web.external-url
or alertmanager.url params could have an extra set of quotes.
See also: https://github.com/prometheus/prometheus/issues/1229
2017-10-04 10:10:02 -05:00
Paul Gier
f79b55d057
cmd/prometheus: remove govalidator for url validation
...
The usage of govalidator is redundant with the call to url.Parse for
url validation. Removing it has the following benefits:
- The explicit error message is displayed instead of just a generic
valid/invalid message
- Slightly smaller code with one fewer external dependency
- Speed improvement by removing duplicate call to url.Parse (inside
govalidator.IsURL()
- Resolves issue #2717
The only potential drawback of removing govalidator is that certain
URLs will be considered valid which were previously invalid. For example:
- URLs with hostnames that start and/or end with an underscore (http://_example.com_ )
- URLs with hostnames that contain some special characters (http://foo&*bar.org )
These are valid URIs according to RFC 3986 and valid domain names per RFC 2181,
however they are not valid hostnames per RFC 952.
2017-10-04 10:08:34 -05:00