Gabriela Gutierrez
9a628bb1c8
Add OpenSSF Scorecard badge to README.md
...
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
2023-09-29 13:21:05 +02:00
Gabriela Gutierrez
a1c1fc8244
Create scorecards.yml
...
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
2023-09-29 13:21:05 +02:00
Julien Pivotto
4b735f02a6
Merge pull request #10569 from zzJinux/discovery-manager-run
...
Fix discovery managers to be properly cancelled
2023-09-29 12:07:55 +02:00
Julien Pivotto
c52db2b196
Remove duplicate tests
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-09-29 10:41:13 +02:00
johncming
5d68ebb207
pkg/rulefmt: fix bug of validate.
...
Signed-off-by: johncming <johncming@yahoo.com>
2023-09-29 10:35:07 +02:00
Julien Pivotto
a56e5a1da0
Merge pull request #12898 from mmorel-35/lint/errorlint
...
ci(lint): enable errorlint linter on cmd
2023-09-29 10:23:56 +02:00
lasea75
f15f0ac16a
Update functions.md
...
Signed-off-by: lasea75 <lasea75@gmail.com>
2023-09-28 12:26:46 -05:00
Matthieu MOREL
67dcca5005
ci(lint): enable errorlint linter on cmd
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-09-28 08:21:01 +00:00
Linas Medziunas
3c047a3518
Expand docs comments
...
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
2023-09-28 09:08:09 +03:00
Linas Medziunas
dfb6292600
Compare FloatHistogram.[Zero]Count float values as binary
...
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
2023-09-28 09:06:54 +03:00
Björn Rabenstein
0de7f39e6a
Merge pull request #12894 from linasm/linasm/test-case-for-ValidateHistogram
...
Additional test case for ValidateHistogram
2023-09-27 14:16:57 +02:00
Linas Medziunas
1aad4004c3
Additional test case for ValidateHistogram
...
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
2023-09-27 09:34:43 +03:00
Julien Pivotto
a3f424641a
Merge pull request #6724 from peergynt/template_reference
...
Added externalURL and pathPrefix functions to Template reference docs
2023-09-26 13:50:33 +02:00
Julien Pivotto
a8cdb7eb6c
Merge branch 'main' into template_reference
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-09-26 13:49:58 +02:00
Bryan Boreham
6dcbd653e9
tsdb: register metrics after Head is initialized ( #12876 )
...
This avoids situations where metrics are scraped before the data they
are trying to look at is initialized.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-09-25 21:57:08 +01:00
Alan Protasio
a15e884e7a
Prevent Prometheus from overallocating memory on subquery with large amount of steps. ( #12734 )
...
* change initial points slice size
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* refactor on the steps calculation and moving the getXPoint/putXPoint method to the evaluator
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* prevent potential panic
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update promql/engine.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update promql/engine.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update promql/engine.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update promql/engine.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Allocating slice with maximum size of 5k
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* adding comments
Signed-off-by: Alan Protasio <alanprot@gmail.com>
---------
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2023-09-25 20:15:41 +01:00
Linas Medziunas
cbd01fc296
Fix NaN sum check in [Float]Histogram.Equals method
...
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
2023-09-25 16:03:55 +03:00
ouyang1204
5d233df7ef
Fix rule check broken ( #12715 )
...
Signed-off-by: DrAuYueng <ouyang1204@gmail.com>
2023-09-25 17:48:05 +10:00
Goutham Veeramachaneni
86729d4d7b
Update exp package ( #12650 )
2023-09-21 22:53:51 +02:00
Björn Rabenstein
f8dd8770ac
Merge pull request #12757 from bboreham/reuse-bufiter
...
TSDB: re-use iterator when moving between series
2023-09-21 14:08:53 +02:00
Björn Rabenstein
ade2ee3fe4
Merge pull request #12716 from bboreham/simplify-seek
...
storage: simplify Seek on BufferedSeriesIterator
2023-09-21 13:56:29 +02:00
Bryan Boreham
91054875d6
Merge pull request #12732 from bboreham/simplify-rangeeval
...
promql: simplify inner loop of rangeEval
2023-09-20 20:22:05 +00:00
Bryan Boreham
d498bb0d8c
Merge pull request #12875 from dimitarvdimitrov/dimitar/TestQuerierIndexQueriesRace-incorrect-exit-condition
...
Fix samples generation in TestQuerierIndexQueriesRace
The loop would run forever if the context was cancelled before the goroutine got started.
2023-09-20 20:20:30 +00:00
Dimitar Dimitrov
6f1284ac93
Fix exit condition of TestQuerierIndexQueriesRace
...
The test was introduced in # but was changed during the code review and not reran with the faulty code since then.
Closes #
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
2023-09-20 20:22:26 +01:00
Bryan Boreham
bca9a79bca
Merge pull request #12877 from bboreham/fix-promtool
...
promtool: fix compile error from bad merge
2023-09-20 19:14:30 +00:00
Bryan Boreham
5ecea3c840
promtool: fix compile error from bad merge
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-09-20 16:34:20 +00:00
Björn Rabenstein
864da019cd
Merge pull request #12874 from krajorama/outof-order-chunks
...
Fix duplicate sample detection at chunk size limit
2023-09-20 18:01:21 +02:00
Björn Rabenstein
9071913fd9
Merge pull request #12831 from aknuds1/arve/posting-context
...
Add context argument to `tsdb.PostingsForMatchers`
2023-09-20 17:15:15 +02:00
Bryan Boreham
2b77ad4591
Merge pull request #12677 from bboreham/retry-on-500
...
remote-write: respect Retry-After header on 5xx errors
2023-09-20 14:02:34 +00:00
György Krajcsovits
9dbd100a5e
Refactor solution to not repeat code
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-09-20 15:54:00 +02:00
György Krajcsovits
96d03b6f46
Fix duplicate sample detection at chunks size limit
...
Before cutting a new XOR chunk in case the chunk goes over the size
limit, check that the timestamp is in order and not equal or older
than the latest sample in the old chunk.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-09-20 14:49:56 +02:00
György Krajcsovits
56b3a015b6
Add regression test for duplicate detection at chunk size limit
...
TestHeadDetectsDuplcateSampleAtSizeLimit tests a regression where a
duplicate sample,is appended to the head, right when the head chunk is
at the size limit. The test adds all samples as duplicate, thus
expecting that the result has exactly half of the samples.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-09-20 14:32:20 +02:00
Ben Ye
c78124427e
Support specifying series matchers to analyze tsdb ( #12842 )
...
* support specifying series matchers to analyze tsdb
Signed-off-by: Ben Ye <benye@amazon.com>
* fix cli docs
Signed-off-by: Ben Ye <benye@amazon.com>
---------
Signed-off-by: Ben Ye <benye@amazon.com>
2023-09-20 11:37:32 +01:00
William Dumont
ce6ad15422
remote-write: TestClientRetryAfter status code 500
...
and compare the retryAfter values.
Signed-off-by: William Dumont <william.dumont@grafana.com>
2023-09-20 10:25:43 +00:00
William Dumont
febd62a23e
remote-write: refactor TestClientRetryAfter
...
The new version features a set of test cases that simplify the addition
of new HTTP status codes.
Signed-off-by: William Dumont <william.dumont@grafana.com>
2023-09-20 10:24:52 +00:00
Bryan Boreham
9b85354acd
remote-write: respect Retry-After header on 5xx errors
...
If the server sent it to us, we should assume it knows better than we
do and respect it.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-09-20 10:14:38 +00:00
Paschalis Tsilias
c173cd57c9
Add a header to count retried remote write requests ( #12729 )
...
Header name is `Retry-Attempt`, only set when >0.
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
2023-09-20 11:11:03 +01:00
Björn Rabenstein
83891135c6
Merge pull request #12838 from krajorama/fix-disappearing-span-panic
...
Fix counterResetInAnyBucket panic
2023-09-19 17:10:27 +02:00
George Krajcsovits
3512b2d678
storage: make histogram reset handling consistent in chainSampleIterator ( #12779 )
...
storage: make histogram reset handling consistent in chainSampleIterator
---------
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-09-19 17:06:46 +02:00
Alan Protasio
959c98441b
Add context argument to tsdb.PostingsForMatchers
...
Signed-off-by: Alan Protasio <alanprot@gmail.com>
2023-09-16 18:13:32 +02:00
zenador
69edd8709b
Add warnings (and annotations) to PromQL query results ( #12152 )
...
Return annotations (warnings and infos) from PromQL queries
This generalizes the warnings we have already used before (but only for problems with remote read) as "annotations".
Annotations can be warnings or infos (the latter could be false positives). We do not treat them different in the API for now and return them all as "warnings". It would be easy to distinguish them and return infos separately, should that appear useful in the future.
The new annotations are then used to create a lot of warnings or infos during PromQL evaluations. Partially these are things we have wanted for a long time (e.g. inform the user that they have applied `rate` to a metric that doesn't look like a counter), but the new native histograms have created even more needs for those annotations (e.g. if a query tries to aggregate float numbers with histograms).
The annotations added here are not yet complete. A prominent example would be a warning about a range too short for a rate calculation. But such a warnings is more tricky to create with good fidelity and we will tackle it later.
Another TODO is to take annotations into account when evaluating recording rules.
---------
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-09-14 18:57:31 +02:00
Arve Knudsen
156222cc50
Add context argument to LabelQuerier.LabelValues ( #12665 )
...
Add context argument to LabelQuerier.LabelValues and
LabelQuerier.SortedLabelValues.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2023-09-14 16:02:04 +02:00
Julien Pivotto
e21ff116d8
Merge pull request #12841 from pnacht/pinned-gha
...
Hash-pin workflow GitHub Actions
2023-09-14 10:58:02 +02:00
Arve Knudsen
a964349e97
Add context argument to LabelQuerier.LabelNames ( #12666 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2023-09-14 10:39:51 +02:00
Björn Rabenstein
8f52477e20
Merge pull request #12839 from prometheus/beorn7/histogram
...
storage: remove obsolete TODO
2023-09-13 18:03:15 +02:00
Arve Knudsen
4451ba10b4
Add context argument to IndexReader.Postings ( #12667 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2023-09-13 17:45:06 +02:00
Pedro Nacht
35a7ae6eb3
Ensure dependabot updates workflows in ./scripts
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
2023-09-13 13:52:37 +00:00
Pedro Nacht
142c829fce
Hash-pin GitHub Actions
...
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
2023-09-13 13:52:14 +00:00
Arve Knudsen
6ef9ed0bc3
Add context argument to DB.Delete ( #12834 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2023-09-13 15:43:06 +02:00
György Krajcsovits
b2fa4d910a
Fix more counterResetInAnyBucket edgecases
...
Case a) empty span is at the beginning of the spans.
Case b) two consequtive empty spans with positive offsets.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-09-13 15:18:40 +02:00