Matt T. Proud
0980aeac52
Merge pull request #96 from prometheus/refactor/persistence/iterator-interface
...
Serious Cleaning of LevelDB Iterator Code
2013-03-25 04:58:36 -07:00
Matt T. Proud
b2e4c88b80
Wrap LevelDB iterator operations behind interface.
...
The LevelDB storage types return an interface type now that wraps
around the underlying iterator. This both enhances testability but
improves upon, in my opinion, the interface design for the LevelDB
iterator.
Secondarily, the resource reaping behaviors for the LevelDB iterators
have been improved by dropping the externalized io.Closer object.
Finally, the iterator provisioning methods provide the option for
indicating whether one wants a snapshotted iterator or not.
2013-03-25 12:57:58 +01:00
Julius Volz
5d4a090987
Merge branch 'master' of github.com:/prometheus/prometheus
2013-03-25 12:15:42 +01:00
Julius Volz
3880a86c9c
In case of empty query results, return an empty matrix.
2013-03-25 12:14:48 +01:00
Johannes 'fish' Ziemke
b290c821d1
Renamed "localAssets" cmd flag to "useLocalAssets".
2013-03-25 12:09:39 +01:00
Matt T. Proud
43a7ccd5be
Merge pull request #94 from prometheus/refactor/persistence/interface-cleanups
...
Remove Cruft from Storage Interfaces
2013-03-25 03:00:27 -07:00
Matt T. Proud
f2a30cf20c
Several important cleanups and deprecations.
...
EachFunc is deprecated.
Remove deprecated ``Pair`` and ``GetAll``.
These were originally used for forensic and the old gorest impl.
Nothing today in the user-facing path nor the tests uses them,
especially since the advent of the ForEach protocol in the
interface.
2013-03-25 08:38:21 +01:00
Matt T. Proud
70448711ec
Merge pull request #95 from prometheus/feature/persistence/batching
...
Several interface cleanups.
2013-03-24 00:19:46 -07:00
Matt T. Proud
8f6b55be71
Several interface cleanups.
...
- Kill Close in Persistent and document interface.
- Extract batching behavior into interface.
- Kill IteratorManager, which was used for unknown reasons.
2013-03-24 07:35:43 +01:00
Johannes 'fish' Ziemke
9bb6820402
Use filename based type if DetectContentType fails.
...
DetectContentType returns text/plain for our stylesheets and javascripts. That causes chrome to ignore those files.
2013-03-22 12:03:31 +01:00
Julius Volz
a33d2726bc
Mark range op as consumed if it receives no data points in range.
2013-03-22 11:50:02 +01:00
Julius Volz
8e4c5b0cea
Use AST query analyzer and views with tiered storage.
2013-03-21 18:16:52 +01:00
Julius Volz
3c9d6cb66c
Add several needed persistence proxy methods to tiered storage.
2013-03-21 18:16:43 +01:00
Julius Volz
081d250929
Fix view's GetRangeValues() reverse iteration behavior.
2013-03-21 18:16:31 +01:00
Julius Volz
0be0aa59c2
Wait until storage is drained before closing the underlying leveldb.
2013-03-21 18:16:07 +01:00
Julius Volz
becc278eb6
Fix two bugs in range op time advancement.
2013-03-21 18:15:52 +01:00
Matt T. Proud
c11737c5fc
Merge pull request #84 from prometheus/refactor/storage/batching
...
WIP — DO NOT MERGE
2013-03-21 10:13:27 -07:00
Matt T. Proud
1b0ca377af
Reformat.
2013-03-21 18:11:34 +01:00
Matt T. Proud
ceb6611957
Fix regression in subsequent range op. compactions.
...
We have an anomaly whereby subsequent range operations fail to be
compacted into one single range operation. This fixes such
behavior.
2013-03-21 18:11:04 +01:00
Matt T. Proud
669abdfefe
`make format
` invocation.
2013-03-21 18:11:04 +01:00
Julius Volz
bdb067b47f
Implement remaining View Get* methods.
2013-03-21 18:11:04 +01:00
Julius Volz
1f42364733
Fix typo in comment.
2013-03-21 18:11:03 +01:00
Julius Volz
bf78d427be
Fix compile error in metric helper function.
2013-03-21 18:11:03 +01:00
Matt T. Proud
4e73c4c204
Include interval test.
2013-03-21 18:11:03 +01:00
Matt T. Proud
758a3f0764
Add documentation and cull junk.
2013-03-21 18:11:03 +01:00
Matt T. Proud
bd8bb0edfd
One additional reduction.
2013-03-21 18:11:03 +01:00
Matt T. Proud
73b463e814
Additional simplifications.
2013-03-21 18:11:03 +01:00
Matt T. Proud
fd47ac570f
Implied simplifications.
2013-03-21 18:11:03 +01:00
Matt T. Proud
51a0f21cf8
Interim documentation
2013-03-21 18:11:03 +01:00
Matt T. Proud
b470f925b7
Extract rewriting of interval queries.
2013-03-21 18:11:03 +01:00
Matt T. Proud
eb721fd220
Include note about greediest range.
2013-03-21 18:11:03 +01:00
Julius Volz
2f814d0e6d
AST persistence adapter simplifications after storage changes.
2013-03-21 18:11:03 +01:00
Julius Volz
e50de005f9
Populate metric in SampleSet returned from GetRangeValues()
2013-03-21 18:11:03 +01:00
Julius Volz
6001d22f87
Change Get* methods to receive fingerprints instead of metrics.
2013-03-21 18:11:03 +01:00
Julius Volz
20c5ca1d72
Lower-case web API method arguments.
2013-03-21 18:11:02 +01:00
Julius Volz
95f8885c8a
Adopt new ops sorting interface in view rendering.
2013-03-21 18:11:02 +01:00
Julius Volz
4d79dc3602
Replace renderView() by cleaner and more correct reimplementation.
2013-03-21 18:11:02 +01:00
Julius Volz
e0dbc8c561
Fix edge cases in data extraction for point and interval ops.
2013-03-21 18:11:02 +01:00
Julius Volz
a4361e4116
Rename extractSampleValue -> extractSampleValues.
2013-03-21 18:08:49 +01:00
Julius Volz
4e7db57e76
Fix iterator behavior in view.GetSampleAtTime()
2013-03-21 18:08:49 +01:00
Julius Volz
bb9c5ed7aa
Fix nil pointer exception in frontier building.
2013-03-21 18:08:48 +01:00
Matt T. Proud
896e172463
Extract time group optimizations.
2013-03-21 18:08:48 +01:00
Matt T. Proud
5a71814778
Additional greediness.
2013-03-21 18:08:48 +01:00
Matt T. Proud
b00ca7e422
Refactor some greediness computations.
2013-03-21 18:08:48 +01:00
Matt T. Proud
978acd4e96
Simplify time group optimizations.
...
The old code performed well according to the benchmarks, but the
new code shaves 1/6th of the time off the original and with less
code.
2013-03-21 18:08:48 +01:00
Matt T. Proud
d7b534e624
Update documentation.
2013-03-21 18:08:48 +01:00
Matt T. Proud
1f7ed52b46
Start writing high watermarks.
2013-03-21 18:08:48 +01:00
Julius Volz
a224dda9f0
Fix diskFrontier.ContainsFingerprint() return value.
2013-03-21 18:08:48 +01:00
Matt T. Proud
47ce7ad302
Extract appending from goroutine.
2013-03-21 18:08:48 +01:00
Matt T. Proud
187cd4cdbc
Extract indexing of Fingerprint to Metrics.
2013-03-21 18:08:48 +01:00