Björn Rabenstein
b6e8d6dfae
Merge pull request #12725 from snosratiershad/docs/fix-native-histograms-reference
...
docs: fix: correct reference to native histograms feature flag
2023-08-22 18:36:45 +02:00
Bryan Boreham
c579144f66
Merge pull request #12726 from bboreham/fix-dropped-targets
...
Fix dropped targets
2023-08-21 22:44:16 +01:00
Bryan Boreham
3879488476
promql: simplify inner loop of rangeEval
...
Took out the loops with break after one iteration, and extract some
common code to a function.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-21 19:52:14 +01:00
György Krajcsovits
983c0c5e9d
Add missing buckets
...
My previous proposal for a fix was wrong and also missed these.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-08-21 14:44:53 +02:00
György Krajcsovits
e846736134
Fix typo
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-08-21 14:13:49 +02:00
György Krajcsovits
2ae8c2bd3d
Set expected values in test
...
The parsing doesn't seem to be perfect as I don't get all classic buckets
possibly another bug found?
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-08-21 13:55:13 +02:00
György Krajcsovits
2a781ec5ac
Replicate infinite loop in native-classic histogram scrape
...
Enable scraping a native histogram with exemplars that leads to
infinite loop.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-08-21 13:12:45 +02:00
Ziqi Zhao
4787c879bc
add more elaborate benchmark test
...
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-08-21 13:28:06 +08:00
Bryan Boreham
611f50bb3d
scrape: retain all dropped targets when KeepDroppedTargets is zero
...
This was a bug.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-20 14:32:23 +01:00
Bryan Boreham
627c99424b
scrape: extend TestDroppedTargetsList to check counts
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-20 14:32:23 +01:00
Salar Nosrati-Ershad
fd96996b75
docs: fix: correct reference to native histograms feature flag
...
Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>
2023-08-19 17:35:20 +03:30
Michael Hoffmann
4d8e380269
promql: allow tests to be imported ( #12050 )
...
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
2023-08-18 20:48:59 +02:00
Julien Pivotto
214d6434c9
Merge pull request #12722 from sylr/12258-followup
...
Remove native histograms / memory snapshot restriction
2023-08-18 15:52:25 +02:00
Sylvain Rabot
4399959f79
Remove native histograms / memory snapshot restriction
...
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
2023-08-18 15:15:55 +02:00
Bryan Boreham
716192d57f
Merge pull request #12684 from bboreham/volunteer-2.47
...
Release: volunteer Bryan Boreham to shepherd 2.47
2023-08-18 13:37:40 +01:00
Julien Pivotto
ac87800031
Merge pull request #12689 from prometheus/revert-12541-main
...
Revert "Remove deleted target from discovery manager"
2023-08-18 09:28:30 +02:00
Julien Pivotto
1953d1954a
Merge pull request #12720 from 0o001/0o001-patch-1
...
fix: error message typo
2023-08-18 00:48:36 +02:00
Mustafa Ateş Uzun
e5e51bebef
fix: error message typo
...
Signed-off-by: Mustafa Ateş Uzun <mustafauzun0@gmail.com>
2023-08-17 16:34:45 +03:00
Bryan Boreham
a018a7ef53
storage: simplify Seek on BufferedSeriesIterator
...
Small tweak to call a simpler method
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-17 07:42:18 +01:00
Ziqi Zhao
bf880a6e77
enhance floathistogram add and sub method
...
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-08-16 22:26:31 +08:00
Julien Pivotto
651b5a049a
Merge pull request #12701 from mmorel-35/main-1
...
ci(deps): group k8s and opentelemetry dependencies
2023-08-16 13:33:07 +02:00
Matthieu MOREL
7e91a79c49
ci(deps): group k8s and opentelemetry dependencies
...
Dependabot allows to group dependencies by a list of pattern.
This allows it on k8s.io and opentelemetry dependencies separately
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-08-15 20:50:29 +02:00
Julien Pivotto
009017a3fb
Revert "Remove deleted target from discovery manager"
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-08-14 23:29:39 +02:00
Bryan Boreham
b6192be856
Release: volunteer Bryan Boreham to shepherd 2.47
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-14 16:24:19 +00:00
Bryan Boreham
d6e1b1acdb
Merge pull request #12681 from prometheus/labels-unused-code
...
labels: remove some unused code
2023-08-14 15:48:17 +01:00
Bryan Boreham
5007fa305d
Merge pull request #12680 from bboreham/faster-has
...
labels: improve Has() method for stringlabels build
2023-08-14 15:47:47 +01:00
Bryan Boreham
d7293ea8b5
Merge pull request #12676 from prometheus/otel-resend-count
...
remote-write: add http.resend_count tracing attribute
2023-08-14 15:47:06 +01:00
Bryan Boreham
1e3fef6ab0
scraping: limit detail on dropped targets, to save memory ( #12647 )
...
It's possible (quite common on Kubernetes) to have a service discovery
return thousands of targets then drop most of them in relabel rules.
The main place this data is used is to display in the web UI, where
you don't want thousands of lines of display.
The new limit is `keep_dropped_targets`, which defaults to 0
for backwards-compatibility.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-14 15:39:25 +01:00
Julien Pivotto
103b8567d6
Merge pull request #12541 from haleyao/main
...
Remove deleted target from discovery manager
2023-08-14 15:37:59 +02:00
Bryan Boreham
5cea37c069
Merge pull request #12682 from bboreham/contains-same-label-set
...
promql engine: check unique labels using existing map
ContainsSameLabelset constructs a map with the same hash key as the one used to compile the output of rangeEval, so we can use that one and save work.
Need to hold the timestamp so we can be sure we saw the same series in the same evaluation.
2023-08-14 14:12:47 +01:00
Julien Pivotto
ea039fcebf
Merge pull request #11463 from proggga/small_refactor
...
marathon.go: Simplified conditions in method
2023-08-14 15:09:02 +02:00
Bryan Boreham
0670e4771a
promql engine: check unique labels using existing map
...
`ContainsSameLabelset` constructs a map with the same hash key as
the one used to compile the output of `rangeEval`, so we can use that
one and save work.
Need to hold the timestamp so we can be sure we saw the same series
in the same evaluation.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-13 18:09:10 +01:00
Bryan Boreham
ce260b1fe1
labels: remove some unused code
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-13 15:14:53 +01:00
Bryan Boreham
b5c6807fea
Labels.Has quick check on first character
...
Exit early if we've gone past - labels are sorted in order.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-13 15:11:22 +01:00
Bryan Boreham
33aab1b2cc
labels: extend benchmark for Has()
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-13 14:55:50 +01:00
Bryan Boreham
d2ae8dc3cb
remote-write: add http.resend_count tracing attribute
...
As recommended by the OpenTelemetry semantic conventions.
https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/#http-client
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-08-11 16:20:12 +00:00
Julien Pivotto
4a56a6bf59
Merge pull request #12643 from gouthamve/add-otlp-docs
...
Add initial OTLP ingestion docs
2023-08-08 13:08:22 +02:00
Julien Pivotto
e3fabd5fdf
Merge pull request #12664 from prometheus/superq/cleanup_chunk_snapshots
...
Cleanup temporary chunk snapshot dirs
2023-08-08 13:02:39 +02:00
SuperQ
8d38d59fc5
Cleanup temporary chunk snapshot dirs
...
Simlar to cleanup of WAL files on startup, cleanup temporary
chunk_snapshot dirs. This prevents storage space leaks due to terminated
snapshots on shutdown.
Signed-off-by: SuperQ <superq@gmail.com>
2023-08-08 09:43:48 +02:00
Julien Pivotto
4c81a8f681
Merge pull request #11578 from chancefeick/fix/querying-documentation
...
Fix Querying Documentation Links
2023-08-08 09:21:31 +02:00
Bryan Boreham
8d47b3d497
Merge pull request #12579 from charleskorn/timestamp
...
Don't recreate iterator for each series on each timestep when evaluating a query with `timestamp()`
2023-08-05 10:51:38 +01:00
Julien Pivotto
c3311272d9
Merge pull request #12652 from colega/fix-typo-in-append-histogram-param-name
...
Fix typo in Appender.AppendHistogram() arg name
2023-08-04 16:37:40 +02:00
Oleg Zaytsev
6ea6def0d3
Use zeropool when replaying agent's DB WAL ( #12651 )
...
Same as https://github.com/prometheus/prometheus/pull/12189 but for
tsdb/agent/db.go
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-08-04 10:39:55 +02:00
Oleg Zaytsev
c810e7cae3
Fix typo in Appender.AppendHistogram() arg name
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-08-04 10:21:16 +02:00
Goutham
acb1f8a097
Fix API endpoint
...
Signed-off-by: Goutham <gouthamve@gmail.com>
2023-08-03 14:02:32 +02:00
Pablo Baeyens
5e21b3b2c6
[go.mod] Bump go.opentelemetry.io/collector/pdata
to v1.0.0-rcv0014
( #12623 )
...
This is the latest release candidate for the pdata module.
Go will pick the latest released version by default with commands such as `go get`
and ignore pre-released versions, but this version includes updates.
Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2023-08-03 13:59:37 +02:00
Goutham Veeramachaneni
9df36c3e5e
Apply suggestions from code review
...
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Goutham Veeramachaneni <gouthamve+github@gmail.com>
2023-08-03 13:56:54 +02:00
Oleg Zaytsev
61daa30bb1
Pass ref to SeriesLifecycleCallback.PostDeletion ( #12626 )
...
When a particular SeriesLifecycleCallback tries to optimize and run
closer to the Head, keeping track of the HeadSeriesRef instead of the
labelsets, it's impossible to handle the PostDeletion callback properly
as there's no way to know which series refs were deleted from the head.
This changes the callback to provide the series refs alongside the
labelsets, so the implementation can choose what to do.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-08-03 10:56:27 +02:00
Goutham
6bb5720141
Add initial OTLP ingestion docs
...
We still need a guide that we can link users to in https://github.com/prometheus/docs/tree/main/content/docs/guides
This guide should show sending metrics from application directly via
the OTel SDKs and also sending through the Collector.
Signed-off-by: Goutham <gouthamve@gmail.com>
2023-08-03 00:12:15 +02:00
Julien Pivotto
95cad0b070
Merge pull request #12640 from prometheus/dependabot/go_modules/github.com/scaleway/scaleway-sdk-go-1.0.0-beta.20
...
build(deps): bump github.com/scaleway/scaleway-sdk-go from 1.0.0-beta.19 to 1.0.0-beta.20
2023-08-02 16:16:44 +02:00