1194 commits

Author	SHA1	Message	Date
György Krajcsovits	44ebbb8458	Fix missing histogram copy in sampleRing ... The specialized version of sample add to the ring: func addH(s hSample, buf []hSample, r *sampleRing) []hSample func addFH(s fhSample, buf []fhSample, r *sampleRing) []fhSample already correctly copy histogram samples from the reused hReader, fhReader buffers, but the generic version does not. This means that the data is overwritten on the next read if the sample ring has seen histogram and float samples at the same time and switched to generic mode. The `genericAdd` function (which was commented anyway) is by now quite different from the specialized functions so that this commit deletes it. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-02 13:57:28 +02:00
Bryan Boreham	54de4fb780	Merge pull request #14975 from colega/process-mempostings-delete-with-gomaxprocs-workers ... Process `MemPostings.Delete()` with `GOMAXPROCS` workers	2024-09-29 07:58:42 +01:00
Ayoub Mrini	105ab2e95a	fix(test): adjust defer invocations (#14996) ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-27 17:13:51 +01:00
Oleg Zaytsev	ada8a6ef10	Add some more tests for MemPostings_Delete ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-27 10:14:39 +02:00
Arthur Silva Sens	d5f65cfce0	Merge pull request #14694 from prometheus/ct-histogram ... Histogram CT Zero ingestion	2024-09-26 12:48:46 -03:00
Arthur Silva Sens	95a53ef982	Join tests for appending float and histogram CTs ... Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2024-09-26 11:29:31 -03:00
Arthur Silva Sens	6bd9b1a7cc	Histogram CT Zero ingestion ... Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2024-09-26 11:29:22 -03:00
Oleg Zaytsev	4fd2556baa	Extract processWithBoundedParallelismAndConsistentWorkers ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-26 15:43:19 +02:00
Oleg Zaytsev	ccd0308abc	Don't do anything if MemPostings are empty ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 15:00:10 +02:00
Oleg Zaytsev	9c417aa710	Fix deadlock with empty MemPostings ... Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 14:08:50 +02:00
Bryan Boreham	5d8f0ef0c2	Merge pull request #14721 from bboreham/exp-grow-postings ... [PERF] TSDB: Grow postings by doubling	2024-09-25 10:47:55 +01:00
Oleg Zaytsev	e196b977af	Process MemPostings.Delete() with GOMAXPROCS workers ... We are still seeing lock contention on MemPostings.mtx, and MemPostings.Delete() is by far the most expensive operation on that mutex. This adds parallelism to that method, trying to reduce the amount of time we spend with the mutex held. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-25 10:38:47 +02:00
Bryan Boreham	ca673eb749	Merge remote-tracking branch 'origin/release-2.55' into merge-2.55-into-main ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-22 17:49:34 +01:00
Bryan Boreham	31c5760551	Neater string vs byte-slice conversions (#14425) ... unsafe.Slice and unsafe.StringData were added in Go 1.20 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-21 12:19:21 +02:00
Bryan Boreham	d42232e178	Merge pull request #14932 from bboreham/chunk-xor-combine-writebits ... [PERF] TSDB: Chunk encoding: shorten some write sequences	2024-09-20 17:53:54 +01:00
Bryan Boreham	6f0d6038b7	[BUGFIX] TSDB: Only query chunks up to truncation time (#14948) ... If the query overlaps the range currently undergoing compaction, we should only fetch chunks up to that time. Need to store that min time in `HeadAndOOOIndexReader`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-20 17:44:04 +01:00
Bryan Boreham	9215252221	[BUGFIX] TSDB: Only query chunks up to truncation time (#14948) ... If the query overlaps the range currently undergoing compaction, we should only fetch chunks up to that time. Need to store that min time in `HeadAndOOOIndexReader`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-20 18:40:17 +02:00
Ganesh Vernekar	5ccb069414	Backward compatibility with upcoming index v3 ... Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2024-09-19 10:27:52 +01:00
George Krajcsovits	0d22a91267	Merge pull request #14874 from krajorama/fix-panic-in-ooo-query2 ... BUGFIX: TSDB: panic in chunk querier	2024-09-19 10:03:53 +01:00
Bryan Boreham	e8c2d916ec	lint ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-18 15:23:46 +01:00
Bryan Boreham	648a668835	[PERF] Chunk encoding: combine timestamp writes ... Instead of a 2-bit write followed by a 14-bit write, do two 8-bit writes, which goes much faster since it avoids looping. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-18 13:19:21 +01:00
Bryan Boreham	b9a9689aae	[PERF] Chunk encoding: simplify writeByte ... Rather than append a zero then set the value at that position, append the value. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-18 13:19:04 +01:00
Bryan Boreham	b65f1b6560	TSDB: Improve xor-chunk benchmarks ... Benchmarks must do the same work N times. Run 3 cases, where the values are constant, vary a bit, and vary a lot. Also aim for 120 samples same as TSDB default. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-18 13:14:49 +01:00
Bryan Boreham	bb47f78929	Merge pull request #14505 from marioferh/improve_performance_regex ... [CHANGE] regexp . to match \n and optimize performance	2024-09-18 09:54:16 +01:00
Antoine Pultier	d90d0976b5	fix(bstream/writeByte): ensure it appends only one byte (#14854) ... fix(bstream/writeByte): ensure it appends only one byte Signed-off-by: Antoine Pultier <antoine.pultier@sintef.no>	2024-09-17 16:28:33 +02:00
machine424	d1b4312f0a	fix(wlog/watcher_test.go): make TestRun_AvoidNotifyWhenBehind more resilient ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-17 13:11:04 +02:00
Mario Fernandez	5814920601	Fix: optimize .* regexp performance ... Shortcut for `.*` matches newlines as well. Add preamble change ^(?s: Add test dotAll flag por al regex Add and fix regex tests Signed-off-by: Mario Fernandez <mariofer@redhat.com>	2024-09-17 12:18:31 +02:00
Bryan Boreham	d5f4fabd12	Merge pull request #14911 from bboreham/clarify-postings-benchmark ... TSDB: Simplify benchmark regexps	2024-09-17 11:52:13 +02:00
Carrie Edwards	14e3c05ce8	tsdb: Add support for ingestion of out-of-order native histogram samples (#14546) ... Add support for ingesting OOO native histograms * Add flag for enabling and disabling OOO native histogram ingestion * Update OOO querying tests to include native histogram samples * Add OOO head tests * Add test for OOO native histogram counter reset headers Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored by: Carrie Edwards <edwrdscarrie@gmail.com> Co-authored by: Jeanette Tan <jeanette.tan@grafana.com> Co-authored by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored by: Fiona Liao <fiona.liao@grafana.com>	2024-09-17 11:19:06 +02:00
Harry John	919dc0cbc6	storage: Update LabelQuerier interface to return sorted label values (#14849) ... * Change LabelQuerier.LabelValues() to return sorted values --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>	2024-09-17 08:55:02 +02:00
Bryan Boreham	a8133f3e87	TSDB: Simplify benchmark regexps ... Several regexps were coded like `"^.*$"`, which is an unnatural formulation nobody is likely to use. Inside `NewMatcher`, `^` and `$` are added anyway, which makes the form in the benchmark redundant. It even printed it out in the expected way. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-09-16 17:48:05 +01:00
George Krajcsovits	5aa3d8260a	TSDB: OOO native histograms: prep for multiple ooo head chunks (#14850) ... * tsdb: mmapCurrentOOOHeadChunk prepare for multiple ooo chunks Currently float samples can only create a single ooo head chunk, but native histograms can result in multiple due to counter resets, etc. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * tsdb: getOOOSeriesChunks prepare for multiple ooo chunks Currently float samples can only create a single ooo head chunk, but native histograms can result in multiple due to counter resets, etc. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-11 23:55:39 +01:00
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868) ... * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2024-09-10 22:32:03 +02:00
Bryan Boreham	16e5e99546	Merge pull request #14767 from bboreham/fix-encoding-comment ... [Comment] Correct the comment on Decbuf.UvarintBytes	2024-09-09 12:52:36 +01:00
György Krajcsovits	d3f4e7c223	Remove unnecessary conversion ... Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-09 12:51:02 +02:00
György Krajcsovits	60ab1cc5a5	BUGFIX: TSDB: panic in chunk querier ... Followup to #14831 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-09 12:43:02 +02:00
George Krajcsovits	536d9f9ce9	BUGFIX: TSDB: panic in query during truncation with OOO head (#14831) ... Check if headQuerier is nil before trying to use it. * TestQueryOOOHeadDuringTruncate: unit test to check query during truncate Regression test for #14822 * Simulate race between query and Compact() Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-09-05 17:17:42 +01:00
Joshua Hesketh	f2064c7987	NH: Do not re-use spans between histograms (#14771) ... promql, tsdb (histograms): Do not re-use spans between histograms When multiple points exist with the same native histogram schemas they share their spans. This causes a problem when a native histogram (NH) schema is modified (for example, during a Sum) then the other NH's with the same spans are also modified. As such, we should create a new Span for each NH. This will ensure NH's interfaces are safe to use without considering the effect on other histograms. At the moment this doesn't present itself as a problem because in all aggregations and functions operating on native histograms they are copied by the promql query engine first. Signed-off-by: Joshua Hesketh <josh@nitrotech.org> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org>	2024-09-04 12:07:16 +02:00
George Krajcsovits	282fb1632a	Merge pull request #14772 from krajorama/fix-mockseriesiterator ... Fix: chunkenc.MockSeriesIterator	2024-09-03 16:55:26 +02:00
Arthur Silva Sens	442f24e099	chore: Simplify TestHeadAppender_AppendCTZeroSample (#14812) ... Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2024-09-02 21:30:37 +01:00
Arve Knudsen	2cfc7b244a	Merge pull request #14700 from shandongzhejiang/main ... Comments: fix some function names	2024-09-02 18:59:28 +02:00
Oleg Zaytsev	ce7d830f1f	Bring back BenchmarkLoadRealWLs (#14757) ... This was part of #14525 which was reverted. I still think that having this benchmark committed in to the repo is useful. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-09-02 17:20:10 +01:00
György Krajcsovits	a693dd19f2	Fix: chunkenc.MockSeriesIterator ... Starts its index from 0 , but users call Next() before first sample so it needs to start from -1 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-08-30 16:44:36 +02:00
Bryan Boreham	0a4f130b39	[Comment] Correct the comment on Decbuf.UvarintBytes ... The value is valid when returned, but can become invalid later. Return to previous wording. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-08-30 09:40:18 +01:00
Callum Styan	a77f5007f9	fix bug with metadata for rw2 (#14766) ... Signed-off-by: Callum Styan <callumstyan@gmail.com>	2024-08-30 08:14:20 +01:00
Bryan Boreham	1f38ae7bca	[TESTS] TSDB: fix up OOO tests for new Series behaviour ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-08-29 10:59:09 +01:00
Bryan Boreham	cde42f30e9	TSDB: streamline reading of overlapping head chunks ... `getOOOSeriesChunks` was already finding sets of overlapping chunks; we store those in a `multiMeta` struct so that `ChunkOrIterable` can reconstruct an `Iterable` easily and predictably. We no longer need a `MergeOOO` flag to indicate that this Meta should be merged with other ones; this is explicit in the `multiMeta` structure. We also no longer need `chunkMetaAndChunkDiskMapperRef`. Add `wrapOOOHeadChunk` to defeat `chunkenc.Pool` - chunks are reset during compaction, but if we wrap them (like `safeHeadChunk` was doing then this is skipped) . Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-08-29 10:57:29 +01:00
Bryan Boreham	838e49e7b8	[REFACTOR] TSDB: move chunkFromSeries from headChunkReader to head ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-08-29 10:51:48 +01:00
Björn Rabenstein	1d6e0071b7	Merge pull request #14751 from riskrole/main ... chore: fix some comments	2024-08-28 16:38:39 +02:00
riskrole	406bf775aa	chore: fix some comments ... Signed-off-by: riskrole <yuhang@before.tech>	2024-08-28 11:26:57 +08:00