Nicolás Pazos
b2cc998418
lint
...
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2024-06-27 13:45:17 -03:00
Nicolás Pazos
236017da35
Merge branch 'main' into njpm/rw2-main-sync
2024-06-27 13:31:02 -03:00
Bartlomiej Plotka
4dbcdd19da
[PRW-2.0] (part 2) Removed automatic negotiation, updates for the latest spec semantics in remote pkg ( #14329 )
...
* [PRW-2.0] (part2) Moved to latest basic negotiation & spec semantics.
Spec: https://github.com/prometheus/docs/pull/2462
Supersedes https://github.com/prometheus/prometheus/pull/13968
Signed-off-by: bwplotka <bwplotka@gmail.com>
# Conflicts:
# config/config.go
# docs/configuration/configuration.md
# storage/remote/queue_manager_test.go
# storage/remote/write.go
# web/api/v1/api.go
* Addressed comments.
Signed-off-by: bwplotka <bwplotka@gmail.com>
---------
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-06-26 11:20:01 +01:00
Bryan Boreham
f24ce00320
Merge pull request #13434 from bboreham/elide-queriers
...
storage: don't wrap single querier in merge-queriers
2024-06-25 17:47:09 +01:00
Arve Knudsen
1abeebacb8
Merge pull request #14340 from aknuds1/arve/fix-lint
...
Upgrade to golangci-lint v1.59.1, fix errors
2024-06-25 18:01:25 +02:00
Jan-Otto Kröpke
99355443c7
remote write handler: reject samples with future timestamps ( #14304 )
...
* fix(remote_write): reject samples with future timestamps
* increase check to +10 minutes to allow for clock drift
---------
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
Co-authored-by: Bryan Boreham <bjboreham@gmail.com>
2024-06-25 12:25:39 +01:00
Bartlomiej Plotka
2b348d43b7
[PRW-2.0] (chain1) New Remote Write 2.0 Config options for 2.0-rc.1 spec. ( #14335 )
...
NOTE: For simple review this change does not touch remote/ packages, only main and configs.
Spec: https://prometheus.io/docs/specs/remote_write_spec_2_0
Supersedes https://github.com/prometheus/prometheus/pull/13968
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-06-25 07:15:27 +01:00
Arve Knudsen
d902116b41
Fix various linting errors
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-06-24 16:11:53 -07:00
Bryan Boreham
6030407d25
Merge branch 'main' into elide-queriers
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-06-24 11:17:33 +01:00
Martin Chodur
00b110c65c
Fix data corruption in remote write if max_sample_age is applied ( #14078 )
...
* fix: try to reproduce the bug from https://github.com/prometheus/prometheus/issues/13979 in a test case
Signed-off-by: David Vavra <sevenood@gmail.com>
* fix: data corruption in remote write if max_sample_age is applied
Signed-off-by: David Vavra <sevenood@gmail.com>
* add benchmark for buildTimeSeries which does the filtering
Signed-off-by: Callum Styan <callumstyan@gmail.com>
---------
Signed-off-by: David Vavra <sevenood@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: David Vavra <sevenood@gmail.com>
Co-authored-by: Callum Styan <callumstyan@gmail.com>
2024-06-21 14:19:58 -07:00
Piotr
d78253319d
queue_manager: add histogram info to error logs ( #14326 )
...
Signed-off-by: Piotr Gwizdala <17101802+thampiotr@users.noreply.github.com>
2024-06-20 16:45:13 -07:00
Marco Pracucci
35564c0cb0
Export remote.LabelsToLabelsProto() and remote.LabelProtosToLabels()
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2024-06-19 17:30:49 +02:00
Marco Pracucci
0fbf4a2529
Export remote.ToLabelMatchers()
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2024-06-17 10:40:45 +02:00
Bryan Boreham
42b546a43d
tsdb: add details to duplicate sample error ( #13277 )
...
Now the error will include the timestamp and the existing and new values.
When you are trying to track down the source of this error, it can be
useful to see that the values are close, or alternating, or something
else.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-06-04 08:54:09 +01:00
Jayapriya Pai
2d2b440304
fix: correct the typo in azuread sdk auth ( #14106 )
...
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
2024-05-21 19:08:35 +02:00
Oleksandr Redko
f10c3454e9
Enable perfsprint linter and fix up code
...
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
2024-05-15 17:51:05 +03:00
Anthony Mirabella
3b8b57700c
otlp: Remove OTel feature gate registration from copied translation package ( #13932 )
...
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-05-10 10:41:21 +02:00
Bryan Boreham
3fd24d1cd7
Merge pull request #13999 from bboreham/extract-promqltest
...
[Test] Extract most PromQL test code into separate packages
2024-05-09 13:23:11 +01:00
Arve Knudsen
d699dc3c77
Fix language in docs and comments ( #14041 )
...
Fix language in docs and comments
---------
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
2024-05-08 17:57:09 +02:00
Bryan Boreham
8fd96241ab
test: add promqltest package references
...
To packages outside of promql.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-05-08 16:08:04 +01:00
Bartlomiej Plotka
6673c346e9
[PRW 2.0] Moved rw2 proto to the full path (both package name and placement) ( #13973 )
...
undefined
2024-05-08 08:08:00 +01:00
Arve Knudsen
fc34570b06
prometheusremotewrite: Move TimeSeries method to timeseries.go
...
To facilitate generating OTel translation code for other Prometheus
compatible backends, modify the prometheusremotewrite sources slightly
so that the PrometheusConverter.TimeSeries method is in a file called
timeseries.go. The rationale is to allow other backends to define their
own implementation of this method.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-05-01 13:02:10 +02:00
Arve Knudsen
9189507569
prometheusremotewrite: Add PrometheusConverter.FromMetrics benchmark
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-04-30 13:13:37 +02:00
Arve Knudsen
99f3051f45
OTLP: Use PrometheusConverter directly
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-04-30 13:10:27 +02:00
Arve Knudsen
759ca8b207
Merge branch 'main' into refactor/add_max_func_to_maxTimestamp
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-04-30 11:50:37 +02:00
Jesus Vazquez
7554384dac
otlp: Prometheus to own its own copy of the otlptranslator package ( #13991 )
...
After a lot of productive discussion between the Prometheus and
OpenTelemetry community we decided that it made sense for Prometheus to
own its own copy of the code in charge for handling OTLP ingestion
traffic.
This commit is removing the README and update-copy.sh files that had the
previous steps to update the code.
Also it is updating the licensing of all the files to make sure the
OpenTelemetry provenance is explicit and to state the new ownership.
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-04-30 11:29:52 +02:00
komisan19
b974a99279
fix
...
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
2024-04-30 10:45:50 +09:00
komisan19
3d84d4d6dc
fix
...
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
2024-04-22 19:04:00 +09:00
komisan19
5ab24a06d0
refactor: add max func to maxTimestamp
...
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
2024-04-21 23:39:25 +09:00
bwplotka
c5c6660e6b
Fixes after main sync.
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-04-18 09:49:48 +01:00
bwplotka
ea97c70720
Merge remote-tracking branch 'origin/main' into rw-2-main2
...
# Conflicts:
# cmd/prometheus/main.go
# docs/command-line/prometheus.md
# documentation/examples/remote_storage/go.mod
# documentation/examples/remote_storage/go.sum
# storage/remote/client.go
# storage/remote/otlptranslator/prometheusremotewrite/helper.go
# storage/remote/queue_manager.go
# storage/remote/queue_manager_test.go
# storage/remote/write_handler.go
# storage/remote/write_handler_test.go
# tsdb/wlog/watcher_test.go
2024-04-18 08:35:32 +01:00
Alex Greenbank
bb12d690c3
remote write 2.0 - content negotiation remediation ( #13921 )
...
* Consolidate renegotiation error into one, fix tests
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
* fix metric name and actuall increment counter
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
---------
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-04-17 14:41:04 +01:00
Matthieu MOREL
6f595c6762
golangci-lint: enable whitespace linter ( #13905 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-04-11 09:27:54 +01:00
Matthieu MOREL
d496687c8e
golangci-lint: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-04-08 19:26:23 +00:00
Alex Greenbank
ae9d2a772a
latest tweaks
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-04-04 13:27:28 +00:00
Alex Greenbank
4a758f1685
Latest updates to review comments
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-04-04 12:56:40 +00:00
Alex Greenbank
7b40203302
Changes based on review comments
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-04-02 14:51:39 +00:00
carehabit
a672662073
all: fix some typos ( #13863 )
...
Signed-off-by: carehabit <shenyuting@outlook.com>
2024-04-01 18:06:05 +02:00
Arve Knudsen
d8e4230696
storage: Fix mockChunkQuerier type name
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-03-22 07:44:38 +01:00
Alex Greenbank
95f1ee61cf
Fix todos around 405 HEAD handling
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-21 15:41:39 +00:00
Alex Greenbank
e5c5ef1a2d
Almost done with lint
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-20 16:14:14 +00:00
Alex Greenbank
ca20eb9f32
Fix another test race
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-19 19:03:22 +00:00
Alex Greenbank
b884b15f39
Fix race in test
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-19 18:28:20 +00:00
Alex Greenbank
766d947ba5
Lint
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-19 18:06:48 +00:00
Alex Greenbank
04929dc610
first draft of content negotiation
...
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
2024-03-19 17:16:20 +00:00
Jan-Otto Kröpke
302e151de8
{discovery,remote_write}/azure: Support default SDK authentication ( #13099 )
...
* discovery/azure: Offer default SDK authentication
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
2024-03-16 11:06:57 +00:00
Julien
d1abc3f255
Merge pull request #13777 from roidelapluie/remoteread2
...
Chunked remote read: close the querier earlier
2024-03-15 14:42:30 +01:00
Julien Pivotto
53091126c2
Chunked remote read: close the querier earlier
...
I have seen prometheis instances misebehaving because of broken chinked remote
read requests.
In order to avoid OOM's when this happens, I propose to close the
queries used by the streamed remote read requests earlier.
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2024-03-15 14:03:16 +01:00
Jakub Čajka
505fd638be
otlptranslator: fix up import paths
...
Signed-off-by: Jakub Čajka <jcajka@redhat.com>
2024-03-13 15:56:14 +01:00
Björn Rabenstein
9acae57937
Merge pull request #13681 from krajorama/native-latency-histograms
...
Add native histograms to latency/duration metrics
2024-03-07 20:46:43 +01:00