gotjosh
e1f2da74a3
api: provide metadata for a single metric
...
This adds support for a new query param on the new `api/v1/metadata`
endpoint that provides metadata for a specified metric via the V1 API.
It collapses metadata that is equal across all targets, and aggregates
under the same metric name the ones that differ.
Signed-off-by: gotjosh <josue@grafana.com>
2019-12-10 21:17:49 +00:00
gotjosh
0a0a228db3
api: provide per metric metadata ( #6420 )
...
* api: provide per metric metadata
This adds a new endpoint that provides per metric metadata via the V1 API.
It collapses metadata that is equal across all targets, and aggregates under the same metric name the ones that differ.
* Allow tests to be asserted on response length
Some tests e.g. limit on API responses, don't require an assertion on
equality.
This allows us to assert against response length instead of
equality.
Signed-off-by: gotjosh <josue@grafana.com>
2019-12-10 14:56:16 +00:00
Boyko
1c66aea992
React UI: Implement alerts page ( #6402 )
...
* url filter rules param
Signed-off-by: blalov <boiskila@gmail.com>
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* address review changes
Signed-off-by: blalov <boiskila@gmail.com>
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* ui initial commit
Signed-off-by: blalov <boiskila@gmail.com>
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* improve ui
Signed-off-by: blalov <boiskila@gmail.com>
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* fix typo in component name
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* create query link + ui enhancements
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
Signed-off-by: blalov <boiskila@gmail.com>
* add count to state labels
Signed-off-by: blalov <boiskila@gmail.com>
* put alerts table render in the right place
Signed-off-by: blalov <boiskila@gmail.com>
* refactoring
Signed-off-by: blalov <boiskila@gmail.com>
* fix rules endpoint test
Signed-off-by: blalov <boiskila@gmail.com>
* lint fixes
Signed-off-by: blalov <boiskila@gmail.com>
* test query params
Signed-off-by: blalov <boiskila@gmail.com>
* refactoring
Signed-off-by: blalov <boiskila@gmail.com>
* review changes
Signed-off-by: blalov <boiskila@gmail.com>
* adding down arrow as click indicator in Alert
Signed-off-by: blalov <boiskila@gmail.com>
* add period at the end of the comment
Signed-off-by: blalov <boiskila@gmail.com>
* review changes
Signed-off-by: blalov <boiskila@gmail.com>
* remove left-over css
Signed-off-by: blalov <boiskila@gmail.com>
* adding expand/collapse arrows on Alert
Signed-off-by: blalov <boiskila@gmail.com>
* create proper expression for alert name
Signed-off-by: blalov <boiskila@gmail.com>
2019-12-09 23:42:59 +01:00
Tom Wilkie
de0a772b8e
Port tsdb to use pkg/labels. ( #6326 )
...
* Port tsdb to use pkg/labels.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Get tests passing.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Remove useless cast.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Appease linters.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Fix review comments
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2019-11-18 11:53:33 -08:00
Tobias Guggenmos
be2bcc50a2
Fix target metadata API for empty match_targets ( #6303 )
...
According to the documentation, the target metadata API accepts it,
if no value for match_target has been provided. This was not the case
in the implementation.
This commit make the API behave as described in the docs.
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2019-11-14 12:09:44 +01:00
Sharad Gaur
a85e7aac0e
Adding TSDB Stats Page in React UI ( #6281 )
...
Signed-off-by: Sharad Gaur <sgaur@splunk.com>
2019-11-12 11:15:20 +01:00
Dustin Hooten
ca60bf298c
React UI: Implement /targets page ( #6276 )
...
* Add LastScrapeDuration to targets endpoint
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Add Scrape job name to targets endpoint
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Implement the /targets page in react
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Add state query param to targets endpoint
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Use state filter in api call
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* api feedback
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* pr feedback frontend
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Implement and use localstorage hook
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* PR feedback
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
2019-11-11 22:42:24 +01:00
Boyko
cb7cbad5f9
WIP: status page - API and UI ( #6243 )
...
* status page initial commit
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* refactor useFetch
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* refactoring
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* adding tests
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* snapshot testing
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* fix wrong go files formatting
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* change the snapshot library
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* update api paths
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* move test folder outside src
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* useFetches tests
Signed-off-by: blalov <boyko.lalov@tick42.com>
* sticky navbar
Signed-off-by: Boyko Lalov <boyskila@gmail.com>
Signed-off-by: blalov <boyko.lalov@tick42.com>
* handle runtimeInfo error on Gather() and add json tags to RuntimeInfo struct
Signed-off-by: blalov <boyko.lalov@tick42.com>
* refactor alert managers section
Signed-off-by: blalov <boyko.lalov@tick42.com>
2019-11-02 16:53:32 +01:00
Goutham Veeramachaneni
4c648eddf4
vendor: Update json-iterator ( #6030 )
...
Also add explicit support for NaN/Inf
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2019-09-17 19:22:26 +05:30
Bartek Płotka
48b2c9c8ea
remote-read: streamed chunked server side; Extended protobuf; Added chunked, checksumed reader ( #5703 )
...
Part of: https://github.com/prometheus/prometheus/issues/4517 and https://github.com/improbable-eng/thanos/issues/488
Changes:
* Extended protobuf for chunked remote read and negotation.
* Added checksumed, chunked Writer/Reader.
* Added Server side implementation for chunked streamed remote-read.
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
2019-08-19 21:16:10 +01:00
Ganesh Vernekar
5ecef3542d
Cleanup after merging tsdb into prometheus
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2019-08-13 14:04:14 +05:30
Thomas Jackson
fef150f1b5
Add tests to ensure we can marshal and unmarshal our min/max times ( #5734 )
...
* Add tests to ensure we can marshal and unmarshal our min/max times
Related to https://github.com/prometheus/client_golang/issues/614
Instead of implementing all the time parsing, we can special-case handle
these 2 times. This means if times in this format show up that
time.Parse can't handle they will still error, but we can marshal/parse
our own min/max time
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2019-07-08 10:43:59 +01:00
Thomas Jackson
91d7175eaa
Add storage.Warnings to LabelValues and LabelNames ( #5673 )
...
Fixes #5661
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2019-06-17 08:31:17 +01:00
Alex Salt
d6a4daa26a
web api: handle alert with Infinity/NaN values ( #5582 )
...
* web/api/v1: alert value as string in alert/rules endpoints
Signed-off-by: Alexander Saltykov <alexander-s@yandex-team.ru>
2019-05-21 10:41:54 +01:00
Simon Pasquier
45506841e6
*: enable all default linters ( #5504 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-05-03 15:11:28 +02:00
Bob Shannon
8c8bb82d04
Add support for POSTing to /series endpoint ( #5422 )
...
* Add support for POSTing to /series endpoint
* Document query API POST support
Signed-off-by: Bob Shannon <bob.m.shannon@gmail.com>
2019-04-02 18:00:29 +01:00
Tariq Ibrahim
8fdfa8abea
refine error handling in prometheus ( #5388 )
...
i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors.
ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives.
iii) Does away with the use of fmt package for errors in favour of pkg/errors
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
2019-03-26 00:01:12 +01:00
Bharath
91306bdf24
Support non POST methods for Lifecycle and Admin APIs ( #5376 )
...
Signed-off-by: Bharath Thiruveedula <bharath_ves@hotmail.com>
2019-03-20 17:33:45 +00:00
Tom Wilkie
c7b3535997
Use pkg/relabelling in remote write.
...
- Unmarshall external_labels config as labels.Labels, add tests.
- Convert some more uses of model.LabelSet to labels.Labels.
- Remove old relabel pkg (fixes #3647 ).
- Validate external label names.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-03-18 20:31:12 +00:00
Palash Nigam
09208b1a58
queryRange: Add more descriptive error messages ( #5229 )
...
Fixes: https://github.com/prometheus/prometheus/issues/4811
Signed-off-by: Palash Nigam <npalash25@gmail.com>
2019-02-19 19:16:14 +00:00
Hrishikesh Barman
a1f34bec2e
Added CORS Origin flag ( #5011 )
...
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
2019-01-17 15:01:06 +00:00
Callum Styan
5358f76c5c
update remote write path proto so that Labels/Timeseries can't be nil ( #4957 )
...
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2019-01-15 19:13:39 +00:00
Simon Pasquier
f678e27eb6
*: use latest release of staticcheck ( #5057 )
...
* *: use latest release of staticcheck
It also fixes a couple of things in the code flagged by the additional
checks.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Use official release of staticcheck
Also run 'go list' before staticcheck to avoid failures when downloading packages.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-01-04 14:47:38 +01:00
Tom Wilkie
6e08029b56
Move err to be the last return value from storage.Select. ( #5054 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-02 11:10:13 +00:00
Julius Volz
11a52be1d8
Better rounding for incoming query timestamps ( #4941 )
...
Fixes https://github.com/prometheus/prometheus/issues/4939
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-12-03 20:25:54 +08:00
mknapphrt
f0e9196dca
Return warnings on a remote read fail ( #4832 )
...
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
2018-11-30 14:27:12 +00:00
Ben Kochie
c6399296dc
Fix spelling/typos ( #4921 )
...
* Fix spelling/typos
Fix spelling/typos reported by codespell/misspell.
* UK -> US spelling changes.
Signed-off-by: Ben Kochie <superq@gmail.com>
2018-11-27 17:44:29 +01:00
Fabian Reinartz
a9803e9ecb
Correctly skip mismatching targets
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
2018-11-23 17:10:31 +01:00
Ganesh Vernekar
ca93fd544b
/api/v1/labels endpoint for getting all label names ( #4835 )
...
* vendor: update tsdb
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* /api/v1/labels endpoint
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* regex matchers for API
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Add docs
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Matchers behaving as OR
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Removed the matchers
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* vendor: update tsdb using go mod
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* vendor update: tsdb
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Added LabelNames() to storage.Querier
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Test for api.labelNames
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Nits
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-11-19 15:51:14 +05:30
Simon Pasquier
6fa8de132b
web/v1/api: add tests for admin actions ( #4767 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2018-11-15 14:22:16 +01:00
Goutham Veeramachaneni
7acedbce64
web(api): Make query and range api errors match
...
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2018-11-14 15:25:54 +05:30
Simon Pasquier
a308a186e4
web/api/v1: fix targets endpoint
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2018-10-25 11:10:26 +02:00
Brian Brazil
9c03e11c2c
Hook OpenMetrics parser into scraping.
...
Extend metadata api to support units.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2018-10-18 13:58:00 +01:00
Goutham Veeramachaneni
ffb7f829ec
Merge pull request #4730 from prometheus/release-2.4
...
Release 2.4
2018-10-12 14:15:42 -07:00
Tariq Ibrahim
d371697841
Adding new metric type to track in-flight queries via the remote read API endpoint. ( #4699 )
...
* Adding new metric type to track in-flight queries via the remote read API endpoint.
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
* fix review comments
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
* fix comments
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-10-10 16:09:08 -07:00
Simon Pasquier
3c00eeaf16
web/api/v1: fix optional skip_head for snapshot ( #4674 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2018-10-02 16:18:07 +05:30
Krasi Georgiev
47a673c3a0
process scrape loops reloading in parallel ( #4526 )
...
The scrape manage receiver's channel now just saves the target sets
and another backgorund runner updates the scrape loops every 5 seconds.
This is so that the scrape manager doesn't block the receiving channel
when it does the long background reloading of the scrape loops.
Active and dropped targets are now saved in each scrape pool instead of
the scrape manager. This is mainly to avoid races when getting the
targets via the web api.
When reloading the scrape loops now happens in parallel to speed up the
final disared state and this also speeds up the prometheus's shutting
down.
Also updated some funcs signatures in the web package for consistency.
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-09-26 12:20:56 +03:00
Tom Wilkie
4c52400708
Limit concurrent remote reads. ( #4656 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-09-25 20:07:34 +01:00
Goutham Veeramachaneni
3e87c04b83
Logger is nil for API. Fixes #4577 ( #4583 )
...
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2018-09-06 16:07:48 +05:30
Tom Wilkie
457e4bb58e
Limit the number of samples remote read can return. ( #4532 )
...
* Limit the number of samples remote read can return.
- Return 413 entity too large.
- Limit can be set be a flag. Allow 0 to mean no limit.
- Include limit in error message.
- Set default limit to 50M (* 16 bytes = 800MB).
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-09-05 15:50:50 +02:00
Max Inden
ecf676cf97
web/api: Expose rule health and last error ( #4501 )
...
Expose rule health and last evaluation error on `/api/v1/rules`.
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
2018-08-23 18:30:10 +05:30
Julius Volz
8fbe1b5133
Handle a bunch of unchecked errors ( #4461 )
...
There are many more (mostly finalizers like Close/Stop/etc.), but most of
the others seemed like one couldn't do much about them anyway.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-17 17:24:35 +02:00
Max Leonard Inden
71fafad099
api/v1: Coninue work exposing rules and alerts
...
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
2018-07-30 15:31:51 +02:00
mg03
31f8ca0dfb
api v1 alerts/rules json endpoint
...
Signed-off-by: mg03 <mgeng03@gmail.com>
2018-07-30 15:29:44 +02:00
Tom Wilkie
b1f600343f
Merge pull request #4359 from prometheus/report-errors
...
Log errors encountered when marshalling and writing responses.
2018-07-25 13:39:04 +01:00
Tom Wilkie
02534510ca
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-07-25 13:35:47 +01:00
Tom Wilkie
901e6d1f82
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-07-25 13:17:10 +01:00
Thomas Jackson
92c6f0c92e
Add offset to selectParams ( #4226 )
...
* Add Start/End to SelectParams
* Make remote read use the new selectParams for start/end
This commit will continue sending the start/end time of the remote read
query as the overarching promql time and the specific range of data that
the query is intersted in receiving a response to is now part of the
ReadHints (upstream discussion in #4226 ).
* Remove unused vendored code
The genproto.sh script was updated, but the code wasn't regenerated.
This simply removes the vendored deps that are no longer part of the
codegen output.
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2018-07-18 04:58:00 +01:00
Tom Wilkie
f83155b11e
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-07-13 19:31:23 +01:00
Tom Wilkie
ccb2ee607b
Log errors encountered when marshalling and writing responses.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-07-06 18:44:45 +01:00