Marco Pracucci
c461e22341
Improve fast regexp matcher cache ( #482 )
...
* Limit FastRegexMatcher by size (bytes) and add a TTL to each entry
Signed-off-by: Marco Pracucci <marco@pracucci.com>
* Add TestNewFastRegexMatcher_CacheSizeLimit
Signed-off-by: Marco Pracucci <marco@pracucci.com>
* Tolerate ristretto goroutines when checking goroutine leaks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
* Tolerate ristretto goroutines when checking goroutine leaks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
---------
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2023-04-17 15:20:58 +02:00
Bryan Boreham
9bb9faabb1
rules tests: use EmptyLabels instead of nil
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-27 18:03:52 +00:00
Ganesh Vernekar
41649ceb1b
Merge remote-tracking branch 'upstream/main' into codesome/sync-prom
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-22 08:35:08 +05:30
Björn Rabenstein
847093479b
Merge pull request #11978 from trevorwhitney/set-counter-hint
...
Set `CounterResetHint` and use in recording rules
2023-03-14 21:52:41 +01:00
Trevor Whitney
c3e0a83725
rules: no longer force CounterResetHint to Gauge
...
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
2023-03-14 14:22:07 -06:00
Ganesh Vernekar
7e74f73733
Merge remote-tracking branch 'upstream/main' into sync-prom
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-13 12:38:59 +05:30
Yuri Nikolic
88d9726b20
Fixing conflicts with commit 666f61a4d5
2023-03-08 16:54:40 +01:00
Yuri Nikolic
13c2945af0
Fixing conflicts with commit 86d3d5fec6
2023-03-08 16:48:58 +01:00
Charles Korn
3db98d7dde
Avoid unnecessary allocations in recording rule evaluation ( #11812 )
...
Re-use the Builder each time round the loop.
2023-03-08 12:57:19 +00:00
Ying WANG
f6b8a939f9
Rules: Increase tolerance for missed iterations on alerts
2023-03-07 17:34:48 +01:00
Bryan Boreham
3f7ba22bde
rules: two places need to call EmptyLabels
...
Can't assume nil is a valid value.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-02-22 15:14:07 +00:00
Julien Pivotto
259bb5c692
Merge pull request #11826 from dannykopping/dannykopping/rule-eval
...
Pass rule details in evaluation context
2023-02-14 21:38:19 +01:00
Justin Lei
af1d9e01c7
Refactor tsdbutil for tests/native histograms ( #11948 )
...
* Add float histograms to ChunkFromSamplesGeneric
Signed-off-by: Justin Lei <justin.lei@grafana.com>
* Add Generate*Samples functions to tsdbutil
Signed-off-by: Justin Lei <justin.lei@grafana.com>
* PR responses
Signed-off-by: Justin Lei <justin.lei@grafana.com>
---------
Signed-off-by: Justin Lei <justin.lei@grafana.com>
2023-02-10 17:09:33 +05:30
Marco Pracucci
2461dee551
Merge remote-tracking branch 'remotes/prometheus/main' into update-upstream
2023-01-26 18:41:17 +01:00
Danny Kopping
98c70e1817
Correcting NewAlertingRule args
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-26 13:21:50 +02:00
Danny Kopping
df078e0a84
Merge branch 'main' into dannykopping/rule-eval
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-26 13:10:18 +02:00
Julien Pivotto
e811d14963
Add comments
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-01-23 13:59:43 +01:00
Danny Kopping
c4ca791f18
Appeasing the linter
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-20 10:53:42 +02:00
Danny Kopping
6486d28c7a
Panic if rule type was not expected
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-20 10:27:50 +02:00
Peter Štibraný
44904a663c
Rename "execution time" to "evaluation time". ( #401 )
...
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
2023-01-19 15:11:44 +00:00
Peter Štibraný
806e71e828
Option to align rule group's evaluation time to interval ( #400 )
...
* Allow rule groups evaluation timestamp to be aligned on the evaluation interval.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
2023-01-19 14:51:26 +01:00
Julien Pivotto
c0724f4e62
New test
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-01-19 11:56:04 +01:00
Julien Pivotto
2c408289f8
Add stabilizing to UI
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-01-19 11:33:54 +01:00
Julien Pivotto
5ad74e6e71
Add tests
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-01-19 10:36:01 +01:00
fayzal-g
7aef6e28fe
Merge remote-tracking branch 'upstream/main' into merge-jan-16-upstream
2023-01-16 15:24:00 +00:00
Julien Pivotto
ce55e5074d
Add 'keep_firing_for' field to alerting rules
...
This commit adds a new 'keep_firing_for' field to Prometheus alerting
rules. The 'resolve_delay' field specifies the minimum amount of time
that an alert should remain firing, even if the expression does not
return any results.
This feature was discussed at a previous dev summit, and it was
determined that a feature like this would be useful in order to allow
the expression time to stabilize and prevent confusing resolved messages
from being propagated through Alertmanager.
This approach is simpler than having two PromQL queries, as was
sometimes discussed, and it should be easy to implement.
This commit does not include tests for the 'resolve_delay' field. This
is intentional, as the purpose of this commit is to gather comments on
the proposed design of the 'resolve_delay' field before implementing
tests. Once the design of the 'resolve_delay' field has been finalized,
a follow-up commit will be submitted with tests."
See https://github.com/prometheus/prometheus/issues/11570
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-01-13 12:11:39 +01:00
Ganesh Vernekar
d82ea2eb1c
Merge pull request #11838 from codesome/histo-rec
...
rules: Support native histograms
2023-01-12 12:35:15 +05:30
Ganesh Vernekar
98a0523e4a
rules: Test native histograms in recording rules
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-01-11 18:27:57 +05:30
Ganesh Vernekar
53a5071a72
rules: Support native histograms
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-01-10 19:07:24 +05:30
Danny Kopping
4d8478d9ac
Add license header to appease CI
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-09 11:05:56 +02:00
Danny Kopping
72527b5f12
Refactoring for simplicity
...
Include labels
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-09 11:01:46 +02:00
Danny Kopping
d8f3e7d16c
gofumpt
...
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-09 11:01:25 +02:00
Danny Kopping
79300340af
Adding recording/alerting rule origin context
...
This will allow correlation of executed rule queries with their associated rule names and type
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2023-01-09 11:01:24 +02:00
György Krajcsovits
103c4fd289
Merge remote-tracking branch 'upstream/main' into main
...
# Conflicts:
# .github/workflows/ci.yml
# tsdb/block.go
# tsdb/compact.go
# tsdb/compact_test.go
# tsdb/head_read.go
# tsdb/index/index.go
# tsdb/ooo_head_read.go
# tsdb/querier_test.go
2023-01-08 14:55:44 +01:00
Ganesh Vernekar
f1a332c496
rules: Consider ErrTooOldSample in expected errors
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-01-05 14:49:30 +05:30
Bryan Boreham
cdbe7f462b
Update package rules for new labels.Labels type
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-19 15:22:09 +00:00
Bryan Boreham
3c7de69059
storage: allow re-use of iterators
...
Patterned after `Chunk.Iterator()`: pass the old iterator in so it
can be re-used to avoid allocating a new object.
(This commit does not do any re-use; it is just changing all the method
signatures so re-use is possible in later commits.)
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-15 18:32:45 +00:00
Julius Volz
1a2c645dfa
Correctly handle error unwrapping in rules and remote write receiver
...
errors.Unwrap() actually dangerously returns nil if the error does not have an
Unwrap() method, which is the case in at least one of these places where I
noticed that no error was being logged at all when it should have.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2022-12-15 12:50:55 +01:00
Jeanette Tan
51cf003517
Merge remote-tracking branch 'upstream/main'
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2022-11-23 01:39:23 +08:00
Ganesh Vernekar
648be89822
Merge remote-tracking branch 'upstream/main' into fix-conflict
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-10-12 14:20:02 +05:30
Ganesh Vernekar
c77b24bcb2
Merge pull request #337 from grafana/sync-prom
...
Sync with upstream
2022-10-11 11:31:52 +05:30
Ganesh Vernekar
b522fb0b76
Merge remote-tracking branch 'upstream/main' into sync-prom
2022-10-10 18:07:39 +05:30
Ganesh Vernekar
8a4a659d73
Fix build and upgrade CI Go to 1.18.7
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-10-10 14:35:33 +05:30
Ganesh Vernekar
46b26c4f09
Fix notifier relabel changing the labels of active alerts ( #11427 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-10-07 20:28:17 +05:30
Jesus Vazquez
e934d0f011
Merge 'main' into sparsehistogram
...
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
2022-10-05 22:14:49 +02:00
Ganesh Vernekar
83d9ee3ab7
Merge remote-tracking branch 'upstream/main' into sync-prom
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-10-05 20:33:36 +05:30
Dimitar Dimitrov
0fc0832427
Add tests
2022-09-09 22:35:10 +02:00
Dimitar Dimitrov
6b33c90efe
Add option to always restore the state of rules when loading
2022-09-09 22:01:11 +02:00
Bryan Boreham
8297f5cb6b
rules: in tests use labels.FromStrings
...
And a number of `EmptyLabels()` instead of `nil`.
Replacing code which assumes the internal structure of `Labels`.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-09-09 13:34:49 +02:00
Cosrider
bef6556ca5
delete redundant alias ( #11180 )
...
Signed-off-by: Cosrider <cosrider7@gmail.com>
Signed-off-by: Cosrider <cosrider7@gmail.com>
2022-08-31 15:50:38 +02:00