mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-14 17:44:06 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
13149 commits 248 branches 440 tags 657 MiB
Commit graph

13149 commits

This branch
This branch
All branches
Author SHA1 Message Date
Björn Rabenstein 806073ad63
Merge pull request #14091 from alexandear/enable-perfsprint-linter 
Enable perfsprint linter and fix up code issues
 2024-05-15 17:43:43 +02:00
Oleksandr Redko f10c3454e9 Enable perfsprint linter and fix up code 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
 2024-05-15 17:51:05 +03:00
Björn Rabenstein 179163a4c6
Merge pull request #14103 from krajorama/handle-context-cancel-in-postingsformatcher 
tsdb/index/postings: fix missing lock unlock
 2024-05-15 14:37:12 +02:00
György Krajcsovits b215a41be4 tsdb/index/postings: fix missing lock unlock 
Followup to #14096

Unfortunately the previous PR introduced this bug by not releasing the
lock before returning.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-05-15 14:02:39 +02:00
George Krajcsovits fdaafdb041
tsdb: check for context cancel before regex matching postings (#14096) 
* tsdb: check for context cancel before regex matching postings

Regex matching can be heavy if the regex takes a lot of cycles to
evaluate and we can get stuck evaluating postings for a long time
without this fix. The constant checkContextEveryNIterations=100
may be changed later.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-05-15 06:26:19 +02:00
Bryan Boreham 10eb23bd6b [TEST] Rules: Sleep 15ms to fit Windows behaviour better 
On Windows, Go will sleep 15ms if you ask for less.  TestAsyncRuleEvaluation
compares actual delay to the nominal time, so using 15ms should work
better on Windows, and be hardly noticeable elsewhere.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-14 17:45:42 +01:00
Björn Rabenstein e6be4240be
Merge pull request #14068 from colega/quote-label-name-in-matchers-when-needed 
Bugfix: quote label name in matchers when needed
 2024-05-14 17:18:58 +02:00
George Krajcsovits 4a5d8461ba
Merge pull request #14098 from zenador/nhcb-merge-main 
[nhcb branch] Merge from main
 2024-05-14 15:34:24 +02:00
Bryan Boreham dc926527ae
Merge pull request #13669 from aiwhj/optimization 
[ENHANCEMENT] Relabeling: small speed-up of hashmod

Code optimization: The relabel operation is used very frequently, and strconv.FormatInt() with better performance should be used.
 2024-05-14 12:54:00 +01:00
Bryan Boreham 67326d8e5c
Merge pull request #13758 from nemobis/federicol-remotewrite-tuning 
[DOCS] Remote-Write: Clarify batch_send_deadline docs
 2024-05-14 12:28:19 +01:00
Jeanette Tan f028496133 Merge branch 'main' into nhcb 
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
 2024-05-14 16:20:15 +08:00
Neeraj Gartia 661856cb65 removes the added tests from engine_test.go 
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
 2024-05-13 22:58:25 +05:30
Neeraj Gartia 6119124d0e some nits 
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
 2024-05-13 22:55:38 +05:30
Neeraj Gartia adf5a36c1e adds test for sum, count, stddev, stdvar, quantile and fraction func to promql testing framework 
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
 2024-05-13 22:55:38 +05:30
Neeraj Gartia 8b838a05d9 adds test for native histogram rate func in promql testing framework 
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
 2024-05-13 22:55:38 +05:30
Neeraj Gartia 548bd9d6fb adds TestNativeHistogramRate func to promql test framework 
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
 2024-05-13 22:55:38 +05:30
Oleg Zaytsev 8b4c9459a2
Check utf8.RuneError result 
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-13 17:44:26 +02:00
Oleg Zaytsev dbe88fae22
Add invalid utf8 test cases to regexp 
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-13 17:05:31 +02:00
Oleg Zaytsev bcff5059e6
Use utf8.DecodeRuneInString(s) 
This replaces the custom `moreThanOneRune` function with the standard
`utf8.DecodeRuneInString(s)` that can be used to figure out the size of
the first rune.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-13 15:41:00 +02:00
Oleg Zaytsev fdfc6d4725
Benchmark zeroOrOneCharacterStringMatcher.Matches 
This adds some more test cases for unicode values, and also a benchmark
for zeroOrOneCharacterStringMatcher.Matches()

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-13 15:36:55 +02:00
Charles Korn 0e934dba8e
Capture timing information while sorting 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-05-13 19:47:18 +10:00
Charles Korn 036c87223c
Ensure series in matrix values returned for instant queries are always sorted 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-05-13 11:03:15 +10:00
Charles Korn a4381608a0
Add failing test case 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-05-13 11:03:14 +10:00
Anthony Mirabella 3b8b57700c
otlp: Remove OTel feature gate registration from copied translation package (#13932) 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
 2024-05-10 10:41:21 +02:00
Bryan Boreham ea82b49c33 [ENHANCEMENT] PromQL: use Kahan summation for sum() 
This can give a more precise result, by keeping a separate running
compensation value to accumulate small errors.

See https://en.wikipedia.org/wiki/Kahan_summation_algorithm

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-09 14:29:38 +01:00
Arve Knudsen aabe4d6e4a promql.ActiveQueryTracker: Unmap mmapped file when done 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-05-09 14:27:29 +02:00
Bryan Boreham 3fd24d1cd7
Merge pull request #13999 from bboreham/extract-promqltest 
[Test] Extract most PromQL test code into separate packages
 2024-05-09 13:23:11 +01:00
Arve Knudsen 5c4310aa37
[ENHANCEMENT] TSDB: Optimize querying with regexp matchers 
Add method `PostingsForLabelMatching` to `tsdb.IndexReader`, to obtain postings for labels with a certain name and values accepted by a provided callback, and use it from `tsdb.PostingsForMatchers`.
The intention is to optimize regexp matcher paths, especially not having to load all label values before matching on them.

Plus tests, and refactor some `tsdb/index.Reader` methods.

Benchmarking shows memory reduction up to ~100%, and speedup of up to ~50%.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2024-05-09 10:55:30 +01:00
Oleg Zaytsev b7b4355807
Use bytes.Buffer from stack buf in Matcher.String() 
Also removed the growing until there's a benchmark for that.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-09 10:00:24 +02:00
Arthur Silva Sens 879d80922a
Merge pull request #14063 from prometheus/prepare-2.52 
Prepare v2.52.0 release
 2024-05-08 18:34:42 -03:00
Bryan Boreham 786e0e706c test: PromQL: stop using internal fields of engine 
* set enablePerStepStats and lookback duration via
  `NewTestEngine` parameters.
* check maxSamples by recreating query engine
* check lookback without modifying internals

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 19:58:41 +01:00
Arve Knudsen d699dc3c77
Fix language in docs and comments (#14041) 
Fix language in docs and comments

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
 2024-05-08 17:57:09 +02:00
Bryan Boreham 0dbfd20b69 test: move most PromQL tests into separate test package 
So that they can import promqltest which imports promql.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 16:28:56 +01:00
Bryan Boreham 4a72607c4a refactor: extract some PromQL Engine tests which use unexported structs 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 16:27:17 +01:00
Bryan Boreham 8fd96241ab test: add promqltest package references 
To packages outside of promql.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 16:08:04 +01:00
Bryan Boreham e7c77f7b40 promql: export NewTestQuery 
So that tests can call it from another package.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 16:08:04 +01:00
Bryan Boreham babfcfdd91 refactor: Move NewTestEngine into promqltest 
And export `DefaultMaxSamplesPerQuery` so callers can replicate previous
behaviour.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 16:07:28 +01:00
Oleg Zaytsev 6ebda5a7bc
Optimize Matcher.String() 
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-08 17:05:27 +02:00
Oleg Zaytsev dabd789fd5
Quote label name in matchers when needed 
When the label name of a matcher contains non-standard characters, like
a dot, or starts with a digit, it should be quoted.

If it's not quoted, then `VectorSelector.String()` isn't a valid PromQL.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-05-08 16:58:51 +02:00
Arve Knudsen 0ba747187d
Merge pull request #14020 from aknuds1/arve/direct-otlp 
prometheusremotewrite: Move TimeSeries method to timeseries.go
 2024-05-08 15:03:57 +02:00
Björn Rabenstein 178935d0e9
Merge pull request #14043 from aknuds1/arve/chunkenc-refactor 
tsdb/chunkenc.Pool: Refactor Get and Put
 2024-05-08 15:03:18 +02:00
Bryan Boreham b3c15d2246 test: clean up promqltest package references 
So it nearly compiles.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham 9aa321d672 test: make field initializers explicit 
Lint started complaining after I moved the file.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham ccf73266f0 test: move promqltest tests together with the implementation 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham 11b27d5d22 test: move test files into new promqltest package 
So that promql package does not bring in test-only dependencies.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham a6e427660a test: check for @-modifier without using engine internals 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham 2b0c87b1b6 test: turn TestKahanSum into scripted test 
This saves having a function solely to call kahanSumInc.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:55 +01:00
Bryan Boreham a1af3c27d4 refactor: extract almost.Equal() to new package 
To avoid a circular reference between promql and promqltest.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-05-08 13:42:10 +01:00
zenador 545a7e48f9
[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009) 
* process custom values in histogram unit test framework
* check for warnings when evaluating in unit test framework
* add test cases for custom buckets in test framework

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
 2024-05-08 13:58:24 +02:00
George Krajcsovits 5f153a8b3f
Merge pull request #14067 from zenador/nhcb-merge-main 
[nhcb branch] Merge main
 2024-05-08 13:56:06 +02:00