mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-14 01:24:04 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
7648 commits 247 branches 438 tags 656 MiB
Commit graph

4 commits

Author SHA1 Message Date
Bartlomiej Plotka cd9516316a Addressed Brian's comments. 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-03-13 14:37:47 +00:00
Bartlomiej Plotka fe802f29c9 storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. 
This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in
Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet
which rely on sorting.

I found during work on https://github.com/prometheus/prometheus/pull/5882 that
we do so many repetitions because of this, for not good reason. I think
I found a good balance between convenience and readability with just one method.
Smaller the interface = better.

Also I don't know what TestSelectSorted was testing, but now it's testing sorting.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-03-13 13:06:25 +00:00
Bartlomiej Plotka 59c9d6ef45 Addressed Brian's comments, moved metrics to main.go 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-02-17 18:03:57 +00:00
李国忠 3cd6a5b050
Storage concurrently tests and bug fix (#6808) 
* Storage concurrently tests and bug fix

Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
 2020-02-12 08:58:52 +00:00