mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-13 17:14:05 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
12484 commits 247 branches 438 tags 656 MiB
Commit graph

688 commits

Author SHA1 Message Date
michaelact eea6ab1cdd
[BUGFIX] Azure SD: Fix 'error: parameter virtualMachineScaleSetName cannot be empty' (#13702) 
Erroneous code was introduced during a merge-back-to-main at #13399.

Signed-off-by: michaelact <86778470+michaelact@users.noreply.github.com>
 2024-03-08 15:19:39 +00:00
Björn Rabenstein dbb4055633
Merge pull request #13593 from machine424/no-index 
discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers…
 2024-02-27 10:48:37 +01:00
Augustin Husson 9738e48a7d
Merge pull request #13629 from prometheus/release-2.50 
merge back release 2.50
 2024-02-22 11:07:52 +01:00
machine424 92544c00bf
discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers in RoleEndpointSlice 
This was due to a missing "return", see https://github.com/prometheus/prometheus/pull/13554#discussion_r1490965817

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-02-16 14:29:28 +01:00
Darshan Chaudhary 0e8a2e44a4
Azure SD: check for nil before accessing and dereferencing (#13578) 
Signed-off-by: darshanime <deathbullet@gmail.com>
 2024-02-14 17:59:01 +01:00
Bryan Boreham 6005ac6f9d
Merge pull request #9311 from Creatone/creatone/use-testify-3 
tests: Move from t.Errorf and others. (Part 3)
 2024-02-05 18:48:59 +01:00
Bryan Boreham 857138d3ce review feedback 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-04 15:52:50 +01:00
Bryan Boreham b17f88b7fb consul sd tests: don't call FailNow from a background goroutine 
This is not allowed by the Go test framework.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-01 15:15:48 +00:00
Bryan Boreham 46008fdecd lint 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-01 14:57:11 +00:00
Ayoub Mrini 581d8d86b4
Pod status changes not discovered by Kube Endpoints SD (#13337) 
* fix(discovery/kubernetes/endpoints): react to changes on Pods because some modifications can occur on them without triggering an update on the related Endpoints (The Pod phase changing from Pending to Running e.g.).

---------

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>
 2024-02-01 12:34:37 +00:00
Paweł Szulik 7f24efccdb Refactor discovery tests to use testify. 
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
 2024-01-31 16:42:11 +00:00
Julien Pivotto 960b6266e2
Merge pull request #13447 from ptodev/update-puppetdb-metric-label 
Change metric label for Puppet SD from 'http' to 'puppetdb'
 2024-01-26 15:40:15 +01:00
Augustin Husson 9a9e73b34a
update all go dependencies (#13438) 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
 2024-01-24 16:53:32 +01:00
Paulin Todev 53589fde4f
Change metric label for Puppetdb from 'http' to 'puppetdb' 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2024-01-23 19:24:13 +00:00
Paulin Todev 78411d5e8b
SD Managers taking over responsibility for registration of debug metrics (#13375) 
SD Managers take over responsibility for SD metrics registration

---------

Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
Signed-off-by: Björn Rabenstein <github@rabenste.in>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
 2024-01-23 16:53:55 +01:00
Bryan Boreham b9952ff571
Merge pull request #13380 from machine424/fixes 
fix(discovery tests): allow requireUpdate util to timeout in discovery/file…
 2024-01-18 14:11:01 +00:00
machine424 2d01e56695
chore(kubernetes): check preconditions earlier and avoid unnecessary checks or iterations 
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-01-16 12:10:35 +01:00
Bartlomiej Plotka db3544c552
Merge branch 'main' into merge-2.49.0-back 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2024-01-15 12:38:36 +01:00
machine424 afc05129f1
fix(discovery): allow requireUpdate util to timeout in discovery/file/file_test.go. 
The loop ran indefinitely if the condition isn't met.

Before, each iteration created a new timer channel which was always outpaced by
the other timer channel with smaller duration.

minor detail: There was a memory leak: resources of the ~10 previous timers were
constantly kept. With the fix, we may keep the resources of one timer around for defaultWait
but this isn't worth the changes to make it right.

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-01-07 21:18:08 +01:00
daniel-resdiary d79ad810aa Get VM Scale Set NIC (#13283) 
Calling `*armnetwork.InterfacesClient.Get()` doesn't work for Scale Set
VM NIC, because these use a different Resource ID format.

Use `*armnetwork.InterfacesClient.GetVirtualMachineScaleSetNetworkInterface()`
instead.  This needs both the scale set name and the instance ID, so
add an `InstanceID` field to the `virtualMachine` struct.  `InstanceID`
is empty for a VM that isn't a ScaleSetVM.

Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>
 2023-12-19 19:20:02 +00:00
Julien Pivotto 5d5303c746
Merge pull request #13285 from daniel-resdiary/DedupGetNic 
Dedup code handling getting network interface
 2023-12-18 15:27:18 +01:00
Julien Pivotto 7600e6cc05
Merge pull request #13294 from mmorel-35/azure 
build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager
 2023-12-18 12:13:50 +01:00
Julien Pivotto 10557ed8e0
Merge pull request #13278 from Automaat/feat/extend-kuma-sd-api 
kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId
 2023-12-18 12:12:07 +01:00
Matthieu MOREL 952cb41373 build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-12-15 10:25:07 +00:00
Daniel Nicholls 0704c72548 Dedup code handling getting network interface 
Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>
 2023-12-13 14:14:01 +00:00
daniel-resdiary 103133124a
Get VM Scale Set NIC (#13283) 
Calling `*armnetwork.InterfacesClient.Get()` doesn't work for Scale Set
VM NIC, because these use a different Resource ID format.

Use `*armnetwork.InterfacesClient.GetVirtualMachineScaleSetNetworkInterface()`
instead.  This needs both the scale set name and the instance ID, so
add an `InstanceID` field to the `virtualMachine` struct.  `InstanceID`
is empty for a VM that isn't a ScaleSetVM.

Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>
 2023-12-13 12:38:16 +00:00
Marcin Skalski e27232614a code review 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
 2023-12-12 08:32:46 +01:00
Marcin Skalski 0af810aa71 fix go lint 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
 2023-12-11 17:01:52 +01:00
Marcin Skalski d12ccf9fa2 kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
 2023-12-11 16:33:42 +01:00
Paulin Todev d2e997030e
Fix linter issues 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 14:28:37 +00:00
Paulin Todev 27bb57a37b
Define metric label values in one place 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 13:39:01 +00:00
Paulin Todev 108a749a45
Set up labels for counters in advance 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 13:39:00 +00:00
Paulin Todev 6a5306a53c
Use const labels for Discovery Manager metrics. 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 11:14:27 +00:00
Paulin Todev 6de80d7fb0
Allow non-default registry to be used for metrics of SD components 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 11:14:26 +00:00
Gavin Lam d5924f305b
Fix missing public IP addresses in Azure service discovery (#13241) 
Fixes #5588, #9293

Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
 2023-12-07 11:42:14 +00:00
Matthieu MOREL 9c4782f1cc
golangci-lint: enable testifylint linter (#13254) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-12-07 11:35:01 +00:00
Julien Pivotto 52b15d2195
Merge pull request #13219 from djcode/main 
Discovery: Add support for NS records to DNS Discovery
 2023-12-01 16:10:07 +01:00
Daniel Jolly 9ebea5e1ca Removed extra whitespace 
Signed-off-by: Daniel Jolly <code@danieljolly.com>
 2023-11-29 12:50:09 -05:00
Oleksandr Redko 2a75604f8e
Enable default revive rules (#13068) 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-11-29 17:23:34 +00:00
Daniel Jolly 2c420b518e Add support for NS records in DNS discovery 
Signed-off-by: Daniel Jolly <code@danieljolly.com>
 2023-11-29 12:21:50 -05:00
Charles Korn 2329fba0e5
Fix linting issues in comments (#13178) 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2023-11-23 09:07:23 +00:00
Etourneau Gwenn b37258c99b
Added Caching of network interface for Azure (#12622) 
* Added Caching of network interface for Azure

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Rename Counter for Azure cache

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Format with goimports

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Updated duration comparaison
Enabled cache by default with 5x the default refresh time

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Change random function

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Remove refresh interval

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Remove from config as well

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

* Reformat config_test
Removed uneeded error

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>

---------

Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>
 2023-11-21 11:59:17 +00:00
Bryan Boreham 6613195487
Merge pull request #13097 from roidelapluie/gpu 
Linode SD: Add __meta_linode_gpus label
 2023-11-13 14:22:37 +00:00
Julien Pivotto 222d46d243 Linode: Add GPU label 
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
 2023-11-03 15:34:31 -04:00
Matthieu MOREL fe057fc60d use Go standard errors package 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-11-03 07:26:31 +00:00
Oleksandr Redko fa90ca46e5 ci(lint): enable godot; append dot at the end of comments 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-10-31 19:53:38 +02:00
Matthieu MOREL 68e6b4dd34
ci(lint): enable errorlint on discovery (#12918) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-10-31 12:46:55 +01:00
Oleksandr Redko 8e5f0387a2
ci(lint): enable nolintlint and remove redundant comments (#12926) 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-10-31 12:35:13 +01:00
Matthieu MOREL bbdc7d5902 Update Azure SDK For Go 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-10-14 03:39:31 +00:00
Julien Pivotto 4b735f02a6
Merge pull request #10569 from zzJinux/discovery-manager-run 
Fix discovery managers to be properly cancelled
 2023-09-29 12:07:55 +02:00