98 commits

Author	SHA1	Message	Date
Neeraj Gartia	d4b1f9eb33	Corrects the behaviour of binary opperators between histogram and float (#14726) ... promql: corrects binary operators functioning for mixed sample with histogram and float For invalid pairings of sample types, an annotation is added now. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-10-15 14:44:36 +02:00
Björn Rabenstein	5b9148e552	Merge pull request #14820 from charleskorn/promqltest-native-histogram-format ... promqltest: use test expression format for histograms in assertion failure messages and include reset hint in the test expression	2024-09-20 16:47:08 +02:00
Charles Korn	6dbb4e1a94	Fix linting issues ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-09-20 11:49:54 +10:00
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868) ... * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2024-09-10 22:32:03 +02:00
Charles Korn	e8c7482137	Return negative counts when multiplied or divided by a negative value ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-09-09 14:37:59 +10:00
Charles Korn	e67358d203	histogram: include counter reset hint in test expression output ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-09-04 15:46:52 +10:00
György Krajcsovits	505ffd34ef	Fix lint error ... Some weird formatting issue in using comment suggestion Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-06-24 09:33:03 +02:00
George Krajcsovits	f45709e710	Update model/histogram/histogram_test.go ... Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-06-24 07:51:56 +02:00
Jeanette Tan	5e4e93c316	fix lint ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-06-07 19:24:05 +08:00
Jeanette Tan	14f8dded39	Merge branch 'main' into nhcb ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-06-07 19:17:14 +08:00
Jeanette Tan	9adc1699c3	fix according to code review ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-06-07 18:50:59 +08:00
Bryan Boreham	d635bcaa84	Merge pull request #13587 from tylitianrui/chore/typo_20240215 ... chore:fix typo	2024-06-04 14:43:18 +03:00
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code ... Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	2024-05-15 17:51:05 +03:00
zenador	545a7e48f9	[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009) ... * process custom values in histogram unit test framework * check for warnings when evaluating in unit test framework * add test cases for custom buckets in test framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-05-08 13:58:24 +02:00
zenador	81862aabd7	[nhcb branch] Add basic unit tests for native histograms with custom buckets converted from classic histograms (#13794) ... * modify unit test framework to automatically generate native histograms with custom buckets from classic histogram series * add very basic tests for classic histogram converted into native histogram with custom bounds * fix histogram_quantile for native histograms with custom buckets * make loading with nhcb explicit * evaluate native histograms with custom buckets on queries with explicit keyword * use regex replacer * use temp histogram struct for automatically loading converted nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-04-24 09:36:05 +02:00
György Krajcsovits	a3d1a46eda	Merge branch 'main' into nhcb	2024-03-22 14:51:48 +01:00
zenador	4acbb7dea6	Add custom buckets to native histogram chunks encoding (#13706) ... * add custom bounds to chunks encoding * change custom buckets schema number * rename custom bounds to custom values Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-03-22 14:36:39 +01:00
machine424	f477e0539a	Move from golang.org/x/exp/slices into slices now that we only support Go >= 1.21 ... Prevent adding back golang.org/x/exp/slices. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-02-28 14:54:53 +01:00
György Krajcsovits	5d0a0a7542	Add custom buckets to native histogram model (#13592) ... * add custom buckets to native histogram model * simple copy for custom bounds * return errors for unsupported add/sub operations * add test cases for string and update appendhistogram in scrape to account for new schema * check fields which are supposed to be unused but may affect results in equals * allow appending custom buckets histograms regardless of max schema Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-02-28 14:06:43 +01:00
tyltr	084420b837	chore:fix typo ... Signed-off-by: tyltr <tylitianrui@126.com>	2024-02-15 20:40:22 +08:00
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340) ... Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-01-23 17:02:14 +01:00
zenador	a3ddfbd1ee	Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram (#13392) ... Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-01-17 17:06:35 +01:00
tyltr	1fa131ee03	fix slice copy in 1.20 (#13389) ... The slices package is added to the standard library in Go 1.21; we need to import from the exp area to maintain compatibility with Go 1.20. Signed-off-by: tyltr <tylitianrui@126.com>	2024-01-16 11:06:58 +00:00
Björn Rabenstein	928d07e3bd	Merge branch 'main' into arve/typos ... Signed-off-by: Björn Rabenstein <beorn@grafana.com>	2023-12-12 12:02:03 +01:00
Filip Petkovski	9008271df5	Use cap to determine slice capacity ... Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2023-12-08 10:23:01 +01:00
Filip Petkovski	10a82f87fd	Enable reusing memory when converting between histogram types ... The 'ToFloat' method on integer histograms currently allocates new memory each time it is called. This commit adds an optional *FloatHistogram parameter that can be used to reuse span and bucket slices. It is up to the caller to make sure the input float histogram is not used anymore after the call. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2023-12-08 10:22:59 +01:00
Björn Rabenstein	85078b968f	Merge pull request #13208 from linasm/panic-free-float-histogram-add-sub ... FloatHistogram.Add/Sub: handle any schema change	2023-12-07 20:12:21 +01:00
Björn Rabenstein	de1ec731c7	Merge pull request #13212 from linasm/optimize-floatBucketIterator-for-common-case ... Histograms: optimize floatBucketIterator for common case	2023-12-07 20:11:58 +01:00
Linas Medziunas	bd895baefc	FloatHistogram.Add/Sub: handle any schema change ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-12-07 20:50:54 +02:00
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254) ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2023-12-07 11:35:01 +00:00
Arve Knudsen	237bfea46b	chunks.Reader: Fix typo in ChunkOrIterable doc string. ... Also fix comment typo in `FloatHistogram.Sub`. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2023-12-07 08:28:45 +01:00
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	2023-11-29 17:23:34 +00:00
Linas Medziunas	048886ae8a	Histograms: optimize floatBucketIterator for common case ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-29 08:54:05 +02:00
Linas Medziunas	49613823f8	Reuse slices in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-28 15:45:31 +02:00
Björn Rabenstein	a6d4b8d97b	Merge pull request #13190 from linasm/fix-float-histogram-add-sub-mutating-argument ... Fix FloatHistogram.Add/Sub mutating its argument	2023-11-28 14:04:50 +01:00
Linas Medziunas	f99ecc376e	Fix FloatHistogram.Add/Sub mutating its argument ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-26 09:26:34 +02:00
Linas Medziunas	ea1862aab4	Explicit schema check in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-25 11:38:15 +02:00
Ziqi Zhao	e250f09b5d	change origin schema in ReduceResolution method of histogram and float histogram (#13116) ... * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-11-10 14:33:34 +01:00
Ziqi Zhao	ab2a7bb74f	add generic shrink function (#13001) ... Add `ReduceResolution` method to `Histogram` and `FloatHistogram` This takes the original `mergeToSchema` function and turns it into a more generic `reduceResolution` function, which is the building block for the new methods. The methods will help with addressing #12864. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-11-08 14:43:05 +01:00
Matthieu MOREL	05fba53e57	web : use Go standard package ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2023-11-08 06:37:59 +00:00
Linas Medziunas	ebed7d0612	Change Validate to be a method on histogram structs ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-03 16:47:59 +02:00
Linas Medziunas	1f8aea11d6	Move histogram validation code to model/histogram ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-03 16:17:24 +02:00
Björn Rabenstein	fae4561369	Merge pull request #12954 from linasm/linasm/optimize-floatBucketIterator2 ... Histogram performance: optimize floatBucketIterator	2023-11-02 23:59:32 +01:00
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	2023-10-31 19:53:38 +02:00
Linas Medžiūnas	e3e22abadb	Merge branch 'main' into linasm/optimize-floatBucketIterator2 ... Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	2023-10-24 16:27:10 +03:00
Marc Tuduri	1ce066e51c	More periods ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2023-10-18 11:53:50 +02:00
Marc Tuduri	af7c31ee10	PR feedback ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2023-10-18 11:53:50 +02:00
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2023-10-18 11:51:11 +02:00
Linas Medziunas	62bbb81e29	Mention bucket values in the comment ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-10-14 21:30:40 +03:00
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-10-09 16:09:46 +03:00