744 commits

Author	SHA1	Message	Date
Matthieu MOREL	ab64966e9d	fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094) ... * fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-10-06 16:35:29 +00:00
bas smit	73997289c3	tests: update discovery tests with new labael ... Previous commit added the pod_container_init label to discovery, so all the tests need to reflect that. Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
bas smit	a10dc9298e	sd k8s: support sidecar containers in endpoint discovery ... Sidecar containers are a newish feature in k8s. They're implemented similar to init containers but actually stay running and allow you to delay startup of your application pod until the sidecar started (like init containers always do). This adds the ports of the sidecar container to the list of discovered endpoint(slice), allowing you to target those containers as well. The implementation is a copy of that of Pod discovery fixes: #14927 Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
bas smit	7a90d73fa6	sd k8s: test for sidecar container support in endpoints ... This test is expected to fail, the followup will add the feature Signed-off-by: bas smit <bsmit@bol.com>	2024-10-01 10:26:58 +02:00
machine424	b5569c4070	fix(discovery): adjust how type is retrieved in Configs' MarshalYAML/UnmarshalYAML ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-30 12:33:07 +02:00
machine424	97f3219157	test(discovery): add a Configs test showing that the custom unmarshalling/marshalling is broken. ... This went under the radar because the utils are never called directly. We usually marshall/unmarshal Configs as embeded in a struct using UnmarshalYAMLWithInlineConfigs/MarshalYAMLWithInlineConfigs which bypasses Configs' custom UnmarshalYAML/MarshalYAML Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-30 12:33:07 +02:00
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868) ... * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2024-09-10 22:32:03 +02:00
machine424	d18fa62ae9	chore(discovery): enable new-service-discovery-manager by default and drop legacymanager package ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-09-05 12:46:03 +02:00
Jan Fajerski	fe4289b502	Merge branch 'main' into HEAD	2024-09-04 18:50:00 +02:00
Jan Fajerski	00315ce15e	Merge branch 'main' into 3.0-main-sync-24-08-30 ... using -Xours Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2024-09-02 11:27:18 +02:00
machine424	d23d196db5	fix(discovery): prevent the manager from storing stale targetGroups ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-08-30 14:39:31 +02:00
machine424	c586c15ae6	fix(discovery): make discovery manager notify consumers of dropped targets for still defined jobs ... scrape/manager_test.go: add a test to check that the manager gets notified for targets that got dropped by discovery to reproduce: https://github.com/prometheus/prometheus/issues/12858#issuecomment-1732318102 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-08-28 17:39:02 +02:00
Bryan Boreham	4202be5e79	Merge branch 'release-2.54' into merge-2.54.1-into-main	2024-08-27 12:04:48 +01:00
beorn7	0f760f63dd	lint: Revamp our linting rules, mostly around doc comments ... Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>	2024-08-22 17:36:11 +02:00
Jan Fajerski	5138922b0d	Merge branch 'main' into 3.0-main-sync-24-08-21	2024-08-21 09:09:36 +02:00
ouyang1204@gmail.com	89dee48cc8	fix the issue of failing to match the first network when the container is reconnected to a new network ... Signed-off-by: ouyang1204@gmail.com <ouyang1204@gmail.com>	2024-08-19 21:26:25 +08:00
Arve Knudsen	3a78e76282	Upgrade golangci-lint to v1.60.1 ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-08-18 12:13:25 +02:00
Julien Pivotto	7711cd5ab5	Remove deprecated storage.tsdb.retention flag ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-08-16 13:53:09 +02:00
cuiweiyuan	1800af54f0	chore: fix some function names ... Signed-off-by: cuiweiyuan <cuiweiyuan@aliyun.com>	2024-08-15 13:57:21 +08:00
Björn Rabenstein	3f16a2e7de	Merge pull request #14543 from jan--f/3.0-main-sync-24-08-01 ... 3.0 main sync 24 08 01	2024-08-13 15:54:13 +02:00
Julien	3933cba052	Merge pull request #14365 from simonpasquier/fix-12884 ... discovery(k8s): remove support for API versions no longer served	2024-08-09 12:48:54 +02:00
Bryan Boreham	79a0ba9d64	Merge pull request #13503 from tylitianrui/chore/remove_redundance ... remove redundant code	2024-07-30 12:44:03 +01:00
Bryan Boreham	ce3bd4abea	Update for Docker deprecation ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-07-17 17:03:32 +01:00
Simon Pasquier	145988d48f	discovery(k8s): remove support for API versions no longer served ... This commit removes support for the following API versions: * `discovery.k8s.io/v1beta1` API version of EndpointSlice (no longer served as of v1.25). * `networking.k8s.io/v1beta1` API version of Ingress (no longer served as of v1.22). Closes #12884 Signed-off-by: Simon Pasquier <spasquie@redhat.com>	2024-07-04 14:54:27 +02:00
Paulo Dias	f4b1fcb73e	discovery: add support for gathering flavor name in Openstack discovery (#14312) ... * feat: add support for gathering flavor name in Openstack discovery Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> * Update instance.go Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com> * Update configuration.md Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com> * fix: fix linting Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> * fix: fix instance type Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> * Update docs/configuration/configuration.md Co-authored-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>	2024-06-30 19:18:18 +02:00
Bryan Boreham	c5040c5ea9	Merge pull request #10490 from DrAuYueng/fix-docker-sd-service-missing ... [ENHANCEMENT] Docker SD: add MatchFirstNetwork for containers with multiple networks Fixes docker sd service misssing in shared mode and deduplicate targets by network	2024-06-26 12:33:50 +01:00
Arve Knudsen	d902116b41	Fix various linting errors ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-06-24 16:11:53 -07:00
unknown	0d25931049	rebase main and adjust the configuration ... Signed-off-by: ouyang1204@gmail.com <ouyang1204@gmail.com>	2024-06-21 19:10:18 +08:00
akunszt	2aaf99dd0a	discovery: aws: expose Primary IPv6 addresses as label, partially fixes #7406 (#14156) ... * discovery: aws: expose Primary IPv6 addresses as label Add __meta_ec2_primary_ipv6_addresses label. This label contains the Primary IPv6 address for every ENI attached to the EC2 instance. It is ordered by the DeviceIndex and the missing elements (interface without Primary IPv6 address) are kept in the list. --------- Signed-off-by: Arpad Kunszt <akunszt@hiya.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>	2024-06-20 14:36:20 +01:00
machine424	94d28cd6cf	chore(notifier): add a reproducer for https://github.com/prometheus/prometheus/issues/13676 ... to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in https://github.com/prometheus/prometheus/pull/10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Ethan Hunter <ehunter@hudson-trading.com>	2024-06-19 09:43:52 +02:00
György Krajcsovits	b18e2d3ef6	Format linter pragma correctly ... Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-06-05 16:50:09 +02:00
György Krajcsovits	180059e6fa	Update scaleway-sdk-go and silence deprecation warnings ... This reverts commit 777daea86e.	2024-06-05 16:37:58 +02:00
György Krajcsovits	0ee4cf8d94	Update Go dependencies for 2.53 ... Ran "make update-all-go-deps" , but do not bump go version and remove toolchain clause from go.mod Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-06-04 18:02:21 +02:00
Arthur Silva Sens	d73537ccc0	Merge branch 'main' into resolveconflicts-2.52.1	2024-05-31 09:36:17 -03:00
David Andruczyk	851f68d1cc	BUGFIX: Need seperate listOptions structs since linodego writes into them for pagination ... Signed-off-by: David Andruczyk <dandrucz@akamai.com>	2024-05-27 17:19:58 +00:00
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code ... Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	2024-05-15 17:51:05 +03:00
Julien	ed4e50e792	Merge pull request #13992 from heckler1/heckler1/discovery-client-go ... discovery(k8s): Only register client-go metrics adapters when needed	2024-04-29 11:18:49 +02:00
Heyoxe	f7e923c3bb	fix(scaleway-sd): use public IPs if no private IP present (#13941) ... * fix(scaleway-sd): use public IPs if no private IP present * tests(scaleway-sd): add instance with routed public ip and no private ip --------- Signed-off-by: Heyoxe <32708033+Heyoxe@users.noreply.github.com>	2024-04-27 15:01:30 +01:00
Stephen Heckler	31a4217784	discovery(k8s): Only register client-go metrics adapters when needed ... Previously the metrics adapters for client-go were registered in an init function. This resulted in clobbering default metrics providers when these packages are imported into an application that leverages the default client-go metrics registry. Instead, let's only register these adapters when requested. Signed-off-by: Stephen Heckler <sheckler@cloudflare.com>	2024-04-25 12:33:29 -05:00
Simon Pasquier	7704cde4ea	discovery(k8s): add metadata labels to endpointslices ... This commit adds 2 new metadata labels for the endpointslice role: * `__meta_kubernetes_endpointslice_endpoint_node_name` * `__meta_kubernetes_endpointslice_endpoint_zone` The latter is only present when the `discovery.k8s.io/v1` API group is available. I also updated the configuration doc and added an entry for the `__meta_kubernetes_endpointslice_endpoint_hostname` label which was missing. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	2024-04-17 11:20:19 +02:00
Matthieu MOREL	6f595c6762	golangci-lint: enable whitespace linter (#13905) ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2024-04-11 09:27:54 +01:00
Bryan Boreham	594b317ecc	Merge pull request #13898 from hanghuge/main ... [DOCS] Fix unavailable link to Kubernetes docs	2024-04-10 11:52:12 +01:00
Matthieu MOREL	d496687c8e	golangci-lint: enable usestdlibvars linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2024-04-08 19:26:23 +00:00
hanghuge	c14a158d03	Signed-off-by: hanghuge <cmoman@outlook.com> ... Fix unavailable link Signed-off-by: hanghuge <cmoman@outlook.com>	2024-04-08 18:44:22 +08:00
David Ashpole	bbfc72b4e2	support unregistering discovery manager metrics (#13896) ... Signed-off-by: David Ashpole <dashpole@google.com>	2024-04-05 16:19:07 +02:00
dandrucz	38b75bc0d7	Linode IPv6 Range support, Optional region filtering, Missing fields in Documentation fixed (#13774) ... * Add support for discovering Linode IPv6 ranges associated with linodes. * Add optional but recommended region filtering (faster queries, more relevant information). * Added missing fields in configuration.md, updated linode test cases. * Convert to TableDrivenTests as per tjhop request. Signed-off-by: David Andruczyk <dandrucz@akamai.com>	2024-04-05 09:31:59 +01:00
Bryan Boreham	8799581b24	Merge pull request #13554 from machine424/k8s-failures ... discovery(k8s): add metric prometheus_sd_kubernetes_failures_total	2024-04-04 10:43:44 +01:00
Bryan Boreham	c6a42f8891	Merge pull request #13741 from bboreham/azure-test-labels ... Azure Discovery tests: Add test for mapping VMs to labels	2024-03-27 11:36:17 +01:00
sellskin	ff15b17400	remove code that will not be executed ... Signed-off-by: sellskin <mydesk@yeah.net>	2024-03-25 12:18:33 +08:00
Jan-Otto Kröpke	302e151de8	{discovery,remote_write}/azure: Support default SDK authentication (#13099) ... * discovery/azure: Offer default SDK authentication Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	2024-03-16 11:06:57 +00:00