mirror of
https://github.com/prometheus/prometheus.git
synced 2024-11-12 16:44:05 -08:00
6ebfbd2d54
For: #14355 This commit updates Prometheus to adopt stdlib's log/slog package in favor of go-kit/log. As part of converting to use slog, several other related changes are required to get prometheus working, including: - removed unused logging util func `RateLimit()` - forward ported the util/logging/Deduper logging by implementing a small custom slog.Handler that does the deduping before chaining log calls to the underlying real slog.Logger - move some of the json file logging functionality to use prom/common package functionality - refactored some of the new json file logging for scraping - changes to promql.QueryLogger interface to swap out logging methods for relevant slog sugar wrappers - updated lots of tests that used/replicated custom logging functionality, attempting to keep the logical goal of the tests consistent after the transition - added a healthy amount of `if logger == nil { $makeLogger }` type conditional checks amongst various functions where none were provided -- old code that used the go-kit/log.Logger interface had several places where there were nil references when trying to use functions like `With()` to add keyvals on the new *slog.Logger type Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
118 lines
4.1 KiB
Go
118 lines
4.1 KiB
Go
// Copyright 2023 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rules
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/prometheus/common/promslog"
|
|
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
"github.com/prometheus/prometheus/promql"
|
|
"github.com/prometheus/prometheus/promql/parser"
|
|
)
|
|
|
|
type unknownRule struct{}
|
|
|
|
func (u unknownRule) Name() string { return "" }
|
|
func (u unknownRule) Labels() labels.Labels { return labels.EmptyLabels() }
|
|
func (u unknownRule) Eval(context.Context, time.Duration, time.Time, QueryFunc, *url.URL, int) (promql.Vector, error) {
|
|
return nil, nil
|
|
}
|
|
func (u unknownRule) String() string { return "" }
|
|
func (u unknownRule) Query() parser.Expr { return nil }
|
|
func (u unknownRule) SetLastError(error) {}
|
|
func (u unknownRule) LastError() error { return nil }
|
|
func (u unknownRule) SetHealth(RuleHealth) {}
|
|
func (u unknownRule) Health() RuleHealth { return "" }
|
|
func (u unknownRule) SetEvaluationDuration(time.Duration) {}
|
|
func (u unknownRule) GetEvaluationDuration() time.Duration { return 0 }
|
|
func (u unknownRule) SetEvaluationTimestamp(time.Time) {}
|
|
func (u unknownRule) GetEvaluationTimestamp() time.Time { return time.Time{} }
|
|
func (u unknownRule) SetNoDependentRules(bool) {}
|
|
func (u unknownRule) NoDependentRules() bool { return false }
|
|
func (u unknownRule) SetNoDependencyRules(bool) {}
|
|
func (u unknownRule) NoDependencyRules() bool { return false }
|
|
|
|
func TestNewRuleDetailPanics(t *testing.T) {
|
|
require.PanicsWithValue(t, `unknown rule type "rules.unknownRule"`, func() {
|
|
NewRuleDetail(unknownRule{})
|
|
})
|
|
}
|
|
|
|
func TestFromOriginContext(t *testing.T) {
|
|
t.Run("should return zero value if RuleDetail is missing in the context", func(t *testing.T) {
|
|
detail := FromOriginContext(context.Background())
|
|
require.Zero(t, detail)
|
|
|
|
// The zero value for NoDependentRules must be the most conservative option.
|
|
require.False(t, detail.NoDependentRules)
|
|
|
|
// The zero value for NoDependencyRules must be the most conservative option.
|
|
require.False(t, detail.NoDependencyRules)
|
|
})
|
|
}
|
|
|
|
func TestNewRuleDetail(t *testing.T) {
|
|
t.Run("should populate NoDependentRules and NoDependencyRules for a RecordingRule", func(t *testing.T) {
|
|
rule := NewRecordingRule("test", &parser.NumberLiteral{Val: 1}, labels.EmptyLabels())
|
|
detail := NewRuleDetail(rule)
|
|
require.False(t, detail.NoDependentRules)
|
|
require.False(t, detail.NoDependencyRules)
|
|
|
|
rule.SetNoDependentRules(true)
|
|
detail = NewRuleDetail(rule)
|
|
require.True(t, detail.NoDependentRules)
|
|
require.False(t, detail.NoDependencyRules)
|
|
|
|
rule.SetNoDependencyRules(true)
|
|
detail = NewRuleDetail(rule)
|
|
require.True(t, detail.NoDependentRules)
|
|
require.True(t, detail.NoDependencyRules)
|
|
})
|
|
|
|
t.Run("should populate NoDependentRules and NoDependencyRules for a AlertingRule", func(t *testing.T) {
|
|
rule := NewAlertingRule(
|
|
"test",
|
|
&parser.NumberLiteral{Val: 1},
|
|
time.Minute,
|
|
0,
|
|
labels.FromStrings("test", "test"),
|
|
labels.EmptyLabels(),
|
|
labels.EmptyLabels(),
|
|
"",
|
|
true, promslog.NewNopLogger(),
|
|
)
|
|
|
|
detail := NewRuleDetail(rule)
|
|
require.False(t, detail.NoDependentRules)
|
|
require.False(t, detail.NoDependencyRules)
|
|
|
|
rule.SetNoDependentRules(true)
|
|
detail = NewRuleDetail(rule)
|
|
require.True(t, detail.NoDependentRules)
|
|
require.False(t, detail.NoDependencyRules)
|
|
|
|
rule.SetNoDependencyRules(true)
|
|
detail = NewRuleDetail(rule)
|
|
require.True(t, detail.NoDependentRules)
|
|
require.True(t, detail.NoDependencyRules)
|
|
})
|
|
}
|