mirror of
https://github.com/prometheus/prometheus.git
synced 2024-11-12 16:44:05 -08:00
583f3e587c
Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
2647 lines
75 KiB
Go
2647 lines
75 KiB
Go
// Copyright 2021 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package histogram
|
|
|
|
import (
|
|
"fmt"
|
|
"math"
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFloatHistogramMul(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in *FloatHistogram
|
|
scale float64
|
|
expected *FloatHistogram
|
|
}{
|
|
{
|
|
"zero value",
|
|
&FloatHistogram{},
|
|
3.1415,
|
|
&FloatHistogram{},
|
|
},
|
|
{
|
|
"zero multiplier",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 0,
|
|
Count: 0,
|
|
Sum: 0,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{0, 0, 0, 0},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{0, 0, 0, 0},
|
|
},
|
|
},
|
|
{
|
|
"no-op",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
1,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
},
|
|
{
|
|
"double",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
2,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 3493.3 * 2,
|
|
Sum: 2349209.324 * 2,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{2, 6.6, 8.4, 0.2},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{6.2, 6, 1.234e5 * 2, 2000},
|
|
},
|
|
},
|
|
{
|
|
"triple",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 23,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
3,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 33,
|
|
Count: 90,
|
|
Sum: 69,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{3, 0, 9, 12, 21},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{9, 3, 15, 18},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
require.Equal(t, c.expected, c.in.Mul(c.scale))
|
|
// Has it also happened in-place?
|
|
require.Equal(t, c.expected, c.in)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatHistogramCopy(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
orig *FloatHistogram
|
|
expected *FloatHistogram
|
|
}{
|
|
{
|
|
name: "without buckets",
|
|
orig: &FloatHistogram{},
|
|
expected: &FloatHistogram{},
|
|
},
|
|
{
|
|
name: "with buckets",
|
|
orig: &FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}},
|
|
PositiveBuckets: []float64{1, 3, -3, 42},
|
|
NegativeSpans: []Span{{3, 2}},
|
|
NegativeBuckets: []float64{5, 3, 1.234e5, 1000},
|
|
},
|
|
expected: &FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}},
|
|
PositiveBuckets: []float64{1, 3, -3, 42},
|
|
NegativeSpans: []Span{{3, 2}},
|
|
NegativeBuckets: []float64{5, 3, 1.234e5, 1000},
|
|
},
|
|
},
|
|
{
|
|
name: "with empty buckets and non empty capacity",
|
|
orig: &FloatHistogram{
|
|
PositiveSpans: make([]Span, 0, 1),
|
|
PositiveBuckets: make([]float64, 0, 1),
|
|
NegativeSpans: make([]Span, 0, 1),
|
|
NegativeBuckets: make([]float64, 0, 1),
|
|
},
|
|
expected: &FloatHistogram{},
|
|
},
|
|
}
|
|
|
|
for _, tcase := range cases {
|
|
t.Run(tcase.name, func(t *testing.T) {
|
|
hCopy := tcase.orig.Copy()
|
|
|
|
// Modify a primitive value in the original histogram.
|
|
tcase.orig.Sum++
|
|
require.Equal(t, tcase.expected, hCopy)
|
|
assertDeepCopyFHSpans(t, tcase.orig, hCopy, tcase.expected)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatHistogramCopyTo(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
orig *FloatHistogram
|
|
expected *FloatHistogram
|
|
}{
|
|
{
|
|
name: "without buckets",
|
|
orig: &FloatHistogram{},
|
|
expected: &FloatHistogram{},
|
|
},
|
|
{
|
|
name: "with buckets",
|
|
orig: &FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}},
|
|
PositiveBuckets: []float64{1, 3, -3, 42},
|
|
NegativeSpans: []Span{{3, 2}},
|
|
NegativeBuckets: []float64{5, 3, 1.234e5, 1000},
|
|
},
|
|
expected: &FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}},
|
|
PositiveBuckets: []float64{1, 3, -3, 42},
|
|
NegativeSpans: []Span{{3, 2}},
|
|
NegativeBuckets: []float64{5, 3, 1.234e5, 1000},
|
|
},
|
|
},
|
|
{
|
|
name: "with empty buckets and non empty capacity",
|
|
orig: &FloatHistogram{
|
|
PositiveSpans: make([]Span, 0, 1),
|
|
PositiveBuckets: make([]float64, 0, 1),
|
|
NegativeSpans: make([]Span, 0, 1),
|
|
NegativeBuckets: make([]float64, 0, 1),
|
|
},
|
|
expected: &FloatHistogram{},
|
|
},
|
|
}
|
|
|
|
for _, tcase := range cases {
|
|
t.Run(tcase.name, func(t *testing.T) {
|
|
hCopy := &FloatHistogram{}
|
|
tcase.orig.CopyTo(hCopy)
|
|
|
|
// Modify a primitive value in the original histogram.
|
|
tcase.orig.Sum++
|
|
require.Equal(t, tcase.expected, hCopy)
|
|
assertDeepCopyFHSpans(t, tcase.orig, hCopy, tcase.expected)
|
|
})
|
|
}
|
|
}
|
|
|
|
func assertDeepCopyFHSpans(t *testing.T, orig, hCopy, expected *FloatHistogram) {
|
|
// Do an in-place expansion of an original spans slice.
|
|
orig.PositiveSpans = expandSpans(orig.PositiveSpans)
|
|
orig.PositiveSpans[len(orig.PositiveSpans)-1] = Span{1, 2}
|
|
|
|
hCopy.PositiveSpans = expandSpans(hCopy.PositiveSpans)
|
|
expected.PositiveSpans = expandSpans(expected.PositiveSpans)
|
|
// Expand the copy spans and assert that modifying the original has not affected the copy.
|
|
require.Equal(t, expected, hCopy)
|
|
}
|
|
|
|
func TestFloatHistogramDiv(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
fh *FloatHistogram
|
|
s float64
|
|
expected *FloatHistogram
|
|
}{
|
|
{
|
|
"zero value",
|
|
&FloatHistogram{},
|
|
3.1415,
|
|
&FloatHistogram{},
|
|
},
|
|
{
|
|
"zero divisor",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: math.Inf(1),
|
|
Count: math.Inf(1),
|
|
Sum: math.Inf(1),
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{math.Inf(1), math.Inf(1), math.Inf(1), math.Inf(1)},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{math.Inf(1), math.Inf(1), math.Inf(1), math.Inf(1)},
|
|
},
|
|
},
|
|
{
|
|
"no-op",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
1,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
},
|
|
{
|
|
"half",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 23,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
2,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 15,
|
|
Sum: 11.5,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{0.5, 0, 1.5, 2, 3.5},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1.5, 0.5, 2.5, 3},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
require.Equal(t, c.expected, c.fh.Div(c.s))
|
|
// Has it also happened in-place?
|
|
require.Equal(t, c.expected, c.fh)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatHistogramDetectReset(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
previous, current *FloatHistogram
|
|
resetExpected bool
|
|
}{
|
|
{
|
|
"zero values",
|
|
&FloatHistogram{},
|
|
&FloatHistogram{},
|
|
false,
|
|
},
|
|
{
|
|
"no buckets to some buckets",
|
|
&FloatHistogram{},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"some buckets to no buckets",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{},
|
|
true,
|
|
},
|
|
{
|
|
"one bucket appears, nothing else changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"one bucket disappears, nothing else changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"an unpopulated bucket disappears, nothing else changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"an unpopulated bucket at the end disappears, nothing else changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 1}, {1, 2}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"an unpopulated bucket disappears in a histogram with nothing else",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{23, 1}},
|
|
PositiveBuckets: []float64{0},
|
|
},
|
|
&FloatHistogram{},
|
|
false,
|
|
},
|
|
{
|
|
"zero count goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.6,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"zero count goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.4,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"count goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.4,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"count goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.2,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"sum goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349210,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"sum goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349200,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"one positive bucket goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.3, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"one positive bucket goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.1, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"one negative bucket goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3.1, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"one negative bucket goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 2.9, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"zero threshold decreases",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.009,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"zero threshold increases without touching any existing buckets",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.011,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"zero threshold increases enough to cover existing buckets",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 1,
|
|
ZeroCount: 7.73,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{1, 3}},
|
|
PositiveBuckets: []float64{3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"zero threshold increases into the middle of an existing buckets",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.3,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"schema increases without any other changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-5, 4}, {2, 6}},
|
|
PositiveBuckets: []float64{0.4, 0.6, 1, 0.23, 2, 1.3, 1.2, 3, 0.05, 0.05},
|
|
NegativeSpans: []Span{{5, 4}, {6, 4}},
|
|
NegativeBuckets: []float64{2, 1.1, 2, 1, 0.234e5, 1e5, 500, 500},
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"schema decreases without any other changes",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-5, 4}, {2, 6}},
|
|
PositiveBuckets: []float64{0.4, 0.6, 1, 0.23, 2, 1.3, 1.2, 3, 0.05, 0.05},
|
|
NegativeSpans: []Span{{5, 4}, {6, 4}},
|
|
NegativeBuckets: []float64{2, 1.1, 2, 1, 0.234e5, 1e5, 500, 500},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"schema decreases and a bucket goes up",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-5, 4}, {2, 6}},
|
|
PositiveBuckets: []float64{0.4, 0.6, 1, 0.23, 2, 1.3, 1.2, 3, 0.05, 0.05},
|
|
NegativeSpans: []Span{{5, 4}, {6, 4}},
|
|
NegativeBuckets: []float64{2, 1.1, 2, 1, 0.234e5, 1e5, 500, 500},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 4.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"schema decreases and a bucket goes down",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-5, 4}, {2, 6}},
|
|
PositiveBuckets: []float64{0.4, 0.6, 1, 0.23, 2, 1.3, 1.2, 3, 0.05, 0.05},
|
|
NegativeSpans: []Span{{5, 4}, {6, 4}},
|
|
NegativeBuckets: []float64{2, 1.1, 2, 1, 0.234e5, 1e5, 500, 500},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 5.5,
|
|
Count: 3493.3,
|
|
Sum: 2349209.324,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 1.23, 2.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
true,
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
require.Equal(t, c.resetExpected, c.current.DetectReset(c.previous))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatHistogramCompact(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in *FloatHistogram
|
|
maxEmptyBuckets int
|
|
expected *FloatHistogram
|
|
}{
|
|
{
|
|
"empty histogram",
|
|
&FloatHistogram{},
|
|
0,
|
|
&FloatHistogram{},
|
|
},
|
|
{
|
|
"nothing should happen",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000},
|
|
},
|
|
},
|
|
{
|
|
"eliminate zero offsets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {0, 3}, {0, 1}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {0, 2}, {2, 1}, {0, 1}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 5}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 4}, {2, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"eliminate zero length",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {2, 0}, {3, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {0, 0}, {2, 0}, {1, 4}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {5, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 4}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"eliminate multiple zero length spans",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {2, 0}, {2, 0}, {2, 0}, {3, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {9, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets at start or end",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 4}, {5, 3}},
|
|
PositiveBuckets: []float64{0, 0, 1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4, 0},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {5, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 4}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets at start and end",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 4}, {5, 6}},
|
|
PositiveBuckets: []float64{0, 0, 1, 3.3, 4.2, 0.1, 3.3, 0, 0, 0},
|
|
NegativeSpans: []Span{{-2, 4}, {3, 5}},
|
|
NegativeBuckets: []float64{0, 0, 3.1, 3, 1.234e5, 1000, 3, 4, 0},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {5, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 4}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets in the middle",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{5, 4}},
|
|
PositiveBuckets: []float64{1, 3, 0, 2},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{
|
|
{Offset: 5, Length: 2},
|
|
{Offset: 1, Length: 1},
|
|
},
|
|
PositiveBuckets: []float64{1, 3, 2},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets at start or end of spans, even in the middle",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 6}},
|
|
PositiveBuckets: []float64{0, 0, 1, 3.3, 0, 0, 4.2, 0.1, 3.3, 0, 0, 0},
|
|
NegativeSpans: []Span{{0, 2}, {2, 6}},
|
|
NegativeBuckets: []float64{3.1, 3, 0, 1.234e5, 1000, 3, 4, 0},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 2}, {5, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 4}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets at start and end - also merge spans due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 4}, {5, 3}},
|
|
PositiveBuckets: []float64{0, 0, 1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4, 0},
|
|
},
|
|
10,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 10}},
|
|
PositiveBuckets: []float64{1, 3.3, 0, 0, 0, 0, 0, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 9}},
|
|
NegativeBuckets: []float64{3.1, 3, 0, 0, 0, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets from the middle of a span",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 3}},
|
|
PositiveBuckets: []float64{0, 0, 1, 0, 0, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 1}, {3, 3}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"cut out a span containing only empty buckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 3}, {2, 2}, {3, 4}},
|
|
PositiveBuckets: []float64{0, 0, 1, 0, 0, 3.3, 4.2, 0.1, 3.3},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {7, 4}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets from the middle of a span, avoiding none due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 4}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3.3},
|
|
},
|
|
1,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 1}},
|
|
PositiveBuckets: []float64{1, 3.3},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets and merge spans due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 4}, {3, 1}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3.3, 4.2},
|
|
},
|
|
1,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 1}, {3, 1}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2},
|
|
},
|
|
},
|
|
{
|
|
"cut empty buckets from the middle of a span, avoiding some due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 3}, {10, 2}},
|
|
PositiveBuckets: []float64{0, 0, 1, 0, 0, 3.3, 4.2, 0.1, 3.3, 2, 3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
1,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 1}, {2, 1}, {3, 3}, {10, 2}},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1, 3.3, 2, 3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"avoiding all cutting of empty buckets from the middle of a chunk due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 3}},
|
|
PositiveBuckets: []float64{0, 0, 1, 0, 0, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
2,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 4}, {3, 3}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"everything merged into one span due to maxEmptyBuckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 3}},
|
|
PositiveBuckets: []float64{0, 0, 1, 0, 0, 3.3, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 2}, {3, 5}},
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
3,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-2, 10}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3.3, 0, 0, 0, 4.2, 0.1, 3.3},
|
|
NegativeSpans: []Span{{0, 10}},
|
|
NegativeBuckets: []float64{3.1, 3, 0, 0, 0, 1.234e5, 1000, 0, 3, 4},
|
|
},
|
|
},
|
|
{
|
|
"only empty buckets and maxEmptyBuckets greater zero",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-4, 6}, {3, 3}},
|
|
PositiveBuckets: []float64{0, 0, 0, 0, 0, 0, 0, 0, 0},
|
|
NegativeSpans: []Span{{0, 7}},
|
|
NegativeBuckets: []float64{0, 0, 0, 0, 0, 0, 0},
|
|
},
|
|
3,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{},
|
|
PositiveBuckets: []float64{},
|
|
NegativeSpans: []Span{},
|
|
NegativeBuckets: []float64{},
|
|
},
|
|
},
|
|
{
|
|
"multiple spans of only empty buckets",
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-10, 2}, {2, 1}, {3, 3}},
|
|
PositiveBuckets: []float64{0, 0, 0, 0, 2, 3},
|
|
NegativeSpans: []Span{{-10, 2}, {2, 1}, {3, 3}},
|
|
NegativeBuckets: []float64{2, 3, 0, 0, 0, 0},
|
|
},
|
|
0,
|
|
&FloatHistogram{
|
|
PositiveSpans: []Span{{-1, 2}},
|
|
PositiveBuckets: []float64{2, 3},
|
|
NegativeSpans: []Span{{-10, 2}},
|
|
NegativeBuckets: []float64{2, 3},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
require.Equal(t, c.expected, c.in.Compact(c.maxEmptyBuckets))
|
|
// Compact has happened in-place, too.
|
|
require.Equal(t, c.expected, c.in)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatHistogramAdd(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in1, in2, expected *FloatHistogram
|
|
}{
|
|
{
|
|
"same bucket layout",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{0, 0, 2, 3, 6},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 5, 7, 13},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{4, 2, 9, 10},
|
|
},
|
|
},
|
|
{
|
|
"same bucket layout, defined differently",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 1}, {0, 2}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 2}, {0, 1}},
|
|
PositiveBuckets: []float64{0, 0, 2, 3, 6},
|
|
NegativeSpans: []Span{{3, 7}},
|
|
NegativeBuckets: []float64{1, 1, 0, 0, 0, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 1}, {0, 2}},
|
|
PositiveBuckets: []float64{1, 0, 5, 7, 13},
|
|
NegativeSpans: []Span{{3, 5}, {0, 2}},
|
|
NegativeBuckets: []float64{4, 2, 0, 0, 0, 9, 10},
|
|
},
|
|
},
|
|
{
|
|
"non-overlapping spans",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.001,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.001,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{0, 2}, {3, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6},
|
|
NegativeSpans: []Span{{-9, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.001,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 4}, {0, 6}},
|
|
PositiveBuckets: []float64{1, 0, 5, 4, 3, 4, 7, 2, 3, 6},
|
|
NegativeSpans: []Span{{-9, 2}, {3, 2}, {5, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4, 3, 1, 5, 6},
|
|
},
|
|
},
|
|
{
|
|
"non-overlapping inverted order",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{0, 2}, {3, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6},
|
|
NegativeSpans: []Span{{-6, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 2}, {0, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{1, 0, 5, 4, 3, 4, 7, 2, 3, 6},
|
|
NegativeSpans: []Span{{-6, 2}, {1, 2}, {4, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4, 3, 1, 5, 6},
|
|
},
|
|
},
|
|
{
|
|
"overlapping spans",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{-1, 4}, {0, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 4}, {0, 4}},
|
|
PositiveBuckets: []float64{1, 5, 4, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"overlapping spans inverted order",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{-1, 4}, {0, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{1, 5, 4, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"schema change",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-1, 4}, {0, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 19,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-2, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{1, 5, 4, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"larger zero bucket in first histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 1,
|
|
ZeroCount: 17,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{1, 2}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 1,
|
|
ZeroCount: 29,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{1, 2}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"larger zero bucket in second histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 1,
|
|
ZeroCount: 17,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{1, 2}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 1,
|
|
ZeroCount: 29,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{1, 5}},
|
|
PositiveBuckets: []float64{2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"larger zero threshold in first histogram ends up inside a populated bucket of second histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.2,
|
|
ZeroCount: 17,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{1, 2}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 29,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-1, 1}, {1, 5}},
|
|
PositiveBuckets: []float64{0, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"larger zero threshold in second histogram ends up inside a populated bucket of first histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.2,
|
|
ZeroCount: 17,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
PositiveSpans: []Span{{1, 2}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 29,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{1, 5}},
|
|
PositiveBuckets: []float64{2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"schema change combined with larger zero bucket in second histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 5, 4, 2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 12,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-3, 2}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 22,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-1, 7}},
|
|
PositiveBuckets: []float64{6, 4, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
{
|
|
"schema change combined with larger zero bucket in first histogram",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 1.234,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-1, 4}, {0, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 3, 6, 2, 5},
|
|
NegativeSpans: []Span{{4, 2}, {1, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.25,
|
|
ZeroCount: 20,
|
|
Count: 51,
|
|
Sum: 3.579,
|
|
PositiveSpans: []Span{{-1, 4}, {0, 3}},
|
|
PositiveBuckets: []float64{5, 4, 2, 6, 10, 9, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{3, 2, 1, 4, 9, 6},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
testHistogramAdd(t, c.in1, c.in2, c.expected)
|
|
testHistogramAdd(t, c.in2, c.in1, c.expected)
|
|
})
|
|
}
|
|
}
|
|
|
|
func testHistogramAdd(t *testing.T, a, b, expected *FloatHistogram) {
|
|
var (
|
|
aCopy = a.Copy()
|
|
bCopy = b.Copy()
|
|
expectedCopy = expected.Copy()
|
|
)
|
|
|
|
res := aCopy.Add(bCopy)
|
|
|
|
res.Compact(0)
|
|
expectedCopy.Compact(0)
|
|
|
|
require.Equal(t, expectedCopy, res)
|
|
|
|
// Has it also happened in-place?
|
|
require.Equal(t, expectedCopy, aCopy)
|
|
|
|
// Check that the argument was not mutated.
|
|
require.Equal(t, b, bCopy)
|
|
}
|
|
|
|
func TestFloatHistogramSub(t *testing.T) {
|
|
// This has fewer test cases than TestFloatHistogramAdd because Add and
|
|
// Sub share most of the trickier code.
|
|
cases := []struct {
|
|
name string
|
|
in1, in2, expected *FloatHistogram
|
|
}{
|
|
{
|
|
"same bucket layout",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 23,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 21,
|
|
Sum: 12,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{0, 0, 2, 3, 6},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{1, 1, 4, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 3,
|
|
Count: 9,
|
|
Sum: 11,
|
|
PositiveSpans: []Span{{-2, 2}, {1, 3}},
|
|
PositiveBuckets: []float64{1, 0, 1, 1, 1},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{2, 0, 1, 2},
|
|
},
|
|
},
|
|
{
|
|
"schema change",
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 8,
|
|
Count: 59,
|
|
Sum: 1.234,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{2, 5, 4, 2, 3, 6, 7, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{4, 10, 1, 4, 14, 7},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 2,
|
|
Count: 19,
|
|
Sum: 0.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 1, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 6,
|
|
Count: 40,
|
|
Sum: 0.889,
|
|
PositiveSpans: []Span{{-2, 5}, {0, 3}},
|
|
PositiveBuckets: []float64{1, 5, 4, 2, 2, 2, 0, 5},
|
|
NegativeSpans: []Span{{3, 3}, {1, 3}},
|
|
NegativeBuckets: []float64{1, 9, 1, 4, 9, 1},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
testFloatHistogramSub(t, c.in1, c.in2, c.expected)
|
|
|
|
expectedNegative := c.expected.Copy().Mul(-1)
|
|
testFloatHistogramSub(t, c.in2, c.in1, expectedNegative)
|
|
})
|
|
}
|
|
}
|
|
|
|
func testFloatHistogramSub(t *testing.T, a, b, expected *FloatHistogram) {
|
|
var (
|
|
aCopy = a.Copy()
|
|
bCopy = b.Copy()
|
|
expectedCopy = expected.Copy()
|
|
)
|
|
|
|
res := aCopy.Sub(bCopy)
|
|
|
|
res.Compact(0)
|
|
expectedCopy.Compact(0)
|
|
|
|
require.Equal(t, expectedCopy, res)
|
|
|
|
// Has it also happened in-place?
|
|
require.Equal(t, expectedCopy, aCopy)
|
|
|
|
// Check that the argument was not mutated.
|
|
require.Equal(t, b, bCopy)
|
|
}
|
|
|
|
func TestFloatHistogramCopyToSchema(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
targetSchema int32
|
|
in, expected *FloatHistogram
|
|
}{
|
|
{
|
|
"no schema change",
|
|
1,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
},
|
|
{
|
|
"schema change",
|
|
0,
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{{-4, 3}, {5, 5}},
|
|
PositiveBuckets: []float64{1, 0, 0, 3, 2, 2, 3, 4},
|
|
NegativeSpans: []Span{{6, 3}, {6, 4}},
|
|
NegativeBuckets: []float64{3, 0.5, 0.5, 2, 3, 2, 4},
|
|
},
|
|
&FloatHistogram{
|
|
ZeroThreshold: 0.01,
|
|
ZeroCount: 11,
|
|
Count: 30,
|
|
Sum: 2.345,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{{-2, 2}, {2, 3}},
|
|
PositiveBuckets: []float64{1, 0, 3, 4, 7},
|
|
NegativeSpans: []Span{{3, 2}, {3, 2}},
|
|
NegativeBuckets: []float64{3, 1, 5, 6},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
inCopy := c.in.Copy()
|
|
require.Equal(t, c.expected, c.in.CopyToSchema(c.targetSchema))
|
|
// Check that the receiver histogram was not mutated:
|
|
require.Equal(t, inCopy, c.in)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestReverseFloatBucketIterator(t *testing.T) {
|
|
h := &FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
}
|
|
|
|
// Assuming that the regular iterator is correct.
|
|
|
|
// Positive buckets.
|
|
var expBuckets, actBuckets []Bucket[float64]
|
|
it := h.PositiveBucketIterator()
|
|
for it.Next() {
|
|
// Append in reverse to check reversed list.
|
|
expBuckets = append([]Bucket[float64]{it.At()}, expBuckets...)
|
|
}
|
|
it = h.PositiveReverseBucketIterator()
|
|
for it.Next() {
|
|
actBuckets = append(actBuckets, it.At())
|
|
}
|
|
require.NotEmpty(t, expBuckets)
|
|
require.NotEmpty(t, actBuckets)
|
|
require.Equal(t, expBuckets, actBuckets)
|
|
|
|
// Negative buckets.
|
|
expBuckets = expBuckets[:0]
|
|
actBuckets = actBuckets[:0]
|
|
it = h.NegativeBucketIterator()
|
|
for it.Next() {
|
|
// Append in reverse to check reversed list.
|
|
expBuckets = append([]Bucket[float64]{it.At()}, expBuckets...)
|
|
}
|
|
it = h.NegativeReverseBucketIterator()
|
|
for it.Next() {
|
|
actBuckets = append(actBuckets, it.At())
|
|
}
|
|
require.NotEmpty(t, expBuckets)
|
|
require.NotEmpty(t, actBuckets)
|
|
require.Equal(t, expBuckets, actBuckets)
|
|
}
|
|
|
|
func TestAllFloatBucketIterator(t *testing.T) {
|
|
cases := []struct {
|
|
h FloatHistogram
|
|
// To determine the expected buckets.
|
|
includeNeg, includeZero, includePos bool
|
|
}{
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: false,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
},
|
|
includeNeg: false,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
},
|
|
includeNeg: false,
|
|
includeZero: true,
|
|
includePos: false,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 0,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: false,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 447,
|
|
ZeroCount: 42,
|
|
ZeroThreshold: 0.5, // Coinciding with bucket boundary.
|
|
Sum: 1008.4,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 447,
|
|
ZeroCount: 42,
|
|
ZeroThreshold: 0.6, // Within the bucket closest to zero.
|
|
Sum: 1008.4,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
|
|
var expBuckets, actBuckets []Bucket[float64]
|
|
|
|
if c.includeNeg {
|
|
it := c.h.NegativeReverseBucketIterator()
|
|
for it.Next() {
|
|
b := it.At()
|
|
if c.includeZero && b.Upper > -c.h.ZeroThreshold {
|
|
b.Upper = -c.h.ZeroThreshold
|
|
}
|
|
expBuckets = append(expBuckets, b)
|
|
}
|
|
}
|
|
if c.includeZero {
|
|
expBuckets = append(expBuckets, Bucket[float64]{
|
|
Lower: -c.h.ZeroThreshold,
|
|
Upper: c.h.ZeroThreshold,
|
|
LowerInclusive: true,
|
|
UpperInclusive: true,
|
|
Count: c.h.ZeroCount,
|
|
})
|
|
}
|
|
if c.includePos {
|
|
it := c.h.PositiveBucketIterator()
|
|
for it.Next() {
|
|
b := it.At()
|
|
if c.includeZero && b.Lower < c.h.ZeroThreshold {
|
|
b.Lower = c.h.ZeroThreshold
|
|
}
|
|
expBuckets = append(expBuckets, b)
|
|
}
|
|
}
|
|
|
|
it := c.h.AllBucketIterator()
|
|
for it.Next() {
|
|
actBuckets = append(actBuckets, it.At())
|
|
}
|
|
|
|
require.Equal(t, expBuckets, actBuckets)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAllReverseFloatBucketIterator(t *testing.T) {
|
|
cases := []struct {
|
|
h FloatHistogram
|
|
// To determine the expected buckets.
|
|
includeNeg, includeZero, includePos bool
|
|
}{
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: false,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
},
|
|
includeNeg: false,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 102,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
},
|
|
includeNeg: false,
|
|
includeZero: true,
|
|
includePos: false,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 405,
|
|
ZeroCount: 0,
|
|
ZeroThreshold: 0.001,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: false,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 447,
|
|
ZeroCount: 42,
|
|
ZeroThreshold: 0.5, // Coinciding with bucket boundary.
|
|
Sum: 1008.4,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
{
|
|
h: FloatHistogram{
|
|
Count: 447,
|
|
ZeroCount: 42,
|
|
ZeroThreshold: 0.6, // Within the bucket closest to zero.
|
|
Sum: 1008.4,
|
|
Schema: 0,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 3},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 0},
|
|
{Offset: 3, Length: 0},
|
|
{Offset: 3, Length: 4},
|
|
{Offset: 2, Length: 0},
|
|
{Offset: 5, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
},
|
|
includeNeg: true,
|
|
includeZero: true,
|
|
includePos: true,
|
|
},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
|
|
var expBuckets, actBuckets []Bucket[float64]
|
|
|
|
if c.includePos {
|
|
it := c.h.PositiveReverseBucketIterator()
|
|
for it.Next() {
|
|
b := it.At()
|
|
if c.includeZero && b.Lower < c.h.ZeroThreshold {
|
|
b.Lower = c.h.ZeroThreshold
|
|
}
|
|
expBuckets = append(expBuckets, b)
|
|
}
|
|
}
|
|
if c.includeZero {
|
|
expBuckets = append(expBuckets, Bucket[float64]{
|
|
Lower: -c.h.ZeroThreshold,
|
|
Upper: c.h.ZeroThreshold,
|
|
LowerInclusive: true,
|
|
UpperInclusive: true,
|
|
Count: c.h.ZeroCount,
|
|
})
|
|
}
|
|
if c.includeNeg {
|
|
it := c.h.NegativeBucketIterator()
|
|
for it.Next() {
|
|
b := it.At()
|
|
if c.includeZero && b.Upper > -c.h.ZeroThreshold {
|
|
b.Upper = -c.h.ZeroThreshold
|
|
}
|
|
expBuckets = append(expBuckets, b)
|
|
}
|
|
}
|
|
|
|
it := c.h.AllReverseBucketIterator()
|
|
for it.Next() {
|
|
actBuckets = append(actBuckets, it.At())
|
|
}
|
|
|
|
require.Equal(t, expBuckets, actBuckets)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFloatBucketIteratorTargetSchema(t *testing.T) {
|
|
h := FloatHistogram{
|
|
Count: 405,
|
|
Sum: 1008.4,
|
|
Schema: 1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 1, Length: 3},
|
|
{Offset: 2, Length: 3},
|
|
},
|
|
PositiveBuckets: []float64{100, 344, 123, 55, 3, 63, 2, 54, 235, 33},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 7, Length: 4},
|
|
{Offset: 1, Length: 3},
|
|
},
|
|
NegativeBuckets: []float64{10, 34, 1230, 54, 67, 63, 2, 554, 235, 33},
|
|
}
|
|
expPositiveBuckets := []Bucket[float64]{
|
|
{Lower: 0.25, Upper: 1, LowerInclusive: false, UpperInclusive: true, Count: 100, Index: 0},
|
|
{Lower: 1, Upper: 4, LowerInclusive: false, UpperInclusive: true, Count: 522, Index: 1},
|
|
{Lower: 4, Upper: 16, LowerInclusive: false, UpperInclusive: true, Count: 68, Index: 2},
|
|
{Lower: 16, Upper: 64, LowerInclusive: false, UpperInclusive: true, Count: 322, Index: 3},
|
|
}
|
|
expNegativeBuckets := []Bucket[float64]{
|
|
{Lower: -1, Upper: -0.25, LowerInclusive: true, UpperInclusive: false, Count: 10, Index: 0},
|
|
{Lower: -4, Upper: -1, LowerInclusive: true, UpperInclusive: false, Count: 1264, Index: 1},
|
|
{Lower: -64, Upper: -16, LowerInclusive: true, UpperInclusive: false, Count: 184, Index: 3},
|
|
{Lower: -256, Upper: -64, LowerInclusive: true, UpperInclusive: false, Count: 791, Index: 4},
|
|
{Lower: -1024, Upper: -256, LowerInclusive: true, UpperInclusive: false, Count: 33, Index: 5},
|
|
}
|
|
|
|
it := h.floatBucketIterator(true, 0, -1)
|
|
for i, b := range expPositiveBuckets {
|
|
require.True(t, it.Next(), "positive iterator exhausted too early")
|
|
require.Equal(t, b, it.At(), "bucket %d", i)
|
|
}
|
|
require.False(t, it.Next(), "positive iterator not exhausted")
|
|
|
|
it = h.floatBucketIterator(false, 0, -1)
|
|
for i, b := range expNegativeBuckets {
|
|
require.True(t, it.Next(), "negative iterator exhausted too early")
|
|
require.Equal(t, b, it.At(), "bucket %d", i)
|
|
}
|
|
require.False(t, it.Next(), "negative iterator not exhausted")
|
|
}
|
|
|
|
// TestFloatHistogramEquals tests FloatHistogram with float-specific cases that
|
|
// cannot be covered by TestHistogramEquals.
|
|
func TestFloatHistogramEquals(t *testing.T) {
|
|
h1 := FloatHistogram{
|
|
Schema: 3,
|
|
Count: 2.2,
|
|
Sum: 9.7,
|
|
ZeroThreshold: 0.1,
|
|
ZeroCount: 1.1,
|
|
PositiveBuckets: []float64{3},
|
|
NegativeBuckets: []float64{4},
|
|
}
|
|
|
|
equals := func(h1, h2 FloatHistogram) {
|
|
require.True(t, h1.Equals(&h2))
|
|
require.True(t, h2.Equals(&h1))
|
|
}
|
|
notEquals := func(h1, h2 FloatHistogram) {
|
|
require.False(t, h1.Equals(&h2))
|
|
require.False(t, h2.Equals(&h1))
|
|
}
|
|
|
|
h2 := h1.Copy()
|
|
equals(h1, *h2)
|
|
|
|
// Count is NaN (but not a StaleNaN).
|
|
hCountNaN := h1.Copy()
|
|
hCountNaN.Count = math.NaN()
|
|
notEquals(h1, *hCountNaN)
|
|
equals(*hCountNaN, *hCountNaN)
|
|
|
|
// ZeroCount is NaN (but not a StaleNaN).
|
|
hZeroCountNaN := h1.Copy()
|
|
hZeroCountNaN.ZeroCount = math.NaN()
|
|
notEquals(h1, *hZeroCountNaN)
|
|
equals(*hZeroCountNaN, *hZeroCountNaN)
|
|
|
|
// Positive bucket value is NaN.
|
|
hPosBucketNaN := h1.Copy()
|
|
hPosBucketNaN.PositiveBuckets[0] = math.NaN()
|
|
notEquals(h1, *hPosBucketNaN)
|
|
equals(*hPosBucketNaN, *hPosBucketNaN)
|
|
|
|
// Negative bucket value is NaN.
|
|
hNegBucketNaN := h1.Copy()
|
|
hNegBucketNaN.NegativeBuckets[0] = math.NaN()
|
|
notEquals(h1, *hNegBucketNaN)
|
|
equals(*hNegBucketNaN, *hNegBucketNaN)
|
|
}
|
|
|
|
func TestFloatHistogramSize(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
fh *FloatHistogram
|
|
expected int
|
|
}{
|
|
{
|
|
"without spans and buckets",
|
|
&FloatHistogram{ // 8 bytes.
|
|
CounterResetHint: 0, // 1 byte.
|
|
Schema: 1, // 4 bytes.
|
|
ZeroThreshold: 0.01, // 8 bytes.
|
|
ZeroCount: 5.5, // 8 bytes.
|
|
Count: 3493.3, // 8 bytes.
|
|
Sum: 2349209.324, // 8 bytes.
|
|
PositiveSpans: nil, // 24 bytes.
|
|
PositiveBuckets: nil, // 24 bytes.
|
|
NegativeSpans: nil, // 24 bytes.
|
|
NegativeBuckets: nil, // 24 bytes.
|
|
},
|
|
8 + 4 + 4 + 8 + 8 + 8 + 8 + 24 + 24 + 24 + 24,
|
|
},
|
|
{
|
|
"complete struct",
|
|
&FloatHistogram{ // 8 bytes.
|
|
CounterResetHint: 0, // 1 byte.
|
|
Schema: 1, // 4 bytes.
|
|
ZeroThreshold: 0.01, // 8 bytes.
|
|
ZeroCount: 5.5, // 8 bytes.
|
|
Count: 3493.3, // 8 bytes.
|
|
Sum: 2349209.324, // 8 bytes.
|
|
PositiveSpans: []Span{ // 24 bytes.
|
|
{-2, 1}, // 2 * 4 bytes.
|
|
{2, 3}, // 2 * 4 bytes.
|
|
},
|
|
PositiveBuckets: []float64{1, 3.3, 4.2, 0.1}, // 24 bytes + 4 * 8 bytes.
|
|
NegativeSpans: []Span{ // 24 bytes.
|
|
{3, 2}, // 2 * 4 bytes.
|
|
{3, 2}}, // 2 * 4 bytes.
|
|
NegativeBuckets: []float64{3.1, 3, 1.234e5, 1000}, // 24 bytes + 4 * 8 bytes.
|
|
},
|
|
8 + 4 + 4 + 8 + 8 + 8 + 8 + (24 + 2*4 + 2*4) + (24 + 2*4 + 2*4) + (24 + 4*8) + (24 + 4*8),
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
require.Equal(t, c.expected, c.fh.Size())
|
|
})
|
|
}
|
|
}
|
|
|
|
func BenchmarkFloatHistogramAllBucketIterator(b *testing.B) {
|
|
rng := rand.New(rand.NewSource(0))
|
|
|
|
fh := createRandomFloatHistogram(rng, 50)
|
|
|
|
b.ReportAllocs() // the current implementation reports 1 alloc
|
|
b.ResetTimer()
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
for it := fh.AllBucketIterator(); it.Next(); {
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkFloatHistogramDetectReset(b *testing.B) {
|
|
rng := rand.New(rand.NewSource(0))
|
|
|
|
fh := createRandomFloatHistogram(rng, 50)
|
|
|
|
b.ReportAllocs() // the current implementation reports 0 allocs
|
|
b.ResetTimer()
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
// Detect against the itself (no resets is the worst case input).
|
|
fh.DetectReset(fh)
|
|
}
|
|
}
|
|
|
|
func createRandomFloatHistogram(rng *rand.Rand, spanNum int32) *FloatHistogram {
|
|
f := &FloatHistogram{}
|
|
f.PositiveSpans, f.PositiveBuckets = createRandomSpans(rng, spanNum)
|
|
f.NegativeSpans, f.NegativeBuckets = createRandomSpans(rng, spanNum)
|
|
return f
|
|
}
|
|
|
|
func createRandomSpans(rng *rand.Rand, spanNum int32) ([]Span, []float64) {
|
|
Spans := make([]Span, spanNum)
|
|
Buckets := make([]float64, 0)
|
|
for i := 0; i < int(spanNum); i++ {
|
|
Spans[i].Offset = rng.Int31n(spanNum) + 1
|
|
Spans[i].Length = uint32(rng.Int31n(spanNum) + 1)
|
|
for j := 0; j < int(Spans[i].Length); j++ {
|
|
Buckets = append(Buckets, float64(rng.Int31n(spanNum)+1))
|
|
}
|
|
}
|
|
return Spans, Buckets
|
|
}
|
|
|
|
func TestFloatHistogramReduceResolution(t *testing.T) {
|
|
tcs := map[string]struct {
|
|
origin *FloatHistogram
|
|
target *FloatHistogram
|
|
}{
|
|
"valid float histogram": {
|
|
origin: &FloatHistogram{
|
|
Schema: 0,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 0, Length: 0},
|
|
{Offset: 3, Length: 2},
|
|
},
|
|
PositiveBuckets: []float64{1, 3, 1, 2, 1, 1},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 4},
|
|
{Offset: 0, Length: 0},
|
|
{Offset: 3, Length: 2},
|
|
},
|
|
NegativeBuckets: []float64{1, 3, 1, 2, 1, 1},
|
|
},
|
|
target: &FloatHistogram{
|
|
Schema: -1,
|
|
PositiveSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 1},
|
|
},
|
|
PositiveBuckets: []float64{1, 4, 2, 2},
|
|
NegativeSpans: []Span{
|
|
{Offset: 0, Length: 3},
|
|
{Offset: 1, Length: 1},
|
|
},
|
|
NegativeBuckets: []float64{1, 4, 2, 2},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range tcs {
|
|
target := tc.origin.ReduceResolution(tc.target.Schema)
|
|
require.Equal(t, tc.target, target)
|
|
// Check that receiver histogram was mutated:
|
|
require.Equal(t, tc.target, tc.origin)
|
|
}
|
|
}
|