mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-26 22:19:40 -08:00
5b78aa0649
* Contribute grafana/agent sigv4 code * address review feedback - move validation logic for RemoteWrite into unmarshal - copy configuration fields from ec2 SD config - remove enabled field, use pointer for enabling sigv4 * Update config/config.go * Don't provide credentials if secret key / access key left blank * Add SigV4 headers to the list of unchangeable headers. * sigv4: don't include all headers in signature * only test for equality in the authorization header, not the signed date * address review feedback 1. s/httpClientConfigEnabled/httpClientConfigAuthEnabled 2. bearer_token tuples to "authorization" 3. Un-export NewSigV4RoundTripper * add x-amz-content-sha256 to list of unchangeable headers * Document sigv4 configuration * add suggestion for using default AWS SDK credentials Signed-off-by: Robert Fratto <robertfratto@gmail.com> Co-authored-by: Julien Pivotto <roidelapluie@gmail.com>
93 lines
2.7 KiB
Go
93 lines
2.7 KiB
Go
// Copyright 2021 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package remote
|
|
|
|
import (
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/aws/credentials"
|
|
"github.com/aws/aws-sdk-go/aws/session"
|
|
signer "github.com/aws/aws-sdk-go/aws/signer/v4"
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSigV4_Inferred_Region(t *testing.T) {
|
|
os.Setenv("AWS_ACCESS_KEY_ID", "secret")
|
|
os.Setenv("AWS_SECRET_ACCESS_KEY", "token")
|
|
os.Setenv("AWS_REGION", "us-west-2")
|
|
|
|
sess, err := session.NewSession(&aws.Config{
|
|
// Setting to an empty string to demostrate the default value from the yaml
|
|
// won't override the environment's region.
|
|
Region: aws.String(""),
|
|
})
|
|
require.NoError(t, err)
|
|
_, err = sess.Config.Credentials.Get()
|
|
require.NoError(t, err)
|
|
|
|
require.NotNil(t, sess.Config.Region)
|
|
require.Equal(t, "us-west-2", *sess.Config.Region)
|
|
}
|
|
|
|
func TestSigV4RoundTripper(t *testing.T) {
|
|
var gotReq *http.Request
|
|
|
|
rt := &sigV4RoundTripper{
|
|
region: "us-east-2",
|
|
next: promhttp.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
|
|
gotReq = req
|
|
return &http.Response{StatusCode: http.StatusOK}, nil
|
|
}),
|
|
signer: signer.NewSigner(credentials.NewStaticCredentials(
|
|
"test-id",
|
|
"secret",
|
|
"token",
|
|
)),
|
|
}
|
|
rt.pool.New = rt.newBuf
|
|
|
|
cli := &http.Client{Transport: rt}
|
|
|
|
req, err := http.NewRequest(http.MethodPost, "google.com", strings.NewReader("Hello, world!"))
|
|
require.NoError(t, err)
|
|
|
|
_, err = cli.Do(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, gotReq)
|
|
|
|
origReq := gotReq
|
|
require.NotEmpty(t, origReq.Header.Get("Authorization"))
|
|
require.NotEmpty(t, origReq.Header.Get("X-Amz-Date"))
|
|
|
|
// Perform the same request but with a header that shouldn't included in the
|
|
// signature; validate that the Authorization signature matches.
|
|
t.Run("Ignored Headers", func(t *testing.T) {
|
|
req, err := http.NewRequest(http.MethodPost, "google.com", strings.NewReader("Hello, world!"))
|
|
require.NoError(t, err)
|
|
|
|
req.Header.Add("Uber-Trace-Id", "some-trace-id")
|
|
|
|
_, err = cli.Do(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, gotReq)
|
|
|
|
require.Equal(t, origReq.Header.Get("Authorization"), gotReq.Header.Get("Authorization"))
|
|
})
|
|
}
|