mirror of
https://github.com/prometheus/prometheus.git
synced 2024-09-21 00:07:36 -07:00
d88aea7e6f
The prefixed target provider changed a pointerized target group that was reused in the wrapped target provider, causing an ever-increasing chain of source prefixes in target groups from the Consul target provider. We now make this bug generally impossible by switching the target group channel from pointer to value type and thus ensuring that target groups are copied before being passed on to other parts of the system. I tried to not let the depointerization leak too far outside of the channel handling (both upstream and downstream) because I tried that initially and caused some nasty bugs, which I want to minimize. Fixes https://github.com/prometheus/prometheus/issues/1083
399 lines
13 KiB
Go
399 lines
13 KiB
Go
// Copyright 2013 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package retrieval
|
|
|
|
import (
|
|
"net/url"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/prometheus/common/model"
|
|
|
|
"github.com/prometheus/prometheus/config"
|
|
)
|
|
|
|
func TestPrefixedTargetProvider(t *testing.T) {
|
|
targetGroups := []*config.TargetGroup{
|
|
{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test-1:1234"},
|
|
},
|
|
}, {
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test-1:1235"},
|
|
},
|
|
},
|
|
}
|
|
|
|
tp := &prefixedTargetProvider{
|
|
job: "job-x",
|
|
mechanism: "static",
|
|
idx: 123,
|
|
TargetProvider: NewStaticProvider(targetGroups),
|
|
}
|
|
|
|
expSources := []string{
|
|
"job-x:static:123:0",
|
|
"job-x:static:123:1",
|
|
}
|
|
if !reflect.DeepEqual(tp.Sources(), expSources) {
|
|
t.Fatalf("expected sources %v, got %v", expSources, tp.Sources())
|
|
}
|
|
|
|
ch := make(chan config.TargetGroup)
|
|
done := make(chan struct{})
|
|
|
|
defer close(done)
|
|
go tp.Run(ch, done)
|
|
|
|
expGroup1 := *targetGroups[0]
|
|
expGroup2 := *targetGroups[1]
|
|
expGroup1.Source = "job-x:static:123:0"
|
|
expGroup2.Source = "job-x:static:123:1"
|
|
|
|
// The static target provider sends on the channel once per target group.
|
|
if tg := <-ch; !reflect.DeepEqual(tg, expGroup1) {
|
|
t.Fatalf("expected target group %v, got %v", expGroup1, tg)
|
|
}
|
|
if tg := <-ch; !reflect.DeepEqual(tg, expGroup2) {
|
|
t.Fatalf("expected target group %v, got %v", expGroup2, tg)
|
|
}
|
|
}
|
|
|
|
func TestTargetManagerChan(t *testing.T) {
|
|
testJob1 := &config.ScrapeConfig{
|
|
JobName: "test_job1",
|
|
ScrapeInterval: config.Duration(1 * time.Minute),
|
|
TargetGroups: []*config.TargetGroup{{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "example.org:80"},
|
|
{model.AddressLabel: "example.com:80"},
|
|
},
|
|
}},
|
|
}
|
|
prov1 := &fakeTargetProvider{
|
|
sources: []string{"src1", "src2"},
|
|
update: make(chan *config.TargetGroup),
|
|
}
|
|
|
|
targetManager := &TargetManager{
|
|
sampleAppender: nopAppender{},
|
|
providers: map[*config.ScrapeConfig][]TargetProvider{
|
|
testJob1: {prov1},
|
|
},
|
|
targets: make(map[string][]*Target),
|
|
}
|
|
go targetManager.Run()
|
|
defer targetManager.Stop()
|
|
|
|
sequence := []struct {
|
|
tgroup *config.TargetGroup
|
|
expected map[string][]model.LabelSet
|
|
}{
|
|
{
|
|
tgroup: &config.TargetGroup{
|
|
Source: "src1",
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test-1:1234"},
|
|
{model.AddressLabel: "test-2:1234", "label": "set"},
|
|
{model.AddressLabel: "test-3:1234"},
|
|
},
|
|
},
|
|
expected: map[string][]model.LabelSet{
|
|
"src1": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-1:1234"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-2:1234", "label": "set"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-3:1234"},
|
|
},
|
|
},
|
|
}, {
|
|
tgroup: &config.TargetGroup{
|
|
Source: "src2",
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test-1:1235"},
|
|
{model.AddressLabel: "test-2:1235"},
|
|
{model.AddressLabel: "test-3:1235"},
|
|
},
|
|
Labels: model.LabelSet{"group": "label"},
|
|
},
|
|
expected: map[string][]model.LabelSet{
|
|
"src1": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-1:1234"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-2:1234", "label": "set"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-3:1234"},
|
|
},
|
|
"src2": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-1:1235", "group": "label"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-2:1235", "group": "label"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-3:1235", "group": "label"},
|
|
},
|
|
},
|
|
}, {
|
|
tgroup: &config.TargetGroup{
|
|
Source: "src2",
|
|
Targets: []model.LabelSet{},
|
|
},
|
|
expected: map[string][]model.LabelSet{
|
|
"src1": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-1:1234"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-2:1234", "label": "set"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-3:1234"},
|
|
},
|
|
},
|
|
}, {
|
|
tgroup: &config.TargetGroup{
|
|
Source: "src1",
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test-1:1234", "added": "label"},
|
|
{model.AddressLabel: "test-3:1234"},
|
|
{model.AddressLabel: "test-4:1234", "fancy": "label"},
|
|
},
|
|
},
|
|
expected: map[string][]model.LabelSet{
|
|
"src1": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-1:1234", "added": "label"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-3:1234"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "test-4:1234", "fancy": "label"},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
for i, step := range sequence {
|
|
prov1.update <- step.tgroup
|
|
|
|
time.Sleep(20 * time.Millisecond)
|
|
|
|
if len(targetManager.targets) != len(step.expected) {
|
|
t.Fatalf("step %d: sources mismatch %v, %v", i, targetManager.targets, step.expected)
|
|
}
|
|
|
|
for source, actTargets := range targetManager.targets {
|
|
expTargets, ok := step.expected[source]
|
|
if !ok {
|
|
t.Fatalf("step %d: unexpected source %q: %v", i, source, actTargets)
|
|
}
|
|
for _, expt := range expTargets {
|
|
found := false
|
|
for _, actt := range actTargets {
|
|
if reflect.DeepEqual(expt, actt.BaseLabels()) {
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
if !found {
|
|
t.Errorf("step %d: expected target %v not found in actual targets", i, expt)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestTargetManagerConfigUpdate(t *testing.T) {
|
|
testJob1 := &config.ScrapeConfig{
|
|
JobName: "test_job1",
|
|
ScrapeInterval: config.Duration(1 * time.Minute),
|
|
Params: url.Values{
|
|
"testParam": []string{"paramValue", "secondValue"},
|
|
},
|
|
TargetGroups: []*config.TargetGroup{{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "example.org:80"},
|
|
{model.AddressLabel: "example.com:80"},
|
|
},
|
|
}},
|
|
RelabelConfigs: []*config.RelabelConfig{
|
|
{
|
|
// Copy out the URL parameter.
|
|
SourceLabels: model.LabelNames{"__param_testParam"},
|
|
Regex: config.MustNewRegexp("(.*)"),
|
|
TargetLabel: "testParam",
|
|
Replacement: "$1",
|
|
Action: config.RelabelReplace,
|
|
},
|
|
},
|
|
}
|
|
testJob2 := &config.ScrapeConfig{
|
|
JobName: "test_job2",
|
|
ScrapeInterval: config.Duration(1 * time.Minute),
|
|
TargetGroups: []*config.TargetGroup{
|
|
{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "example.org:8080"},
|
|
{model.AddressLabel: "example.com:8081"},
|
|
},
|
|
Labels: model.LabelSet{
|
|
"foo": "bar",
|
|
"boom": "box",
|
|
},
|
|
},
|
|
{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test.com:1234"},
|
|
},
|
|
},
|
|
{
|
|
Targets: []model.LabelSet{
|
|
{model.AddressLabel: "test.com:1235"},
|
|
},
|
|
Labels: model.LabelSet{"instance": "fixed"},
|
|
},
|
|
},
|
|
RelabelConfigs: []*config.RelabelConfig{
|
|
{
|
|
SourceLabels: model.LabelNames{model.AddressLabel},
|
|
Regex: config.MustNewRegexp(`test\.(.*?):(.*)`),
|
|
Replacement: "foo.${1}:${2}",
|
|
TargetLabel: model.AddressLabel,
|
|
Action: config.RelabelReplace,
|
|
},
|
|
{
|
|
// Add a new label for example.* targets.
|
|
SourceLabels: model.LabelNames{model.AddressLabel, "boom", "foo"},
|
|
Regex: config.MustNewRegexp("example.*?-b([a-z-]+)r"),
|
|
TargetLabel: "new",
|
|
Replacement: "$1",
|
|
Separator: "-",
|
|
Action: config.RelabelReplace,
|
|
},
|
|
{
|
|
// Drop an existing label.
|
|
SourceLabels: model.LabelNames{"boom"},
|
|
Regex: config.MustNewRegexp(".*"),
|
|
TargetLabel: "boom",
|
|
Replacement: "",
|
|
Action: config.RelabelReplace,
|
|
},
|
|
},
|
|
}
|
|
|
|
sequence := []struct {
|
|
scrapeConfigs []*config.ScrapeConfig
|
|
expected map[string][]model.LabelSet
|
|
}{
|
|
{
|
|
scrapeConfigs: []*config.ScrapeConfig{testJob1},
|
|
expected: map[string][]model.LabelSet{
|
|
"test_job1:static:0:0": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.org:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.org:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.com:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.com:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
},
|
|
},
|
|
}, {
|
|
scrapeConfigs: []*config.ScrapeConfig{testJob1},
|
|
expected: map[string][]model.LabelSet{
|
|
"test_job1:static:0:0": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.org:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.org:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.com:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.com:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
},
|
|
},
|
|
}, {
|
|
scrapeConfigs: []*config.ScrapeConfig{testJob1, testJob2},
|
|
expected: map[string][]model.LabelSet{
|
|
"test_job1:static:0:0": {
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.org:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.org:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
{model.JobLabel: "test_job1", model.InstanceLabel: "example.com:80", "testParam": "paramValue",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.com:80", model.ParamLabelPrefix + "testParam": "paramValue"},
|
|
},
|
|
"test_job2:static:0:0": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "example.org:8080", "foo": "bar", "new": "ox-ba",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.org:8080"},
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "example.com:8081", "foo": "bar", "new": "ox-ba",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.com:8081"},
|
|
},
|
|
"test_job2:static:0:1": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "foo.com:1234",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "foo.com:1234"},
|
|
},
|
|
"test_job2:static:0:2": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "fixed",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "foo.com:1235"},
|
|
},
|
|
},
|
|
}, {
|
|
scrapeConfigs: []*config.ScrapeConfig{},
|
|
expected: map[string][]model.LabelSet{},
|
|
}, {
|
|
scrapeConfigs: []*config.ScrapeConfig{testJob2},
|
|
expected: map[string][]model.LabelSet{
|
|
"test_job2:static:0:0": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "example.org:8080", "foo": "bar", "new": "ox-ba",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.org:8080"},
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "example.com:8081", "foo": "bar", "new": "ox-ba",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "example.com:8081"},
|
|
},
|
|
"test_job2:static:0:1": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "foo.com:1234",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "foo.com:1234"},
|
|
},
|
|
"test_job2:static:0:2": {
|
|
{model.JobLabel: "test_job2", model.InstanceLabel: "fixed",
|
|
model.SchemeLabel: "", model.MetricsPathLabel: "", model.AddressLabel: "foo.com:1235"},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
conf := &config.Config{}
|
|
*conf = config.DefaultConfig
|
|
|
|
targetManager := NewTargetManager(nopAppender{})
|
|
targetManager.ApplyConfig(conf)
|
|
|
|
targetManager.Run()
|
|
defer targetManager.Stop()
|
|
|
|
for i, step := range sequence {
|
|
conf.ScrapeConfigs = step.scrapeConfigs
|
|
targetManager.ApplyConfig(conf)
|
|
|
|
time.Sleep(50 * time.Millisecond)
|
|
|
|
if len(targetManager.targets) != len(step.expected) {
|
|
t.Fatalf("step %d: sources mismatch: expected %v, got %v", i, step.expected, targetManager.targets)
|
|
}
|
|
|
|
for source, actTargets := range targetManager.targets {
|
|
expTargets, ok := step.expected[source]
|
|
if !ok {
|
|
t.Fatalf("step %d: unexpected source %q: %v", i, source, actTargets)
|
|
}
|
|
for _, expt := range expTargets {
|
|
found := false
|
|
for _, actt := range actTargets {
|
|
if reflect.DeepEqual(expt, actt.fullLabels()) {
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
if !found {
|
|
t.Errorf("step %d: expected target %v for %q not found in actual targets", i, expt, source)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestHandleUpdatesReturnsWhenUpdateChanIsClosed(t *testing.T) {
|
|
tm := NewTargetManager(nopAppender{})
|
|
ch := make(chan targetGroupUpdate)
|
|
close(ch)
|
|
tm.handleUpdates(ch, make(chan struct{}))
|
|
}
|