prometheus/promql
beorn7 5b53aa1108 style: Replace else if cascades with switch
Wiser coders than myself have come to the conclusion that a `switch`
statement is almost always superior to a statement that includes any
`else if`.

The exceptions that I have found in our codebase are just these two:

* The `if else` is followed by an additional statement before the next
  condition (separated by a `;`).
* The whole thing is within a `for` loop and `break` statements are
  used. In this case, using `switch` would require tagging the `for`
  loop, which probably tips the balance.

Why are `switch` statements more readable?

For one, fewer curly braces. But more importantly, the conditions all
have the same alignment, so the whole thing follows the natural flow
of going down a list of conditions. With `else if`, in contrast, all
conditions but the first are "hidden" behind `} else if `, harder to
spot and (for no good reason) presented differently from the first
condition.

I'm sure the aforemention wise coders can list even more reasons.

In any case, I like it so much that I have found myself recommending
it in code reviews. I would like to make it a habit in our code base,
without making it a hard requirement that we would test on the CI. But
for that, there has to be a role model, so this commit eliminates all
`if else` occurrences, unless it is autogenerated code or fits one of
the exceptions above.

Signed-off-by: beorn7 <beorn@grafana.com>
2023-04-19 17:22:31 +02:00
..
fuzz-data
parser style: Replace else if cascades with switch 2023-04-19 17:22:31 +02:00
testdata
bench_test.go lint: Adjust to the lint warnings raised by current versions of golint-ci 2023-04-19 17:10:10 +02:00
engine.go style: Replace else if cascades with switch 2023-04-19 17:22:31 +02:00
engine_test.go add ctx to QueryEngine interface 2023-04-17 21:32:38 -07:00
functions.go style: Replace else if cascades with switch 2023-04-19 17:22:31 +02:00
functions_test.go add ctx to QueryEngine interface 2023-04-17 21:32:38 -07:00
fuzz.go
fuzz_test.go error for invalid media type should not be completely swallowed (#10186) 2022-02-08 10:57:56 +01:00
promql_test.go add ctx to QueryEngine interface 2023-04-17 21:32:38 -07:00
quantile.go style: Replace else if cascades with switch 2023-04-19 17:22:31 +02:00
query_logger.go Close file descriptor in query logging (#11148) 2022-08-17 15:27:27 +05:30
query_logger_test.go
test.go add ctx to QueryEngine interface 2023-04-17 21:32:38 -07:00
test_test.go promql: Separate Point into FPoint and HPoint 2023-04-13 19:25:16 +02:00
value.go promql: Separate Point into FPoint and HPoint 2023-04-13 19:25:16 +02:00
value_test.go Shortcut ContainsSameLabelset() (#11000) 2022-07-13 15:18:10 +05:30