prometheus/tsdb
Filip Petkovski 1f69dcfa6b
Fix reusing float histograms
In https://github.com/prometheus/prometheus/pull/13276 we started reusing float histogram objects to reduce allocations in PromQL.
That PR introduces a bug where histogram pointers gets copied to the beginning of the histograms slice,
but are still kept in the end of the slice. When a new histogram is read into the last element,
it can overwrite a previous element because the pointer is the same.

This commit fixes the issue by moving outdated points to the end of the slice
so that we don't end up with duplicate pointers in the same buffer. In other words,
the slice gets rotated so that old objects can get reused.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-14 11:53:58 +01:00
..
agent tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
chunkenc tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
chunks Merge branch 'main' into arve/typos 2023-12-12 12:02:03 +01:00
docs
encoding tsdb/encoding: use Go standard errors package 2023-11-11 19:01:11 +01:00
errors Enable default revive rules (#13068) 2023-11-29 17:23:34 +00:00
fileutil tsdb/fileutil: use Go standard errors 2023-11-14 19:05:21 +00:00
goversion
index Merge pull request #12878 from bboreham/loser-tree 2023-12-12 21:38:30 +00:00
record Enable reusing memory when converting between histogram types 2023-12-08 10:22:59 +01:00
testdata
tombstones Update tombstones.go 2023-11-11 19:22:06 +01:00
tsdbutil Fix reusing float histograms 2023-12-14 11:53:58 +01:00
wlog tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
.gitignore
block.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
block_test.go Enable reusing memory when converting between histogram types 2023-12-08 10:22:59 +01:00
blockwriter.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
blockwriter_test.go
CHANGELOG.md
compact.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
compact_test.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
db.go tsdb: remove unused option (#13282) 2023-12-12 09:58:54 +00:00
db_test.go tsdb: remove unused option (#13282) 2023-12-12 09:58:54 +00:00
example_test.go
exemplar.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
exemplar_test.go golangci-lint: enable testifylint linter (#13254) 2023-12-07 11:35:01 +00:00
head.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
head_append.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
head_bench_test.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
head_read.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
head_read_test.go golangci-lint: enable testifylint linter (#13254) 2023-12-07 11:35:01 +00:00
head_test.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
head_wal.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
isolation.go
isolation_test.go
mocks_test.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
ooo_head.go Fix issue where queries can fail or omit OOO samples if OOO head compaction occurs between creating a querier and reading chunks (#13115) 2023-11-24 12:38:38 +01:00
ooo_head_read.go Change ChunkReader.Chunk() to ChunkOrIterable() 2023-11-28 11:14:29 +01:00
ooo_head_read_test.go golangci-lint: enable testifylint linter (#13254) 2023-12-07 11:35:01 +00:00
ooo_head_test.go
ooo_isolation.go Fix issue where queries can fail or omit OOO samples if OOO head compaction occurs between creating a querier and reading chunks (#13115) 2023-11-24 12:38:38 +01:00
ooo_isolation_test.go Fix issue where queries can fail or omit OOO samples if OOO head compaction occurs between creating a querier and reading chunks (#13115) 2023-11-24 12:38:38 +01:00
querier.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
querier_bench_test.go
querier_test.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
README.md
repair.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
repair_test.go
tsdbblockutil.go
wal.go tsdb: use Go standard errors 2023-12-11 12:18:54 +00:00
wal_test.go golangci-lint: enable testifylint linter (#13254) 2023-12-07 11:35:01 +00:00

TSDB

GoPkg

This directory contains the Prometheus TSDB (Time Series DataBase) library, which handles storage and querying of all Prometheus v2 data.

Documentation

External resources

A series of blog posts explaining different components of TSDB: