mirror of
https://github.com/prometheus/prometheus.git
synced 2024-11-14 17:44:06 -08:00
c3c7d44d84
We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>
52 lines
1.9 KiB
Go
52 lines
1.9 KiB
Go
// Copyright 2023 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rules
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
"github.com/prometheus/prometheus/promql"
|
|
"github.com/prometheus/prometheus/promql/parser"
|
|
)
|
|
|
|
type unknownRule struct{}
|
|
|
|
func (u unknownRule) Name() string { return "" }
|
|
func (u unknownRule) Labels() labels.Labels { return labels.EmptyLabels() }
|
|
func (u unknownRule) Eval(context.Context, time.Time, QueryFunc, *url.URL, int) (promql.Vector, error) {
|
|
return nil, nil
|
|
}
|
|
func (u unknownRule) String() string { return "" }
|
|
func (u unknownRule) Query() parser.Expr { return nil }
|
|
func (u unknownRule) SetLastError(error) {}
|
|
func (u unknownRule) LastError() error { return nil }
|
|
func (u unknownRule) SetHealth(RuleHealth) {}
|
|
func (u unknownRule) Health() RuleHealth { return "" }
|
|
func (u unknownRule) SetEvaluationDuration(time.Duration) {}
|
|
func (u unknownRule) GetEvaluationDuration() time.Duration { return 0 }
|
|
func (u unknownRule) SetEvaluationTimestamp(time.Time) {}
|
|
func (u unknownRule) GetEvaluationTimestamp() time.Time { return time.Time{} }
|
|
|
|
func TestNewRuleDetailPanics(t *testing.T) {
|
|
require.PanicsWithValue(t, `unknown rule type "rules.unknownRule"`, func() {
|
|
NewRuleDetail(unknownRule{})
|
|
})
|
|
}
|