prometheus/cmd/promtool
zenador 69edd8709b
Add warnings (and annotations) to PromQL query results (#12152)
Return annotations (warnings and infos) from PromQL queries

This generalizes the warnings we have already used before (but only for problems with remote read) as "annotations".

Annotations can be warnings or infos (the latter could be false positives). We do not treat them different in the API for now and return them all as "warnings". It would be easy to distinguish them and return infos separately, should that appear useful in the future.

The new annotations are then used to create a lot of warnings or infos during PromQL evaluations. Partially these are things we have wanted for a long time (e.g. inform the user that they have applied `rate` to a metric that doesn't look like a counter), but the new native histograms have created even more needs for those annotations (e.g. if a query tries to aggregate float numbers with histograms).

The annotations added here are not yet complete. A prominent example would be a warning about a range too short for a rate calculation. But such a warnings is more tricky to create with good fidelity and we will tackle it later.

Another TODO is to take annotations into account when evaluating recording rules.

---------

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-09-14 18:57:31 +02:00
..
testdata Unit tests for native histograms (#12668) 2023-08-25 23:35:42 +02:00
archive.go refactor (package cmd): move from github.com/pkg/errors to 'errors' and 'fmt' packages (#10733) 2022-05-24 16:58:59 +10:00
backfill.go enable gocritic, unconvert and unused linters 2023-04-13 19:20:22 +00:00
backfill_test.go Add context argument to Querier.Select (#12660) 2023-09-12 12:37:38 +02:00
debug.go refactor (package cmd): move from github.com/pkg/errors to 'errors' and 'fmt' packages (#10733) 2022-05-24 16:58:59 +10:00
main.go Add context argument to IndexReader.Postings (#12667) 2023-09-13 17:45:06 +02:00
main_test.go Document command line tools 2023-03-13 14:20:55 +01:00
metrics.go fix: apply suggested changes 2023-06-27 09:30:39 +02:00
rules.go Merge branch 'main' into linter/nilerr 2023-04-19 19:56:39 +02:00
rules_test.go Add context argument to Querier.Select (#12660) 2023-09-12 12:37:38 +02:00
sd.go Merge pull request #12048 from bboreham/faster-targets 2023-03-09 11:10:01 +00:00
sd_test.go cmd/promtool: in tests use labels.FromStrings 2022-09-09 13:34:49 +02:00
tsdb.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
unittest.go Unit tests for native histograms (#12668) 2023-08-25 23:35:42 +02:00
unittest_test.go Disable time based retention in tests (#8818) 2022-01-02 23:46:03 +01:00