prometheus/promql
zenador 69edd8709b
Add warnings (and annotations) to PromQL query results (#12152)
Return annotations (warnings and infos) from PromQL queries

This generalizes the warnings we have already used before (but only for problems with remote read) as "annotations".

Annotations can be warnings or infos (the latter could be false positives). We do not treat them different in the API for now and return them all as "warnings". It would be easy to distinguish them and return infos separately, should that appear useful in the future.

The new annotations are then used to create a lot of warnings or infos during PromQL evaluations. Partially these are things we have wanted for a long time (e.g. inform the user that they have applied `rate` to a metric that doesn't look like a counter), but the new native histograms have created even more needs for those annotations (e.g. if a query tries to aggregate float numbers with histograms).

The annotations added here are not yet complete. A prominent example would be a warning about a range too short for a rate calculation. But such a warnings is more tricky to create with good fidelity and we will tackle it later.

Another TODO is to take annotations into account when evaluating recording rules.

---------

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-09-14 18:57:31 +02:00
..
fuzz-data textparse: Add fuzzing and fix bug caught 2017-07-07 11:12:17 +02:00
parser Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
testdata Unit tests for native histograms (#12668) 2023-08-25 23:35:42 +02:00
bench_test.go Add context argument to IndexReader.Postings (#12667) 2023-09-13 17:45:06 +02:00
engine.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
engine_test.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
functions.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
functions_test.go Merge branch 'main' into linter/nilerr 2023-04-19 19:56:39 +02:00
fuzz.go textparse/scrape: Add option to scrape both classic and native histograms 2023-05-13 01:32:25 +02:00
fuzz_test.go error for invalid media type should not be completely swallowed (#10186) 2022-02-08 10:57:56 +01:00
promql_test.go promql: allow tests to be imported (#12050) 2023-08-18 20:48:59 +02:00
quantile.go histograms: Improve comment 2023-07-12 14:52:49 +02:00
query_logger.go add Close for ActiveQueryTracker to close the file. 2023-04-14 14:43:23 +08:00
query_logger_test.go add Close for ActiveQueryTracker to close the file. 2023-04-14 14:43:23 +08:00
test.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
test_test.go Add context argument to Querier.Select (#12660) 2023-09-12 12:37:38 +02:00
value.go Add warnings (and annotations) to PromQL query results (#12152) 2023-09-14 18:57:31 +02:00
value_test.go Shortcut ContainsSameLabelset() (#11000) 2022-07-13 15:18:10 +05:30