mirror of
https://github.com/prometheus/prometheus.git
synced 2025-01-27 13:42:31 -08:00
ce1ee444f1
This does two things:
1) Make TieredStorage.AppendSamples() write directly to memory instead of
buffering to a channel first. This is needed in cases where a rule might
immediately need the data generated by a previous rule.
2) Replace the single storage mutex by two new ones:
- memoryMutex - needs to be locked at any time that two concurrent
goroutines could be accessing (via read or write) the
TieredStorage memoryArena.
- memoryDeleteMutex - used to prevent any deletion of samples from
memoryArena as long as renderView is running and
assembling data from it.
The LevelDB disk storage does not need to be protected by a mutex when
rendering a view since renderView works off a LevelDB snapshot.
The rationale against adding memoryMutex directly to the memory storage: taking
a mutex does come with a small inherent time cost, and taking it is only
required in few places. In fact, no locking is required for the memory storage
instance which is part of a view (and not the TieredStorage).
111 lines
2.9 KiB
Go
111 lines
2.9 KiB
Go
// Copyright 2013 Prometheus Team
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package metric
|
|
|
|
import (
|
|
"fmt"
|
|
"github.com/prometheus/prometheus/model"
|
|
"github.com/prometheus/prometheus/utility/test"
|
|
"time"
|
|
)
|
|
|
|
var (
|
|
// ``hg clone https://code.google.com/p/go ; cd go ; hg log | tail -n 20``
|
|
usEastern, _ = time.LoadLocation("US/Eastern")
|
|
testInstant = time.Date(1972, 7, 18, 19, 5, 45, 0, usEastern).In(time.UTC)
|
|
)
|
|
|
|
func testAppendSample(p MetricPersistence, s model.Sample, t test.Tester) {
|
|
err := p.AppendSample(s)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func buildLevelDBTestPersistencesMaker(name string, t test.Tester) func() (MetricPersistence, test.Closer) {
|
|
return func() (MetricPersistence, test.Closer) {
|
|
temporaryDirectory := test.NewTemporaryDirectory("get_value_at_time", t)
|
|
|
|
p, err := NewLevelDBMetricPersistence(temporaryDirectory.Path())
|
|
if err != nil {
|
|
t.Errorf("Could not start up LevelDB: %q\n", err)
|
|
}
|
|
|
|
return p, temporaryDirectory
|
|
}
|
|
}
|
|
|
|
func buildLevelDBTestPersistence(name string, f func(p MetricPersistence, t test.Tester)) func(t test.Tester) {
|
|
return func(t test.Tester) {
|
|
temporaryDirectory := test.NewTemporaryDirectory(fmt.Sprintf("test_leveldb_%s", name), t)
|
|
defer temporaryDirectory.Close()
|
|
|
|
p, err := NewLevelDBMetricPersistence(temporaryDirectory.Path())
|
|
if err != nil {
|
|
t.Errorf("Could not create LevelDB Metric Persistence: %q\n", err)
|
|
}
|
|
|
|
defer p.Close()
|
|
|
|
f(p, t)
|
|
}
|
|
}
|
|
|
|
func buildMemoryTestPersistence(f func(p MetricPersistence, t test.Tester)) func(t test.Tester) {
|
|
return func(t test.Tester) {
|
|
|
|
p := NewMemorySeriesStorage()
|
|
|
|
defer p.Close()
|
|
|
|
f(p, t)
|
|
}
|
|
}
|
|
|
|
type testTieredStorageCloser struct {
|
|
storage *TieredStorage
|
|
directory test.Closer
|
|
}
|
|
|
|
func (t testTieredStorageCloser) Close() {
|
|
t.storage.Close()
|
|
t.directory.Close()
|
|
}
|
|
|
|
func NewTestTieredStorage(t test.Tester) (storage *TieredStorage, closer test.Closer) {
|
|
var directory test.TemporaryDirectory
|
|
directory = test.NewTemporaryDirectory("test_tiered_storage", t)
|
|
storage, err := NewTieredStorage(2500, 1000, 5*time.Second, 15*time.Second, 0*time.Second, directory.Path())
|
|
|
|
if err != nil {
|
|
if storage != nil {
|
|
storage.Close()
|
|
}
|
|
directory.Close()
|
|
t.Fatalf("Error creating storage: %s", err)
|
|
}
|
|
|
|
if storage == nil {
|
|
directory.Close()
|
|
t.Fatalf("storage == nil")
|
|
}
|
|
|
|
go storage.Serve()
|
|
closer = &testTieredStorageCloser{
|
|
storage: storage,
|
|
directory: directory,
|
|
}
|
|
return
|
|
}
|