mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-26 14:09:41 -08:00
66dfb951c4
* Add errors and Warnings to SeriesSet Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Change Querier interface and refactor accordingly Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactor promql/engine to propagate warnings at eval stage Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Make sure all the series from all Selects are pre-advanced Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Separate merge series sets Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Clean Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactor merge querier failure handling Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactored and simplified fanout with improvements from incoming chunk iterator PRs. * Secondary logic is hidden, instead of weird failed series set logic we had. * Fanout is well commented * Fanout closing record all errors * MergeQuerier improved API (clearer) * deferredGenericMergeSeriesSet is not needed as we return no samples anyway for failed series sets (next = false). Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fix formatting Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix CI issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Added final tests for error handling. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Brian's comments. * Moved hints in populate to be allocated only when needed. * Used sync.Once in secondary Querier to achieve all-or-nothing partial response logic. * Select after first Next is done will panic. NOTE: in lazySeriesSet in theory we could just panic, I think however we can totally just return error, it will panic in expand anyway. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Utilize errWithWarnings Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix recently introduced expansion issue Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add tests for secondary querier error handling Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Implement lazy merge Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add name to test cases Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Reorganize Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review comments Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review comments Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Remove redundant warnings Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix rebase mistake Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
68 lines
1.7 KiB
Go
68 lines
1.7 KiB
Go
// Copyright 2017 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package storage
|
|
|
|
type lazySeriesSet struct {
|
|
create func() (s genericSeriesSet, ok bool)
|
|
|
|
set genericSeriesSet
|
|
}
|
|
|
|
func (c *lazySeriesSet) Next() bool {
|
|
if c.set != nil {
|
|
return c.set.Next()
|
|
}
|
|
|
|
var ok bool
|
|
c.set, ok = c.create()
|
|
return ok
|
|
}
|
|
|
|
func (c *lazySeriesSet) Err() error {
|
|
if c.set != nil {
|
|
return c.set.Err()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *lazySeriesSet) At() Labels {
|
|
if c.set != nil {
|
|
return c.set.At()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *lazySeriesSet) Warnings() Warnings {
|
|
if c.set != nil {
|
|
return c.set.Warnings()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
type warningsOnlySeriesSet Warnings
|
|
|
|
func (warningsOnlySeriesSet) Next() bool { return false }
|
|
func (warningsOnlySeriesSet) Err() error { return nil }
|
|
func (warningsOnlySeriesSet) At() Labels { return nil }
|
|
func (c warningsOnlySeriesSet) Warnings() Warnings { return Warnings(c) }
|
|
|
|
type errorOnlySeriesSet struct {
|
|
err error
|
|
}
|
|
|
|
func (errorOnlySeriesSet) Next() bool { return false }
|
|
func (errorOnlySeriesSet) At() Labels { return nil }
|
|
func (s errorOnlySeriesSet) Err() error { return s.err }
|
|
func (errorOnlySeriesSet) Warnings() Warnings { return nil }
|