mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-26 06:04:05 -08:00
5408666387
Since rule evaluations work via String(), this fixes evaluation of rules containing GROUP_x modifiers without labels. This change is the minimal bugfix (so that we can release a fixed version without risk). It does not intend to implement any additional features (like allowing `GROUP_LEFT()` or `ON()` or even `ON` - see discussion in https://github.com/prometheus/prometheus/issues/1597 ).
82 lines
1.8 KiB
Go
82 lines
1.8 KiB
Go
// Copyright 2015 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package promql
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestExprString(t *testing.T) {
|
|
// A list of valid expressions that are expected to be
|
|
// returned as out when calling String(). If out is empty the output
|
|
// is expected to equal the input.
|
|
inputs := []struct {
|
|
in, out string
|
|
}{
|
|
{
|
|
in: `sum(task:errors:rate10s{job="s"}) BY (code)`,
|
|
},
|
|
{
|
|
in: `sum(task:errors:rate10s{job="s"}) BY (code) KEEP_COMMON`,
|
|
},
|
|
{
|
|
in: `sum(task:errors:rate10s{job="s"}) KEEP_COMMON`,
|
|
},
|
|
{
|
|
in: `sum(task:errors:rate10s{job="s"}) WITHOUT (instance)`,
|
|
},
|
|
{
|
|
in: `a - ON(b) c`,
|
|
},
|
|
{
|
|
in: `a - ON(b) GROUP_LEFT(x) c`,
|
|
},
|
|
{
|
|
in: `a - ON(b) GROUP_LEFT(x, y) c`,
|
|
},
|
|
{
|
|
in: `a - ON(b) GROUP_LEFT c`,
|
|
},
|
|
{
|
|
in: `a - IGNORING(b) c`,
|
|
},
|
|
{
|
|
in: `up > BOOL 0`,
|
|
},
|
|
{
|
|
in: `a OFFSET 1m`,
|
|
},
|
|
{
|
|
in: `a{c="d"}[5m] OFFSET 1m`,
|
|
},
|
|
{
|
|
in: `a[5m] OFFSET 1m`,
|
|
},
|
|
}
|
|
|
|
for _, test := range inputs {
|
|
expr, err := ParseExpr(test.in)
|
|
if err != nil {
|
|
t.Fatalf("parsing error for %q: %s", test.in, err)
|
|
}
|
|
exp := test.in
|
|
if test.out != "" {
|
|
exp = test.out
|
|
}
|
|
if expr.String() != exp {
|
|
t.Fatalf("expected %q to be returned as:\n%s\ngot:\n%s\n", test.in, exp, expr.String())
|
|
}
|
|
}
|
|
}
|