mirror of
https://github.com/prometheus/prometheus.git
synced 2025-02-21 03:16:00 -08:00
9b4c8f6be2
* rulefmt: add tests with YAML aliases for Alert/Record/Expr Altough somewhat discouraged in favour of using proper configuration management tools to generate full YAML, it can still be useful in some situations to use YAML anchors/aliases in rules. The current implementation is however confusing: aliases will work everywhere except on the alert/record name and expr This first commit adds (failing) tests to illustrate the issue, the next one fixes it. The YAML test file is intentionally filled with anchors and aliases. Although this is probably not representative of a real-world use case (which would have less of them), it errs on the safer side. Signed-off-by: François HORTA <fhorta@scaleway.com> * rulefmt: support YAML aliases for Alert/Record/Expr This fixes the use of YAML aliases in alert/recording rule names and expressions. A side effect of this change is that the RuleNode YAML type is no longer propagated deeper in the codebase, instead the generic Rule type can now be used. Signed-off-by: François HORTA <fhorta@scaleway.com> * rulefmt: Add test for YAML merge combined with aliases Currently this does work, but adding a test for the related functionally here makes sense. Signed-off-by: David Leadbeater <dgl@dgl.cx> * rulefmt: Rebase to latest changes Signed-off-by: David Leadbeater <dgl@dgl.cx> --------- Signed-off-by: François HORTA <fhorta@scaleway.com> Signed-off-by: David Leadbeater <dgl@dgl.cx> Co-authored-by: David Leadbeater <dgl@dgl.cx> |
||
|---|---|---|
| .. | ||
| bad_expr.bad.yaml | ||
| bad_field.bad.yaml | ||
| duplicate_grp.bad.yaml | ||
| invalid_label_name.bad.yaml | ||
| invalid_record_name.bad.yaml | ||
| no_rec_alert.bad.yaml | ||
| noexpr.bad.yaml | ||
| record_and_alert.bad.yaml | ||
| record_and_for.bad.yaml | ||
| record_and_keep_firing_for.bad.yaml | ||
| test.yaml | ||
| test_aliases.yaml | ||
| utf-8_annotation.good.yaml | ||
| utf-8_lname.good.yaml | ||