mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-24 21:24:05 -08:00
583f3e587c
Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
143 lines
4.3 KiB
Go
143 lines
4.3 KiB
Go
// Copyright 2021 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package storage
|
|
|
|
import (
|
|
"math"
|
|
|
|
"github.com/prometheus/prometheus/model/histogram"
|
|
"github.com/prometheus/prometheus/tsdb/chunkenc"
|
|
)
|
|
|
|
// MemoizedSeriesIterator wraps an iterator with a buffer to look back the previous element.
|
|
//
|
|
// This iterator regards integer histograms as float histograms; calls to Seek() will never return chunkenc.Histogram.
|
|
// This iterator deliberately does not implement chunkenc.Iterator.
|
|
type MemoizedSeriesIterator struct {
|
|
it chunkenc.Iterator
|
|
delta int64
|
|
|
|
lastTime int64
|
|
valueType chunkenc.ValueType
|
|
|
|
// Keep track of the previously returned value.
|
|
prevTime int64
|
|
prevValue float64
|
|
prevFloatHistogram *histogram.FloatHistogram
|
|
}
|
|
|
|
// NewMemoizedEmptyIterator is like NewMemoizedIterator but it's initialised with an empty iterator.
|
|
func NewMemoizedEmptyIterator(delta int64) *MemoizedSeriesIterator {
|
|
return NewMemoizedIterator(chunkenc.NewNopIterator(), delta)
|
|
}
|
|
|
|
// NewMemoizedIterator returns a new iterator that buffers the values within the
|
|
// time range of the current element and the duration of delta before.
|
|
func NewMemoizedIterator(it chunkenc.Iterator, delta int64) *MemoizedSeriesIterator {
|
|
bit := &MemoizedSeriesIterator{
|
|
delta: delta,
|
|
prevTime: math.MinInt64,
|
|
}
|
|
bit.Reset(it)
|
|
|
|
return bit
|
|
}
|
|
|
|
// Reset the internal state to reuse the wrapper with the provided iterator.
|
|
func (b *MemoizedSeriesIterator) Reset(it chunkenc.Iterator) {
|
|
b.it = it
|
|
b.lastTime = math.MinInt64
|
|
b.prevTime = math.MinInt64
|
|
b.valueType = it.Next()
|
|
}
|
|
|
|
// PeekPrev returns the previous element of the iterator. If there is none buffered,
|
|
// ok is false.
|
|
func (b *MemoizedSeriesIterator) PeekPrev() (t int64, v float64, fh *histogram.FloatHistogram, ok bool) {
|
|
if b.prevTime == math.MinInt64 {
|
|
return 0, 0, nil, false
|
|
}
|
|
return b.prevTime, b.prevValue, b.prevFloatHistogram, true
|
|
}
|
|
|
|
// Seek advances the iterator to the element at time t or greater.
|
|
func (b *MemoizedSeriesIterator) Seek(t int64) chunkenc.ValueType {
|
|
t0 := t - b.delta
|
|
|
|
if b.valueType != chunkenc.ValNone && t0 > b.lastTime {
|
|
// Reset the previously stored element because the seek advanced
|
|
// more than the delta.
|
|
b.prevTime = math.MinInt64
|
|
|
|
b.valueType = b.it.Seek(t0)
|
|
switch b.valueType {
|
|
case chunkenc.ValNone:
|
|
return chunkenc.ValNone
|
|
case chunkenc.ValHistogram:
|
|
b.valueType = chunkenc.ValFloatHistogram
|
|
}
|
|
b.lastTime = b.it.AtT()
|
|
}
|
|
if b.lastTime >= t {
|
|
return b.valueType
|
|
}
|
|
for b.Next() != chunkenc.ValNone {
|
|
if b.lastTime >= t {
|
|
return b.valueType
|
|
}
|
|
}
|
|
|
|
return chunkenc.ValNone
|
|
}
|
|
|
|
// Next advances the iterator to the next element. Note that this does not check whether the element being buffered is
|
|
// within the time range of the current element and the duration of delta before.
|
|
func (b *MemoizedSeriesIterator) Next() chunkenc.ValueType {
|
|
// Keep track of the previous element.
|
|
switch b.valueType {
|
|
case chunkenc.ValNone:
|
|
return chunkenc.ValNone
|
|
case chunkenc.ValFloat:
|
|
b.prevTime, b.prevValue = b.it.At()
|
|
b.prevFloatHistogram = nil
|
|
case chunkenc.ValHistogram, chunkenc.ValFloatHistogram:
|
|
b.prevValue = 0
|
|
b.prevTime, b.prevFloatHistogram = b.it.AtFloatHistogram(nil)
|
|
}
|
|
|
|
b.valueType = b.it.Next()
|
|
if b.valueType != chunkenc.ValNone {
|
|
b.lastTime = b.it.AtT()
|
|
}
|
|
if b.valueType == chunkenc.ValHistogram {
|
|
b.valueType = chunkenc.ValFloatHistogram
|
|
}
|
|
return b.valueType
|
|
}
|
|
|
|
// At returns the current float element of the iterator.
|
|
func (b *MemoizedSeriesIterator) At() (int64, float64) {
|
|
return b.it.At()
|
|
}
|
|
|
|
// AtFloatHistogram returns the current float-histogram element of the iterator.
|
|
func (b *MemoizedSeriesIterator) AtFloatHistogram() (int64, *histogram.FloatHistogram) {
|
|
return b.it.AtFloatHistogram(nil)
|
|
}
|
|
|
|
// Err returns the last encountered error.
|
|
func (b *MemoizedSeriesIterator) Err() error {
|
|
return b.it.Err()
|
|
}
|