mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-25 05:34:05 -08:00
f44bba31b3
We should never modify (or even shallow copy) Config after config.Load; added comments and modified GetScrapeConfigs to do so. For GetScrapeConfigs the validation (even repeated) was likely doing writes (because global fields was 0). We GetScrapeConfigs concurrently in tests and ApplyConfig causing test races. In prod there were races but likelyt only to replace 0 with 0, so not too severe. I removed validation since I don't see anyone using our config.Config without Load. I had to refactor one test that was doing it, all others use yaml config. Fixes #15538 Previous attempt: https://github.com/prometheus/prometheus/pull/15634 Signed-off-by: bwplotka <bwplotka@gmail.com> |
||
|---|---|---|
| .. | ||
| testdata | ||
| clientprotobuf.go | ||
| helpers_test.go | ||
| manager.go | ||
| manager_test.go | ||
| metrics.go | ||
| scrape.go | ||
| scrape_test.go | ||
| target.go | ||
| target_test.go | ||