mirror of
https://github.com/prometheus/prometheus.git
synced 2025-02-02 08:31:11 -08:00
Add --ignore-unknown-fields that ignores unknown fields in rule group
files. There are lots of tools in the ecosystem that "like" to extend
the rule group file structure but they are currently unreadable by
promtool if there's anything extra. The purpose of this flag is so that
we could use the "vanilla" promtool instead of rolling our own.
Some examples of tools/code:
https://github.com/grafana/mimir/blob/main/pkg/mimirtool/rules/rwrulefmt/rulefmt.go
8898eb3cc5/pkg/rules/rules.go (L18-L25)
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
252 lines
5.7 KiB
Go
252 lines
5.7 KiB
Go
// Copyright 2018 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/xml"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/prometheus/prometheus/promql/promqltest"
|
|
"github.com/prometheus/prometheus/util/junitxml"
|
|
)
|
|
|
|
func TestRulesUnitTest(t *testing.T) {
|
|
t.Parallel()
|
|
type args struct {
|
|
files []string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
queryOpts promqltest.LazyLoaderOpts
|
|
want int
|
|
}{
|
|
{
|
|
name: "Passing Unit Tests",
|
|
args: args{
|
|
files: []string{"./testdata/unittest.yml"},
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "Long evaluation interval",
|
|
args: args{
|
|
files: []string{"./testdata/long-period.yml"},
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "Bad input series",
|
|
args: args{
|
|
files: []string{"./testdata/bad-input-series.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Bad PromQL",
|
|
args: args{
|
|
files: []string{"./testdata/bad-promql.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Bad rules (syntax error)",
|
|
args: args{
|
|
files: []string{"./testdata/bad-rules-syntax-test.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Bad rules (error evaluating)",
|
|
args: args{
|
|
files: []string{"./testdata/bad-rules-error-test.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Simple failing test",
|
|
args: args{
|
|
files: []string{"./testdata/failing.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Disabled feature (@ modifier)",
|
|
args: args{
|
|
files: []string{"./testdata/at-modifier-test.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Enabled feature (@ modifier)",
|
|
args: args{
|
|
files: []string{"./testdata/at-modifier-test.yml"},
|
|
},
|
|
queryOpts: promqltest.LazyLoaderOpts{
|
|
EnableAtModifier: true,
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "Disabled feature (negative offset)",
|
|
args: args{
|
|
files: []string{"./testdata/negative-offset-test.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Enabled feature (negative offset)",
|
|
args: args{
|
|
files: []string{"./testdata/negative-offset-test.yml"},
|
|
},
|
|
queryOpts: promqltest.LazyLoaderOpts{
|
|
EnableNegativeOffset: true,
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "No test group interval",
|
|
args: args{
|
|
files: []string{"./testdata/no-test-group-interval.yml"},
|
|
},
|
|
queryOpts: promqltest.LazyLoaderOpts{
|
|
EnableNegativeOffset: true,
|
|
},
|
|
want: 0,
|
|
},
|
|
}
|
|
reuseFiles := []string{}
|
|
reuseCount := [2]int{}
|
|
for _, tt := range tests {
|
|
if (tt.queryOpts == promqltest.LazyLoaderOpts{
|
|
EnableNegativeOffset: true,
|
|
} || tt.queryOpts == promqltest.LazyLoaderOpts{
|
|
EnableAtModifier: true,
|
|
}) {
|
|
reuseFiles = append(reuseFiles, tt.args.files...)
|
|
reuseCount[tt.want] += len(tt.args.files)
|
|
}
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
if got := RulesUnitTest(tt.queryOpts, nil, false, false, false, tt.args.files...); got != tt.want {
|
|
t.Errorf("RulesUnitTest() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
t.Run("Junit xml output ", func(t *testing.T) {
|
|
t.Parallel()
|
|
var buf bytes.Buffer
|
|
if got := RulesUnitTestResult(&buf, promqltest.LazyLoaderOpts{}, nil, false, false, false, reuseFiles...); got != 1 {
|
|
t.Errorf("RulesUnitTestResults() = %v, want 1", got)
|
|
}
|
|
var test junitxml.JUnitXML
|
|
output := buf.Bytes()
|
|
err := xml.Unmarshal(output, &test)
|
|
if err != nil {
|
|
fmt.Println("error in decoding XML:", err)
|
|
return
|
|
}
|
|
var total int
|
|
var passes int
|
|
var failures int
|
|
var cases int
|
|
total = len(test.Suites)
|
|
if total != len(reuseFiles) {
|
|
t.Errorf("JUnit output had %d testsuite elements; expected %d\n", total, len(reuseFiles))
|
|
}
|
|
|
|
for _, i := range test.Suites {
|
|
if i.FailureCount == 0 {
|
|
passes++
|
|
} else {
|
|
failures++
|
|
}
|
|
cases += len(i.Cases)
|
|
}
|
|
if total != passes+failures {
|
|
t.Errorf("JUnit output mismatch: Total testsuites (%d) does not equal the sum of passes (%d) and failures (%d).", total, passes, failures)
|
|
}
|
|
if cases < total {
|
|
t.Errorf("JUnit output had %d suites without test cases\n", total-cases)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestRulesUnitTestRun(t *testing.T) {
|
|
t.Parallel()
|
|
type args struct {
|
|
run []string
|
|
files []string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
queryOpts promqltest.LazyLoaderOpts
|
|
want int
|
|
ignoreUnknownFields bool
|
|
}{
|
|
{
|
|
name: "Test all without run arg",
|
|
args: args{
|
|
run: nil,
|
|
files: []string{"./testdata/rules_run.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Test all with run arg",
|
|
args: args{
|
|
run: []string{"correct", "wrong"},
|
|
files: []string{"./testdata/rules_run.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Test correct",
|
|
args: args{
|
|
run: []string{"correct"},
|
|
files: []string{"./testdata/rules_run.yml"},
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "Test wrong",
|
|
args: args{
|
|
run: []string{"wrong"},
|
|
files: []string{"./testdata/rules_run.yml"},
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "Test all with extra fields",
|
|
args: args{
|
|
files: []string{"./testdata/rules_run_extrafields.yml"},
|
|
},
|
|
ignoreUnknownFields: true,
|
|
want: 0,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
got := RulesUnitTest(tt.queryOpts, tt.args.run, false, false, tt.ignoreUnknownFields, tt.args.files...)
|
|
require.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|