mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-26 14:09:41 -08:00
fe802f29c9
This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet which rely on sorting. I found during work on https://github.com/prometheus/prometheus/pull/5882 that we do so many repetitions because of this, for not good reason. I think I found a good balance between convenience and readability with just one method. Smaller the interface = better. Also I don't know what TestSelectSorted was testing, but now it's testing sorting. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
55 lines
1.4 KiB
Go
55 lines
1.4 KiB
Go
// Copyright 2017 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package storage
|
|
|
|
import (
|
|
"github.com/prometheus/prometheus/pkg/labels"
|
|
)
|
|
|
|
type noopQuerier struct{}
|
|
|
|
// NoopQuerier is a Querier that does nothing.
|
|
func NoopQuerier() Querier {
|
|
return noopQuerier{}
|
|
}
|
|
|
|
func (noopQuerier) Select(bool, *SelectHints, ...*labels.Matcher) (SeriesSet, Warnings, error) {
|
|
return NoopSeriesSet(), nil, nil
|
|
}
|
|
|
|
func (noopQuerier) LabelValues(name string) ([]string, Warnings, error) {
|
|
return nil, nil, nil
|
|
}
|
|
|
|
func (noopQuerier) LabelNames() ([]string, Warnings, error) {
|
|
return nil, nil, nil
|
|
}
|
|
|
|
func (noopQuerier) Close() error {
|
|
return nil
|
|
}
|
|
|
|
type noopSeriesSet struct{}
|
|
|
|
// NoopSeriesSet is a SeriesSet that does nothing.
|
|
func NoopSeriesSet() SeriesSet {
|
|
return noopSeriesSet{}
|
|
}
|
|
|
|
func (noopSeriesSet) Next() bool { return false }
|
|
|
|
func (noopSeriesSet) At() Series { return nil }
|
|
|
|
func (noopSeriesSet) Err() error { return nil }
|