mirror of
https://github.com/prometheus/prometheus.git
synced 2024-09-19 23:37:31 -07:00
c3c7d44d84
We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>
50 lines
1.5 KiB
Go
50 lines
1.5 KiB
Go
// Copyright 2017 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package testutil
|
|
|
|
import (
|
|
"net/http"
|
|
)
|
|
|
|
type roundTrip struct {
|
|
theResponse *http.Response
|
|
theError error
|
|
}
|
|
|
|
func (rt *roundTrip) RoundTrip(*http.Request) (*http.Response, error) {
|
|
return rt.theResponse, rt.theError
|
|
}
|
|
|
|
type roundTripCheckRequest struct {
|
|
checkRequest func(*http.Request)
|
|
roundTrip
|
|
}
|
|
|
|
func (rt *roundTripCheckRequest) RoundTrip(r *http.Request) (*http.Response, error) {
|
|
rt.checkRequest(r)
|
|
return rt.theResponse, rt.theError
|
|
}
|
|
|
|
// NewRoundTripCheckRequest creates a new instance of a type that implements http.RoundTripper,
|
|
// which before returning theResponse and theError, executes checkRequest against a http.Request.
|
|
func NewRoundTripCheckRequest(checkRequest func(*http.Request), theResponse *http.Response, theError error) http.RoundTripper {
|
|
return &roundTripCheckRequest{
|
|
checkRequest: checkRequest,
|
|
roundTrip: roundTrip{
|
|
theResponse: theResponse,
|
|
theError: theError,
|
|
},
|
|
}
|
|
}
|