Apply suggestions from code review

Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
This commit is contained in:
Raphael Bernhart 2022-01-22 13:59:36 +01:00 committed by GitHub
parent 0313acd4c5
commit dd3992063e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -173,6 +173,7 @@ export default {
getBeatTitle(beat) { getBeatTitle(beat) {
return `${this.$root.datetime(beat.time)}` + ((beat.msg) ? ` - ${beat.msg}` : ``); return `${this.$root.datetime(beat.time)}` + ((beat.msg) ? ` - ${beat.msg}` : ``);
}, },
// Toggling the activeSibling class on hover over the current hover item // Toggling the activeSibling class on hover over the current hover item
toggleActivateSibling(e) { toggleActivateSibling(e) {
// Variable definition // Variable definition
@ -189,6 +190,7 @@ export default {
if (previous.children && !previous.classList.contains("empty")) { if (previous.children && !previous.classList.contains("empty")) {
previous.classList.toggle("active-sibling"); previous.classList.toggle("active-sibling");
} }
// Check if Next Sibling is heartbar element and doesn't have the empty class // Check if Next Sibling is heartbar element and doesn't have the empty class
if (next.children && !next.classList.contains("empty")) { if (next.children && !next.classList.contains("empty")) {
next.classList.toggle("active-sibling"); next.classList.toggle("active-sibling");
@ -238,6 +240,7 @@ export default {
opacity: 0.8; opacity: 0.8;
transform: scale(var(--hover-scale)); transform: scale(var(--hover-scale));
} }
&.active-sibling { &.active-sibling {
transform: scale(1.3); transform: scale(1.3);
transition: all ease 0.15s; transition: all ease 0.15s;