Commit graph

17 commits

Author SHA1 Message Date
Frank Elsinga 0e3b3a9ab8
Made sure that more of the async usages are awaited (#4574) 2024-03-15 15:02:55 +01:00
Frank Elsinga a9a1cf1353
Chore: General notification reformatting (#3182)
- I unified where in file the name of `NotificationProvider.name` is placed
- I made sure that all the providers adhere to the signature of `NotificationProvider.send()`
- I made sure that all the providers use `okMsg` if returning success messages directly from the function.
  Here a discussion should be had:
  Should this be refactored into a constant of `NotificationProvider`? I could imagine that `NotificationProvider.SENDING_SUCCESSFULL`  could be a suitable alternative.
- I made sure all providers have the URL they `POST`/`GET` to be extraced into a variable.
  => refactored this way due to Nelsons suggestion
2024-03-14 14:21:15 +01:00
Chongyi Zheng 499429858c
Use API v2 for Bark notification (#2759)
* Use API v2 for Bark notification

* API v2 endpoint should end with path `/push`

* Support both v1 and v2

* Flip the bool

* Allow selecting api version

* Apply review suggestion

Co-authored-by: Nelson Chan <[email protected]>

* Add translated string to `en.json`

* Apply review suggestion

Co-authored-by: Nelson Chan <[email protected]>

---------

Co-authored-by: Nelson Chan <[email protected]>
2023-09-21 21:08:04 +08:00
Matthew Nickson 8a92054c2b
Added JSDoc to ESLint (#3529)
* Added JSDoc to eslint rules

Signed-off-by: Matthew Nickson <[email protected]>

* Fixed JSDoc eslint errors

Signed-off-by: Matthew Nickson <[email protected]>

* Update the check-linters workflow to Node.js 20

---------

Signed-off-by: Matthew Nickson <[email protected]>
Co-authored-by: Louis Lam <[email protected]>
2023-08-11 15:46:41 +08:00
Super Manito 38c45a3fe3
Fix previously PR bug about Bark Notification (#2084)
Co-authored-by: zuosc <[email protected]>
2022-09-16 14:21:22 +08:00
Super Manito 54b9698a05 Update 2022-06-13 21:44:10 +08:00
Super Manito 1c4ddaeddf Update 2022-06-13 18:17:47 +08:00
Super Manito 55a6e5af42
Update server/notification-providers/bark.js
Co-authored-by: Adam Stachowicz <[email protected]>
2022-06-13 17:06:12 +08:00
Super Manito 252709ff49
Update server/notification-providers/bark.js
Co-authored-by: Adam Stachowicz <[email protected]>
2022-06-13 17:06:05 +08:00
Super Manito 404923b7c8 bugfix 2022-06-12 22:49:04 +08:00
Super Manito a41023ca2a Update 2022-06-12 22:41:24 +08:00
Super Manito 817c941489 Add Bark Notification Parameters 2022-06-12 22:30:42 +08:00
Matthew Nickson 6d22ebedca
Merge branch 'master' into add-JSDoc-comments 2022-04-21 13:01:22 +01:00
Louis Lam 47c72192e1 [eslint] Enable yoda and eqeqeq 2022-04-17 15:43:03 +08:00
Matthew Nickson 5a209c74e1
Add JSDoc to server/notification-providers/*
Signed-off-by: Matthew Nickson <[email protected]>
2022-04-16 20:24:53 +01:00
Louis Lam 649f3106e1 Enforce semicolon, fix format globally 2022-04-14 01:20:54 +08:00
Lakr Aream ce852dfa02 Support for Bark (APN) notifications
Update bark.js
2021-10-24 00:31:43 +08:00