mudhorn/zxing
1
0
Fork 0
mirror of https://github.com/zxing/zxing.git synced 2024-11-10 04:54:04 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Convert asserts to exceptions where the conditions could be false in a correct, bug-free program -- makes sure caller errors are caught and reported meaningfully

Browse source 
git-svn-id: https://zxing.googlecode.com/svn/trunk@840 59b500cc-1b3d-0410-9834-0bbf25fbcc57
This commit is contained in:
srowen 2009-02-05 13:06:19 +00:00
parent 07db37e997
commit 1c539c66a4
3 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
android/src/com/google/zxing/client/android/YUVMonochromeBitmapSource.java
View file

@ -40,11 +40,12 @@ final class YUVMonochromeBitmapSource extends BaseMonochromeBitmapSource {
* @param crop The rectangle within the yuvData to expose to MonochromeBitmapSource users
*/
YUVMonochromeBitmapSource(byte[] yuvData, int dataWidth, int dataHeight, Rect crop) {
if (crop.width() > dataWidth || crop.height() > dataHeight) {
throw new IllegalArgumentException();
}
mYUVData = yuvData;
mDataWidth = dataWidth;
mCrop = crop;
assert (crop.width() <= dataWidth);
assert (crop.height() <= dataHeight);
}
@Override

4
androidtest/src/com/google/zxing/client/androidtest/BenchmarkItem.java
View file

@ -27,8 +27,10 @@ public final class BenchmarkItem {
private BarcodeFormat mFormat;
public BenchmarkItem(String path, int runs) {
if (runs <= 0) {
throw new IllegalArgumentException();
}
mPath = path;
assert(runs > 0);
mTimes = new int[runs];
mPosition = 0;
mDecoded = false;

5
androidtest/src/com/google/zxing/client/androidtest/SaveThread.java
View file

@ -67,8 +67,9 @@ final class SaveThread extends Thread {
private void save(byte[] data, int width, int height) {
int framingWidth = mFramingRect.width();
int framingHeight = mFramingRect.height();
assert (framingWidth <= width);
assert (framingHeight <= height);
if (framingWidth > width || framingHeight > height) {
throw new IllegalArgumentException();
}
int leftOffset = mFramingRect.left;
int topOffset = mFramingRect.top;