mudhorn/zxing
1
0
Fork 0
mirror of https://github.com/zxing/zxing.git synced 2024-11-09 20:44:03 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Directory Bug (#1046)

Browse source 
The correct pattern to make a directory is: `if (!dir.mkdirs() && !dir.isDirectory()) { error }` mkdirs checks for exists so the exists check is redundant.
This commit is contained in:
Felix Bergmann 2018-07-30 00:07:39 +02:00 committed by Sean Owen
parent 96d974f44d
commit 45d89bce80
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
android/src/com/google/zxing/client/android/history/HistoryManager.java
View file

@ -298,7 +298,7 @@ public final class HistoryManager {
static Uri saveHistory(String history) {
File bsRoot = new File(Environment.getExternalStorageDirectory(), "BarcodeScanner");
File historyRoot = new File(bsRoot, "History");
if (!historyRoot.exists() && !historyRoot.mkdirs()) {
if (!historyRoot.mkdirs() && !historyRoot.isDirectory()) {
Log.w(TAG, "Couldn't make dir " + historyRoot);
return null;
}