mudhorn/zxing
1
0
Fork 0
mirror of https://github.com/zxing/zxing.git synced 2025-03-05 20:48:51 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tiny optimizations to boolean logic to avoid extra byte code and branches in semi-critical sections

Browse source 
git-svn-id: https://zxing.googlecode.com/svn/trunk@867 59b500cc-1b3d-0410-9834-0bbf25fbcc57
This commit is contained in:
srowen 2009-02-23 13:52:45 +00:00
parent b2f3eb6b7b
commit b24fbdd7b0
7 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/com/google/zxing/datamatrix/detector/Detector.java
View file

@ -231,7 +231,7 @@ public final class Detector {
boolean inBlack = image.isBlack(steep ? fromY : fromX, steep ? fromX : fromY); boolean inBlack = image.isBlack(steep ? fromY : fromX, steep ? fromX : fromY);
for (int x = fromX, y = fromY; x != toX; x += xstep) { for (int x = fromX, y = fromY; x != toX; x += xstep) {
boolean isBlack = image.isBlack(steep ? y : x, steep ? x : y); boolean isBlack = image.isBlack(steep ? y : x, steep ? x : y);
if (isBlack == !inBlack) { if (isBlack != inBlack) {
transitions++; transitions++;
inBlack = isBlack; inBlack = isBlack;
} }

4
core/src/com/google/zxing/oned/AbstractOneDReader.java
View file

@ -169,7 +169,7 @@ public abstract class AbstractOneDReader implements OneDReader {
int i = start; int i = start;
while (i < end) { while (i < end) {
boolean pixel = row.get(i); boolean pixel = row.get(i);
if ((!pixel && isWhite) || (pixel && !isWhite)) { if (pixel ^ isWhite) { // that is, exactly one is true
counters[counterPosition]++; counters[counterPosition]++;
} else { } else {
counterPosition++; counterPosition++;
@ -177,7 +177,7 @@ public abstract class AbstractOneDReader implements OneDReader {
break; break;
} else { } else {
counters[counterPosition] = 1; counters[counterPosition] = 1;
isWhite = !isWhite; isWhite ^= true; // isWhite = !isWhite; Is this too clever? shorter byte code, no conditional
} }
} }
i++; i++;

4
core/src/com/google/zxing/oned/AbstractUPCEANReader.java
View file

@ -228,7 +228,7 @@ public abstract class AbstractUPCEANReader extends AbstractOneDReader implements
int patternStart = rowOffset; int patternStart = rowOffset;
for (int x = rowOffset; x < width; x++) { for (int x = rowOffset; x < width; x++) {
boolean pixel = row.get(x); boolean pixel = row.get(x);
if ((!pixel && isWhite) || (pixel && !isWhite)) { if (pixel ^ isWhite) {
counters[counterPosition]++; counters[counterPosition]++;
} else { } else {
if (counterPosition == patternLength - 1) { if (counterPosition == patternLength - 1) {
@ -246,7 +246,7 @@ public abstract class AbstractUPCEANReader extends AbstractOneDReader implements
counterPosition++; counterPosition++;
} }
counters[counterPosition] = 1; counters[counterPosition] = 1;
isWhite = !isWhite; isWhite ^= true; // isWhite = !isWhite;
} }
} }
throw ReaderException.getInstance(); throw ReaderException.getInstance();

4
core/src/com/google/zxing/oned/Code128Reader.java
View file

@ -180,7 +180,7 @@ public final class Code128Reader extends AbstractOneDReader {
for (int i = rowOffset; i < width; i++) { for (int i = rowOffset; i < width; i++) {
boolean pixel = row.get(i); boolean pixel = row.get(i);
if ((!pixel && isWhite) || (pixel && !isWhite)) { if (pixel ^ isWhite) {
counters[counterPosition]++; counters[counterPosition]++;
} else { } else {
if (counterPosition == patternLength - 1) { if (counterPosition == patternLength - 1) {
@ -210,7 +210,7 @@ public final class Code128Reader extends AbstractOneDReader {
counterPosition++; counterPosition++;
} }
counters[counterPosition] = 1; counters[counterPosition] = 1;
isWhite = !isWhite; isWhite ^= true; // isWhite = !isWhite;
} }
} }
throw ReaderException.getInstance(); throw ReaderException.getInstance();

4
core/src/com/google/zxing/oned/Code39Reader.java
View file

@ -184,7 +184,7 @@ public final class Code39Reader extends AbstractOneDReader {
for (int i = rowOffset; i < width; i++) { for (int i = rowOffset; i < width; i++) {
boolean pixel = row.get(i); boolean pixel = row.get(i);
if ((!pixel && isWhite) || (pixel && !isWhite)) { if (pixel ^ isWhite) {
counters[counterPosition]++; counters[counterPosition]++;
} else { } else {
if (counterPosition == patternLength - 1) { if (counterPosition == patternLength - 1) {
@ -209,7 +209,7 @@ public final class Code39Reader extends AbstractOneDReader {
counterPosition++; counterPosition++;
} }
counters[counterPosition] = 1; counters[counterPosition] = 1;
isWhite = !isWhite; isWhite ^= true; // isWhite = !isWhite;
} }
} }
throw ReaderException.getInstance(); throw ReaderException.getInstance();

4
core/src/com/google/zxing/oned/ITFReader.java
View file

@ -296,7 +296,7 @@ public final class ITFReader extends AbstractOneDReader {
int patternStart = rowOffset; int patternStart = rowOffset;
for (int x = rowOffset; x < width; x++) { for (int x = rowOffset; x < width; x++) {
boolean pixel = row.get(x); boolean pixel = row.get(x);
if ((!pixel && isWhite) || (pixel && !isWhite)) { if (pixel ^ isWhite) {
counters[counterPosition]++; counters[counterPosition]++;
} else { } else {
if (counterPosition == patternLength - 1) { if (counterPosition == patternLength - 1) {
@ -314,7 +314,7 @@ public final class ITFReader extends AbstractOneDReader {
counterPosition++; counterPosition++;
} }
counters[counterPosition] = 1; counters[counterPosition] = 1;
isWhite = !isWhite; isWhite ^= true; // isWhite = !isWhite;
} }
} }
throw ReaderException.getInstance(); throw ReaderException.getInstance();

2
core/src/com/google/zxing/qrcode/decoder/BitMatrixParser.java
View file

@ -198,7 +198,7 @@ final class BitMatrixParser {
} }
} }
} }
readingUp = !readingUp; // switch directions readingUp ^= true; // readingUp = !readingUp; // switch directions
} }
if (resultOffset != version.getTotalCodewords()) { if (resultOffset != version.getTotalCodewords()) {
throw ReaderException.getInstance(); throw ReaderException.getInstance();