mudhorn/zxing
1
0
Fork 0
mirror of https://github.com/zxing/zxing.git synced 2025-01-14 12:48:03 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Issue 131: reuse Alert objects

Browse source 
git-svn-id: https://zxing.googlecode.com/svn/trunk@829 59b500cc-1b3d-0410-9834-0bbf25fbcc57
This commit is contained in:
srowen 2009-01-20 23:41:10 +00:00
parent 6a5d483aa5
commit e7f4699037
1 changed files with 24 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
View file

@ -54,6 +54,8 @@ public final class ZXingMIDlet extends MIDlet {
private Canvas canvas; private Canvas canvas;
private Player player; private Player player;
private VideoControl videoControl; private VideoControl videoControl;
private Alert confirmation;
private Alert alert;
Displayable getCanvas() { Displayable getCanvas() {
return canvas; return canvas;
@ -94,6 +96,17 @@ public final class ZXingMIDlet extends MIDlet {
} catch (MediaException me) { } catch (MediaException me) {
throw new MIDletStateChangeException(me.toString()); throw new MIDletStateChangeException(me.toString());
} }
// Set up one confirmation and alert object to re-use
confirmation = new Alert(null);
confirmation.setType(AlertType.CONFIRMATION);
confirmation.setTimeout(ALERT_TIMEOUT_MS);
Command yes = new Command("Yes", Command.OK, 1);
confirmation.addCommand(yes);
Command no = new Command("No", Command.CANCEL, 1);
confirmation.addCommand(no);
alert = new Alert(null);
alert.setTimeout(ALERT_TIMEOUT_MS);
} }
private static Player createPlayer() throws IOException, MediaException { private static Player createPlayer() throws IOException, MediaException {
@ -149,12 +162,8 @@ public final class ZXingMIDlet extends MIDlet {
// Convenience methods to show dialogs // Convenience methods to show dialogs
private void showOpenURL(String title, String display, final String uri) { private void showOpenURL(String title, String display, final String uri) {
Alert alert = new Alert(title, display, null, AlertType.CONFIRMATION); confirmation.setTitle(title);
alert.setTimeout(ALERT_TIMEOUT_MS); confirmation.setString(display);
Command yes = new Command("Yes", Command.OK, 1);
alert.addCommand(yes);
Command no = new Command("No", Command.CANCEL, 1);
alert.addCommand(no);
CommandListener listener = new CommandListener() { CommandListener listener = new CommandListener() {
public void commandAction(Command command, Displayable displayable) { public void commandAction(Command command, Displayable displayable) {
if (command.getCommandType() == Command.OK) { if (command.getCommandType() == Command.OK) {
@ -171,13 +180,14 @@ public final class ZXingMIDlet extends MIDlet {
} }
} }
}; };
alert.setCommandListener(listener); confirmation.setCommandListener(listener);
showAlert(alert); showAlert(confirmation);
} }
private void showAlert(String title, String text) { private void showAlert(String title, String text) {
Alert alert = new Alert(title, text, null, AlertType.INFO); alert.setTitle(title);
alert.setTimeout(ALERT_TIMEOUT_MS); alert.setString(text);
alert.setType(AlertType.INFO);
showAlert(alert); showAlert(alert);
} }
@ -191,7 +201,10 @@ public final class ZXingMIDlet extends MIDlet {
} }
void showError(String message) { void showError(String message) {
showAlert(new Alert("Error", message, null, AlertType.ERROR)); alert.setTitle("Error");
alert.setString(message);
alert.setType(AlertType.ERROR);
showAlert(alert);
} }
private void showAlert(Alert alert) { private void showAlert(Alert alert) {