Commit graph

233 commits

Author SHA1 Message Date
dswitkin 936343b221 Added some very difficult reflective UPC-A images - we get 8/21. We would probably have to do something very special to handle soda cans with those silver on silver barcodes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@507 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 20:50:03 +00:00
dswitkin 251e4623e6 All the positive test cases now track normal and try harder success rates separately. This lets us monitor regressions separately, and gives an idea of how much better try harder actually is.
git-svn-id: https://zxing.googlecode.com/svn/trunk@506 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 20:15:53 +00:00
dswitkin f05d22687e Added 52 real world UPC-A greyscale test images. We get 26/52, but more with try harder. I think I'm going to break try harder results into their own test so we can track these separately.
git-svn-id: https://zxing.googlecode.com/svn/trunk@505 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 19:00:33 +00:00
srowen 42940c4580 Add iCal support, plus many small changes suggested by code inspection -- mostly making things less visible for now
git-svn-id: https://zxing.googlecode.com/svn/trunk@502 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-08 04:11:24 +00:00
srowen 90297efc57 Added mms:, mmsto: support and tests, plus basic tests for vCard format
git-svn-id: https://zxing.googlecode.com/svn/trunk@488 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 18:14:19 +00:00
srowen aa65741586 More refactoring of parsed results / result parsers; added basic vCard support
git-svn-id: https://zxing.googlecode.com/svn/trunk@487 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 17:50:47 +00:00
srowen dd57042f9a And fixed the "270" issue: logic error in computing the "skip" allowed after finding two finder patterns when the QR Code was inverted.
git-svn-id: https://zxing.googlecode.com/svn/trunk@486 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 22:58:08 +00:00
srowen 011e6e9cee Big refactoring of ParsedResult: now split into ResultParser and ParsedResult classes, per Christian's suggestion. This unifies the parsed results that are produced from various input, simplifying client handling of different types.
git-svn-id: https://zxing.googlecode.com/svn/trunk@482 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 19:49:38 +00:00
dswitkin 12a57d0baf Added new test of unsupported barcodes, to make sure we don't decode them.
git-svn-id: https://zxing.googlecode.com/svn/trunk@477 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 01:26:22 +00:00
dswitkin cfa10cf26c Added blackbox test of partial barcodes which should not decode.
git-svn-id: https://zxing.googlecode.com/svn/trunk@476 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 01:10:52 +00:00
dswitkin 67656a7ee3 Reworked the false positives unit tests to track each rotation separately, and to allow new tests to be added. I also removed four images which are going to live in another test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@475 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 00:51:37 +00:00
srowen 584564a594 Added ECI for values 0-2 and also standardize character encoding names throughout the code to use the canonical values for java.lang and java.io
git-svn-id: https://zxing.googlecode.com/svn/trunk@468 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-23 17:11:53 +00:00
srowen c9ead4ce8a Added some degree of support for Character Set ECIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@467 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 22:38:35 +00:00
dswitkin d713f52437 Tuned the Code 128 parameters:
Right-side up went from 9/40 to 33/40
Upside down went from 8/40 to 34/40

and try harder now gets 39/40.

git-svn-id: https://zxing.googlecode.com/svn/trunk@462 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:57:48 +00:00
dswitkin 834bc3297a Added 40 real world Code 128 images. We decode 9/40 right-side up, and 8/40 upside down. A fix will follow shortly to get these numbers up - we overtightened the pattern matching in the first round of false positive changes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@461 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:24:02 +00:00
dswitkin 40ca2706e2 Added 17 real world Code 39 images to our unit tests. We decode all 17, upside down and right-side up.
git-svn-id: https://zxing.googlecode.com/svn/trunk@460 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:20:27 +00:00
dswitkin 12e5d9462c Fixed a bug in patternMatchVariance() which caused the max individual variance to never eliminate any patterns. As a result, the false positives unit test dropped from 15 to 4. Also did some other minor cleanup.
git-svn-id: https://zxing.googlecode.com/svn/trunk@456 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 21:38:48 +00:00
srowen e0db8f9271 Standardize and update all copyright statements to name "ZXing authors" as suggested by open-source team to correctly attribute copyright in a project with contributions from several sources.
git-svn-id: https://zxing.googlecode.com/svn/trunk@455 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 20:56:24 +00:00
dswitkin fb5fbccf7c Add 26.jpg back with the command line client
git-svn-id: https://zxing.googlecode.com/svn/trunk@453 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 20:00:13 +00:00
dswitkin d4cda3377d Delete 26.jpg again.
git-svn-id: https://zxing.googlecode.com/svn/trunk@452 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 19:59:23 +00:00
dswitkin 466130bcf0 Added rotation to unit test output for clarification.
git-svn-id: https://zxing.googlecode.com/svn/trunk@450 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 16:41:40 +00:00
dswitkin 640ccb5fd2 Trying to add image 26 back to the false positives unit test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@449 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 15:51:04 +00:00
dswitkin eea1c7fd2f Deleting image 26 which somehow arrived at the server with a length of zero bytes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@448 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 15:49:51 +00:00
srowen 15f34edb52 Simple check in Code 39 reader to determine wide bars vary in width a lot, to cut out most false positives
git-svn-id: https://zxing.googlecode.com/svn/trunk@442 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 22:52:45 +00:00
srowen 180e833b3e Improved approach to 1D decoding -- better use of integer math by scaling pattern ratios up to expected number of pixels, rather than the other way. Modified constants accordingly. Also introduced notion of maxium variance that any one bar in a pattern can have and stiill be accepted. Finally, adjusted false-positives test failure limit downward due to recent improvements.
git-svn-id: https://zxing.googlecode.com/svn/trunk@441 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 22:12:59 +00:00
srowen 2f9e5ca32b Fix pretty clear bug on Code 128 and 39 readers: reject empty barcodes as a false positive.
git-svn-id: https://zxing.googlecode.com/svn/trunk@440 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 21:56:30 +00:00
dswitkin 4d1229bd65 Created a library of images which do not contain barcodes, or contain barcodes we don't yet support. Wrote a new unit test designed to identify false positives, and set a benchmark which we can improve over time. Out of these 26 images, tested in all four rotations, we currently find 44/104 false positives. The Code 39 decoder in particular seems to be too lenient.
git-svn-id: https://zxing.googlecode.com/svn/trunk@436 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-17 18:35:16 +00:00
srowen b5b4351727 Final updates to use local test images rather than remote
git-svn-id: https://zxing.googlecode.com/svn/trunk@432 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-16 16:29:48 +00:00
srowen ab3a9bf493 More updates to use local test images rather than remote
git-svn-id: https://zxing.googlecode.com/svn/trunk@431 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-16 16:13:12 +00:00
srowen f66a048f5c First set of updates to use local test images rather than remote
git-svn-id: https://zxing.googlecode.com/svn/trunk@430 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-16 16:00:51 +00:00
srowen 70c64558cf Minor style tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@428 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-13 12:15:49 +00:00
srowen 14895cf9b3 Now use integer math in patternMatchVariance for performance, plus a few other similar style and speed tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@422 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 15:17:53 +00:00
srowen f5b58916c1 Fix bad logic black point estimator, improving threshold estimation performance (and adjust some == to .equals())
git-svn-id: https://zxing.googlecode.com/svn/trunk@417 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 19:59:38 +00:00
dswitkin f431cae59f - Added support for rotation in our blackbox test framework, and refactored the ways tests are created and run.
- Turned on 0 and 180 degree rotation for all 1D formats.
- Turned on 0, 90, 180, and 270 degree rotation for QR.
- Changed the 1D code to re-enable upside down scanning, with a dramatic improvement in barcodes found and fewer false positives.

git-svn-id: https://zxing.googlecode.com/svn/trunk@411 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 00:05:51 +00:00
srowen 635d904283 Many more little tweaks from IntelliJ inspections
git-svn-id: https://zxing.googlecode.com/svn/trunk@382 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-02 19:18:14 +00:00
dswitkin 0987663963 Added some simple sharpening for 1D decoding which allowed a couple more blackbox images to pass. There were a few cases where the format or content is now misdetected, but since the net gain was positive I decided to make those non-fatal errors. In real world use the sharpening seems to help, and I think we can do even better with a better algorithm.
git-svn-id: https://zxing.googlecode.com/svn/trunk@372 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-21 18:11:02 +00:00
dswitkin a69a87e98d Replaced the smaller, resized EAN13-2 test images with the full-size originals.
git-svn-id: https://zxing.googlecode.com/svn/trunk@370 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-19 18:38:52 +00:00
dswitkin 9eceb0593e Added a new test library of 16 blurry EAN-13 barcodes. Currently we cannot decode any of them. I'm checking these in as a baseline so we can evaluate various sharpening techniques.
git-svn-id: https://zxing.googlecode.com/svn/trunk@368 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 15:51:39 +00:00
dswitkin a2662ebb40 Changed the black box tests to require an absolute number of images to decode successfully, instead of a percentage, and set the high water mark for each test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@367 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 14:43:56 +00:00
srowen a5b385e764 Standardize array initializer syntax to use the form without "new type[]", to be consistent and make translation to C++ easier
git-svn-id: https://zxing.googlecode.com/svn/trunk@348 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-07 19:42:35 +00:00
srowen 11fc234d76 Completed basic support for NFC / NDEF formats applicable to 2D barcodes. Not yet enabled.
git-svn-id: https://zxing.googlecode.com/svn/trunk@329 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-31 20:51:24 +00:00
srowen 4473c00147 Restored a corrected Reed-Solomon optimization and fixed a small issue in black box test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@316 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 16:22:02 +00:00
srowen 7de539a67c biasTowardsWhite was, embarassingly, not accomplishing anything mathematically. It proved to not have much value so has been removed, to simplify the code.
git-svn-id: https://zxing.googlecode.com/svn/trunk@313 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 14:42:33 +00:00
srowen 3a1e3dc156 Optimized 0- and 1-error case of Reed Solomon decoding a bit
git-svn-id: https://zxing.googlecode.com/svn/trunk@309 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-24 20:02:06 +00:00
srowen 7129e6a5ee Added overdue Reed-Solomon tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@293 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 20:48:32 +00:00
srowen 379c3a8cc0 Add support for tel: URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@292 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 20:17:20 +00:00
srowen fab1e27971 Add geo: URL support (oh and removed an old moved file)
git-svn-id: https://zxing.googlecode.com/svn/trunk@284 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 14:57:56 +00:00
srowen 34cc1d2b9d Move GridSampler into common package and refactor to ready it for use with Data Matrix
git-svn-id: https://zxing.googlecode.com/svn/trunk@278 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-14 18:44:41 +00:00
srowen 40e039302d This URL seems dead, removing the test
git-svn-id: https://zxing.googlecode.com/svn/trunk@277 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-14 18:43:41 +00:00
srowen d31305c5f6 Temporarily turning off Data Matrix in MultiFormatReader until it's done
git-svn-id: https://zxing.googlecode.com/svn/trunk@271 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-12 19:19:02 +00:00
srowen ea13f8b052 Refactorings to allow raw bytes to be passed back with reader result, where applicable
git-svn-id: https://zxing.googlecode.com/svn/trunk@270 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-12 18:51:46 +00:00
srowen 727cc95858 Fixed a few more extractPureBits() gotchas that came up, and added a couple tests for UPC-E
git-svn-id: https://zxing.googlecode.com/svn/trunk@269 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-11 17:43:32 +00:00
srowen 0be4184870 Added overdue EAN-8 tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@268 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-11 15:28:23 +00:00
srowen fd1620e753 Small tweaks on this test too
git-svn-id: https://zxing.googlecode.com/svn/trunk@266 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-11 15:05:10 +00:00
briangbrown 916edd548e Added code for the Data Matrix decoder.
Added initial ASCII tests for Data Matrix.
Added test symbols for DataMatrix.
Modified MultiFormatReader to try the DataMatrixReader after 1D and QRCode.



git-svn-id: https://zxing.googlecode.com/svn/trunk@264 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-11 03:48:12 +00:00
srowen 600e93c174 Overdue unit tests for some QR code classes
git-svn-id: https://zxing.googlecode.com/svn/trunk@260 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-10 20:38:00 +00:00
srowen 7a6f72bad4 Move BitSource to common package so that it can be reused by Data Matrix decoder
git-svn-id: https://zxing.googlecode.com/svn/trunk@259 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-10 20:16:57 +00:00
srowen f7306489b6 Now supports KDDI/AU / Softbank address book format
git-svn-id: https://zxing.googlecode.com/svn/trunk@249 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-06 15:43:31 +00:00
srowen bdcf60913b Disallow BufferedImage of type TYPE_CUSTOM -- not decoding properly, and is kind of a weird case from ImageIO anyway
git-svn-id: https://zxing.googlecode.com/svn/trunk@241 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 22:45:52 +00:00
srowen 7c475c5cad New rotated 1D barcode test case
git-svn-id: https://zxing.googlecode.com/svn/trunk@237 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 20:50:41 +00:00
srowen 7c1d8184f3 Tries TRY_HARDER too in tests now, to confirm it only improves accuracy, never hurts
git-svn-id: https://zxing.googlecode.com/svn/trunk@236 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 20:21:22 +00:00
srowen 1f442884aa Added BarcodeFormat to Result, indicating what type of barcode was detected. Added TRY_HARDER hint. Improved logicalness of results when reading UPC-A code / EAN-13 code starting with 0.
git-svn-id: https://zxing.googlecode.com/svn/trunk@230 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-25 23:02:50 +00:00
srowen 848609c0c5 Added "URLTO" format support
git-svn-id: https://zxing.googlecode.com/svn/trunk@229 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-25 22:15:36 +00:00
srowen 9af91c0cf1 Removed bad test cases -- for now considering this image too blurred for the "easy" test suite
git-svn-id: https://zxing.googlecode.com/svn/trunk@224 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-22 19:17:49 +00:00
srowen 4525328e45 Little bug fix affecting QR Codes that run all the way to the left/top edge of an image
git-svn-id: https://zxing.googlecode.com/svn/trunk@215 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 21:49:26 +00:00
srowen 82bc8e437a Add some basic Code 39, Code 128 tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@214 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 21:09:55 +00:00
srowen febdcf8d15 Fixed UTF-8 detection, again, and added unit test
git-svn-id: https://zxing.googlecode.com/svn/trunk@204 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-15 16:21:55 +00:00
srowen eb2fa80eaf Biiig standardization of whitespace. 2 space indents now, no tabs.
git-svn-id: https://zxing.googlecode.com/svn/trunk@191 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 20:25:54 +00:00
srowen 3f3c2fd7e5 More minor javadoc, code tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@189 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 20:05:31 +00:00
srowen ea00e20d22 Major reorg of test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@180 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-13 23:28:52 +00:00
srowen 9f0cd86114 Small optimization to check ranges of bits set in BitArray in bulk
git-svn-id: https://zxing.googlecode.com/svn/trunk@176 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-12 17:32:15 +00:00
srowen d3a09024f8 Make images smaller for a better test
git-svn-id: https://zxing.googlecode.com/svn/trunk@173 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-08 06:40:02 +00:00
srowen dc2c7aa52e Shrunk big images -- more of a challenging test now
git-svn-id: https://zxing.googlecode.com/svn/trunk@172 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-07 17:01:13 +00:00
srowen 8f7a3346cb Major refactoring of 1D barcode code. Moved into com.google.zxing.oned package. Misc. other changes to support this refactoring
git-svn-id: https://zxing.googlecode.com/svn/trunk@159 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-04 19:14:29 +00:00
srowen 35f4a385e2 More test cases from Enrique G. S.
git-svn-id: https://zxing.googlecode.com/svn/trunk@145 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-16 22:13:00 +00:00
srowen 552630677f Overhaul unit tests to include more test cases, and begin to establish a decent framework for these black-box tests.
git-svn-id: https://zxing.googlecode.com/svn/trunk@144 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-15 20:47:47 +00:00
srowen b112a890fb Improved black point estimation -- favor a point not white so close the white peak
git-svn-id: https://zxing.googlecode.com/svn/trunk@135 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-07 16:31:26 +00:00
srowen 0daa06a5e0 Moved com.google.zxing.client.result from core-ext to core, rewrote it for J2ME, changed javame to use it, and removed core-ext
git-svn-id: https://zxing.googlecode.com/svn/trunk@114 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-12 18:38:22 +00:00
srowen e459482771 Finally added the beginnings of a decent black-box unit test for QR code decoding
git-svn-id: https://zxing.googlecode.com/svn/trunk@87 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-30 22:24:02 +00:00
srowen 96ea7e296c Fixed the rest of my typos and added basic unit test
git-svn-id: https://zxing.googlecode.com/svn/trunk@23 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-09 22:19:46 +00:00
srowen e73dd9a068 Fix compile problem for JDK 1.4
git-svn-id: https://zxing.googlecode.com/svn/trunk@16 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 18:42:40 +00:00
srowen 9b296c7e1e Added more test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@15 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 06:52:45 +00:00
srowen 7726e8fcb2 git-svn-id: https://zxing.googlecode.com/svn/trunk@6 59b500cc-1b3d-0410-9834-0bbf25fbcc57 2007-10-23 19:12:27 +00:00