Commit graph

168 commits

Author SHA1 Message Date
srowen 4cecc3578d Oops, fix an error introduced in recent change
git-svn-id: https://zxing.googlecode.com/svn/trunk@504 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 17:25:44 +00:00
srowen 6d124e1be5 Minor style tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@503 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 17:24:02 +00:00
srowen 42940c4580 Add iCal support, plus many small changes suggested by code inspection -- mostly making things less visible for now
git-svn-id: https://zxing.googlecode.com/svn/trunk@502 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-08 04:11:24 +00:00
srowen 3feb56ece3 Rename some methods so that they're not technically overloading one another -- maybe slightly better style-wise in Java but reduces complication in port to C++
git-svn-id: https://zxing.googlecode.com/svn/trunk@501 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-07 18:25:19 +00:00
srowen 2a9feb1f49 Added another phone type field to BIZCARD implementation
git-svn-id: https://zxing.googlecode.com/svn/trunk@499 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-03 20:36:06 +00:00
dswitkin 0ddf4bcf96 Don't add a newline at the front of a ParsedResult.
git-svn-id: https://zxing.googlecode.com/svn/trunk@498 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-03 16:35:00 +00:00
srowen 64369b3878 Add BIZCARD support and a little refactoring
git-svn-id: https://zxing.googlecode.com/svn/trunk@494 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-01 19:02:03 +00:00
srowen d392d57c67 Now we can support BDAY in DoCoMo MECARD format
git-svn-id: https://zxing.googlecode.com/svn/trunk@493 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 19:38:24 +00:00
srowen 0e311f40c9 Standardize getDisplayResult() implementation in parsed results, and fix up web site download page to show one J2ME download
git-svn-id: https://zxing.googlecode.com/svn/trunk@490 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 18:55:00 +00:00
srowen 1eab5aba49 Add minimal support for FNC1 mode in QR Code
git-svn-id: https://zxing.googlecode.com/svn/trunk@489 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 18:47:31 +00:00
srowen 90297efc57 Added mms:, mmsto: support and tests, plus basic tests for vCard format
git-svn-id: https://zxing.googlecode.com/svn/trunk@488 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 18:14:19 +00:00
srowen aa65741586 More refactoring of parsed results / result parsers; added basic vCard support
git-svn-id: https://zxing.googlecode.com/svn/trunk@487 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 17:50:47 +00:00
srowen dd57042f9a And fixed the "270" issue: logic error in computing the "skip" allowed after finding two finder patterns when the QR Code was inverted.
git-svn-id: https://zxing.googlecode.com/svn/trunk@486 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 22:58:08 +00:00
srowen 621a9f25e9 Switch to integer math in a critical QR Code detector method for speed and tweak a few things before I start investigating this method and the infamous "270 issue"
git-svn-id: https://zxing.googlecode.com/svn/trunk@485 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 22:14:53 +00:00
srowen 011e6e9cee Big refactoring of ParsedResult: now split into ResultParser and ParsedResult classes, per Christian's suggestion. This unifies the parsed results that are produced from various input, simplifying client handling of different types.
git-svn-id: https://zxing.googlecode.com/svn/trunk@482 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 19:49:38 +00:00
srowen 584564a594 Added ECI for values 0-2 and also standardize character encoding names throughout the code to use the canonical values for java.lang and java.io
git-svn-id: https://zxing.googlecode.com/svn/trunk@468 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-23 17:11:53 +00:00
srowen c9ead4ce8a Added some degree of support for Character Set ECIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@467 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 22:38:35 +00:00
dswitkin d713f52437 Tuned the Code 128 parameters:
Right-side up went from 9/40 to 33/40
Upside down went from 8/40 to 34/40

and try harder now gets 39/40.

git-svn-id: https://zxing.googlecode.com/svn/trunk@462 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:57:48 +00:00
dswitkin 12e5d9462c Fixed a bug in patternMatchVariance() which caused the max individual variance to never eliminate any patterns. As a result, the false positives unit test dropped from 15 to 4. Also did some other minor cleanup.
git-svn-id: https://zxing.googlecode.com/svn/trunk@456 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 21:38:48 +00:00
srowen e0db8f9271 Standardize and update all copyright statements to name "ZXing authors" as suggested by open-source team to correctly attribute copyright in a project with contributions from several sources.
git-svn-id: https://zxing.googlecode.com/svn/trunk@455 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 20:56:24 +00:00
srowen 24e31c6a9a Correct a few more things about ECI parsing
git-svn-id: https://zxing.googlecode.com/svn/trunk@451 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 16:49:04 +00:00
dswitkin 905d44424b Fixed the build.
git-svn-id: https://zxing.googlecode.com/svn/trunk@447 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 15:46:39 +00:00
srowen 9ee69fee5a Added, at least, parsing of ECI mode in QR Code
git-svn-id: https://zxing.googlecode.com/svn/trunk@443 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 01:37:49 +00:00
srowen 15f34edb52 Simple check in Code 39 reader to determine wide bars vary in width a lot, to cut out most false positives
git-svn-id: https://zxing.googlecode.com/svn/trunk@442 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 22:52:45 +00:00
srowen 180e833b3e Improved approach to 1D decoding -- better use of integer math by scaling pattern ratios up to expected number of pixels, rather than the other way. Modified constants accordingly. Also introduced notion of maxium variance that any one bar in a pattern can have and stiill be accepted. Finally, adjusted false-positives test failure limit downward due to recent improvements.
git-svn-id: https://zxing.googlecode.com/svn/trunk@441 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 22:12:59 +00:00
srowen 2f9e5ca32b Fix pretty clear bug on Code 128 and 39 readers: reject empty barcodes as a false positive.
git-svn-id: https://zxing.googlecode.com/svn/trunk@440 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 21:56:30 +00:00
srowen 4cc490db56 Remove compile-time reference to DataMatrixReader
git-svn-id: https://zxing.googlecode.com/svn/trunk@426 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 16:30:01 +00:00
srowen 56c4b6a94d Added build-optimized target to produce optimized core.jar; tests now test optimized version; also removed the dependency from core to MIDP 2.0 as it was just depending on silly IllegalStateException
git-svn-id: https://zxing.googlecode.com/svn/trunk@423 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 15:55:42 +00:00
srowen 14895cf9b3 Now use integer math in patternMatchVariance for performance, plus a few other similar style and speed tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@422 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 15:17:53 +00:00
srowen 038add9da1 Oops one more style change
git-svn-id: https://zxing.googlecode.com/svn/trunk@421 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 12:52:18 +00:00
srowen 31b8b3d226 Small tweaks on top of Daniel's excellent refactoring
git-svn-id: https://zxing.googlecode.com/svn/trunk@420 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-12 12:51:26 +00:00
dswitkin 7b2cafe970 Missed one place that needs to cache the luminance data.
git-svn-id: https://zxing.googlecode.com/svn/trunk@419 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 23:58:04 +00:00
dswitkin 9adb83bbd3 Refactored the MonochromeBitmapSource hierarchy to share a great deal of code and shrink the derived classes considerably.
git-svn-id: https://zxing.googlecode.com/svn/trunk@418 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 23:52:35 +00:00
srowen f5b58916c1 Fix bad logic black point estimator, improving threshold estimation performance (and adjust some == to .equals())
git-svn-id: https://zxing.googlecode.com/svn/trunk@417 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 19:59:38 +00:00
srowen 88afca0842 Unify UPC-A reader into EAN-13 reader since EAN-13 is a superset and we can take advantage of the commonality to improve performance.
git-svn-id: https://zxing.googlecode.com/svn/trunk@416 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 19:30:57 +00:00
dswitkin f431cae59f - Added support for rotation in our blackbox test framework, and refactored the ways tests are created and run.
- Turned on 0 and 180 degree rotation for all 1D formats.
- Turned on 0, 90, 180, and 270 degree rotation for QR.
- Changed the 1D code to re-enable upside down scanning, with a dramatic improvement in barcodes found and fewer false positives.

git-svn-id: https://zxing.googlecode.com/svn/trunk@411 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 00:05:51 +00:00
srowen 2cc9d7f630 Tiny bug fix, need to deal with no query params case correctly
git-svn-id: https://zxing.googlecode.com/svn/trunk@410 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-10 19:44:47 +00:00
srowen a73fc5919a Added SMSTO support, added subject/body param support in mailto:, improved handling of mailto: and tel: URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@402 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-23 22:40:13 +00:00
srowen c2c8b2fcfb Added handy toString() methods
git-svn-id: https://zxing.googlecode.com/svn/trunk@401 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-23 22:20:10 +00:00
srowen 8d31073968 Detector is now a little more skeptical once it has found 3 confirmed finder patterns -- one may be a false positive, so it also checks to see if the estimated module sizes are "pretty similar". If not, keeps looking.
git-svn-id: https://zxing.googlecode.com/svn/trunk@394 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-08 15:12:44 +00:00
srowen 40f2cf1a80 Fix some minor javadoc issues
git-svn-id: https://zxing.googlecode.com/svn/trunk@388 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-05 17:56:47 +00:00
srowen 08c7c6fadb Checking in somewhat ugly 'fix' for ArrayIndexOutOfBoundsException in rare cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@385 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-05 17:31:31 +00:00
srowen 635d904283 Many more little tweaks from IntelliJ inspections
git-svn-id: https://zxing.googlecode.com/svn/trunk@382 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-02 19:18:14 +00:00
srowen 188c7fbecb Added preliminary support for MobileTag formats; not enabled yet.
Added "sms:" URI support.

git-svn-id: https://zxing.googlecode.com/svn/trunk@380 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-02 18:39:03 +00:00
dswitkin a816d5d9b1 Changed the parsing logic to refer to EAN-8 and EAN-13 as UPCs as well, so that the clients can recognize them as product barcodes and offer to do a product search.
git-svn-id: https://zxing.googlecode.com/svn/trunk@366 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 14:30:02 +00:00
srowen 989dc395f0 Added workaround for NoSuchMethodError on some Nokia JVMs with a superfluous abstract method (thanks Marnix)
git-svn-id: https://zxing.googlecode.com/svn/trunk@364 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-16 00:38:54 +00:00
dswitkin ae54d7a937 Changed how many rows we scan while detecting QR finder patterns. The mobile case dynamically calculates this based on the height of the image, and ranges from a small speedup to a big difference for large inputs. Also changed the try harder case to scan every 3rd line for a 3x speedup. The unit tests have the same success rate as before: 16/20 on qr1, 10/10 on qr2.
git-svn-id: https://zxing.googlecode.com/svn/trunk@354 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-10 20:26:42 +00:00
srowen 1c9b906442 Workaround for codes that fail to include (required) final TERMINATOR mode indicator
git-svn-id: https://zxing.googlecode.com/svn/trunk@351 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-07 22:05:40 +00:00
srowen a5b385e764 Standardize array initializer syntax to use the form without "new type[]", to be consistent and make translation to C++ easier
git-svn-id: https://zxing.googlecode.com/svn/trunk@348 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-07 19:42:35 +00:00
srowen 9c1b4a1393 Make two methods public for easier reuse by third-party implementaitons
git-svn-id: https://zxing.googlecode.com/svn/trunk@345 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-04 16:34:42 +00:00