Commit graph

829 commits

Author SHA1 Message Date
srowen 2526ea8713 Reformat, and implement some performance optimization
git-svn-id: https://zxing.googlecode.com/svn/trunk@1578 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-07 23:53:33 +00:00
dav.olivier@gmail.com 674a5c6f91 Minor deletion of code that shouldn't have been committed
git-svn-id: https://zxing.googlecode.com/svn/trunk@1576 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-05 11:28:12 +00:00
dav.olivier@gmail.com dca6c9a353 corrected possibilities of crashing while detecting a datamatrix
git-svn-id: https://zxing.googlecode.com/svn/trunk@1575 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-04 18:07:09 +00:00
dav.olivier@gmail.com a573e789d2 Improved datamatrix reader with new algorithm
git-svn-id: https://zxing.googlecode.com/svn/trunk@1574 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-03 20:49:22 +00:00
srowen 47d2f3c798 David Olivier's Data Matrix improvements
git-svn-id: https://zxing.googlecode.com/svn/trunk@1573 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-03 07:50:47 +00:00
srowen 14a03f40b1 Issue 537, don't return UPC-A for EAN-13 starting with 0 when UPC-A isn't allowed
git-svn-id: https://zxing.googlecode.com/svn/trunk@1572 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-01 10:26:37 +00:00
smparkes@smparkes.net d98d2af1ab Issue 524
git-svn-id: https://zxing.googlecode.com/svn/trunk@1570 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-31 03:18:56 +00:00
dswitkin@google.com b14a77502d One more change to accommodate differences in jpeg libraries. Some machines will report this test as too lax by one image.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1568 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:58:03 +00:00
dswitkin@google.com 1ba5eceeb2 Updated the negative blackbox test values.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1567 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:55:17 +00:00
dswitkin@google.com 226bf1a1a6 Added rounding code to getRow() as well and updated the tests accordingly.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1564 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:06:44 +00:00
dswitkin@google.com 7db3546ea6 Created new false positives blackbox test. We definitely have a problem with EAN_8 firing too often.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1560 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-25 18:23:00 +00:00
smparkes@smparkes.net 4836a3e28c Issue 494 round luminance values rather than truncate
git-svn-id: https://zxing.googlecode.com/svn/trunk@1558 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-25 15:54:19 +00:00
dswitkin@google.com a080a85cdd Created new UPC-A blackbox test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1554 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-23 15:47:13 +00:00
smparkes@smparkes.net dd1336d0cf Tweak svn/git ignores
Add OS X libzxing.a project
Include a copy of scons-local for cpp


git-svn-id: https://zxing.googlecode.com/svn/trunk@1549 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-20 00:41:26 +00:00
smparkes@smparkes.net 6e3b219023 cleaned up versions of new tests; hopefully no EOL issues
git-svn-id: https://zxing.googlecode.com/svn/trunk@1542 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-17 00:10:33 +00:00
smparkes@smparkes.net 6220f46c94 remove CRLF files before readding them (in an attempt to not confuse SVN with EOL stuff)
git-svn-id: https://zxing.googlecode.com/svn/trunk@1541 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-17 00:09:09 +00:00
srowen 346d163125 Issue 520
git-svn-id: https://zxing.googlecode.com/svn/trunk@1540 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-16 21:55:33 +00:00
smparkes@smparkes.net b2cf605bc9 a set of synthetic version 40 tests at each ECC level
git-svn-id: https://zxing.googlecode.com/svn/trunk@1539 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-16 21:02:27 +00:00
srowen 5d34f3a55d Issue 519
git-svn-id: https://zxing.googlecode.com/svn/trunk@1537 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-16 20:19:09 +00:00
srowen aee6be71f3 Issue 492
git-svn-id: https://zxing.googlecode.com/svn/trunk@1533 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-14 19:11:49 +00:00
srowen d096810e67 Remove another -Xint, and use -Djava.awt.headless=true to avoid Apple JDK annoyance
git-svn-id: https://zxing.googlecode.com/svn/trunk@1530 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-13 17:20:42 +00:00
srowen f2ac4e651b Tiny style bits
git-svn-id: https://zxing.googlecode.com/svn/trunk@1528 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-13 17:17:47 +00:00
srowen 073a3033fc Workaround for Hotspot bug that lets tests run without -Xint, from Steven Parkes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1526 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-13 03:30:58 +00:00
srowen 0a6cac9820 Issue 508
git-svn-id: https://zxing.googlecode.com/svn/trunk@1523 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-12 20:24:38 +00:00
srowen 6c9812e9bb Issue 511
git-svn-id: https://zxing.googlecode.com/svn/trunk@1522 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-12 20:18:08 +00:00
srowen 09b0039530 Add result points for UPC EAN metadata extension
git-svn-id: https://zxing.googlecode.com/svn/trunk@1519 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-11 13:59:48 +00:00
srowen 14712eff37 Issue 512
git-svn-id: https://zxing.googlecode.com/svn/trunk@1517 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-11 13:42:39 +00:00
srowen 0a5e8e9298 Preserve query in geo URI
git-svn-id: https://zxing.googlecode.com/svn/trunk@1514 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-07 13:21:35 +00:00
dswitkin@google.com 2cb4f5f82b Issue 495: Renamed DATAMATRIX to DATA_MATRIX for consistency.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1508 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-05 15:22:30 +00:00
srowen 6b5616e7dd Issue 469 -- tweak to special case of all-black 8x8 region. Parse it as black. Other near-uniform regions remain parsed as all white.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1500 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-07-31 15:07:16 +00:00
srowen 273220b3f8 Fix corner case - pure barcode, 1 pixel module
git-svn-id: https://zxing.googlecode.com/svn/trunk@1483 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-07-14 20:49:13 +00:00
srowen b3993e7d51 Remove use of methods not in J2ME
git-svn-id: https://zxing.googlecode.com/svn/trunk@1452 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-22 06:23:20 +00:00
srowen 2d7b4138ab Display possible country origin info on product scan
git-svn-id: https://zxing.googlecode.com/svn/trunk@1438 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-16 21:13:47 +00:00
srowen 627cd6cab0 Avoid possible AIOOBE on bad input
git-svn-id: https://zxing.googlecode.com/svn/trunk@1437 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-16 21:12:43 +00:00
srowen 8cbe558ec3 Add support for UPC/EAN +5 extensions, plus basic tests, and display the content in Android client as metadata
git-svn-id: https://zxing.googlecode.com/svn/trunk@1436 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-16 19:49:22 +00:00
vikrama 58fefb095c Core library changes to include wifi type. One measly test included as well.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1421 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-10 03:49:18 +00:00
srowen 51970aa020 Issue 439: be more lax and don't look for END
git-svn-id: https://zxing.googlecode.com/svn/trunk@1416 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-08 05:20:00 +00:00
bas5winkel d818288177 Changed validation method in order to prevent false positives on other 1D barcodes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1407 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-01 14:39:24 +00:00
bas5winkel 97060619fe Renamed Codabar files and added text files for testing purposes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1406 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-01 14:35:38 +00:00
srowen 492492b591 Update Codabar style and disable it as its causing too many false positives
git-svn-id: https://zxing.googlecode.com/svn/trunk@1403 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-31 12:49:29 +00:00
bas5winkel@gmail.com e5a9d43849 Added support for codabar format
git-svn-id: https://zxing.googlecode.com/svn/trunk@1401 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-31 12:39:48 +00:00
bas5winkel@gmail.com 9a3da71c4c Added support for codabar format
git-svn-id: https://zxing.googlecode.com/svn/trunk@1399 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-31 12:18:49 +00:00
srowen 05e8181ef5 Add Code 93 support. Update tests to reflect new (better) number of successes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1398 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-30 14:37:08 +00:00
srowen a86b0e7cf3 Small speedup, per issue 422
git-svn-id: https://zxing.googlecode.com/svn/trunk@1395 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-28 15:39:11 +00:00
srowen 1ef423bf68 More encoding related changes for encoding Chinese chars in QR codes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1392 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-27 11:25:00 +00:00
srowen@gmail.com a189e6c00c Issue 412
git-svn-id: https://zxing.googlecode.com/svn/trunk@1376 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-20 10:50:34 +00:00
srowen cd06f524d8 Issue 411
git-svn-id: https://zxing.googlecode.com/svn/trunk@1375 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-19 18:36:59 +00:00
srowen 88788a8b7e Issue 408 comment fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@1371 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-19 07:20:28 +00:00
srowen 737e0de917 Move character encoding logic out to common, try again to improve its handling of UTF8 for Chinese market, per manufacturer request, added test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@1364 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-15 11:21:03 +00:00
srowen 74c8744e8c Big RSS Expanded changelist -- thank you authors
git-svn-id: https://zxing.googlecode.com/svn/trunk@1350 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-10 19:18:50 +00:00
srowen 87b0b9c8aa Tighten up some stuff I saw from the logs
git-svn-id: https://zxing.googlecode.com/svn/trunk@1344 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-08 20:56:31 +00:00
srowen 8763063b7b Typo fix, thanks Ken
git-svn-id: https://zxing.googlecode.com/svn/trunk@1328 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-02 16:41:55 +00:00
srowen 816d6b81e0 Replace tabs with spaces ( part of accepting another big patch); fix one failing test due to typo
git-svn-id: https://zxing.googlecode.com/svn/trunk@1326 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-02 06:49:18 +00:00
srowen 8a46200c72 Add ENCODING=QUOTED-PRINTABLE support
git-svn-id: https://zxing.googlecode.com/svn/trunk@1317 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-24 09:28:10 +00:00
srowen 33bbcab859 Issue 357
git-svn-id: https://zxing.googlecode.com/svn/trunk@1313 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-19 20:49:54 +00:00
srowen e51dbb3c53 Use RSS14 on the command line; scan more lines since RSS14 stacked kind of needs this; fix VerifyError when RSS14 is enabled on Android
git-svn-id: https://zxing.googlecode.com/svn/trunk@1311 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-19 09:23:43 +00:00
srowen 88649bb0d4 Allow 12-digit ITF
git-svn-id: https://zxing.googlecode.com/svn/trunk@1308 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-16 06:45:10 +00:00
srowen 2e9afb3673 Add description support, as well as handle VEVENT line continuation. Get rid of unused 'title' property
git-svn-id: https://zxing.googlecode.com/svn/trunk@1304 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-13 10:46:31 +00:00
srowen 3a415a4994 Fix small compile error in javame/, update for Java ME SDK 3.x layout, finally disentangle Proguard location from WTK
git-svn-id: https://zxing.googlecode.com/svn/trunk@1302 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-12 08:59:41 +00:00
srowen 047c932fcb Recognize LOCATION in VEVENT
git-svn-id: https://zxing.googlecode.com/svn/trunk@1301 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-11 16:42:11 +00:00
srowen c7d5c2af5a Noticed we should just use BarcodeFormat constants in the client for simplicity
git-svn-id: https://zxing.googlecode.com/svn/trunk@1295 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-10 15:30:22 +00:00
srowen 06a6a35ce1 Pure-barcode mode can now deal with asymmetric borders instead of assuming it's pure generator output with equal borders
git-svn-id: https://zxing.googlecode.com/svn/trunk@1288 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 21:30:53 +00:00
srowen 634273cfdb Use jar packaging
git-svn-id: https://zxing.googlecode.com/svn/trunk@1287 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 19:58:40 +00:00
srowen be71fb0613 Back up and restore poms to prerelease state
git-svn-id: https://zxing.googlecode.com/svn/trunk@1285 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 12:38:26 +00:00
srowen 8eb728e9c9 [maven-release-plugin] prepare release core-1.5
git-svn-id: https://zxing.googlecode.com/svn/trunk@1283 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 11:59:11 +00:00
srowen e3fd5a55f8 [maven-release-plugin] rollback the release of core-1.5
git-svn-id: https://zxing.googlecode.com/svn/trunk@1282 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 11:57:56 +00:00
srowen 916c5a4d70 [maven-release-plugin] prepare for next development iteration
git-svn-id: https://zxing.googlecode.com/svn/trunk@1281 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 09:37:46 +00:00
srowen 8d4feb5eff [maven-release-plugin] prepare release core-1.5
git-svn-id: https://zxing.googlecode.com/svn/trunk@1279 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-06 09:37:27 +00:00
srowen 7410fd3082 Issue 361
git-svn-id: https://zxing.googlecode.com/svn/trunk@1268 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-30 22:53:34 +00:00
srowen 0b74dfc7fe Update sms: and geo: handling to better respect new RFCs
git-svn-id: https://zxing.googlecode.com/svn/trunk@1266 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-30 18:33:54 +00:00
srowen 0b2f7dcd2e Add timestamp to result screen
git-svn-id: https://zxing.googlecode.com/svn/trunk@1261 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-26 22:40:09 +00:00
srowen 48a74e2b14 Turn down depth of recursion
git-svn-id: https://zxing.googlecode.com/svn/trunk@1256 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-25 17:23:55 +00:00
srowen 53dcdf4ffc Quick patch to make this work with current writer API
git-svn-id: https://zxing.googlecode.com/svn/trunk@1253 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-25 15:16:33 +00:00
srowen 6e05578429 Add basic Code 128, Code 39, ITF writers, per Erik
git-svn-id: https://zxing.googlecode.com/svn/trunk@1252 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-25 12:49:27 +00:00
srowen a0381b760d Avoid RSS-14 false positive issue, which temporarily hurts its scanning a lot, but will work more later. Readjust unit test pass counts, which seem to have drifted. The change is net neutral in any event.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1251 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-25 11:42:08 +00:00
srowen 59fbd6564e Issue 327. Relax decoder assumptions
git-svn-id: https://zxing.googlecode.com/svn/trunk@1243 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-10 11:10:49 +00:00
srowen 70933a7ffd To fix http://groups.google.com/group/zxing/browse_thread/thread/bf1d150a7ed44ee8#, try a little harder on 1D, which is fine
git-svn-id: https://zxing.googlecode.com/svn/trunk@1239 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-05 10:41:51 +00:00
srowen d273ab5dbc Prevent an array out of bounds exception I noticed in the web logs
git-svn-id: https://zxing.googlecode.com/svn/trunk@1238 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-04 21:15:39 +00:00
srowen 0c54a9f45b Caught a few J2ME incompatibilities in build
git-svn-id: https://zxing.googlecode.com/svn/trunk@1235 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-04 18:53:58 +00:00
srowen 0cf89d0402 Preliminary RSS-14 support. Not enabled yet in Android client.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1233 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-04 18:38:58 +00:00
srowen 4f072f67ee Per Brad Threatt -- don't fail early on NotFoundException when finding multiple finder patterns
git-svn-id: https://zxing.googlecode.com/svn/trunk@1232 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-02 14:58:18 +00:00
srowen 508697a318 Related to Issue 205, but not the direct issue: read both copies of the format info and use both in determining the right one. This avoids a close, but incorrect first match throwing off the decoding. Also fix creating an image from ByteMatrix -- was inverted
git-svn-id: https://zxing.googlecode.com/svn/trunk@1226 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-01 11:04:22 +00:00
srowen 5ef5f3b02d "Split" ReaderException into subclasses to enable more useful error reporting
git-svn-id: https://zxing.googlecode.com/svn/trunk@1195 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-02-02 08:23:46 +00:00
srowen f9b648c131 Fixed old unit test compile problem I probaby introduced
git-svn-id: https://zxing.googlecode.com/svn/trunk@1194 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-02-02 07:34:35 +00:00
srowen 87f2fada9a Pre-RSS-14 changes. Necessary code changes, but not the decoder. Committing this since it does no harm and clears out my client so I can modify these files for other purposes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1193 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-02-01 19:41:17 +00:00
srowen 171bd88c5d Issue 331
git-svn-id: https://zxing.googlecode.com/svn/trunk@1191 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-29 10:27:07 +00:00
dswitkin 04d5b85502 This is a set of mobile image taken at 480x360 with difficult lighting.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1187 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-17 23:12:21 +00:00
dswitkin 395f145067 Deleted the old ean13-2 test data which contained high resolution blurry images. These are not the focus of ZXing and not worth testing against. I'm going to replace them shortly with more relevant test images.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1186 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-17 22:19:59 +00:00
srowen c2a6255e19 Fix/improvement from Jiayong
git-svn-id: https://zxing.googlecode.com/svn/trunk@1184 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-11 06:08:20 +00:00
srowen 719ed5b883 Undo the ^= true thing in more files
git-svn-id: https://zxing.googlecode.com/svn/trunk@1182 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-10 12:41:04 +00:00
srowen 2d0b3bc83a Issue 316
git-svn-id: https://zxing.googlecode.com/svn/trunk@1181 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-10 09:59:54 +00:00
srowen ae379e56e9 Better version of revision 1166 and 1165 -- corrects behavior, by changing code such that points are always within image. Happens to make one test image fail at one rotation, but think that was a 'false gain' so accepted that tiny step backwards.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1178 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-06 14:02:16 +00:00
srowen e44cc99359 Maybe avoid weird Proguard issue by removing inner class?
git-svn-id: https://zxing.googlecode.com/svn/trunk@1177 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-06 12:13:46 +00:00
srowen c7a5b5f0a9 Issue 311 fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@1174 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-05 09:40:54 +00:00
srowen bfaa68426b Issue 309, don't fail if birthday is bad
git-svn-id: https://zxing.googlecode.com/svn/trunk@1172 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-04 20:02:33 +00:00
srowen d71f40fef6 Two tiny improvements to make code more consistent
git-svn-id: https://zxing.googlecode.com/svn/trunk@1170 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-03 16:15:39 +00:00
srowen a38b0123f6 Tighten up detection of URLs on some garbage strings
git-svn-id: https://zxing.googlecode.com/svn/trunk@1167 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 18:30:09 +00:00
srowen 00c49493c0 Oops realized DM decoder also benefits from that last possible fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@1166 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 12:24:02 +00:00
srowen 18002649eb Guess of a fix at array index out of bounds problem observed in the wild
git-svn-id: https://zxing.googlecode.com/svn/trunk@1165 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 12:19:31 +00:00
srowen 2736b6e19e Unit test for some reason too stringent by one? was breaking in a clean build
git-svn-id: https://zxing.googlecode.com/svn/trunk@1164 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 12:18:32 +00:00
dswitkin 539f890acf Added a new build-optimized target to core for applications which want the library to be optimized but don't want to run ProGuard themselves against the entire app.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1162 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-20 20:08:32 +00:00
dswitkin e779586745 Made a small performance tweak (about 1% faster).
git-svn-id: https://zxing.googlecode.com/svn/trunk@1158 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 21:36:38 +00:00
dswitkin 5cc1df3c92 Finished work on the local binarizer and renamed it to HybridBinarizer. It uses the old histogram for 1D and the new approach for 2D. The unit tests don't fully demonstrate how much better this is in real-world lighting, but it pretty much solves the situation of pointing at a QR Code for 30 seconds without scanning, due to a shadow or gradient.
HybridBinarizer is now the default across all the fast clients and the unit tests.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1157 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 21:08:57 +00:00
dswitkin 8ba08bb916 Added the ability to track who is throwing exceptions and how often in the core library. Uncomment to enable it.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1155 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 17:10:02 +00:00
dswitkin fbff1b9718 Eliminated up to 700 execeptions being thrown per image by changing one method to return -1 on failure.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1154 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 16:58:28 +00:00
dswitkin b21dd14d9b Added a check so that the PDF417 reader can get through the partial blackbox test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1152 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 15:02:33 +00:00
srowen ef4cdf1969 Issue 295 and Issue 294, treat ADR as wholly different addresses, not 2 lines of 1 address
git-svn-id: https://zxing.googlecode.com/svn/trunk@1150 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-10 15:50:54 +00:00
srowen 6271b86315 Issue 294, add support for several address lines in parsed results
git-svn-id: https://zxing.googlecode.com/svn/trunk@1148 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-10 00:34:54 +00:00
srowen 9f3ee05fe1 Opening up the Detector a little to allow extension, such as per Ralf
git-svn-id: https://zxing.googlecode.com/svn/trunk@1143 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 19:58:01 +00:00
srowen 27be3fb930 Oops, last change meant to include this -- changelist got split
git-svn-id: https://zxing.googlecode.com/svn/trunk@1142 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 19:49:52 +00:00
srowen 1e5964024b Make finder pattern detection a little more tolerant, per Ralf. Increases accuracy slightly.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1141 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 19:47:50 +00:00
srowen e0fc79fda0 Small bug fix from Ralf
git-svn-id: https://zxing.googlecode.com/svn/trunk@1140 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 15:51:32 +00:00
srowen edddb45040 Remove use of Hashtable.clone(), doesn't work in J2ME
git-svn-id: https://zxing.googlecode.com/svn/trunk@1139 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 12:02:35 +00:00
dswitkin bdc25cf5bc Removed three interfaces which weren't doing any good and were making the 1D class hierarchy even more complicated than it already is.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1138 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 02:15:35 +00:00
dswitkin 5c627db289 Added some comments and fixed up lines over 100 columns.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1134 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-03 20:35:10 +00:00
srowen efd5cc819f Issue 287
git-svn-id: https://zxing.googlecode.com/svn/trunk@1131 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-30 16:01:20 +00:00
srowen d1973dce0a Draft of 'thinking' visualization for barcode scanning. Works for 1D and QR codes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1125 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-23 16:42:31 +00:00
srowen 88c77b18b8 Fixed unit test fail from vCard change
git-svn-id: https://zxing.googlecode.com/svn/trunk@1122 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-23 09:37:58 +00:00
srowen f75a6ec766 Loosen BDAY parsing for vCard results
git-svn-id: https://zxing.googlecode.com/svn/trunk@1118 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-22 11:14:39 +00:00
srowen b710e257eb More fixes, to cropping BufferedImages
git-svn-id: https://zxing.googlecode.com/svn/trunk@1109 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-13 10:46:04 +00:00
srowen 431ace93e1 Oops fixed typo in last patch
git-svn-id: https://zxing.googlecode.com/svn/trunk@1108 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-13 09:57:14 +00:00
srowen ac64595afa Be more conservative about choosing Kanji mode. Since we don't support mixed mode, can only use it when the input is all double-byte Kanji.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1107 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-13 09:49:49 +00:00
srowen 0debee9c71 Issue 271
git-svn-id: https://zxing.googlecode.com/svn/trunk@1106 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-13 09:17:18 +00:00
srowen 8e4824da68 Fix some double-reversed i-j problems in this code
git-svn-id: https://zxing.googlecode.com/svn/trunk@1104 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-12 22:18:25 +00:00
srowen 9fd4391f8e Added Code 39 check digit hint
git-svn-id: https://zxing.googlecode.com/svn/trunk@1098 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-04 22:00:27 +00:00
srowen e913ff5990 Remove some redundant 'throws'; allocate more reasonably sized StringBuffers for performance
git-svn-id: https://zxing.googlecode.com/svn/trunk@1093 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-02 10:16:03 +00:00
dswitkin 0fd5a2c506 - Created Barcode Scanner 3.0 beta 1, for Donut and above only.
- Added support for ACTION_SEND intent for encoding a QR from Contacts.
- Made VCARD parsing a little less strict.
- Updated help and fixed a minor UI issue.
- Removed vestigial intent support using the old package name.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1075 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-10-19 18:04:57 +00:00
srowen a9788f0419 Oops passing somewhat too large values for width / height -- were being used as right/bottom coordinates.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1074 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-10-13 17:20:25 +00:00
srowen fbcafd74c8 Issue 249, fix references to methods not in MIDP 2
git-svn-id: https://zxing.googlecode.com/svn/trunk@1073 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-10-13 17:16:19 +00:00
srowen 29b88b66e3 Improved history function
git-svn-id: https://zxing.googlecode.com/svn/trunk@1066 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-29 22:33:03 +00:00
srowen 63b8253e10 Remove MobileTag support -- outdated, unused, and not clear we support the direction MobileTag is going
git-svn-id: https://zxing.googlecode.com/svn/trunk@1060 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-23 13:33:45 +00:00
srowen 938c44c17a Another shot at TCP CLOSE_WAIT issue, and tiny code tweak
git-svn-id: https://zxing.googlecode.com/svn/trunk@1057 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-18 10:27:17 +00:00
srowen 3b557e6229 Run tests with -Xint to work around weird JIT bug in Java 6, which causes ArithmeticException failure in a few QR code tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@1054 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-15 09:06:45 +00:00
srowen 5b041daad0 Spell checker fixes, narrowed scope / made less visible where possible. Little stuff
git-svn-id: https://zxing.googlecode.com/svn/trunk@1053 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-15 09:03:05 +00:00
srowen eef79f730b Fix for old logic error in seeking format information -- actually was comparing unmasked rather than masked values, though it ended up working
git-svn-id: https://zxing.googlecode.com/svn/trunk@1052 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-14 10:17:17 +00:00
srowen c02bd97b6a Tiny code adjustments from inspection
git-svn-id: https://zxing.googlecode.com/svn/trunk@1041 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-25 21:29:39 +00:00
srowen 46640620e9 Issue 230
git-svn-id: https://zxing.googlecode.com/svn/trunk@1040 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-24 06:49:57 +00:00
srowen e1dd41a115 Improve detector logic to throw out false positive finder patterns in a more reasonable manner. Current logic didn't quite achieve its goal in some corner cases and needed rethinking and some simplification. Fixes a reported failure from the group list. Net change in passed test cases is -1 otherwise (for 270 degree rotation -- not vital) so I consider it a net tiny win.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1039 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-23 15:32:01 +00:00
srowen 362236564e Miscellaneous changes from FindBugs analysis
git-svn-id: https://zxing.googlecode.com/svn/trunk@1038 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-22 15:16:36 +00:00
srowen 6dbf893cb0 Add MatrixToImageWriter convenience class, small code tweaks in javase/, make ByteMatrix width/height property getters names standard
git-svn-id: https://zxing.googlecode.com/svn/trunk@1028 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-30 08:58:57 +00:00
dswitkin d8b1011324 Fixed some long lines over 100 columns.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1027 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-23 22:10:43 +00:00
srowen 4331605913 Added error correction level to Result
git-svn-id: https://zxing.googlecode.com/svn/trunk@1026 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-22 10:40:18 +00:00
srowen 91d8e04d86 Re-enable ProGuard, and finally identified the workaround that seems to make 4.4 work with our code without a VerifyError
git-svn-id: https://zxing.googlecode.com/svn/trunk@1025 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-22 10:36:11 +00:00
srowen 9f475ac33e Small detector simplification that addresses issue 215 and picks up a net +4 more images decoded in tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@1022 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-21 09:39:31 +00:00
srowen 636c00e844 Another tweak to get some valid ISO-8859-1 strings like "frédéric" to be guessed correctly
git-svn-id: https://zxing.googlecode.com/svn/trunk@1021 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-17 09:30:46 +00:00
dswitkin 54e6ed418a More x, y cleanup and 100 column fixes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1017 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-08 21:17:52 +00:00
dswitkin 402880798c Modified my skew correction code to also work upside down, meaning we now decode three more inverted PDF 417 images.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1016 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-08 20:38:21 +00:00
dswitkin b238cb7828 I noticed that the codeword coordinates in PDF 417 barcodes were a few pixels off if there was skew or rotation in the image. I added a simple method to correct the vertical component of these points, and the units tests went from 8/23 to 11/23.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1015 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-02 20:07:09 +00:00
dswitkin 0944a2bb18 Got 180 degree rotation working for PDF 417, and turned on the appropriate unit tests as a result.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1014 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 19:42:52 +00:00
dswitkin af2ce46c37 Cleaned up a number of comments and code to fit in 100 columns and added some TODO items.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1013 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 16:35:05 +00:00
dswitkin e44f00ba75 Converted the last user of the old MonochromeBitmapSource-style calls over to BitMatrix, and removed these deprecated methods.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1012 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 16:13:25 +00:00
dswitkin c31b489efe Added the second PDF 417 test to the AllPositiveBlackBoxTester.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1011 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 15:13:44 +00:00
dswitkin 01eed5266e - Converted parts of the PDF 417 reader to use BitMatrix.
- Changed the PDF 417 detector to search the image more broadly, instead of assuming the barcode starts in the left 1/4 and ends in the right 1/4. We now get 8/23 on the real-world blackbox test, and we'll probably do even better with further improvements here.
- Added a quiet zone to two of the unit test images and updated a golden result for one of them. We now get 3/7 on the first test.
- Tried to fix some bugs in the upside down code but it still doesn't work.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1010 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 21:55:19 +00:00
dswitkin 0667b29155 Added the PDF 417 blackbox tests to the test-blackbox Ant target.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1009 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 18:51:43 +00:00
dswitkin f5124cec37 Created a new blackbox unit test of real-world PDF 417 images taken with an Android device. Currently we decode 0/23.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1008 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 18:47:34 +00:00
dswitkin 2397216901 Added a few computer-generated PDF 417 barcodes to the blackbox tests. The current code doesn't seem to handle more advanced error correction modes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1007 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 17:32:12 +00:00
dswitkin eb8b9677cf Added the previous Android benchmark I've been using to track performance, as well as a new one which uses wider images and therefore twice as many pixels.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1006 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 22:08:38 +00:00
dswitkin e2324bc2ae Added slightly better blackbox unit test stats.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1005 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 21:57:59 +00:00
dswitkin 10dfe7789b - Got the DataMatrix decoder compiling again with a quick bandaid.
- Fixed two bugs in the LocalBlockBinarizer sharpening routine. It can now decode 2132 images in our blackbox tests, compared to 2103 using the global histogram approach.
- Added the PDF 417 blackbox test to AllPositiveBlackBoxTester, and allowed it to complete even if the tests fail.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1004 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 15:49:42 +00:00
srowen 597fcfb23d Code analysis tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@1003 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-28 16:33:02 +00:00
srowen 550511d760 Remove use of BinaryBitmap in QR Code, DM
git-svn-id: https://zxing.googlecode.com/svn/trunk@999 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 19:22:48 +00:00
dswitkin ce1badea71 Sean had a good idea to add @deprecated Javadoc comments to these three methods to help track down their usage. We can't use a Java @Deprecated annotation because core builds against Java 1.2.
git-svn-id: https://zxing.googlecode.com/svn/trunk@998 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 19:04:12 +00:00
dswitkin 167197ec7a Refactored the MonochromeBitmapSource class hierarchy into LuminanceSource, Binarizer, and BinaryBitmap classes. The unit tests pass and I believe the change is complete, but there are some clients like J2ME and Bug that I can't build.
This change will allow new thresholding algorithms to be developed and tested, as well as implemented per platform if needed (e.g. in JNI on Android). It should also perform better when multiple 2D Readers are installed, because the underlying image will only be converted to 1 bit once. It also allows some platforms to return luminance data without a copy.

The current state of this checkin is to use the old black point algorithm, which now lives in GlobalHistogramBinarizer. This will be our benchmark and fallback for slower platforms. Going forward we will begin to use LocalBlockBinarizer as I shake out the edge cases and tune it for performance. Currently it is unused.

IMPORTANT: I have temporarily included three methods from MonochromeBitmapSource at the end of BinaryBitmap as a way to make this change in stages. They are deprecated and will be removed soon. All of the Reader classes will need to change the way they examine 1 bit pixels to use the new getBlackRow() and getBlackMatrix() calls.

git-svn-id: https://zxing.googlecode.com/svn/trunk@993 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 17:49:45 +00:00
kev.sully 974fb5e403 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@987 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 14:34:16 +00:00
dswitkin da4f56b022 Fixed some code which was ignoring the result of MonochromeBitmapSource calls, which may work in some cases but isn't legal and failed and in some experiments.
git-svn-id: https://zxing.googlecode.com/svn/trunk@986 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-25 19:46:49 +00:00
srowen 969088fa82 Style changes mostly
git-svn-id: https://zxing.googlecode.com/svn/trunk@985 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 13:19:53 +00:00
kev.sully 372dfa1145 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@984 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 10:03:37 +00:00
kev.sully ffbbda2086 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@983 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 10:02:58 +00:00
kev.sully db23e7c3b1 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@982 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 10:02:27 +00:00
kev.sully 36db720dac ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@981 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 10:02:04 +00:00
kev.sully f80399966f ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@980 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-24 10:01:47 +00:00
dswitkin 6367973b49 Added a clear() method to BitMatrix.
git-svn-id: https://zxing.googlecode.com/svn/trunk@979 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-23 21:05:09 +00:00
dswitkin b613112615 Rewrote BitMatrix to allow rectangular 2D arrays, and so that every row begins with a new int, which makes it fast to copy out rows into BitArrays. This will be the basis of the upcoming bitmap refactoring for 1D Readers.
git-svn-id: https://zxing.googlecode.com/svn/trunk@978 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-22 21:03:34 +00:00
dswitkin 7fec06465a Continuing with the x, y coordinate push, BitMatrix is now standardized. I also converted DataMask back to i, j for now to be consistent with the rest of the QR module, and made sure all the tests still pass.
git-svn-id: https://zxing.googlecode.com/svn/trunk@977 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-22 19:52:51 +00:00
srowen 4b7e5e6461 Remove getBits()
git-svn-id: https://zxing.googlecode.com/svn/trunk@976 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-22 17:48:37 +00:00
dswitkin 5f2b64ee50 Used IntelliJ's amazing refactoring functions to change the argument ordering of ByteMatrix. I want to standardize this across ZXing: the first component should always be horizontal and the second vertical, whether supplying an x, y point or a width, height pair. Also, we should always use x and y as variables with x being the horizontal component to avoid confusion.
git-svn-id: https://zxing.googlecode.com/svn/trunk@975 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-22 15:50:08 +00:00
dswitkin 406f353e53 Modified some comments to reflect that these objects are thread-safe but not reentrant.
git-svn-id: https://zxing.googlecode.com/svn/trunk@974 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-22 15:32:59 +00:00
dswitkin 0c3a4b4b5a Updated some comments about thread safety and fixed one easy case. Sean, please have a look.
git-svn-id: https://zxing.googlecode.com/svn/trunk@973 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-19 19:08:31 +00:00
srowen 63a1dc62a3 Issue 198
git-svn-id: https://zxing.googlecode.com/svn/trunk@972 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-19 13:23:09 +00:00
dswitkin 9f509172b6 Wrote a quick command line app to calculate how many total images are passing our blackbox unit tests. This could use some improvement but it's a start.
git-svn-id: https://zxing.googlecode.com/svn/trunk@971 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-18 20:55:42 +00:00
dswitkin 1da9bd60b3 Added a new blackbox test with extreme shadows and highlights. We do pretty poorly on this, but I've been experimenting with local thresholding algorithms which are a night and day improvement.
Also made the ImageConverter app ignore some kinds of files.

git-svn-id: https://zxing.googlecode.com/svn/trunk@969 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-16 18:47:34 +00:00
srowen 5c17a1ad71 Added getBlackDiagonal() which I likely want to use later
git-svn-id: https://zxing.googlecode.com/svn/trunk@968 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-11 13:42:39 +00:00
dswitkin c07fad6410 Created a new QR blackbox test with difficult exposures, mostly self-shadowing cases. We only get 34 out of 120 tests, which is about what I expected. To fix these we will have to move away from a global black point and towards a more sophisticated local thresholding algorithm.
git-svn-id: https://zxing.googlecode.com/svn/trunk@961 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-28 18:45:48 +00:00
dswitkin 932715065b Only allocate a StringBuffer if the start pattern has been found successfully in the ITFReader.
git-svn-id: https://zxing.googlecode.com/svn/trunk@958 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 21:11:10 +00:00
srowen dbb2c31a40 Fixed an old misspelling and a few tiny tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@956 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 10:03:23 +00:00
srowen 58c367d9ea Improvement to Shift_JIS encoding detector to avoid detecting some UTF-8 strings as Shift_JIS
git-svn-id: https://zxing.googlecode.com/svn/trunk@955 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 09:14:17 +00:00
srowen 78c1b8ccd7 Oops, one more fix to rotateCounterClockwise() here
git-svn-id: https://zxing.googlecode.com/svn/trunk@952 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-24 13:06:51 +00:00
srowen 4282827336 More intelligence to avoid very deep recursion
git-svn-id: https://zxing.googlecode.com/svn/trunk@951 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-23 10:33:53 +00:00
dswitkin ec77a581d2 Changed the 2D histogram calculation to sample four rows spread across the image rather than taking a diagonal. We get a net increase of 63 blackbox tests with this change.
git-svn-id: https://zxing.googlecode.com/svn/trunk@950 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-22 20:59:15 +00:00
srowen 825d99786d Off by one error in last change
git-svn-id: https://zxing.googlecode.com/svn/trunk@949 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-22 08:19:11 +00:00
dswitkin 51ade2ca96 Added better logging for our blackbox tests. It now displays the number of images which passes per test out of the total, and the percentage. It also warns when a blackbox test is too lax (i.e. we've made decoding improvements but haven't raised the high water mark).
git-svn-id: https://zxing.googlecode.com/svn/trunk@947 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 21:18:27 +00:00
dswitkin 6687d5772f Fixed a typo in our golden results.
git-svn-id: https://zxing.googlecode.com/svn/trunk@946 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 20:29:56 +00:00
dswitkin e19e9a83f6 I moved a chunk of the histogram/black point code out of BaseMonochromeBitmapSource and into BlackPointEstimator which makes a lot more sense. Unfortunately I had to expose three new methods and touch a bunch of files. But I did manage to reuse an array on subsequent calls, which was being allocated on every row scanned, so that might be a bit faster. It will also be easier to convert this code to JNI in the future if we want to, and/or do more advanced thresholding.
git-svn-id: https://zxing.googlecode.com/svn/trunk@945 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 19:56:25 +00:00
dswitkin 038f113274 Moved CroppedMonochromeBitmapSource into the common package and fixed some more 100 column issues.
git-svn-id: https://zxing.googlecode.com/svn/trunk@944 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 18:46:53 +00:00
dswitkin c9d3eae171 Cleaned up some code to fit in 100 columns.
git-svn-id: https://zxing.googlecode.com/svn/trunk@942 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 15:36:51 +00:00
srowen bd73aebc73 Be smarter about recursion to avoid infinite loop
git-svn-id: https://zxing.googlecode.com/svn/trunk@940 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 14:26:29 +00:00
srowen 76eeeed99a Add toString() for easy debugging
git-svn-id: https://zxing.googlecode.com/svn/trunk@939 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-11 21:51:20 +00:00
srowen 793f4c7176 Marginal improvement to datamatrix decoder
git-svn-id: https://zxing.googlecode.com/svn/trunk@937 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-11 21:02:08 +00:00
srowen 0c07f139b5 Fix issue 189. Need to guard against 'false positive' success in reading version info.
git-svn-id: https://zxing.googlecode.com/svn/trunk@934 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-06 21:50:13 +00:00
srowen b2bd63a228 Alternate multi QR Code reader from Hannes
git-svn-id: https://zxing.googlecode.com/svn/trunk@933 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-05 09:52:46 +00:00
srowen a26e5fbc10 Forge ahead with detection even if we missed an alignment pattern -- can still decode in some cases without it
git-svn-id: https://zxing.googlecode.com/svn/trunk@929 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-03 19:52:03 +00:00
srowen 361f4504a3 Add MultipleBarcodeReader interface to allow for more implementations
git-svn-id: https://zxing.googlecode.com/svn/trunk@927 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-03 05:56:51 +00:00
srowen 7e86f379ea Moved MultipleBarcodeReader and added ByQuadrantReader to try to accommodate many QR codes in an image
git-svn-id: https://zxing.googlecode.com/svn/trunk@921 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-30 19:12:32 +00:00
srowen 949eca972e Adding a few test images from a defunct issue report
git-svn-id: https://zxing.googlecode.com/svn/trunk@919 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-28 22:29:30 +00:00
srowen 29d7d6443e Issue 183: Adds support for detecting multiple barcodes, and simplifies ResultPoint abstraction
git-svn-id: https://zxing.googlecode.com/svn/trunk@918 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-28 17:35:33 +00:00
srowen e9c19530cc Improve URL detection rule to exclude stuff like "Hi."
git-svn-id: https://zxing.googlecode.com/svn/trunk@914 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-18 08:57:32 +00:00
srowen e74c041e46 Improve URL detection rule to exclude stuff like "Hi."
git-svn-id: https://zxing.googlecode.com/svn/trunk@913 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-18 08:02:08 +00:00
srowen d08ddbe733 In extreme decoder failure case, make sure not to let an IAE propagate up. Turn it into ReaderException.
git-svn-id: https://zxing.googlecode.com/svn/trunk@911 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-17 21:30:36 +00:00
dswitkin 02f779cbee Fixed or removed a bunch of TODOs, and enforced the 100 columns limit in a bunch of places. Also allowed QR Codes to be encoded of contacts without names.
git-svn-id: https://zxing.googlecode.com/svn/trunk@907 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-13 21:20:11 +00:00
srowen 94915afb71 Enable DataMatrix in the web app / other small tweaks (forgot one class!); also fix a small bug in QRCodeWriter
git-svn-id: https://zxing.googlecode.com/svn/trunk@904 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-12 06:39:10 +00:00
srowen dea0247615 Enable DataMatrix in the web app / other small tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@903 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-10 13:46:11 +00:00
srowen 3d8d68a464 Issue 165
git-svn-id: https://zxing.googlecode.com/svn/trunk@900 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:56:06 +00:00
srowen 3c84048565 Issue 164
git-svn-id: https://zxing.googlecode.com/svn/trunk@898 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:46:02 +00:00
srowen d4e82758eb Issue 158: Correct some off-by-one problems in Data Matrix detector and a few more improvements, ignore unsupported DM symbols
git-svn-id: https://zxing.googlecode.com/svn/trunk@895 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:22:07 +00:00
srowen 0210ec9fe9 Fixed tiny javadoc glitches
git-svn-id: https://zxing.googlecode.com/svn/trunk@892 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-12 21:17:06 +00:00
dswitkin dfb6b60dd4 - Added a new unit test of 13 ITF images I took with a T-Mobile G1.
- Added upside down unit tests for the existing ITF images.
- Removed the temporary format code from these tests now that ITF is on by default.

git-svn-id: https://zxing.googlecode.com/svn/trunk@883 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 20:48:48 +00:00
dswitkin 5b5c7945bb Turned on ITF support in the Android client, and fixed a bug in the ITF result points, which by convention should draw across the whole body of the barcode, not just the start range.
git-svn-id: https://zxing.googlecode.com/svn/trunk@881 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:57:57 +00:00
srowen 7561941341 Tiny optimization to reverse()
git-svn-id: https://zxing.googlecode.com/svn/trunk@880 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:56:08 +00:00
dswitkin 04ff9c43b5 Turned on ITF support by default. The typical overhead in real world scanning on an Android device is 3-8 ms.
git-svn-id: https://zxing.googlecode.com/svn/trunk@879 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:46:27 +00:00
srowen e367d3ef96 Fixed decodeEnd() situation whereby row might not be re-reversed, and fixed an old NPE I caused
git-svn-id: https://zxing.googlecode.com/svn/trunk@878 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-07 10:51:03 +00:00
srowen 8b339661d9 Some clever, perhaps too-clever optimization of masking code
git-svn-id: https://zxing.googlecode.com/svn/trunk@877 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 22:55:19 +00:00
dswitkin c1bc060065 Changed the order of the BaseMonochromeBitmapSource constructor arguments to be width, height to match the rest of the codebase, and added two apparently missing methods to the J2ME subclass, although I can't test it.
git-svn-id: https://zxing.googlecode.com/svn/trunk@874 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 16:52:35 +00:00
srowen 6fe022eb10 Normalize GEO: to geo:
git-svn-id: https://zxing.googlecode.com/svn/trunk@873 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 15:25:26 +00:00
srowen 415c9257d6 Fix #150 again by moving towards a more RFC 2822-compliant definition of valid syntax
git-svn-id: https://zxing.googlecode.com/svn/trunk@872 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 15:17:38 +00:00
srowen 83f6b96f82 Backed out last 'fix' to email address parsing -- isn't going to work. Needs a better, real fix.
git-svn-id: https://zxing.googlecode.com/svn/trunk@871 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:28:57 +00:00
srowen cf24cfd453 Normalize TEL: to tel: to make sure it works with Android
git-svn-id: https://zxing.googlecode.com/svn/trunk@870 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:26:21 +00:00
srowen ddffcde9f4 Address Issue 152
git-svn-id: https://zxing.googlecode.com/svn/trunk@869 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:19:48 +00:00
srowen b24fbdd7b0 Tiny optimizations to boolean logic to avoid extra byte code and branches in semi-critical sections
git-svn-id: https://zxing.googlecode.com/svn/trunk@867 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-23 13:52:45 +00:00
srowen 1e96791817 git-svn-id: https://zxing.googlecode.com/svn/trunk@859 59b500cc-1b3d-0410-9834-0bbf25fbcc57 2009-02-15 12:38:12 +00:00
srowen 8e73582187 A fixed fix for email parsing
git-svn-id: https://zxing.googlecode.com/svn/trunk@858 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 12:00:52 +00:00
srowen dd1eccfda8 Tighten email check logic a little
git-svn-id: https://zxing.googlecode.com/svn/trunk@857 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 09:45:52 +00:00
srowen 8e18d651bb Tightened a condition to reduce accidentally detecting the alignment pattern as a finder pattern
git-svn-id: https://zxing.googlecode.com/svn/trunk@856 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 09:43:40 +00:00
srowen f2a9165b7c Refactored width/height values into superclass and enabled construction of RGBMonochromeBitmapSource from a Bitmap
git-svn-id: https://zxing.googlecode.com/svn/trunk@846 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-09 21:25:45 +00:00
srowen 089cc3ac44 Fix Issue 143, failure on invalid geo: URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@842 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-06 13:30:10 +00:00
srowen db61519508 More changes in the direction of supporting ECI in the encoder
git-svn-id: https://zxing.googlecode.com/svn/trunk@837 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-31 20:17:43 +00:00
srowen 807c1646b9 Added basic support for caller-specified character encoding
git-svn-id: https://zxing.googlecode.com/svn/trunk@836 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-31 00:40:04 +00:00
srowen 1e8155190d Add ALLOWED_LENGTHS hint, for now, in support of ITF
git-svn-id: https://zxing.googlecode.com/svn/trunk@834 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-30 17:29:27 +00:00
srowen 4d225d48e1 Fix a nagging inconvenience from my IDE in running tests, due to working directory issues
git-svn-id: https://zxing.googlecode.com/svn/trunk@832 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-28 19:03:25 +00:00
srowen bb373c5929 Oops, StringBuffer.append(StringBuffer) doesn't exist in J2ME
git-svn-id: https://zxing.googlecode.com/svn/trunk@831 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-27 23:24:23 +00:00
srowen f05302cc4c Actually, let the scanner read codes using structured append -- just ignore these segments and show whatever part of the overall message that this code encodes
git-svn-id: https://zxing.googlecode.com/svn/trunk@830 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-21 21:07:00 +00:00
srowen 6a5d483aa5 Issue 127: Add structured append mode and make it clear this is not supported
git-svn-id: https://zxing.googlecode.com/svn/trunk@828 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-20 23:15:09 +00:00
srowen 25bdb39ac1 Remove WTK dependency which added little and only made life hard for mac users
git-svn-id: https://zxing.googlecode.com/svn/trunk@825 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-15 21:03:37 +00:00
srowen 5efb6ef335 Separated rectangle detection from decoder for reuse
git-svn-id: https://zxing.googlecode.com/svn/trunk@824 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-14 10:44:46 +00:00
srowen 37fbeaa36a Small updates from code inspection
git-svn-id: https://zxing.googlecode.com/svn/trunk@823 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-10 17:01:34 +00:00
dswitkin 0a885aca56 Added 18 real world DataMatrix blackbox images, plus turned on rotation for the original set.
git-svn-id: https://zxing.googlecode.com/svn/trunk@815 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-06 21:11:55 +00:00
srowen d0bc7df5d4 On a tip from Sandy found an error in the QR code detector that would miss a third finder pattern in cases of about 135 degree rotation. This changes test results but is a net win.
git-svn-id: https://zxing.googlecode.com/svn/trunk@814 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-01-04 21:11:25 +00:00
srowen 9433c5955b Add more unit tests for client.result, and more small code tweaks.
git-svn-id: https://zxing.googlecode.com/svn/trunk@809 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-12-30 15:31:25 +00:00
dswitkin 3269c66e77 Moved one file back to the ITF directory because it should be readable.
git-svn-id: https://zxing.googlecode.com/svn/trunk@806 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-12-23 17:21:31 +00:00
kev.sully 12a283ebf9 ISSUE: http://code.google.com/p/zxing/issues/detail?id=110
Moved failing test cases to partial.

git-svn-id: https://zxing.googlecode.com/svn/trunk@805 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-12-23 12:11:14 +00:00
kev.sully c1ee018a50 ISSUE: http://code.google.com/p/zxing/issues/detail?id=110
Moved failing test cases to partial.

git-svn-id: https://zxing.googlecode.com/svn/trunk@804 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-12-23 12:10:30 +00:00