mudhorn/zxing
1
0
Fork 0
mirror of https://github.com/zxing/zxing.git synced 2025-02-02 05:41:08 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity
1268 commits 6 branches 32 tags 331 MiB
Commit graph

598 commits

Author SHA1 Message Date
srowen 508697a318 Related to Issue 205, but not the direct issue: read both copies of the format info and use both in determining the right one. This avoids a close, but incorrect first match throwing off the decoding. Also fix creating an image from ByteMatrix -- was inverted 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1226 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-03-01 11:04:22 +00:00
srowen 5ef5f3b02d "Split" ReaderException into subclasses to enable more useful error reporting 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1195 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-02-02 08:23:46 +00:00
srowen f9b648c131 Fixed old unit test compile problem I probaby introduced 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1194 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-02-02 07:34:35 +00:00
srowen 87f2fada9a Pre-RSS-14 changes. Necessary code changes, but not the decoder. Committing this since it does no harm and clears out my client so I can modify these files for other purposes. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1193 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-02-01 19:41:17 +00:00
srowen 171bd88c5d Issue 331 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1191 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-29 10:27:07 +00:00
dswitkin 04d5b85502 This is a set of mobile image taken at 480x360 with difficult lighting. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1187 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-17 23:12:21 +00:00
dswitkin 395f145067 Deleted the old ean13-2 test data which contained high resolution blurry images. These are not the focus of ZXing and not worth testing against. I'm going to replace them shortly with more relevant test images. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1186 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-17 22:19:59 +00:00
srowen c2a6255e19 Fix/improvement from Jiayong 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1184 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-11 06:08:20 +00:00
srowen 719ed5b883 Undo the ^= true thing in more files 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1182 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-10 12:41:04 +00:00
srowen 2d0b3bc83a Issue 316 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1181 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-10 09:59:54 +00:00
srowen ae379e56e9 Better version of revision 1166 and 1165 -- corrects behavior, by changing code such that points are always within image. Happens to make one test image fail at one rotation, but think that was a 'false gain' so accepted that tiny step backwards. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1178 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-06 14:02:16 +00:00
srowen e44cc99359 Maybe avoid weird Proguard issue by removing inner class? 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1177 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-06 12:13:46 +00:00
srowen c7a5b5f0a9 Issue 311 fix 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1174 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-05 09:40:54 +00:00
srowen bfaa68426b Issue 309, don't fail if birthday is bad 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1172 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-04 20:02:33 +00:00
srowen d71f40fef6 Two tiny improvements to make code more consistent 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1170 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2010-01-03 16:15:39 +00:00
srowen a38b0123f6 Tighten up detection of URLs on some garbage strings 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1167 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-22 18:30:09 +00:00
srowen 00c49493c0 Oops realized DM decoder also benefits from that last possible fix 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1166 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-22 12:24:02 +00:00
srowen 18002649eb Guess of a fix at array index out of bounds problem observed in the wild 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1165 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-22 12:19:31 +00:00
srowen 2736b6e19e Unit test for some reason too stringent by one? was breaking in a clean build 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1164 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-22 12:18:32 +00:00
dswitkin 539f890acf Added a new build-optimized target to core for applications which want the library to be optimized but don't want to run ProGuard themselves against the entire app. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1162 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-20 20:08:32 +00:00
dswitkin e779586745 Made a small performance tweak (about 1% faster). 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1158 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-13 21:36:38 +00:00
dswitkin 5cc1df3c92 Finished work on the local binarizer and renamed it to HybridBinarizer. It uses the old histogram for 1D and the new approach for 2D. The unit tests don't fully demonstrate how much better this is in real-world lighting, but it pretty much solves the situation of pointing at a QR Code for 30 seconds without scanning, due to a shadow or gradient. 
HybridBinarizer is now the default across all the fast clients and the unit tests.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1157 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-13 21:08:57 +00:00
dswitkin 8ba08bb916 Added the ability to track who is throwing exceptions and how often in the core library. Uncomment to enable it. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1155 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-13 17:10:02 +00:00
dswitkin fbff1b9718 Eliminated up to 700 execeptions being thrown per image by changing one method to return -1 on failure. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1154 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-13 16:58:28 +00:00
dswitkin b21dd14d9b Added a check so that the PDF417 reader can get through the partial blackbox test. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1152 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-13 15:02:33 +00:00
srowen ef4cdf1969 Issue 295 and Issue 294, treat ADR as wholly different addresses, not 2 lines of 1 address 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1150 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-10 15:50:54 +00:00
srowen 6271b86315 Issue 294, add support for several address lines in parsed results 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1148 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-10 00:34:54 +00:00
srowen 9f3ee05fe1 Opening up the Detector a little to allow extension, such as per Ralf 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1143 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 19:58:01 +00:00
srowen 27be3fb930 Oops, last change meant to include this -- changelist got split 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1142 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 19:49:52 +00:00
srowen 1e5964024b Make finder pattern detection a little more tolerant, per Ralf. Increases accuracy slightly. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1141 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 19:47:50 +00:00
srowen e0fc79fda0 Small bug fix from Ralf 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1140 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 15:51:32 +00:00
srowen edddb45040 Remove use of Hashtable.clone(), doesn't work in J2ME 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1139 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 12:02:35 +00:00
dswitkin bdc25cf5bc Removed three interfaces which weren't doing any good and were making the 1D class hierarchy even more complicated than it already is. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1138 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-08 02:15:35 +00:00
dswitkin 5c627db289 Added some comments and fixed up lines over 100 columns. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1134 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-12-03 20:35:10 +00:00
srowen efd5cc819f Issue 287 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1131 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-30 16:01:20 +00:00
srowen d1973dce0a Draft of 'thinking' visualization for barcode scanning. Works for 1D and QR codes. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1125 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-23 16:42:31 +00:00
srowen 88c77b18b8 Fixed unit test fail from vCard change 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1122 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-23 09:37:58 +00:00
srowen f75a6ec766 Loosen BDAY parsing for vCard results 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1118 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-22 11:14:39 +00:00
srowen b710e257eb More fixes, to cropping BufferedImages 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1109 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-13 10:46:04 +00:00
srowen 431ace93e1 Oops fixed typo in last patch 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1108 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-13 09:57:14 +00:00
srowen ac64595afa Be more conservative about choosing Kanji mode. Since we don't support mixed mode, can only use it when the input is all double-byte Kanji. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1107 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-13 09:49:49 +00:00
srowen 0debee9c71 Issue 271 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1106 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-13 09:17:18 +00:00
srowen 8e4824da68 Fix some double-reversed i-j problems in this code 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1104 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-12 22:18:25 +00:00
srowen 9fd4391f8e Added Code 39 check digit hint 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1098 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-04 22:00:27 +00:00
srowen e913ff5990 Remove some redundant 'throws'; allocate more reasonably sized StringBuffers for performance 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1093 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-11-02 10:16:03 +00:00
dswitkin 0fd5a2c506 - Created Barcode Scanner 3.0 beta 1, for Donut and above only. 
- Added support for ACTION_SEND intent for encoding a QR from Contacts.
- Made VCARD parsing a little less strict.
- Updated help and fixed a minor UI issue.
- Removed vestigial intent support using the old package name.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1075 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-10-19 18:04:57 +00:00
srowen a9788f0419 Oops passing somewhat too large values for width / height -- were being used as right/bottom coordinates. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1074 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-10-13 17:20:25 +00:00
srowen fbcafd74c8 Issue 249, fix references to methods not in MIDP 2 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1073 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-10-13 17:16:19 +00:00
srowen 29b88b66e3 Improved history function 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1066 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-29 22:33:03 +00:00
srowen 63b8253e10 Remove MobileTag support -- outdated, unused, and not clear we support the direction MobileTag is going 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1060 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-23 13:33:45 +00:00
srowen 938c44c17a Another shot at TCP CLOSE_WAIT issue, and tiny code tweak 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1057 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-18 10:27:17 +00:00
srowen 3b557e6229 Run tests with -Xint to work around weird JIT bug in Java 6, which causes ArithmeticException failure in a few QR code tests 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1054 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-15 09:06:45 +00:00
srowen 5b041daad0 Spell checker fixes, narrowed scope / made less visible where possible. Little stuff 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1053 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-15 09:03:05 +00:00
srowen eef79f730b Fix for old logic error in seeking format information -- actually was comparing unmasked rather than masked values, though it ended up working 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1052 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-09-14 10:17:17 +00:00
srowen c02bd97b6a Tiny code adjustments from inspection 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1041 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-08-25 21:29:39 +00:00
srowen 46640620e9 Issue 230 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1040 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-08-24 06:49:57 +00:00
srowen e1dd41a115 Improve detector logic to throw out false positive finder patterns in a more reasonable manner. Current logic didn't quite achieve its goal in some corner cases and needed rethinking and some simplification. Fixes a reported failure from the group list. Net change in passed test cases is -1 otherwise (for 270 degree rotation -- not vital) so I consider it a net tiny win. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1039 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-08-23 15:32:01 +00:00
srowen 362236564e Miscellaneous changes from FindBugs analysis 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1038 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-08-22 15:16:36 +00:00
srowen 6dbf893cb0 Add MatrixToImageWriter convenience class, small code tweaks in javase/, make ByteMatrix width/height property getters names standard 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1028 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-30 08:58:57 +00:00
dswitkin d8b1011324 Fixed some long lines over 100 columns. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1027 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-23 22:10:43 +00:00
srowen 4331605913 Added error correction level to Result 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1026 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-22 10:40:18 +00:00
srowen 91d8e04d86 Re-enable ProGuard, and finally identified the workaround that seems to make 4.4 work with our code without a VerifyError 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1025 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-22 10:36:11 +00:00
srowen 9f475ac33e Small detector simplification that addresses issue 215 and picks up a net +4 more images decoded in tests 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1022 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-21 09:39:31 +00:00
srowen 636c00e844 Another tweak to get some valid ISO-8859-1 strings like "frédéric" to be guessed correctly 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1021 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-17 09:30:46 +00:00
dswitkin 54e6ed418a More x, y cleanup and 100 column fixes. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1017 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-08 21:17:52 +00:00
dswitkin 402880798c Modified my skew correction code to also work upside down, meaning we now decode three more inverted PDF 417 images. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1016 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-08 20:38:21 +00:00
dswitkin b238cb7828 I noticed that the codeword coordinates in PDF 417 barcodes were a few pixels off if there was skew or rotation in the image. I added a simple method to correct the vertical component of these points, and the units tests went from 8/23 to 11/23. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1015 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-02 20:07:09 +00:00
dswitkin 0944a2bb18 Got 180 degree rotation working for PDF 417, and turned on the appropriate unit tests as a result. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1014 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-01 19:42:52 +00:00
dswitkin af2ce46c37 Cleaned up a number of comments and code to fit in 100 columns and added some TODO items. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1013 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-01 16:35:05 +00:00
dswitkin e44f00ba75 Converted the last user of the old MonochromeBitmapSource-style calls over to BitMatrix, and removed these deprecated methods. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1012 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-01 16:13:25 +00:00
dswitkin c31b489efe Added the second PDF 417 test to the AllPositiveBlackBoxTester. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1011 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-07-01 15:13:44 +00:00
dswitkin 01eed5266e - Converted parts of the PDF 417 reader to use BitMatrix. 
- Changed the PDF 417 detector to search the image more broadly, instead of assuming the barcode starts in the left 1/4 and ends in the right 1/4. We now get 8/23 on the real-world blackbox test, and we'll probably do even better with further improvements here.
- Added a quiet zone to two of the unit test images and updated a golden result for one of them. We now get 3/7 on the first test.
- Tried to fix some bugs in the upside down code but it still doesn't work.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1010 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-30 21:55:19 +00:00
dswitkin 0667b29155 Added the PDF 417 blackbox tests to the test-blackbox Ant target. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1009 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-30 18:51:43 +00:00
dswitkin f5124cec37 Created a new blackbox unit test of real-world PDF 417 images taken with an Android device. Currently we decode 0/23. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1008 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-30 18:47:34 +00:00
dswitkin 2397216901 Added a few computer-generated PDF 417 barcodes to the blackbox tests. The current code doesn't seem to handle more advanced error correction modes. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1007 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-30 17:32:12 +00:00
dswitkin eb8b9677cf Added the previous Android benchmark I've been using to track performance, as well as a new one which uses wider images and therefore twice as many pixels. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1006 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-29 22:08:38 +00:00
dswitkin e2324bc2ae Added slightly better blackbox unit test stats. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1005 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-29 21:57:59 +00:00
dswitkin 10dfe7789b - Got the DataMatrix decoder compiling again with a quick bandaid. 
- Fixed two bugs in the LocalBlockBinarizer sharpening routine. It can now decode 2132 images in our blackbox tests, compared to 2103 using the global histogram approach.
- Added the PDF 417 blackbox test to AllPositiveBlackBoxTester, and allowed it to complete even if the tests fail.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1004 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-29 15:49:42 +00:00
srowen 597fcfb23d Code analysis tweaks 
git-svn-id: https://zxing.googlecode.com/svn/trunk@1003 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-28 16:33:02 +00:00
srowen 550511d760 Remove use of BinaryBitmap in QR Code, DM 
git-svn-id: https://zxing.googlecode.com/svn/trunk@999 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-26 19:22:48 +00:00
dswitkin ce1badea71 Sean had a good idea to add @deprecated Javadoc comments to these three methods to help track down their usage. We can't use a Java @Deprecated annotation because core builds against Java 1.2. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@998 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-26 19:04:12 +00:00
dswitkin 167197ec7a Refactored the MonochromeBitmapSource class hierarchy into LuminanceSource, Binarizer, and BinaryBitmap classes. The unit tests pass and I believe the change is complete, but there are some clients like J2ME and Bug that I can't build. 
This change will allow new thresholding algorithms to be developed and tested, as well as implemented per platform if needed (e.g. in JNI on Android). It should also perform better when multiple 2D Readers are installed, because the underlying image will only be converted to 1 bit once. It also allows some platforms to return luminance data without a copy.

The current state of this checkin is to use the old black point algorithm, which now lives in GlobalHistogramBinarizer. This will be our benchmark and fallback for slower platforms. Going forward we will begin to use LocalBlockBinarizer as I shake out the edge cases and tune it for performance. Currently it is unused.

IMPORTANT: I have temporarily included three methods from MonochromeBitmapSource at the end of BinaryBitmap as a way to make this change in stages. They are deprecated and will be removed soon. All of the Reader classes will need to change the way they examine 1 bit pixels to use the new getBlackRow() and getBlackMatrix() calls.

git-svn-id: https://zxing.googlecode.com/svn/trunk@993 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-26 17:49:45 +00:00
kev.sully 974fb5e403 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@987 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-26 14:34:16 +00:00
dswitkin da4f56b022 Fixed some code which was ignoring the result of MonochromeBitmapSource calls, which may work in some cases but isn't legal and failed and in some experiments. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@986 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-25 19:46:49 +00:00
srowen 969088fa82 Style changes mostly 
git-svn-id: https://zxing.googlecode.com/svn/trunk@985 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 13:19:53 +00:00
kev.sully 372dfa1145 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@984 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 10:03:37 +00:00
kev.sully ffbbda2086 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@983 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 10:02:58 +00:00
kev.sully db23e7c3b1 ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@982 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 10:02:27 +00:00
kev.sully 36db720dac ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@981 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 10:02:04 +00:00
kev.sully f80399966f ISSUE: http://code.google.com/p/zxing/issues/detail?id=42 
Added PDF417 to list of readers. Will be used only if its specified in a Hint.

git-svn-id: https://zxing.googlecode.com/svn/trunk@980 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-24 10:01:47 +00:00
dswitkin 6367973b49 Added a clear() method to BitMatrix. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@979 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-23 21:05:09 +00:00
dswitkin b613112615 Rewrote BitMatrix to allow rectangular 2D arrays, and so that every row begins with a new int, which makes it fast to copy out rows into BitArrays. This will be the basis of the upcoming bitmap refactoring for 1D Readers. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@978 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-22 21:03:34 +00:00
dswitkin 7fec06465a Continuing with the x, y coordinate push, BitMatrix is now standardized. I also converted DataMask back to i, j for now to be consistent with the rest of the QR module, and made sure all the tests still pass. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@977 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-22 19:52:51 +00:00
srowen 4b7e5e6461 Remove getBits() 
git-svn-id: https://zxing.googlecode.com/svn/trunk@976 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-22 17:48:37 +00:00
dswitkin 5f2b64ee50 Used IntelliJ's amazing refactoring functions to change the argument ordering of ByteMatrix. I want to standardize this across ZXing: the first component should always be horizontal and the second vertical, whether supplying an x, y point or a width, height pair. Also, we should always use x and y as variables with x being the horizontal component to avoid confusion. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@975 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-22 15:50:08 +00:00
dswitkin 406f353e53 Modified some comments to reflect that these objects are thread-safe but not reentrant. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@974 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-22 15:32:59 +00:00
dswitkin 0c3a4b4b5a Updated some comments about thread safety and fixed one easy case. Sean, please have a look. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@973 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-19 19:08:31 +00:00
srowen 63a1dc62a3 Issue 198 
git-svn-id: https://zxing.googlecode.com/svn/trunk@972 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-19 13:23:09 +00:00
dswitkin 9f509172b6 Wrote a quick command line app to calculate how many total images are passing our blackbox unit tests. This could use some improvement but it's a start. 
git-svn-id: https://zxing.googlecode.com/svn/trunk@971 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-18 20:55:42 +00:00
dswitkin 1da9bd60b3 Added a new blackbox test with extreme shadows and highlights. We do pretty poorly on this, but I've been experimenting with local thresholding algorithms which are a night and day improvement. 
Also made the ImageConverter app ignore some kinds of files.

git-svn-id: https://zxing.googlecode.com/svn/trunk@969 59b500cc-1b3d-0410-9834-0bbf25fbcc57
 2009-06-16 18:47:34 +00:00