Commit graph

336 commits

Author SHA1 Message Date
srowen d75a7467f9 Update generator version and add one more test
git-svn-id: https://zxing.googlecode.com/svn/trunk@2123 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2012-01-20 16:45:39 +00:00
srowen 5415b12050 Count misreads in the test framework and track. Retune slightly on this basis to pick up a few more images
git-svn-id: https://zxing.googlecode.com/svn/trunk@2116 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2012-01-13 14:38:38 +00:00
srowen 01c274cfd1 Fix slight problem in heuristic for detecting URIs: accept a.singleletterdomainelement.com
git-svn-id: https://zxing.googlecode.com/svn/trunk@2108 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2012-01-11 14:52:53 +00:00
srowen 4af95ab471 Use better regex-based test for URI
git-svn-id: https://zxing.googlecode.com/svn/trunk@2098 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-12-23 15:20:18 +00:00
srowen 8f005274c0 Faster getNextSet; more gains from getNextUnset
git-svn-id: https://zxing.googlecode.com/svn/trunk@2051 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-11-25 12:37:39 +00:00
srowen b93f68f0db Another half-percent from specializing some operations on bit arrays
git-svn-id: https://zxing.googlecode.com/svn/trunk@2050 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-11-25 01:17:28 +00:00
srowen 293f565db9 Issue 1067 and more. Add "VALUE=DATE" to encoding of all-day dates. Don't pretend end was specified in original barcode if not present. However for benefit of Android Calendar apps, use +1 hour/day end time for missing end. Fix some error messages in appspot generator too.
git-svn-id: https://zxing.googlecode.com/svn/trunk@2040 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-11-17 09:35:48 +00:00
srowen 5311b1ce27 Issue 1054 unescape vCard / VEVENT correctly and don't strip semicolon in vCard
git-svn-id: https://zxing.googlecode.com/svn/trunk@2021 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-11-10 15:01:33 +00:00
srowen db60385d7d Update all Java code to use Java 6
git-svn-id: https://zxing.googlecode.com/svn/trunk@2002 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-11-02 11:16:30 +00:00
srowen 8743bb6de2 Update RSS14 test; remove IDE formatting comment (?)
git-svn-id: https://zxing.googlecode.com/svn/trunk@1975 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-10-15 07:24:19 +00:00
smparkes@smparkes.net 70190f7805 Tweak blackpoints estimates for internal black blocks. Closes Issue 1012.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1973 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-10-15 00:31:07 +00:00
srowen 303ed2e6a0 A pile of changes from proper static analysis for nullability issues, with full annotations.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1937 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-09-26 19:09:45 +00:00
srowen a035285f2f Some style and related stuff I found in code inspection
git-svn-id: https://zxing.googlecode.com/svn/trunk@1921 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-09-19 14:04:25 +00:00
srowen 015e2a5915 Style changes to CodaBar writer
git-svn-id: https://zxing.googlecode.com/svn/trunk@1908 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-09-15 09:22:48 +00:00
dsbnatut 02b0816126 add CodaBarWriter, and make separation from UPCEANWriter to OneDimensionalCodeWriter and UPCEANWriter which inherits OneDimensionalCodeWriter.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1907 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-09-15 00:45:54 +00:00
srowen fa5c84a0cf Let RSS tests succeed even when run from project root
git-svn-id: https://zxing.googlecode.com/svn/trunk@1883 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-08-13 16:58:32 +00:00
srowen 869ddc1dbf Improvement to finder/alignment pattern detection in low-res situations: use averages. It makes it much better on images of this sort, decreasing failure rate by about 60%. (It makes one old image fail, but looks like a fluke)
git-svn-id: https://zxing.googlecode.com/svn/trunk@1875 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-08-02 16:20:59 +00:00
srowen 05455c7b68 Issue 897 tighten URI definition
git-svn-id: https://zxing.googlecode.com/svn/trunk@1851 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-07-09 09:23:23 +00:00
dswitkin@google.com dbc98a7a22 Made sure otpauth: is recognized as a valid URI.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1811 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-06-07 15:24:31 +00:00
srowen df65c5b83e A bunch of code style related changes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1795 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-21 03:36:39 +00:00
srowen 2d7ef9faf4 Issue 742 at least parse iCal GEO in core library
git-svn-id: https://zxing.googlecode.com/svn/trunk@1787 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-20 07:12:49 +00:00
dswitkin@google.com 8ff9e7f4fa Standardized the naming of our barcode formats and alphabetized them.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1775 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-17 15:46:09 +00:00
dswitkin@google.com 8f924716f0 Created a new blackbox test of real world Aztec images taken with a mobile phone. We're only decoding 9% at the moment.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1771 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-13 21:42:52 +00:00
srowen 0e28aa0e4c Fix previous update to PDF417 regarding AS vs AL
git-svn-id: https://zxing.googlecode.com/svn/trunk@1764 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-10 20:10:11 +00:00
srowen e1fda03246 Another user-suggested fix - misdetecting rectangular matrices in corner cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@1761 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-05-08 14:57:15 +00:00
srowen 2e4e0d0c77 Issue 820 second format info was read incorrectly
git-svn-id: https://zxing.googlecode.com/svn/trunk@1751 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-04-29 08:35:13 +00:00
dswitkin@google.com ff5a939fbf Added two new blackbox tests of blurry barcodes taken with a fixed-focus mobile phone. Also fixed several other 1D blackbox tests that were off by an image here and there.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1721 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-02-23 23:47:01 +00:00
srowen 7a6cc4c3d0 Various user-contributed fixes (Issue 701, Issue 710, Issue 714, Issue 718)
git-svn-id: https://zxing.googlecode.com/svn/trunk@1717 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-02-15 13:23:14 +00:00
srowen e6d969b6f4 Issue 675 commit Lachezars great fix for large DM decoding
git-svn-id: https://zxing.googlecode.com/svn/trunk@1699 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2011-01-11 15:40:47 +00:00
srowen 99d09e0a44 Style stuff mostly but fix a problem between Aztec and J2ME too
git-svn-id: https://zxing.googlecode.com/svn/trunk@1681 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-12-15 14:42:17 +00:00
srowen 8c172f4891 Issue 658
git-svn-id: https://zxing.googlecode.com/svn/trunk@1678 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-12-12 22:31:51 +00:00
dav.olivier@gmail.com e1c047c54b Support for aztec codes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1668 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-11-20 21:21:34 +00:00
dav.olivier@gmail.com 5ec9b84660 Generator polynomial for reed-Solomon algorithm can now have coefficients in any Gallois fields rather than GF(256) only
git-svn-id: https://zxing.googlecode.com/svn/trunk@1666 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-11-20 21:18:04 +00:00
srowen e9ae6dd4d3 Issue 582
git-svn-id: https://zxing.googlecode.com/svn/trunk@1625 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-10-13 14:13:55 +00:00
srowen c3f4602678 Issue 581, Hanzi mode support from Shiyuan Guo
git-svn-id: https://zxing.googlecode.com/svn/trunk@1623 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-10-12 16:01:31 +00:00
dav.olivier@gmail.com 94679de34d Issue 563: Support non-rectangular Data Matrix
git-svn-id: https://zxing.googlecode.com/svn/trunk@1616 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-10-05 20:19:53 +00:00
srowen 8f2ddd96e7 At last update to JUnit 4.x
git-svn-id: https://zxing.googlecode.com/svn/trunk@1611 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-30 22:26:48 +00:00
srowen c01ee70804 Support SMTP URLs
git-svn-id: https://zxing.googlecode.com/svn/trunk@1609 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-30 15:44:39 +00:00
dav.olivier@gmail.com a573e789d2 Improved datamatrix reader with new algorithm
git-svn-id: https://zxing.googlecode.com/svn/trunk@1574 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-03 20:49:22 +00:00
srowen 47d2f3c798 David Olivier's Data Matrix improvements
git-svn-id: https://zxing.googlecode.com/svn/trunk@1573 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-03 07:50:47 +00:00
srowen 14a03f40b1 Issue 537, don't return UPC-A for EAN-13 starting with 0 when UPC-A isn't allowed
git-svn-id: https://zxing.googlecode.com/svn/trunk@1572 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-09-01 10:26:37 +00:00
dswitkin@google.com b14a77502d One more change to accommodate differences in jpeg libraries. Some machines will report this test as too lax by one image.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1568 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:58:03 +00:00
dswitkin@google.com 1ba5eceeb2 Updated the negative blackbox test values.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1567 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:55:17 +00:00
dswitkin@google.com 226bf1a1a6 Added rounding code to getRow() as well and updated the tests accordingly.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1564 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-26 14:06:44 +00:00
dswitkin@google.com 7db3546ea6 Created new false positives blackbox test. We definitely have a problem with EAN_8 firing too often.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1560 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-25 18:23:00 +00:00
smparkes@smparkes.net 4836a3e28c Issue 494 round luminance values rather than truncate
git-svn-id: https://zxing.googlecode.com/svn/trunk@1558 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-25 15:54:19 +00:00
dswitkin@google.com a080a85cdd Created new UPC-A blackbox test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1554 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-23 15:47:13 +00:00
smparkes@smparkes.net 6e3b219023 cleaned up versions of new tests; hopefully no EOL issues
git-svn-id: https://zxing.googlecode.com/svn/trunk@1542 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-17 00:10:33 +00:00
smparkes@smparkes.net 6220f46c94 remove CRLF files before readding them (in an attempt to not confuse SVN with EOL stuff)
git-svn-id: https://zxing.googlecode.com/svn/trunk@1541 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-17 00:09:09 +00:00
srowen 346d163125 Issue 520
git-svn-id: https://zxing.googlecode.com/svn/trunk@1540 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-16 21:55:33 +00:00
smparkes@smparkes.net b2cf605bc9 a set of synthetic version 40 tests at each ECC level
git-svn-id: https://zxing.googlecode.com/svn/trunk@1539 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-16 21:02:27 +00:00
srowen aee6be71f3 Issue 492
git-svn-id: https://zxing.googlecode.com/svn/trunk@1533 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-14 19:11:49 +00:00
srowen 6c9812e9bb Issue 511
git-svn-id: https://zxing.googlecode.com/svn/trunk@1522 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-12 20:18:08 +00:00
srowen 0a5e8e9298 Preserve query in geo URI
git-svn-id: https://zxing.googlecode.com/svn/trunk@1514 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-07 13:21:35 +00:00
dswitkin@google.com 2cb4f5f82b Issue 495: Renamed DATAMATRIX to DATA_MATRIX for consistency.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1508 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-08-05 15:22:30 +00:00
srowen 2d7b4138ab Display possible country origin info on product scan
git-svn-id: https://zxing.googlecode.com/svn/trunk@1438 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-16 21:13:47 +00:00
srowen 8cbe558ec3 Add support for UPC/EAN +5 extensions, plus basic tests, and display the content in Android client as metadata
git-svn-id: https://zxing.googlecode.com/svn/trunk@1436 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-16 19:49:22 +00:00
vikrama 58fefb095c Core library changes to include wifi type. One measly test included as well.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1421 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-10 03:49:18 +00:00
bas5winkel 97060619fe Renamed Codabar files and added text files for testing purposes
git-svn-id: https://zxing.googlecode.com/svn/trunk@1406 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-06-01 14:35:38 +00:00
bas5winkel@gmail.com e5a9d43849 Added support for codabar format
git-svn-id: https://zxing.googlecode.com/svn/trunk@1401 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-31 12:39:48 +00:00
srowen 05e8181ef5 Add Code 93 support. Update tests to reflect new (better) number of successes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1398 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-30 14:37:08 +00:00
srowen 737e0de917 Move character encoding logic out to common, try again to improve its handling of UTF8 for Chinese market, per manufacturer request, added test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@1364 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-15 11:21:03 +00:00
srowen 74c8744e8c Big RSS Expanded changelist -- thank you authors
git-svn-id: https://zxing.googlecode.com/svn/trunk@1350 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-10 19:18:50 +00:00
srowen 816d6b81e0 Replace tabs with spaces ( part of accepting another big patch); fix one failing test due to typo
git-svn-id: https://zxing.googlecode.com/svn/trunk@1326 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-05-02 06:49:18 +00:00
srowen 8a46200c72 Add ENCODING=QUOTED-PRINTABLE support
git-svn-id: https://zxing.googlecode.com/svn/trunk@1317 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-24 09:28:10 +00:00
srowen 2e9afb3673 Add description support, as well as handle VEVENT line continuation. Get rid of unused 'title' property
git-svn-id: https://zxing.googlecode.com/svn/trunk@1304 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-13 10:46:31 +00:00
srowen 047c932fcb Recognize LOCATION in VEVENT
git-svn-id: https://zxing.googlecode.com/svn/trunk@1301 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-04-11 16:42:11 +00:00
srowen 7410fd3082 Issue 361
git-svn-id: https://zxing.googlecode.com/svn/trunk@1268 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-30 22:53:34 +00:00
srowen 0b74dfc7fe Update sms: and geo: handling to better respect new RFCs
git-svn-id: https://zxing.googlecode.com/svn/trunk@1266 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-30 18:33:54 +00:00
srowen a0381b760d Avoid RSS-14 false positive issue, which temporarily hurts its scanning a lot, but will work more later. Readjust unit test pass counts, which seem to have drifted. The change is net neutral in any event.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1251 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-25 11:42:08 +00:00
srowen 0cf89d0402 Preliminary RSS-14 support. Not enabled yet in Android client.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1233 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-04 18:38:58 +00:00
srowen 508697a318 Related to Issue 205, but not the direct issue: read both copies of the format info and use both in determining the right one. This avoids a close, but incorrect first match throwing off the decoding. Also fix creating an image from ByteMatrix -- was inverted
git-svn-id: https://zxing.googlecode.com/svn/trunk@1226 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-03-01 11:04:22 +00:00
srowen 5ef5f3b02d "Split" ReaderException into subclasses to enable more useful error reporting
git-svn-id: https://zxing.googlecode.com/svn/trunk@1195 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-02-02 08:23:46 +00:00
srowen f9b648c131 Fixed old unit test compile problem I probaby introduced
git-svn-id: https://zxing.googlecode.com/svn/trunk@1194 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-02-02 07:34:35 +00:00
dswitkin 04d5b85502 This is a set of mobile image taken at 480x360 with difficult lighting.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1187 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-17 23:12:21 +00:00
dswitkin 395f145067 Deleted the old ean13-2 test data which contained high resolution blurry images. These are not the focus of ZXing and not worth testing against. I'm going to replace them shortly with more relevant test images.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1186 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-17 22:19:59 +00:00
srowen c2a6255e19 Fix/improvement from Jiayong
git-svn-id: https://zxing.googlecode.com/svn/trunk@1184 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-11 06:08:20 +00:00
srowen ae379e56e9 Better version of revision 1166 and 1165 -- corrects behavior, by changing code such that points are always within image. Happens to make one test image fail at one rotation, but think that was a 'false gain' so accepted that tiny step backwards.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1178 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2010-01-06 14:02:16 +00:00
srowen a38b0123f6 Tighten up detection of URLs on some garbage strings
git-svn-id: https://zxing.googlecode.com/svn/trunk@1167 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 18:30:09 +00:00
srowen 2736b6e19e Unit test for some reason too stringent by one? was breaking in a clean build
git-svn-id: https://zxing.googlecode.com/svn/trunk@1164 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-22 12:18:32 +00:00
dswitkin 5cc1df3c92 Finished work on the local binarizer and renamed it to HybridBinarizer. It uses the old histogram for 1D and the new approach for 2D. The unit tests don't fully demonstrate how much better this is in real-world lighting, but it pretty much solves the situation of pointing at a QR Code for 30 seconds without scanning, due to a shadow or gradient.
HybridBinarizer is now the default across all the fast clients and the unit tests.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1157 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-13 21:08:57 +00:00
srowen 6271b86315 Issue 294, add support for several address lines in parsed results
git-svn-id: https://zxing.googlecode.com/svn/trunk@1148 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-10 00:34:54 +00:00
srowen 1e5964024b Make finder pattern detection a little more tolerant, per Ralf. Increases accuracy slightly.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1141 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-12-08 19:47:50 +00:00
srowen 88c77b18b8 Fixed unit test fail from vCard change
git-svn-id: https://zxing.googlecode.com/svn/trunk@1122 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-11-23 09:37:58 +00:00
srowen eef79f730b Fix for old logic error in seeking format information -- actually was comparing unmasked rather than masked values, though it ended up working
git-svn-id: https://zxing.googlecode.com/svn/trunk@1052 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-09-14 10:17:17 +00:00
srowen e1dd41a115 Improve detector logic to throw out false positive finder patterns in a more reasonable manner. Current logic didn't quite achieve its goal in some corner cases and needed rethinking and some simplification. Fixes a reported failure from the group list. Net change in passed test cases is -1 otherwise (for 270 degree rotation -- not vital) so I consider it a net tiny win.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1039 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-23 15:32:01 +00:00
srowen 6dbf893cb0 Add MatrixToImageWriter convenience class, small code tweaks in javase/, make ByteMatrix width/height property getters names standard
git-svn-id: https://zxing.googlecode.com/svn/trunk@1028 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-30 08:58:57 +00:00
srowen 4331605913 Added error correction level to Result
git-svn-id: https://zxing.googlecode.com/svn/trunk@1026 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-22 10:40:18 +00:00
srowen 9f475ac33e Small detector simplification that addresses issue 215 and picks up a net +4 more images decoded in tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@1022 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-21 09:39:31 +00:00
dswitkin 402880798c Modified my skew correction code to also work upside down, meaning we now decode three more inverted PDF 417 images.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1016 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-08 20:38:21 +00:00
dswitkin b238cb7828 I noticed that the codeword coordinates in PDF 417 barcodes were a few pixels off if there was skew or rotation in the image. I added a simple method to correct the vertical component of these points, and the units tests went from 8/23 to 11/23.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1015 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-02 20:07:09 +00:00
dswitkin 0944a2bb18 Got 180 degree rotation working for PDF 417, and turned on the appropriate unit tests as a result.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1014 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 19:42:52 +00:00
dswitkin c31b489efe Added the second PDF 417 test to the AllPositiveBlackBoxTester.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1011 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 15:13:44 +00:00
dswitkin 01eed5266e - Converted parts of the PDF 417 reader to use BitMatrix.
- Changed the PDF 417 detector to search the image more broadly, instead of assuming the barcode starts in the left 1/4 and ends in the right 1/4. We now get 8/23 on the real-world blackbox test, and we'll probably do even better with further improvements here.
- Added a quiet zone to two of the unit test images and updated a golden result for one of them. We now get 3/7 on the first test.
- Tried to fix some bugs in the upside down code but it still doesn't work.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1010 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 21:55:19 +00:00
dswitkin f5124cec37 Created a new blackbox unit test of real-world PDF 417 images taken with an Android device. Currently we decode 0/23.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1008 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 18:47:34 +00:00
dswitkin 2397216901 Added a few computer-generated PDF 417 barcodes to the blackbox tests. The current code doesn't seem to handle more advanced error correction modes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1007 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 17:32:12 +00:00
dswitkin eb8b9677cf Added the previous Android benchmark I've been using to track performance, as well as a new one which uses wider images and therefore twice as many pixels.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1006 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 22:08:38 +00:00
dswitkin e2324bc2ae Added slightly better blackbox unit test stats.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1005 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 21:57:59 +00:00
dswitkin 10dfe7789b - Got the DataMatrix decoder compiling again with a quick bandaid.
- Fixed two bugs in the LocalBlockBinarizer sharpening routine. It can now decode 2132 images in our blackbox tests, compared to 2103 using the global histogram approach.
- Added the PDF 417 blackbox test to AllPositiveBlackBoxTester, and allowed it to complete even if the tests fail.

git-svn-id: https://zxing.googlecode.com/svn/trunk@1004 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 15:49:42 +00:00
dswitkin 167197ec7a Refactored the MonochromeBitmapSource class hierarchy into LuminanceSource, Binarizer, and BinaryBitmap classes. The unit tests pass and I believe the change is complete, but there are some clients like J2ME and Bug that I can't build.
This change will allow new thresholding algorithms to be developed and tested, as well as implemented per platform if needed (e.g. in JNI on Android). It should also perform better when multiple 2D Readers are installed, because the underlying image will only be converted to 1 bit once. It also allows some platforms to return luminance data without a copy.

The current state of this checkin is to use the old black point algorithm, which now lives in GlobalHistogramBinarizer. This will be our benchmark and fallback for slower platforms. Going forward we will begin to use LocalBlockBinarizer as I shake out the edge cases and tune it for performance. Currently it is unused.

IMPORTANT: I have temporarily included three methods from MonochromeBitmapSource at the end of BinaryBitmap as a way to make this change in stages. They are deprecated and will be removed soon. All of the Reader classes will need to change the way they examine 1 bit pixels to use the new getBlackRow() and getBlackMatrix() calls.

git-svn-id: https://zxing.googlecode.com/svn/trunk@993 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 17:49:45 +00:00