dswitkin
c07fad6410
Created a new QR blackbox test with difficult exposures, mostly self-shadowing cases. We only get 34 out of 120 tests, which is about what I expected. To fix these we will have to move away from a global black point and towards a more sophisticated local thresholding algorithm.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@961 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-28 18:45:48 +00:00
dswitkin
932715065b
Only allocate a StringBuffer if the start pattern has been found successfully in the ITFReader.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@958 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 21:11:10 +00:00
srowen
dbb2c31a40
Fixed an old misspelling and a few tiny tweaks
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@956 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 10:03:23 +00:00
srowen
58c367d9ea
Improvement to Shift_JIS encoding detector to avoid detecting some UTF-8 strings as Shift_JIS
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@955 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-27 09:14:17 +00:00
srowen
78c1b8ccd7
Oops, one more fix to rotateCounterClockwise() here
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@952 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-24 13:06:51 +00:00
srowen
4282827336
More intelligence to avoid very deep recursion
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@951 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-23 10:33:53 +00:00
dswitkin
ec77a581d2
Changed the 2D histogram calculation to sample four rows spread across the image rather than taking a diagonal. We get a net increase of 63 blackbox tests with this change.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@950 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-22 20:59:15 +00:00
srowen
825d99786d
Off by one error in last change
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@949 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-22 08:19:11 +00:00
dswitkin
51ade2ca96
Added better logging for our blackbox tests. It now displays the number of images which passes per test out of the total, and the percentage. It also warns when a blackbox test is too lax (i.e. we've made decoding improvements but haven't raised the high water mark).
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@947 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 21:18:27 +00:00
dswitkin
6687d5772f
Fixed a typo in our golden results.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@946 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 20:29:56 +00:00
dswitkin
e19e9a83f6
I moved a chunk of the histogram/black point code out of BaseMonochromeBitmapSource and into BlackPointEstimator which makes a lot more sense. Unfortunately I had to expose three new methods and touch a bunch of files. But I did manage to reuse an array on subsequent calls, which was being allocated on every row scanned, so that might be a bit faster. It will also be easier to convert this code to JNI in the future if we want to, and/or do more advanced thresholding.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@945 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 19:56:25 +00:00
dswitkin
038f113274
Moved CroppedMonochromeBitmapSource into the common package and fixed some more 100 column issues.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@944 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 18:46:53 +00:00
dswitkin
c9d3eae171
Cleaned up some code to fit in 100 columns.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@942 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 15:36:51 +00:00
srowen
bd73aebc73
Be smarter about recursion to avoid infinite loop
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@940 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-21 14:26:29 +00:00
srowen
76eeeed99a
Add toString() for easy debugging
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@939 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-11 21:51:20 +00:00
srowen
793f4c7176
Marginal improvement to datamatrix decoder
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@937 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-11 21:02:08 +00:00
srowen
0c07f139b5
Fix issue 189. Need to guard against 'false positive' success in reading version info.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@934 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-06 21:50:13 +00:00
srowen
b2bd63a228
Alternate multi QR Code reader from Hannes
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@933 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-05 09:52:46 +00:00
srowen
a26e5fbc10
Forge ahead with detection even if we missed an alignment pattern -- can still decode in some cases without it
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@929 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-03 19:52:03 +00:00
srowen
361f4504a3
Add MultipleBarcodeReader interface to allow for more implementations
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@927 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-05-03 05:56:51 +00:00
srowen
7e86f379ea
Moved MultipleBarcodeReader and added ByQuadrantReader to try to accommodate many QR codes in an image
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@921 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-30 19:12:32 +00:00
srowen
949eca972e
Adding a few test images from a defunct issue report
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@919 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-28 22:29:30 +00:00
srowen
29d7d6443e
Issue 183: Adds support for detecting multiple barcodes, and simplifies ResultPoint abstraction
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@918 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-28 17:35:33 +00:00
srowen
e9c19530cc
Improve URL detection rule to exclude stuff like "Hi."
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@914 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-18 08:57:32 +00:00
srowen
e74c041e46
Improve URL detection rule to exclude stuff like "Hi."
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@913 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-18 08:02:08 +00:00
srowen
d08ddbe733
In extreme decoder failure case, make sure not to let an IAE propagate up. Turn it into ReaderException.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@911 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-17 21:30:36 +00:00
dswitkin
02f779cbee
Fixed or removed a bunch of TODOs, and enforced the 100 columns limit in a bunch of places. Also allowed QR Codes to be encoded of contacts without names.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@907 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-13 21:20:11 +00:00
srowen
94915afb71
Enable DataMatrix in the web app / other small tweaks (forgot one class!); also fix a small bug in QRCodeWriter
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@904 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-12 06:39:10 +00:00
srowen
dea0247615
Enable DataMatrix in the web app / other small tweaks
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@903 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-10 13:46:11 +00:00
srowen
3d8d68a464
Issue 165
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@900 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:56:06 +00:00
srowen
3c84048565
Issue 164
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@898 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:46:02 +00:00
srowen
d4e82758eb
Issue 158: Correct some off-by-one problems in Data Matrix detector and a few more improvements, ignore unsupported DM symbols
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@895 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-04-06 21:22:07 +00:00
srowen
0210ec9fe9
Fixed tiny javadoc glitches
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@892 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-12 21:17:06 +00:00
dswitkin
dfb6b60dd4
- Added a new unit test of 13 ITF images I took with a T-Mobile G1.
...
- Added upside down unit tests for the existing ITF images.
- Removed the temporary format code from these tests now that ITF is on by default.
git-svn-id: https://zxing.googlecode.com/svn/trunk@883 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 20:48:48 +00:00
dswitkin
5b5c7945bb
Turned on ITF support in the Android client, and fixed a bug in the ITF result points, which by convention should draw across the whole body of the barcode, not just the start range.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@881 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:57:57 +00:00
srowen
7561941341
Tiny optimization to reverse()
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@880 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:56:08 +00:00
dswitkin
04ff9c43b5
Turned on ITF support by default. The typical overhead in real world scanning on an Android device is 3-8 ms.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@879 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-09 15:46:27 +00:00
srowen
e367d3ef96
Fixed decodeEnd() situation whereby row might not be re-reversed, and fixed an old NPE I caused
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@878 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-07 10:51:03 +00:00
srowen
8b339661d9
Some clever, perhaps too-clever optimization of masking code
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@877 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 22:55:19 +00:00
dswitkin
c1bc060065
Changed the order of the BaseMonochromeBitmapSource constructor arguments to be width, height to match the rest of the codebase, and added two apparently missing methods to the J2ME subclass, although I can't test it.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@874 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 16:52:35 +00:00
srowen
6fe022eb10
Normalize GEO: to geo:
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@873 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 15:25:26 +00:00
srowen
415c9257d6
Fix #150 again by moving towards a more RFC 2822-compliant definition of valid syntax
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@872 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-06 15:17:38 +00:00
srowen
83f6b96f82
Backed out last 'fix' to email address parsing -- isn't going to work. Needs a better, real fix.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@871 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:28:57 +00:00
srowen
cf24cfd453
Normalize TEL: to tel: to make sure it works with Android
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@870 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:26:21 +00:00
srowen
ddffcde9f4
Address Issue 152
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@869 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-03-05 02:19:48 +00:00
srowen
b24fbdd7b0
Tiny optimizations to boolean logic to avoid extra byte code and branches in semi-critical sections
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@867 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-23 13:52:45 +00:00
srowen
1e96791817
git-svn-id: https://zxing.googlecode.com/svn/trunk@859 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 12:38:12 +00:00
srowen
8e73582187
A fixed fix for email parsing
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@858 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 12:00:52 +00:00
srowen
dd1eccfda8
Tighten email check logic a little
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@857 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 09:45:52 +00:00
srowen
8e18d651bb
Tightened a condition to reduce accidentally detecting the alignment pattern as a finder pattern
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@856 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-02-15 09:43:40 +00:00
