Commit graph

109 commits

Author SHA1 Message Date
srowen e6e3472471 Renamed UPC result type to Product, and introduced an idea of 'product ID' and 'normalized product ID' to account for UPC-E, where the actual visible ID is different from what we may want to search for as a key. Updated clients to use this too.
git-svn-id: https://zxing.googlecode.com/svn/trunk@668 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-11-04 12:08:19 +00:00
srowen 14e22bd443 Revamp the character encoding detection to use a more complicated but still crude algorithm that detects more Shift_JIS sequences correctly.
git-svn-id: https://zxing.googlecode.com/svn/trunk@664 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-11-02 12:22:33 +00:00
srowen 79d7b01e9e Updated qrcode-2 with corrected output for some Japanese-language results. Also standardized on UTF-8 encoding for test result files and enabled --dump_results for single-file case.
git-svn-id: https://zxing.googlecode.com/svn/trunk@663 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-11-02 11:06:20 +00:00
dswitkin bf362ae853 Added 17 new, unusual QR Codes to the blackbox tests. We can decode the majority OK, but some of the contents are not agreeing with the golden results because of a text encoding issue.
git-svn-id: https://zxing.googlecode.com/svn/trunk@658 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-31 18:09:24 +00:00
dswitkin bef3c75048 Fixed a crash in calendar parsing when encountering an illegal VEVENT without newlines.
git-svn-id: https://zxing.googlecode.com/svn/trunk@655 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-30 16:35:26 +00:00
dswitkin d80cd07064 Made a change to the QR detector which cuts the worst case rejection time from 300 ms to 160 ms, with almost no penalty in decoding ability. Given that we're emphasizing continuous decoding, I feel it's much better to reject the occasional borderline image in half the time, and get on with the next scan.
git-svn-id: https://zxing.googlecode.com/svn/trunk@648 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-29 14:22:44 +00:00
dswitkin 8cb804ec9e Made a change to 1D decoding which looks for 100% instead of 150% of the start and end patterns when searching for quiet zones, but in exchange for that reduction, we reject rows whose quiet zones would run off either edge of the image.
The result is complete elimination of all false positives in the new batch of 40 images I just checked in. Bettter than that, we come up with a net gain of 38 new barcodes decoded (counting rotation and try harder variations). We even get some of the reflective images that were impossible up to this point.

git-svn-id: https://zxing.googlecode.com/svn/trunk@620 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-15 19:47:34 +00:00
dswitkin edcf34f0c5 Created 40 new blackbox images which are partial shots of a very large QR code. In mobile mode we do OK, but in try harder we find bogus 1D results in almost half of these. I'm checking this in as a baseline, and will work on improving the situation in a subsequent change.
git-svn-id: https://zxing.googlecode.com/svn/trunk@618 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-14 22:08:48 +00:00
dswitkin ef2f3f8ce0 Expanded calendar parsing to allow more date formats, added some unit tests for ISBN and VEVENTS, and fixed the EAN13-1 test which was failing by one image.
git-svn-id: https://zxing.googlecode.com/svn/trunk@616 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-14 15:56:03 +00:00
dswitkin 13c08aedaf Added 13 new blackbox images.
git-svn-id: https://zxing.googlecode.com/svn/trunk@603 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-07 18:57:15 +00:00
srowen 8c3b727bd4 Recent bug fix uncovered some bugs in test case -- fixing those
git-svn-id: https://zxing.googlecode.com/svn/trunk@594 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-01 16:17:03 +00:00
dswitkin 16bdeac581 Added two more UPC-A blackbox images submitted by the community.
git-svn-id: https://zxing.googlecode.com/svn/trunk@593 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-10-01 14:17:17 +00:00
srowen 6db50e0b79 Finally actually fix the Code-128 bug and add tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@588 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-09-24 12:16:41 +00:00
srowen 78af16ca34 More UPC-A tests: interesting clear but low-res images that don't decode
git-svn-id: https://zxing.googlecode.com/svn/trunk@587 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-09-23 17:24:03 +00:00
srowen 67d139dadb git-svn-id: https://zxing.googlecode.com/svn/trunk@574 59b500cc-1b3d-0410-9834-0bbf25fbcc57 2008-09-01 00:33:53 +00:00
dswitkin f344098895 Added a new unit test of real world QR codes. We get 29/42 - pretty good, but room for improvement.
git-svn-id: https://zxing.googlecode.com/svn/trunk@571 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-25 17:44:23 +00:00
srowen 8b5d15cc5c URIParsedResult now has isPossiblyMaliciousURI() to check for username in host, which may be an attempt to mask the host of the URI
git-svn-id: https://zxing.googlecode.com/svn/trunk@570 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-21 04:33:42 +00:00
srowen 7dbc556789 Per dominik.wild, added support for "sms:number:body" format URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@565 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-15 16:35:47 +00:00
srowen 966c5a8e97 (Thanks to John White) Make UPC/EAN decoder less picky about white space bordering 1D code
git-svn-id: https://zxing.googlecode.com/svn/trunk@557 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-12 18:29:29 +00:00
dswitkin 3371fdb4d3 Added 55 EAN-13 real world test images. For mobile we get 49/55 of these, 55/55 with try harder.
git-svn-id: https://zxing.googlecode.com/svn/trunk@554 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-08 15:26:21 +00:00
srowen 86ce6b77b7 Use unicode escapes to avoid apparent source file encoding issues here
git-svn-id: https://zxing.googlecode.com/svn/trunk@549 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-08-06 16:21:47 +00:00
srowen 944feda925 Re-add ECI test case and groundwork for more tests of DecodedBitStreamParser
git-svn-id: https://zxing.googlecode.com/svn/trunk@539 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-30 23:01:37 +00:00
srowen 423f0a05ca Remove dead files
git-svn-id: https://zxing.googlecode.com/svn/trunk@536 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-24 21:43:40 +00:00
dswitkin 2267be2e61 Small improvement to unit test results output.
git-svn-id: https://zxing.googlecode.com/svn/trunk@510 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-10 19:45:50 +00:00
dswitkin 28f6c26335 Added a reflective UPC-E unit test. We cannot decode any of these silver on silver barcodes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@509 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 21:46:27 +00:00
dswitkin 13cb307965 Added 41 real world UPC-E tests. We need to improve regular decoding here: it gets 17/41, but try harder gets 28/41.
git-svn-id: https://zxing.googlecode.com/svn/trunk@508 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 21:37:09 +00:00
dswitkin 936343b221 Added some very difficult reflective UPC-A images - we get 8/21. We would probably have to do something very special to handle soda cans with those silver on silver barcodes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@507 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 20:50:03 +00:00
dswitkin 251e4623e6 All the positive test cases now track normal and try harder success rates separately. This lets us monitor regressions separately, and gives an idea of how much better try harder actually is.
git-svn-id: https://zxing.googlecode.com/svn/trunk@506 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 20:15:53 +00:00
dswitkin f05d22687e Added 52 real world UPC-A greyscale test images. We get 26/52, but more with try harder. I think I'm going to break try harder results into their own test so we can track these separately.
git-svn-id: https://zxing.googlecode.com/svn/trunk@505 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-09 19:00:33 +00:00
srowen 42940c4580 Add iCal support, plus many small changes suggested by code inspection -- mostly making things less visible for now
git-svn-id: https://zxing.googlecode.com/svn/trunk@502 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-07-08 04:11:24 +00:00
srowen 90297efc57 Added mms:, mmsto: support and tests, plus basic tests for vCard format
git-svn-id: https://zxing.googlecode.com/svn/trunk@488 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 18:14:19 +00:00
srowen aa65741586 More refactoring of parsed results / result parsers; added basic vCard support
git-svn-id: https://zxing.googlecode.com/svn/trunk@487 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-27 17:50:47 +00:00
srowen dd57042f9a And fixed the "270" issue: logic error in computing the "skip" allowed after finding two finder patterns when the QR Code was inverted.
git-svn-id: https://zxing.googlecode.com/svn/trunk@486 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 22:58:08 +00:00
srowen 011e6e9cee Big refactoring of ParsedResult: now split into ResultParser and ParsedResult classes, per Christian's suggestion. This unifies the parsed results that are produced from various input, simplifying client handling of different types.
git-svn-id: https://zxing.googlecode.com/svn/trunk@482 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-26 19:49:38 +00:00
dswitkin 12a57d0baf Added new test of unsupported barcodes, to make sure we don't decode them.
git-svn-id: https://zxing.googlecode.com/svn/trunk@477 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 01:26:22 +00:00
dswitkin cfa10cf26c Added blackbox test of partial barcodes which should not decode.
git-svn-id: https://zxing.googlecode.com/svn/trunk@476 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 01:10:52 +00:00
dswitkin 67656a7ee3 Reworked the false positives unit tests to track each rotation separately, and to allow new tests to be added. I also removed four images which are going to live in another test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@475 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-25 00:51:37 +00:00
srowen 584564a594 Added ECI for values 0-2 and also standardize character encoding names throughout the code to use the canonical values for java.lang and java.io
git-svn-id: https://zxing.googlecode.com/svn/trunk@468 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-23 17:11:53 +00:00
srowen c9ead4ce8a Added some degree of support for Character Set ECIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@467 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 22:38:35 +00:00
dswitkin d713f52437 Tuned the Code 128 parameters:
Right-side up went from 9/40 to 33/40
Upside down went from 8/40 to 34/40

and try harder now gets 39/40.

git-svn-id: https://zxing.googlecode.com/svn/trunk@462 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:57:48 +00:00
dswitkin 834bc3297a Added 40 real world Code 128 images. We decode 9/40 right-side up, and 8/40 upside down. A fix will follow shortly to get these numbers up - we overtightened the pattern matching in the first round of false positive changes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@461 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:24:02 +00:00
dswitkin 40ca2706e2 Added 17 real world Code 39 images to our unit tests. We decode all 17, upside down and right-side up.
git-svn-id: https://zxing.googlecode.com/svn/trunk@460 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-20 19:20:27 +00:00
dswitkin 12e5d9462c Fixed a bug in patternMatchVariance() which caused the max individual variance to never eliminate any patterns. As a result, the false positives unit test dropped from 15 to 4. Also did some other minor cleanup.
git-svn-id: https://zxing.googlecode.com/svn/trunk@456 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 21:38:48 +00:00
srowen e0db8f9271 Standardize and update all copyright statements to name "ZXing authors" as suggested by open-source team to correctly attribute copyright in a project with contributions from several sources.
git-svn-id: https://zxing.googlecode.com/svn/trunk@455 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 20:56:24 +00:00
dswitkin fb5fbccf7c Add 26.jpg back with the command line client
git-svn-id: https://zxing.googlecode.com/svn/trunk@453 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 20:00:13 +00:00
dswitkin d4cda3377d Delete 26.jpg again.
git-svn-id: https://zxing.googlecode.com/svn/trunk@452 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 19:59:23 +00:00
dswitkin 466130bcf0 Added rotation to unit test output for clarification.
git-svn-id: https://zxing.googlecode.com/svn/trunk@450 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 16:41:40 +00:00
dswitkin 640ccb5fd2 Trying to add image 26 back to the false positives unit test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@449 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 15:51:04 +00:00
dswitkin eea1c7fd2f Deleting image 26 which somehow arrived at the server with a length of zero bytes.
git-svn-id: https://zxing.googlecode.com/svn/trunk@448 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-19 15:49:51 +00:00
srowen 15f34edb52 Simple check in Code 39 reader to determine wide bars vary in width a lot, to cut out most false positives
git-svn-id: https://zxing.googlecode.com/svn/trunk@442 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-18 22:52:45 +00:00