ci: Prevent skipping of E2E fail job (no-changelog) (#5958)

* ci: Prevent skipping of E2E fail job (no-changelog)

* Set `continue-on-error: true` for e2e-reusable and add fail job

* Always run e2e checks

* Update 1-workflows.cy.ts

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

.github/workflows/e2e-tests-pr.yml

@@ -37,9 +37,10 @@ jobs:
     runs-on: ubuntu-latest
     name: E2E [Electron/Node 16] - Checks
     needs: [run-e2e-tests]
+    if: always()
     steps:
       - name: E2E success comment
-        if: success()
+        if: needs.run-e2e-tests.result == 'success'
         uses: peter-evans/create-or-update-comment@v3
         with:
           issue-number: ${{ github.event.pull_request.number }}
@@ -48,10 +49,14 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: E2E fail comment
-        if: failure()
+        if: needs.run-e2e-tests.result == 'failure'
         uses: peter-evans/create-or-update-comment@v3
         with:
           issue-number: ${{ github.event.pull_request.number }}
           body: |
             :warning: Some Cypress E2E specs are failing, please fix them before merging
           token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Fail job if run-e2e-tests failed
+        if: needs.run-e2e-tests.result == 'failure'
+        run: exit 1